Re: [PATCH] Initialize struct stat st_[acm]tim.tv_nsec when present

2017-05-06 Thread Egmont Koblinger
Hi guys, It is a regression (on my Fedora at least), as timestamps were preserved > with the earlier mc versions. > As far as I understand the current story, this is probably due to some other change since mc didn't change its relevant code recently. Also, generally it's not feasible to make a

Re: [PATCH] Initialize struct stat st_[acm]tim.tv_nsec when present

2017-05-06 Thread Nerijus Baliunas
On Sat, 6 May 2017 22:08:47 +0200 (CEST) "Yury V. Zaytsev" wrote: > Regarding the release, I'm not sure about it. As far as I understand, it's > not a regression, but a bug that has been present for a very long time, so > if this is true, then we are not really in a hurry.

Re: [PATCH] Initialize struct stat st_[acm]tim.tv_nsec when present

2017-05-06 Thread Yury V. Zaytsev
On Sat, 6 May 2017, Nerijus Baliunas wrote: It works, and it fixes my yesterday reported problem with zip/rar subdirs. Thanks! IMHO it would be nice to release 4.8.20 with this fix, it is important. Thanks for the confirmation, I have put the branch on review. Regarding the release, I'm not

Re: [PATCH] Initialize struct stat st_[acm]tim.tv_nsec when present

2017-05-06 Thread Nerijus Baliunas
On Sat, 6 May 2017 21:06:39 +0200 (CEST) "Yury V. Zaytsev" wrote: > I've created a ticket and branch for this patch: > > https://midnight-commander.org/ticket/3821#comment:1 > > I've also patched all other places where stat is filled manually that I > could find. The

Re: [PATCH] Initialize struct stat st_[acm]tim.tv_nsec when present

2017-05-06 Thread Yury V. Zaytsev
I've created a ticket and branch for this patch: https://midnight-commander.org/ticket/3821#comment:1 I've also patched all other places where stat is filled manually that I could find. The all builds & tests seem to run through. Does this version work, or problems remain? On Wed, 19

Re: file timestamps not preserved

2017-05-06 Thread Yury V. Zaytsev
On Sat, 6 May 2017, Nerijus Baliunas wrote: On Fri, 5 May 2017 23:31:50 +0200 Andrey Gursky wrote: I've downloaded the original mc 4.8.19 release, applied the patches, run autoreconf, then configure, make install and it works for me. Have you tested with the file

Re: [PATCH] Remove unused check in configure.ac

2017-05-06 Thread Yury V. Zaytsev
On Wed, 19 Apr 2017, Andrey Gursky wrote: AC_STRUCT_ST_BLOCKS is a leftover from cleanup in 0ba019a90b3798abae32ba261e72b737dc945615 I don't understand why you're saying that this macro is unused. It defines HAVE_STRUCT_STAT_ST_BLOCKS if struct `stat` contains an `st_blocks` member.

Re: file timestamps not preserved

2017-05-06 Thread Nerijus Baliunas
On Fri, 5 May 2017 23:31:50 +0200 Andrey Gursky wrote: > I've downloaded the original mc 4.8.19 release, applied the patches, > run autoreconf, then configure, make install and it works for me. Have > you tested with the file you've sent me? If yes, I'm curious what