Re: [PATCH] FISH DoS when copying file with '`' in name to remote FS

2006-11-09 Thread Leonard den Ottolander
Hi Jindrich, On Thu, 2006-11-09 at 13:44 +0100, Jindrich Novy wrote: I was unsuccessful to fix the script responsible for this bug by any quotation as backtick '`' did quite bad things so that bash was unable to parse it, quoted or not. Thanks for your explanation. Committed. Leonard. --

[PATCH] FISH DoS when copying file with '`' in name to remote FS

2006-11-08 Thread Jindrich Novy
Hi all, there's a problem when copying file named like file` to remote filesystem via FISH. It simply won't do anything because of error in BASH script which is generated in vfs/fish.c caused by the filename. Attached patch should fix it. References: http://bugzilla.redhat.com/214255 Jindrich

Re: [PATCH] FISH DoS when copying file with '`' in name to remote FS

2006-11-08 Thread Leonard den Ottolander
Hi Jindrich, On Wed, 2006-11-08 at 19:37 +0100, Jindrich Novy wrote: +file=/%s\n Why the substitution instead of just quoting the occurrences of %s? (unsigned long) s.st_size, name, -(unsigned long) s.st_size, quoted_name, -