Re: [Midnight Commander] #269: Revert from mhl to Glib
#269: Revert from mhl to Glib ---+ Reporter: Patrick Winnertz | Owner: winnie Type: defect| Status: testing Priority: major | Milestone: 4.7 Component: mc-core | Version: 4.6.2 Resolution: fixed |Keywords: vote-angel_il vote-slyfox vote-andrew_b vote-winnie vote-miguel vote-slavazanko vote-styx approved Blocking:| Blockedby: ---+ Changes (by styx): * status: accepted => testing * resolution: => fixed -- Ticket URL: Midnight Commander Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #269: Revert from mhl to Glib
#269: Revert from mhl to Glib ---+ Reporter: Patrick Winnertz | Owner: winnie Type: defect| Status: accepted Priority: major | Milestone: 4.7 Component: mc-core | Version: 4.6.2 Resolution:|Keywords: vote-angel_il vote-slyfox vote-andrew_b vote-winnie vote-miguel vote-slavazanko vote-styx approved Blocking:| Blockedby: ---+ Changes (by styx): * keywords: vote-angel_il vote-slyfox vote-andrew_b vote-winnie vote- miguel vote-slavazanko => vote-angel_il vote- slyfox vote-andrew_b vote-winnie vote-miguel vote-slavazanko vote-styx approved -- Ticket URL: Midnight Commander Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #269: Revert from mhl to Glib
#269: Revert from mhl to Glib ---+ Reporter: Patrick Winnertz | Owner: winnie Type: defect| Status: accepted Priority: major | Milestone: 4.7 Component: mc-core | Version: 4.6.2 Resolution:|Keywords: vote-angel_il vote-slyfox vote-andrew_b vote-winnie vote-miguel vote-slavazanko Blocking:| Blockedby: ---+ Changes (by angel_il): * keywords: vote-angel_il => vote-angel_il vote-slyfox vote-andrew_b vote-winnie vote-miguel vote-slavazanko -- Ticket URL: Midnight Commander Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #269: Revert from mhl to Glib
#269: Revert from mhl to Glib ---+ Reporter: Patrick Winnertz | Owner: winnie Type: defect| Status: accepted Priority: major | Milestone: 4.7 Component: mc-core | Version: 4.6.2 Resolution:|Keywords: vote-angel_il Blocking:| Blockedby: ---+ Changes (by angel_il): * keywords: review vote-slyfox vote-andrew_b vote-winnie vote-miguel vote-slavazanko => vote-angel_il Comment: it's work -- Ticket URL: Midnight Commander Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #269: Revert from mhl to Glib
#269: Revert from mhl to Glib ---+ Reporter: Patrick Winnertz | Owner: winnie Type: defect| Status: accepted Priority: major | Milestone: 4.7 Component: mc-core | Version: 4.6.2 Resolution:|Keywords: review vote-slyfox vote-andrew_b vote-winnie vote-miguel vote-slavazanko Blocking:| Blockedby: ---+ Changes (by slavazanko): * keywords: review vote-slyfox vote-andrew_b vote-winnie vote-miguel => review vote-slyfox vote-andrew_b vote-winnie vote-miguel vote-slavazanko Comment: Well... we need to one-style of writing code. MHL was attempt (don't successfull attempt), and my vote for removal this here. As for me, not important less size of the code or more speed of code (a few nanoseconds faster). For me important understanding of source code written in one style. -- Ticket URL: Midnight Commander Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #269: Revert from mhl to Glib
#269: Revert from mhl to Glib ---+ Reporter: Patrick Winnertz | Owner: winnie Type: defect| Status: accepted Priority: major | Milestone: 4.7 Component: mc-core | Version: 4.6.2 Resolution:|Keywords: review vote-slyfox vote-andrew_b vote-winnie vote-miguel Blocking:| Blockedby: ---+ Changes (by miguel): * keywords: review vote-slyfox vote-andrew_b vote-winnie => review vote- slyfox vote-andrew_b vote-winnie vote-miguel Comment: Adding vote-miguel thanks for all the work Patrick! -- Ticket URL: Midnight Commander Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #269: Revert from mhl to Glib
#269: Revert from mhl to Glib ---+ Reporter: Patrick Winnertz | Owner: winnie Type: defect| Status: accepted Priority: major | Milestone: 4.7 Component: mc-core | Version: 4.6.2 Resolution:|Keywords: review vote-slyfox vote-andrew_b vote-winnie Blocking:| Blockedby: ---+ Comment(by winnie): Replying to [comment:5 andrew_b]: > mhl headers are still included in vfs/smbfs.c file. Thanks.. this is fixed now. -- Ticket URL: Midnight Commander Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #269: Revert from mhl to Glib
#269: Revert from mhl to Glib ---+ Reporter: Patrick Winnertz | Owner: winnie Type: defect| Status: accepted Priority: major | Milestone: 4.7 Component: mc-core | Version: 4.6.2 Resolution:|Keywords: review vote-slyfox vote-andrew_b vote-winnie Blocking:| Blockedby: ---+ Changes (by winnie): * keywords: vote-slyfox vote-andrew_b vote-winnie => review vote-slyfox vote-andrew_b vote-winnie -- Ticket URL: Midnight Commander Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #269: Revert from mhl to Glib
#269: Revert from mhl to Glib ---+ Reporter: Patrick Winnertz | Owner: winnie Type: defect| Status: accepted Priority: major | Milestone: 4.7 Component: mc-core | Version: 4.6.2 Resolution:|Keywords: vote-slyfox vote-andrew_b vote-winnie Blocking:| Blockedby: ---+ Changes (by winnie): * keywords: vote-slyfox vote-andrew_b => vote-slyfox vote-andrew_b vote- winnie -- Ticket URL: Midnight Commander Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #269: Revert from mhl to Glib
#269: Revert from mhl to Glib ---+ Reporter: Patrick Winnertz | Owner: winnie Type: defect| Status: accepted Priority: major | Milestone: 4.7 Component: mc-core | Version: 4.6.2 Resolution:|Keywords: vote-slyfox vote-andrew_b Blocking:| Blockedby: ---+ Changes (by andrew_b): * keywords: vote-slyfox => vote-slyfox vote-andrew_b -- Ticket URL: Midnight Commander Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #269: Revert from mhl to Glib
#269: Revert from mhl to Glib ---+ Reporter: Patrick Winnertz | Owner: winnie Type: defect| Status: accepted Priority: major | Milestone: 4.7 Component: mc-core | Version: 4.6.2 Resolution:|Keywords: vote-slyfox Blocking:| Blockedby: ---+ Comment(by andrew_b): mhl headers are still included in vfs/smbfs.c file. -- Ticket URL: Midnight Commander Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #269: Revert from mhl to Glib
#269: Revert from mhl to Glib ---+ Reporter: Patrick Winnertz | Owner: winnie Type: defect| Status: accepted Priority: major | Milestone: 4.7 Component: mc-core | Version: 4.6.2 Resolution:|Keywords: vote-slyfox Blocking:| Blockedby: ---+ Comment(by andrew_b): What's wrong with S-Lang? configure: error: Rejecting S-Lang with UTF-8 support, it's not fully supported yet. -- Ticket URL: Midnight Commander Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #269: Revert from mhl to Glib
#269: Revert from mhl to Glib ---+ Reporter: Patrick Winnertz | Owner: winnie Type: defect| Status: accepted Priority: major | Milestone: 4.7 Component: mc-core | Version: 4.6.2 Resolution:|Keywords: vote-slyfox Blocking:| Blockedby: ---+ Changes (by slyfox): * keywords: => vote-slyfox -- Ticket URL: Midnight Commander Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #269: Revert from mhl to Glib
#269: Revert from mhl to Glib ---+ Reporter: Patrick Winnertz | Owner: winnie Type: defect| Status: accepted Priority: major | Milestone: 4.7 Component: mc-core | Version: 4.6.2 Resolution:|Keywords: Blocking:| Blockedby: ---+ Changes (by winnie): * owner: => winnie * status: new => accepted Old description: > Hey, > > After a huge discussion in our jabber room we decided to not replace glib > with > own written code but revert this and use in the future glib. > If there are any systems which will need a very small mc there is eglib. > > As this branch was created prior filling this bug the branchname doesn't > start > with the id of this ticket but is just called "revert_mhl_to_glib". > Please > review this and vote. > > Thanks in advance > Greetings > Winnie New description: Hey, After a huge discussion in our jabber room we decided to not replace glib with own written code but revert this and use in the future glib. If there are any systems which will need a very small mc there is eglib. As this branch was created prior filling this bug the branchname doesn't start with the id of this ticket but is just called "revert_mhl_to_glib". Please review this and vote. Thanks in advance Greetings Winnie -- Comment: This is only the bug for master branch.. After applying this there we'll backport this to 4.6. -- Ticket URL: Midnight Commander Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
