Re: [Midnight Commander] #65: savannah: Pascal syntax highlighting update
#65: savannah: Pascal syntax highlighting update --+- Reporter: slavazanko | Owner: winnie Type: enhancement | Status: testing Priority: minor| Milestone: 4.6.2 Component: mc-core | Version: Resolution: fixed|Keywords: review vote-metux, vote-slavaz Blocking: | Blockedby: --+- Changes (by slavazanko): * keywords: review vote-metux = review vote-metux, vote-slavaz -- Ticket URL: www.midnight-commander.org/ticket/65#comment:11 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #65: savannah: Pascal syntax highlighting update
#65: savannah: Pascal syntax highlighting update --+- Reporter: slavazanko | Owner: winnie Type: enhancement | Status: testing Priority: minor| Milestone: 4.6.2 Component: mc-core | Version: Resolution: fixed|Keywords: review vote-metux, vote-slavazanko Blocking: | Blockedby: --+- Changes (by slavazanko): * keywords: review vote-metux, vote-slavaz = review vote-metux, vote- slavazanko -- Ticket URL: www.midnight-commander.org/ticket/65#comment:12 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #65: savannah: Pascal syntax highlighting update
#65: savannah: Pascal syntax highlighting update --+- Reporter: slavazanko | Owner: winnie Type: enhancement | Status: closed Priority: minor| Milestone: 4.6.2 Component: mc-core | Version: Resolution: fixed|Keywords: review vote-metux vote-slavazanko approved Blocking: | Blockedby: --+- Changes (by winnie): * status: testing = closed Comment: Merged into mc-4.6 and master.. therefore closing now -- Ticket URL: www.midnight-commander.org/ticket/65#comment:14 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #65: savannah: Pascal syntax highlighting update
#65: savannah: Pascal syntax highlighting update --+- Reporter: slavazanko | Owner: winnie Type: enhancement | Status: testing Priority: minor| Milestone: 4.6.2 Component: mc-core | Version: Resolution: fixed|Keywords: review vote-metux vote-slavazanko approved Blocking: | Blockedby: --+- Changes (by winnie): * keywords: review vote-metux, vote-slavazanko = review vote-metux vote-slavazanko approved Comment: Add approved keyword as 2 people have voted. -- Ticket URL: www.midnight-commander.org/ticket/65#comment:13 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #65: savannah: Pascal syntax highlighting update
#65: savannah: Pascal syntax highlighting update --+- Reporter: slavazanko | Owner: winnie Type: enhancement | Status: testing Priority: minor| Milestone: 4.6.2 Component: mc-core | Version: Resolution: fixed|Keywords: preview Blocking: | Blockedby: --+- Changes (by winnie): * keywords: = preview * status: accepted = testing * resolution: = fixed -- Ticket URL: www.midnight-commander.org/ticket/65#comment:9 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #65: savannah: Pascal syntax highlighting update
#65: savannah: Pascal syntax highlighting update --+- Reporter: slavazanko | Owner: winnie Type: enhancement | Status: accepted Priority: minor| Milestone: 4.6.2 Component: mc-core | Version: Resolution: |Keywords: Blocking: | Blockedby: --+- Comment(by Enrico Weigelt): For what language specification is this patch ? Back from my old pascal times (about 10yrs ago), there was neither anything like finalisation nor overloading. (read|write)(ln|) always have been normal functions, just Borland broke the standard by adding some compiler magic, IMHO ... cu -- Ticket URL: /ticket/65#comment: Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #65: savannah: Pascal syntax highlighting update
#65: savannah: Pascal syntax highlighting update --+- Reporter: slavazanko | Owner: winnie Type: enhancement | Status: accepted Priority: minor| Milestone: 4.6.2 Component: mc-core | Version: Resolution: |Keywords: Blocking: | Blockedby: --+- Comment(by slavazanko): I think we also should add keywords from delphi and freepascal to this file.. Just add those keywords and attach new patch (you may make new branch). Is this okay? Any idea okay, IMHO :) -- Ticket URL: www.midnight-commander.org/ticket/65#comment:8 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #65: savannah: Pascal syntax highlighting update
#65: savannah: Pascal syntax highlighting update --+- Reporter: slavazanko | Owner: winnie Type: enhancement | Status: accepted Priority: minor| Milestone: 4.6.2 Component: mc-core | Version: Resolution: |Keywords: Blocking: | Blockedby: --+- Comment(by Patrick Winnertz): Hey, finalization is a keyword from delphi to be honest. So yes.. this is a addition which was done more or less by Borland.. overloading also... I think we also should add keywords from delphi and freepascal to this file.. Is this okay? Greetings Winnie -- Ticket URL: www.midnight-commander.org/ticket/65#comment: Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #65: savannah: Pascal syntax highlighting update
#65: savannah: Pascal syntax highlighting update --+- Reporter: slavazanko | Owner: winnie Type: enhancement | Status: accepted Priority: minor| Milestone: 4.6.2 Component: mc-core | Version: Resolution: |Keywords: Blocking: | Blockedby: --+- Comment(by slavazanko): Only accepter or ticket-starter (if developer) may apply patch. For now ticket accepted to 'winnie', but you may accept yourself (and write reason). This patch will applyed only after 2 votes of developers (now only 1 vote - by Winnie, vote of pather (my) don't accepted). If any other developer will vote to this patch too (additional_pascal_keywords-rev2.patch) - patch will apply to a 'master' branch; state of ticket will change to 'testing stage'. After applying patch will need write comment to this ticket with a link to revision contains this patch. I think, this must be rules for all tickets. -- Ticket URL: http://www.midnight-commander.org/ticket/65#comment:5 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #65: savannah: Pascal syntax highlighting update
#65: savannah: Pascal syntax highlighting update --+- Reporter: slavazanko | Owner: winnie Type: enhancement | Status: accepted Priority: minor| Milestone: 4.6.2 Component: mc-core | Version: Resolution: |Keywords: Blocking: | Blockedby: --+- Comment(by metux): If it's committed, should this ticket be closed ? -- Ticket URL: http://www.midnight-commander.org/ticket/65#comment:4 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #65: savannah: Pascal syntax highlighting update
#65: savannah: Pascal syntax highlighting update --+- Reporter: slavazanko | Owner: winnie Type: enhancement | Status: accepted Priority: minor| Milestone: Component: mc-core | Version: Resolution: |Keywords: Blocking: | Blockedby: --+- Changes (by winnie): * owner: = winnie * priority: major = minor * status: new = accepted Comment: Okay, I checked it: write, read, overload and finalization are valid pascal keywords. I'm creating a patch right now. -- Ticket URL: http://www.midnight-commander.org/ticket/65#comment:2 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #65: savannah: Pascal syntax highlighting update
#65: savannah: Pascal syntax highlighting update --+- Reporter: slavazanko | Owner: winnie Type: enhancement | Status: accepted Priority: minor| Milestone: 4.6.2 Component: mc-core | Version: Resolution: |Keywords: Blocking: | Blockedby: --+- Changes (by winnie): * milestone: = 4.6.2 Comment: rev2 seems to be okay for me, therefore: +1 for rev2 Setting Milestone to 4.6.2 as this is very trivial and should be fixed within the next release. -- Ticket URL: http://www.midnight-commander.org/ticket/65#comment:3 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
