Re: [PATCH] segfault-on-invalid-mtime fix

2008-12-29 Thread Miguel de Icaza
Hello,

This patch looks good, but there are two uses of strftime as well,
it might make sense to wrap the use of strftime in a new routine that
always make this check (when localtime returns NULL).


 mc-4.6.1/src/util.c

___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel


Re: [PATCH] segfault-on-invalid-mtime fix

2008-12-29 Thread Enrico Weigelt
* Miguel de Icaza mig...@novell.com schrieb:

Hi,

 This patch looks good, but there are two uses of strftime as well,
 it might make sense to wrap the use of strftime in a new routine that
 always make this check (when localtime returns NULL).

I'm working on that.

BTW: we've got some situations where precense of strftime() is
checked (HAVE_STRFTIME) and fallback to ctime(), and some where
it is NOT. 

Should we always do the #ifdef or completely drop the fallback ? 


cu
-- 
-
 Enrico Weigelt==   metux IT service - http://www.metux.de/
-
 Please visit the OpenSource QM Taskforce:
http://wiki.metux.de/public/OpenSource_QM_Taskforce
 Patches / Fixes for a lot dozens of packages in dozens of versions:
http://patches.metux.de/
-
___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel