[mdb-discuss] code review request for 7355 mdb(1) reads lbolt through mdb_vread()

2009-09-10 Thread John Levon
On Wed, Sep 09, 2009 at 03:11:49PM -0700, Rafael Vanoni wrote: webrev @ http://cr.opensolaris.org/~rafaelv/mdb-lbolt/ mdb_ks.c:1598 Isn't this wrong for mdb examining crash dumps - it gives the live kernel's hrtime, not the dump's? Surely you should be looking for lbolt_debug_ts in the

[mdb-discuss] code review request for 7355 mdb(1) reads lbolt through mdb_vread()

2009-09-10 Thread John Levon
On Wed, Sep 09, 2009 at 11:01:35PM -0700, Rafael Vanoni wrote: webrev @ http://cr.opensolaris.org/~rafaelv/mdb-lbolt/ Why not move the panic_lbolt() read into mdb_get_lbolt() rather than duplicate it? The existing modules that don't respect panic_lbolt are essentially wrong anyway, I think, and

[mdb-discuss] code review request for 7355 mdb(1) reads lbolt through mdb_vread()

2009-09-09 Thread Rafael Vanoni
Hi folks Could someone please review my changes to (k)mdb for the tickless/lbolt project? Here's a summary of the changes: - added two new routines to mdb_ks.c, mdb_gethrtime() and mdb_get_lbolt() - moved former mdb consumers of the lbolt variable to mdb_get_lbolt() - created a new dcmd,