[MediaWiki-commits] [Gerrit] mediawiki...CentralAuth[master]: Fix premature transactions commit problems

2016-08-13 Thread Aaron Schulz (Code Review)
Aaron Schulz has uploaded a new change for review. https://gerrit.wikimedia.org/r/304688 Change subject: Fix premature transactions commit problems .. Fix premature transactions commit problems * Use startAtomic/endAtomic()

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Make transaction enforcement stricter

2016-08-13 Thread Aaron Schulz (Code Review)
Aaron Schulz has uploaded a new change for review. https://gerrit.wikimedia.org/r/304687 Change subject: Make transaction enforcement stricter .. Make transaction enforcement stricter * Nested begin() will fail for DBO_TRX

[MediaWiki-commits] [Gerrit] mediawiki...ORES[master]: Make FetchScoreJob.php more readable

2016-08-13 Thread Ladsgroup (Code Review)
Ladsgroup has uploaded a new change for review. https://gerrit.wikimedia.org/r/304686 Change subject: Make FetchScoreJob.php more readable .. Make FetchScoreJob.php more readable Based on

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: HTMLForm: Use ObjectFactory instead of Reflection

2016-08-13 Thread Legoktm (Code Review)
Legoktm has uploaded a new change for review. https://gerrit.wikimedia.org/r/304685 Change subject: HTMLForm: Use ObjectFactory instead of Reflection .. HTMLForm: Use ObjectFactory instead of Reflection ObjectFactory has a

[MediaWiki-commits] [Gerrit] mediawiki...CentralAuth[master]: Make sure status updates in jobs commit/rollback all DBs tog...

2016-08-13 Thread Aaron Schulz (Code Review)
Aaron Schulz has uploaded a new change for review. https://gerrit.wikimedia.org/r/304684 Change subject: Make sure status updates in jobs commit/rollback all DBs together .. Make sure status updates in jobs commit/rollback

[MediaWiki-commits] [Gerrit] mediawiki...Collection[master]: Allow Collection+mwlib to use an alternate URL

2016-08-13 Thread MarkAHershberger (Code Review)
MarkAHershberger has uploaded a new change for review. https://gerrit.wikimedia.org/r/304683 Change subject: Allow Collection+mwlib to use an alternate URL .. Allow Collection+mwlib to use an alternate URL Some wikis have

[MediaWiki-commits] [Gerrit] mediawiki...EventLogging[master]: Adapt code sample to provide the extension.json version inst...

2016-08-13 Thread Legoktm (Code Review)
Legoktm has uploaded a new change for review. https://gerrit.wikimedia.org/r/304682 Change subject: Adapt code sample to provide the extension.json version instead of PHP .. Adapt code sample to provide the extension.json

[MediaWiki-commits] [Gerrit] mediawiki...SecurePoll[master]: First letter of the string should be fetched using ms_substr...

2016-08-13 Thread Huji (Code Review)
Huji has uploaded a new change for review. https://gerrit.wikimedia.org/r/304681 Change subject: First letter of the string should be fetched using ms_substr() and not using square brackets; the latter is not multibyte compliant.

[MediaWiki-commits] [Gerrit] pywikibot/core[master]: Assume utf-8 encoding for JSON

2016-08-13 Thread Jberkel (Code Review)
Jberkel has uploaded a new change for review. https://gerrit.wikimedia.org/r/304680 Change subject: Assume utf-8 encoding for JSON .. Assume utf-8 encoding for JSON The wikidata sparql endpoint returns

[MediaWiki-commits] [Gerrit] mediawiki...SecurePoll[master]: Remove extra tag from the output of the tallier

2016-08-13 Thread Huji (Code Review)
Huji has uploaded a new change for review. https://gerrit.wikimedia.org/r/304679 Change subject: Remove extra tag from the output of the tallier .. Remove extra tag from the output of the tallier Bug: T142922 Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: ores: Enable uwsgi-specific statsd setup

2016-08-13 Thread Ladsgroup (Code Review)
Ladsgroup has uploaded a new change for review. https://gerrit.wikimedia.org/r/304678 Change subject: ores: Enable uwsgi-specific statsd setup .. ores: Enable uwsgi-specific statsd setup Bug: T141543 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...EventLogging[master]: Have RemoteSchema actually implement JsonSerializable

2016-08-13 Thread Legoktm (Code Review)
Legoktm has uploaded a new change for review. https://gerrit.wikimedia.org/r/304677 Change subject: Have RemoteSchema actually implement JsonSerializable .. Have RemoteSchema actually implement JsonSerializable And fix the

[MediaWiki-commits] [Gerrit] pywikibot/core[master]: flake8

2016-08-13 Thread Jberkel (Code Review)
Jberkel has uploaded a new change for review. https://gerrit.wikimedia.org/r/304676 Change subject: flake8 .. flake8 Change-Id: I610102024a0691f2ab133dfab27892a6f3b9e455 --- M pywikibot/data/sparql.py M tests/sparql_tests.py

[MediaWiki-commits] [Gerrit] pywikibot/core[master]: __str__ / __repr__ should always return str

2016-08-13 Thread Jberkel (Code Review)
Jberkel has uploaded a new change for review. https://gerrit.wikimedia.org/r/304675 Change subject: __str__ / __repr__ should always return str .. __str__ / __repr__ should always return str Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Don't pass null as 1st parameter to SpecialMobileHistory::sh...

2016-08-13 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Don't pass null as 1st parameter to SpecialMobileHistory::shouldUseSpecialHistory() .. Don't pass null as 1st parameter to

[MediaWiki-commits] [Gerrit] mediawiki...GoogleLogin[master]: Don't use protocol relative urls for Google auth client

2016-08-13 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Don't use protocol relative urls for Google auth client .. Don't use protocol relative urls for Google auth client The Google auth client requires

[MediaWiki-commits] [Gerrit] mediawiki...GoogleLogin[master]: Don't use protocol relative urls for Google auth client

2016-08-13 Thread Florianschmidtwelzow (Code Review)
Florianschmidtwelzow has uploaded a new change for review. https://gerrit.wikimedia.org/r/304674 Change subject: Don't use protocol relative urls for Google auth client .. Don't use protocol relative urls for Google auth

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Enable WikidataPageBanner on he.wikivoyage

2016-08-13 Thread Dereckson (Code Review)
Dereckson has uploaded a new change for review. https://gerrit.wikimedia.org/r/304632 Change subject: Enable WikidataPageBanner on he.wikivoyage .. Enable WikidataPageBanner on he.wikivoyage Bug: T140717 Change-Id:

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: wmgUseWPB → wmgUseWikidataPageBanner

2016-08-13 Thread Dereckson (Code Review)
Dereckson has uploaded a new change for review. https://gerrit.wikimedia.org/r/304631 Change subject: wmgUseWPB → wmgUseWikidataPageBanner .. wmgUseWPB → wmgUseWikidataPageBanner Even if WikidataPageBanner individual

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Don't pass null as 1st parameter to SpecialMobileHistory::sh...

2016-08-13 Thread Florianschmidtwelzow (Code Review)
Florianschmidtwelzow has uploaded a new change for review. https://gerrit.wikimedia.org/r/304628 Change subject: Don't pass null as 1st parameter to SpecialMobileHistory::shouldUseSpecialHistory() .. Don't pass null as 1st

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Make various MWCallableUpdate usages rollback-safe

2016-08-13 Thread Aaron Schulz (Code Review)
Aaron Schulz has uploaded a new change for review. https://gerrit.wikimedia.org/r/304627 Change subject: Make various MWCallableUpdate usages rollback-safe .. Make various MWCallableUpdate usages rollback-safe Support for

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: SpecialRecentChanges: Allow tagfilter=tag as "subpage"

2016-08-13 Thread Florianschmidtwelzow (Code Review)
Florianschmidtwelzow has uploaded a new change for review. https://gerrit.wikimedia.org/r/304626 Change subject: SpecialRecentChanges: Allow tagfilter=tag as "subpage" .. SpecialRecentChanges: Allow tagfilter=tag as "subpage"

[MediaWiki-commits] [Gerrit] mediawiki...CentralAuth[master]: SpecialGlobalRenameProgress: show backlink subtitle when val...

2016-08-13 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: SpecialGlobalRenameProgress: show backlink subtitle when valid username is specififed .. SpecialGlobalRenameProgress: show backlink subtitle when valid

[MediaWiki-commits] [Gerrit] mediawiki...ConfirmEdit[master]: Update AUTHORS.txt

2016-08-13 Thread Florianschmidtwelzow (Code Review)
Florianschmidtwelzow has uploaded a new change for review. https://gerrit.wikimedia.org/r/304624 Change subject: Update AUTHORS.txt .. Update AUTHORS.txt Change-Id: I4fab6f944e1cacbabf469d9396b85e2c8bf38f52 Also: Add

[MediaWiki-commits] [Gerrit] mediawiki...ConfirmEdit[master]: Remove CHANGELOG.md

2016-08-13 Thread Florianschmidtwelzow (Code Review)
Florianschmidtwelzow has uploaded a new change for review. https://gerrit.wikimedia.org/r/304623 Change subject: Remove CHANGELOG.md .. Remove CHANGELOG.md This extension does not maintain a changelog, so this one is really

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Lower down the maximum kafka topic partition size to 350GiB

2016-08-13 Thread Ottomata (Code Review)
Ottomata has submitted this change and it was merged. Change subject: Lower down the maximum kafka topic partition size to 350GiB .. Lower down the maximum kafka topic partition size to 350GiB Today four text/upload topic log

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Update interwiki map

2016-08-13 Thread Aude (Code Review)
Aude has uploaded a new change for review. https://gerrit.wikimedia.org/r/304622 Change subject: Update interwiki map .. Update interwiki map * wikimediadc wiki changed to https * added wikiconference.org wiki Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Use scb1002 as canary node instead of scb2001

2016-08-13 Thread Ladsgroup (Code Review)
Ladsgroup has submitted this change and it was merged. Change subject: Use scb1002 as canary node instead of scb2001 .. Use scb1002 as canary node instead of scb2001 Bug: T142630 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Use scb1002 as canary node instead of scb2001

2016-08-13 Thread Ladsgroup (Code Review)
Ladsgroup has uploaded a new change for review. https://gerrit.wikimedia.org/r/304621 Change subject: Use scb1002 as canary node instead of scb2001 .. Use scb1002 as canary node instead of scb2001 Bug: T142630 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: LogPager: Use Title::getDBkey for non-existent users' userna...

2016-08-13 Thread Glaisher (Code Review)
Glaisher has uploaded a new change for review. https://gerrit.wikimedia.org/r/304620 Change subject: LogPager: Use Title::getDBkey for non-existent users' username in query condition .. LogPager: Use Title::getDBkey for

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Fix wfLoadExtension typo

2016-08-13 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Fix wfLoadExtension typo .. Fix wfLoadExtension typo Change-Id: I9f3fac5ec924bb574389a7797eef167037f8c264 --- M wmf-config/CommonSettings.php 1 file

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Fix wfLoadExtension typo

2016-08-13 Thread Reedy (Code Review)
Reedy has uploaded a new change for review. https://gerrit.wikimedia.org/r/304618 Change subject: Fix wfLoadExtension typo .. Fix wfLoadExtension typo Change-Id: I9f3fac5ec924bb574389a7797eef167037f8c264 --- M

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Switch many extensions to use wfLoadExtension()

2016-08-13 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Switch many extensions to use wfLoadExtension() .. Switch many extensions to use wfLoadExtension() Where they have no $wg = $wmg config Tidy up

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Only require_once JsonConfig.php in one place

2016-08-13 Thread Reedy (Code Review)
Reedy has uploaded a new change for review. https://gerrit.wikimedia.org/r/304617 Change subject: Only require_once JsonConfig.php in one place .. Only require_once JsonConfig.php in one place Change-Id:

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Remove .php from WikimediaMessages

2016-08-13 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Remove .php from WikimediaMessages .. Remove .php from WikimediaMessages Change-Id: Ie1e64513e160070e1c106a813e85deda06f66a68 --- M

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Remove .php from WikimediaMessages

2016-08-13 Thread Reedy (Code Review)
Reedy has uploaded a new change for review. https://gerrit.wikimedia.org/r/304616 Change subject: Remove .php from WikimediaMessages .. Remove .php from WikimediaMessages Change-Id: Ie1e64513e160070e1c106a813e85deda06f66a68

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Remove orphaned OpenStreetMapSlippyMap config

2016-08-13 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Remove orphaned OpenStreetMapSlippyMap config .. Remove orphaned OpenStreetMapSlippyMap config Change-Id: Iaf15025712b80cf824566a7c5b336571f72f5cb5 --- M

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Load WikimediaMessages via wfLoadExtension

2016-08-13 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Load WikimediaMessages via wfLoadExtension .. Load WikimediaMessages via wfLoadExtension Bug: T140852 Depends-On:

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Remove s from VipsScaler extension.json

2016-08-13 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Remove s from VipsScaler extension.json .. Remove s from VipsScaler extension.json Change-Id: Idcb94ebe2dcdd44864a3ffb88e02ccd0aaf4c2ca --- M

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Remove s from VipsScaler extension.json

2016-08-13 Thread Reedy (Code Review)
Reedy has uploaded a new change for review. https://gerrit.wikimedia.org/r/304615 Change subject: Remove s from VipsScaler extension.json .. Remove s from VipsScaler extension.json Change-Id:

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Remove orphaned OpenStreetMapSlippyMap config

2016-08-13 Thread Reedy (Code Review)
Reedy has uploaded a new change for review. https://gerrit.wikimedia.org/r/304614 Change subject: Remove orphaned OpenStreetMapSlippyMap config .. Remove orphaned OpenStreetMapSlippyMap config Change-Id:

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Switch many extensions to use wfLoadExtension()

2016-08-13 Thread Reedy (Code Review)
Reedy has uploaded a new change for review. https://gerrit.wikimedia.org/r/304613 Change subject: Switch many extensions to use wfLoadExtension() .. Switch many extensions to use wfLoadExtension() Where they have no $wg =

[MediaWiki-commits] [Gerrit] mediawiki...WikimediaMessages[master]: Remove wikimedialicensetexts-desc, no longer needed

2016-08-13 Thread Reedy (Code Review)
Reedy has uploaded a new change for review. https://gerrit.wikimedia.org/r/304612 Change subject: Remove wikimedialicensetexts-desc, no longer needed .. Remove wikimedialicensetexts-desc, no longer needed Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Wikidata[master]: New Wikidata Build - 2016-08-13T10:00:01+0000

2016-08-13 Thread WikidataBuilder (Code Review)
WikidataBuilder has uploaded a new change for review. https://gerrit.wikimedia.org/r/304611 Change subject: New Wikidata Build - 2016-08-13T10:00:01+ .. New Wikidata Build - 2016-08-13T10:00:01+ Change-Id:

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Fix path to FancyCaptcha extension.json

2016-08-13 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Fix path to FancyCaptcha extension.json .. Fix path to FancyCaptcha extension.json Change-Id: I3522b9f24ab90d8fb151284582821fd49c2f6f37 --- M

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Fix path to FancyCaptcha extension.json

2016-08-13 Thread Reedy (Code Review)
Reedy has uploaded a new change for review. https://gerrit.wikimedia.org/r/304610 Change subject: Fix path to FancyCaptcha extension.json .. Fix path to FancyCaptcha extension.json Change-Id:

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: 8 more to extension.json in extension-list

2016-08-13 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: 8 more to extension.json in extension-list .. 8 more to extension.json in extension-list Bug: T139800 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Contributors[master]: Add an option to the Special:contributors to show the contri...

2016-08-13 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Add an option to the Special:contributors to show the contributors to subpages. .. Add an option to the Special:contributors to show the contributors to

[MediaWiki-commits] [Gerrit] mediawiki...Contributors[master]: Add the first and last date of edits made by a contributor.

2016-08-13 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Add the first and last date of edits made by a contributor. .. Add the first and last date of edits made by a contributor. Bug: T139883 Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Lower down the maximum kafka topic partition size to 350GiB

2016-08-13 Thread Elukey (Code Review)
Elukey has uploaded a new change for review. https://gerrit.wikimedia.org/r/304609 Change subject: Lower down the maximum kafka topic partition size to 350GiB .. Lower down the maximum kafka topic partition size to 350GiB

[MediaWiki-commits] [Gerrit] mediawiki...Contributors[master]: To have an improved tabular display of the contributor list

2016-08-13 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: To have an improved tabular display of the contributor list .. To have an improved tabular display of the contributor list Bug: T139879 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Echo[master]: Bundle mention success and failure notifications

2016-08-13 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Bundle mention success and failure notifications .. Bundle mention success and failure notifications Adds common bundling including messages and icons.

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: De-duplicate IncomingMessage action

2016-08-13 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: De-duplicate IncomingMessage action .. De-duplicate IncomingMessage action Change-Id: I0a1b311fdfa6c3d1968cf7e0ae21aa18f4c994ad --- R

[MediaWiki-commits] [Gerrit] wikimedia...civicrm-buildkit[master]: Use module list from crm repo

2016-08-13 Thread Awight (Code Review)
Awight has submitted this change and it was merged. Change subject: Use module list from crm repo .. Use module list from crm repo This will keep vagrant and tests in sync, and require fewer extra commits when adding or

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: Legacy PayPal: send pending message.

2016-08-13 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Legacy PayPal: send pending message. .. Legacy PayPal: send pending message. Will be used by SmashPig job to get utm tracking data Bug: T141654

[MediaWiki-commits] [Gerrit] wikimedia...crm[master]: globalcollect_audit doesn't need contribution_audit

2016-08-13 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: globalcollect_audit doesn't need contribution_audit .. globalcollect_audit doesn't need contribution_audit Rename constants to make them clearly GC-only.

[MediaWiki-commits] [Gerrit] wikimedia...crm[master]: Remove prototype dedupe interface

2016-08-13 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/304606 Change subject: Remove prototype dedupe interface .. Remove prototype dedupe interface Change-Id: Ieb849d8b14dead28bd4b0d8b8af12193cdd70f7d

[MediaWiki-commits] [Gerrit] wikimedia...crm[master]: Remove rotten audit module

2016-08-13 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/304605 Change subject: Remove rotten audit module .. Remove rotten audit module Change-Id: Id54b753d11388cb0e9e6185cd8781a2d18080158 --- D

[MediaWiki-commits] [Gerrit] mediawiki...release[master]: use gerrit command over ssh to vote code-review +2 on the wi...

2016-08-13 Thread 20after4 (Code Review)
20after4 has uploaded a new change for review. https://gerrit.wikimedia.org/r/304604 Change subject: use gerrit command over ssh to vote code-review +2 on the wikiversion bump .. use gerrit command over ssh to vote

[MediaWiki-commits] [Gerrit] mediawiki...PerformanceInspector[master]: Include the NewPP report in Performance inspector

2016-08-13 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Include the NewPP report in Performance inspector .. Include the NewPP report in Performance inspector Lets display the information from the NewPP report

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Fix importation of weird file names in importTextFiles.php

2016-08-13 Thread TTO (Code Review)
TTO has uploaded a new change for review. https://gerrit.wikimedia.org/r/304603 Change subject: Fix importation of weird file names in importTextFiles.php .. Fix importation of weird file names in importTextFiles.php When