Hello Reedy, Subins2000, MtDu, Legoktm, Florianschmidtwelzow, jenkins-bot,
Siebrand,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/330102
to review the following change.
Change subject: Revert "Replaced Linker::link() & Linker::linkKnown() with
LinkRender
SamanthaNguyen has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/330101 )
Change subject: v3.1.5 - Remove unused scripts
..
v3.1.5 - Remove unused scripts
Change-Id: I19349d4072aa207b1067f4cea63609cb3f21db0
jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/327897 )
Change subject: Add `showThumbnails` option to slideshow galleries
..
Add `showThumbnails` option to slideshow galleries
This o
jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/329714 )
Change subject: Rebaser: Separate namespace creation from /doc/edit
..
Rebaser: Separate namespace creation from /doc/edit
Chan
jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/330042 )
Change subject: listpages.py: fix help on formatting
..
listpages.py: fix help on formatting
Change-Id: Ib59ba3182130624f01bb40
SamanthaNguyen has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/330100 )
Change subject: Replace hard-coded English strings with i18n messages
..
Replace hard-coded English strings with i18n messages
Also
jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/330095 )
Change subject: Change "Go" to "List pages"
..
Change "Go" to "List pages"
Bug: T154347
Change-Id: I1de14f7350e0a74f55eeb434120
jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/330099 )
Change subject: Replace assertRaises with asserRaisesRegex in family_tests.py
..
Replace assertRaises with asserRaisesRegex in f
MtDu has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/330099 )
Change subject: Replace assertRaises with asserRaisesRegex in family_tests.py
..
Replace assertRaises with asserRaisesRegex in family_tests.py
jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/330098 )
Change subject: Make extension description more i18n-friendly
..
Make extension description more i18n-friendly
Change-Id: I8657
SamanthaNguyen has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/330098 )
Change subject: Make extension description more i18n-friendly
..
Make extension description more i18n-friendly
Change-Id: I8657654b2
SamanthaNguyen has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/330097 )
Change subject: Remove duplicate i18n messages, use semantic HTML element
..
Remove duplicate i18n messages, use semantic HTML elemen
jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/330062 )
Change subject: Update Maintenance scripts to use $this->requireExtension()
..
Update Maintenance scripts to use $this->requireE
jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/330063 )
Change subject: Update Maintenance scripts to use $this->requireExtension()
..
Update Maintenance scripts to use $this->requireE
Eileen has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/330096 )
Change subject: Add small extension to mark dead contacts as opted out.
..
Add small extension to mark dead contacts as opted out.
On instal
Ladsgroup has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/330095 )
Change subject: Change "Go" to "List pages"
..
Change "Go" to "List pages"
Bug: T154347
Change-Id: I1de14f7350e0a74f55eeb434120cd34e652ff
SamanthaNguyen has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/330094 )
Change subject: Remove deprecated PHP entry point
..
Remove deprecated PHP entry point
Bug: T154411
Change-Id: I7b392afb26db131fbdc1
SamanthaNguyen has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/330093 )
Change subject: Rewording for "autohide" i18n messages so they make more sense
..
Rewording for "autohide" i18n messages so they make
jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/330085 )
Change subject: Add grunt-jsonlint
..
Add grunt-jsonlint
Together with existing grunt-banana-checker this will check for valid
jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/330088 )
Change subject: Add grunt-jsonlint
..
Add grunt-jsonlint
Together with existing grunt-banana-checker this will check for valid
jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/330084 )
Change subject: Lowercase content i18n messages for consistency
..
Lowercase content i18n messages for consistency
Also make wo
Umherirrender has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/330091 )
Change subject: Add grunt-jsonlint
..
Add grunt-jsonlint
Together with existing grunt-banana-checker this will check for valid
i18n f
Umherirrender has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/330092 )
Change subject: Add grunt-jsonlint
..
Add grunt-jsonlint
Together with existing grunt-banana-checker this will check for valid
i18n f
Umherirrender has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/330090 )
Change subject: Add grunt-jsonlint
..
Add grunt-jsonlint
Together with existing grunt-banana-checker this will check for valid
i18n f
Umherirrender has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/330089 )
Change subject: Add grunt-jsonlint
..
Add grunt-jsonlint
Together with existing grunt-banana-checker this will check for valid
i18n f
Umherirrender has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/330088 )
Change subject: Add grunt-jsonlint
..
Add grunt-jsonlint
Together with existing grunt-banana-checker this will check for valid
i18n f
Umherirrender has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/330087 )
Change subject: Add grunt-jsonlint
..
Add grunt-jsonlint
Together with existing grunt-banana-checker this will check for valid
i18n f
Umherirrender has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/330086 )
Change subject: Add grunt-jsonlint
..
Add grunt-jsonlint
Together with existing grunt-banana-checker this will check for valid
i18n f
Umherirrender has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/330085 )
Change subject: Add grunt-jsonlint
..
Add grunt-jsonlint
Together with existing grunt-banana-checker this will check for valid
i18n f
SamanthaNguyen has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/330084 )
Change subject: Lowercase content i18n messages for consistency
..
Lowercase content i18n messages for consistency
Bug: T152879
Chan
Awu42 has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/330083 )
Change subject: Converted Special:Tags to OOUI
..
Converted Special:Tags to OOUI
Updated forms to use OOUI with HTMLForm::factory()
Change-I
jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/330081 )
Change subject: Avoid passing $this by reference in hooks
..
Avoid passing $this by reference in hooks
Renamed $this passed by
Paladox has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/330082 )
Change subject: Update some packages
..
Update some packages
Update karma to 1.1.2, changelog at
https://github.com/karma-runner/karma/blob
Georggi199 has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/330081 )
Change subject: Avoid passing $this by reference in hooks
..
Avoid passing $this by reference in hooks
Renamed $this passed by reference
Paladox has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/330080 )
Change subject: Test do not merge
..
Test do not merge
Change-Id: I89fe5a3c3a3e45bb9e3230dcb67438325e988c42
---
0 files changed, 0 insertio
Umherirrender has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/330079 )
Change subject: [FundraisingEmailUnsubscribe] add npm job
..
[FundraisingEmailUnsubscribe] add npm job
package.json was added with Ie
Umherirrender has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/330078 )
Change subject: [FundraisingChart] add npm job
..
[FundraisingChart] add npm job
package.json was added with 170bac9c85e053c036e027bb
Umherirrender has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/330077 )
Change subject: [AWS] add npm job
..
[AWS] add npm job
package.json was added with Iedaf44ee92e992e6c1ad4e27dc73a894d1f93b27
Change-
Umherirrender has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/330076 )
Change subject: [BlueSky] add npm job
..
[BlueSky] add npm job
package.json is there since begin
Icb20b470f42f3a8e99b1592cc466cee2060
jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/329767 )
Change subject: Replaced deprecated Linker::link() usages
..
Replaced deprecated Linker::link() usages
Bug: T149346
Change-Id:
jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/330066 )
Change subject: Remove unneeded devDependencies "jshint"
..
Remove unneeded devDependencies "jshint"
Repo is using grunt with g
jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/329812 )
Change subject: Enable translations for the Material skin
..
Enable translations for the Material skin
Requires I50828b6056f220
Hashar has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/330075 )
Change subject: [WikiLove] add npm for banana check
..
[WikiLove] add npm for banana check
Source change https://gerrit.wikimedia.org/r/#/c/
jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/329764 )
Change subject: Replace mocks of DatabaseMysql by DatabaseMysqli
..
Replace mocks of DatabaseMysql by DatabaseMysqli
The class
Umherirrender has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/330073 )
Change subject: Add grunt-banana-checker
..
Add grunt-banana-checker
Change-Id: I830665f626bc71b8332262a300acbb693e80fd25
---
M Grunt
Umherirrender has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/330072 )
Change subject: Call jshint over grunt
..
Call jshint over grunt
This allows to add grunt-banana-checker later
Change-Id: I50a1084a6
Umherirrender has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/330071 )
Change subject: Add grunt-banana-checker
..
Add grunt-banana-checker
Change-Id: I28490befec5d0324f63e5e52ca1c6b7078e353ff
---
M Grunt
Umherirrender has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/330070 )
Change subject: Call jshint and jscs over grunt
..
Call jshint and jscs over grunt
This allows to add grunt-banana-checker later
Cha
Umherirrender has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/330069 )
Change subject: Add grunt-banana-checker
..
Add grunt-banana-checker
Change-Id: I6ac354efd91a2dcc06886d1a615e331537d61df2
---
M Grunt
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/330068 )
Change subject: Apply webkit GPU hack to scrollable panels
..
Apply webkit GPU hack to scrollable panels
Bug: T154385
Change-Id: Ie8b99bf8
Umherirrender has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/330067 )
Change subject: Call jshint and jscs over grunt
..
Call jshint and jscs over grunt
This allows to add grunt-banana-checker later
Cha
jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/330044 )
Change subject: Use content language for Babel AutoCreate's edit summaries
..
Use content language for Babel AutoCreate's edit s
Umherirrender has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/330066 )
Change subject: Remove unneeded devDependencies "jshint"
..
Remove unneeded devDependencies "jshint"
Repo is using grunt with grunt-c
Umherirrender has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/330065 )
Change subject: Fix extension name in $wgMessagesDirs key
..
Fix extension name in $wgMessagesDirs key
Change-Id: I44754e462e21c0f014
jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/329673 )
Change subject: jquery.tablesorter: Sort invalid elements as -Infinity
..
jquery.tablesorter: Sort invalid elements as -Infinity
Umherirrender has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/330064 )
Change subject: Update grunt to 1.0.1
..
Update grunt to 1.0.1
Rename grunt.js to Gruntfile.js to match the name used in all other
re
jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/329801 )
Change subject: Removed deprecated Title::moveNoAuth function
..
Removed deprecated Title::moveNoAuth function
(deprecated sinc
jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/329807 )
Change subject: Fix typo in unresolved-property-category-desc
..
Fix typo in unresolved-property-category-desc
"can not" -> "ca
Divadsn has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/330063 )
Change subject: Update Maintenance scripts to use $this->requireExtension()
..
Update Maintenance scripts to use $this->requireExtension()
jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/330060 )
Change subject: Update Maintenance scripts to use $this->requireExtension()
..
Update Maintenance scripts to use $this->requireE
Divadsn has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/330062 )
Change subject: Update Maintenance scripts to use $this->requireExtension()
..
Update Maintenance scripts to use $this->requireExtension()
Umherirrender has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/330061 )
Change subject: [WikiLove] add npm job
..
[WikiLove] add npm job
Needed with I288e902ec922cff36f2dbd3332644bbf527e6301
Bug: T150332
jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/320597 )
Change subject: Add npm entry point and banana i18n linter
..
Add npm entry point and banana i18n linter
Bug: T150332
Change-Id
Divadsn has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/330060 )
Change subject: Update Maintenance scripts to use $this->requireExtension()
..
Update Maintenance scripts to use $this->requireExtension()
Umherirrender has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/330059 )
Change subject: [WikiLexicalData] Change to composer-test
..
[WikiLexicalData] Change to composer-test
Related I6124fab4d64028d7a9a45
Umherirrender has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/330058 )
Change subject: Add composer.json for php-parallel-lint
..
Add composer.json for php-parallel-lint
repo contains folder with spaces,
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/330057 )
Change subject: php: Use new array syntax
..
php: Use new array syntax
Change-Id: Ifa264114b1de6d9397d1ab0a7b8e54b135cebcf5
---
M Extensio
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/330055 )
Change subject: Use ActionFieldLayout for dropdown+button
..
Use ActionFieldLayout for dropdown+button
Change-Id: Ia1feba432b6221bbb0a034b
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/330054 )
Change subject: build: Replace jshint/jscs with eslint & stylelint
..
build: Replace jshint/jscs with eslint & stylelint
Change-Id: I020da
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/330056 )
Change subject: Replace IDs with classes
..
Replace IDs with classes
Change-Id: Id007aefa2eaaa6a7d7fe4288fe48fa7b840901e1
---
M includes/s
jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/330050 )
Change subject: Change extension url to https
..
Change extension url to https
Change-Id: Ib0fc39614b0576918242541dd989afcef3a7
jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/330053 )
Change subject: Make the signature of UploadAvatar::performUpload() consistent
with UploadBase::performUpload() to get rid of an E_STRICT notice
jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/329773 )
Change subject: Removed deprecated class ImageGallery
..
Removed deprecated class ImageGallery
Bug: T61113
Change-Id: If315002e
Jack Phoenix has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/330053 )
Change subject: Make the signature of UploadAvatar::performUpload() consistent
with UploadBase::performUpload() to get rid of an E_STRICT notice
..
jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/329768 )
Change subject: Replaced deprecated Linker::link() usages
..
Replaced deprecated Linker::link() usages
Bug: T149346
Change-Id:
jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/329769 )
Change subject: Replaced deprecated Linker::link() usages
..
Replaced deprecated Linker::link() usages
Bug: T149346
Change-Id:
Umherirrender has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/330052 )
Change subject: Change extension url to https
..
Change extension url to https
Change-Id: I628231f57fcc95f2686611354199d38e873ac38d
-
Umherirrender has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/330051 )
Change subject: Change extension url to https
..
Change extension url to https
Change-Id: If1b65e737a83d8e235f8103443c92d33573b6401
-
Umherirrender has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/330050 )
Change subject: Change extension url to https
..
Change extension url to https
Change-Id: Ib0fc39614b0576918242541dd989afcef3a7ec2b
-
Umherirrender has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/330049 )
Change subject: Change extension url to https
..
Change extension url to https
Change-Id: Ibac2dcf811d414ed844caf14a1990d59bcee3ebb
-
Filip has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/330048 )
Change subject: Removed unnecessary logging/
..
Removed unnecessary logging/
Deletion and restore are unnecessary, becouse they're logged in
jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/329690 )
Change subject: Remove unit test hack, no longer needed.
..
Remove unit test hack, no longer needed.
Change-Id: Iff757ba0eac1ef
Umherirrender has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/330047 )
Change subject: Rename api example message of oathvalidate
..
Rename api example message of oathvalidate
To make clear from the messa
jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/329657 )
Change subject: Remove serialization test cheat; make tests actually pass
..
Remove serialization test cheat; make tests actuall
jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/328700 )
Change subject: ce.Surface: in blur, make sure activeElement exists before
blurring it
..
ce.Surface: in blur, make sure active
TTO has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/330046 )
Change subject: Add language name as second parameter to babel-portal message
..
Add language name as second parameter to babel-portal message
Umherirrender has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/330045 )
Change subject: Fix param values in apihelp
..
Fix param values in apihelp
When there are extra messages for the param values, than t
TTO has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/330044 )
Change subject: Use content language for Babel AutoCreate's edit summaries
..
Use content language for Babel AutoCreate's edit summaries
Doesn'
TTO has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/330043 )
Change subject: Fix disappearing language names on Category: and File: pages
..
Fix disappearing language names on Category: and File: pages
Wh
Mpaa has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/330042 )
Change subject: listpages.py: fix help on formatting
..
listpages.py: fix help on formatting
Change-Id: Ib59ba3182130624f01bb4068a2e525c0862e5
jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/329644 )
Change subject: Using pytest-httpbin
..
Using pytest-httpbin
Now http_tests use pytest-httpbin if pytest is used to run the tes
TTO has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/330041 )
Change subject: Map MediaWiki's fake language codes to real ones
..
Map MediaWiki's fake language codes to real ones
'My understanding of the p
Nikerabbit has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/330040 )
Change subject: Allow betawiki to restart mw-jobrunner
..
Allow betawiki to restart mw-jobrunner
This allows me to add restart command t
Nikerabbit has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/330039 )
Change subject: Allow moving all pages for translation admins (translate-manage)
..
Allow moving all pages for translation admins (transl
WikidataBuilder has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/330038 )
Change subject: New Wikidata Build - 2017-01-01T10:00:02+
..
New Wikidata Build - 2017-01-01T10:00:02+
Change-Id: I13153a72
95 matches
Mail list logo