[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: db-eqiad.php: Depool db1110

2017-12-28 Thread Marostegui (Code Review)
Marostegui has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400630 ) Change subject: db-eqiad.php: Depool db1110 .. db-eqiad.php: Depool db1110 Going to use it to rebuild dewiki.imagelinks and

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Improve @covers tags

2017-12-28 Thread Legoktm (Code Review)
Legoktm has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400629 ) Change subject: Improve @covers tags .. Improve @covers tags Change-Id: I94c29a2d90fc992a6798a58c560a249ab6c58d53 --- M

[MediaWiki-commits] [Gerrit] mediawiki...ProofreadPage[master]: Make @covers tags absolute

2017-12-28 Thread Legoktm (Code Review)
Legoktm has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400628 ) Change subject: Make @covers tags absolute .. Make @covers tags absolute Change-Id: Ifd6d5a209d4b9e1d39ccfb514aac8ef5ed0b969b --- M

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Make ImagePage#getThumbPrevText and ImagePage#makeSizeLink p...

2017-12-28 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/399574 ) Change subject: Make ImagePage#getThumbPrevText and ImagePage#makeSizeLink protected instead of private .. Make

[MediaWiki-commits] [Gerrit] mediawiki...Newsletter[master]: Unit test NewsletterDb::updateMainPage

2017-12-28 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/400600 ) Change subject: Unit test NewsletterDb::updateMainPage .. Unit test NewsletterDb::updateMainPage Bug: T183620 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: [wip] mw.widgets: Add SizeFilterWidget and its PHP implement...

2017-12-28 Thread Prtksxna (Code Review)
Prtksxna has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400627 ) Change subject: [wip] mw.widgets: Add SizeFilterWidget and its PHP implementation .. [wip] mw.widgets: Add SizeFilterWidget and its PHP

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Special:ProtectedPages: Add fields directly in $formDescriptor

2017-12-28 Thread Prtksxna (Code Review)
Prtksxna has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400626 ) Change subject: Special:ProtectedPages: Add fields directly in $formDescriptor .. Special:ProtectedPages: Add fields directly in

[MediaWiki-commits] [Gerrit] mediawiki...ORES[master]: Clean up ThresholdLookup

2017-12-28 Thread Ladsgroup (Code Review)
Ladsgroup has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400625 ) Change subject: Clean up ThresholdLookup .. Clean up ThresholdLookup - Using proper dependency injection, specially for services -

[MediaWiki-commits] [Gerrit] pywikibot/core[master]: Creating daemonize_tests.py

2017-12-28 Thread Eisenhaus335 (Code Review)
Eisenhaus335 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400624 ) Change subject: Creating daemonize_tests.py .. Creating daemonize_tests.py Change-Id: If29aed0d8c8103d811a89c2dabda3f5f58833192 --- M

[MediaWiki-commits] [Gerrit] mediawiki...ORES[master]: Integration tests for API

2017-12-28 Thread Ladsgroup (Code Review)
Ladsgroup has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400623 ) Change subject: Integration tests for API .. Integration tests for API Bug: T182942 Change-Id: Ice9ba784e51021a16b29c28c622212612830dc8d

[MediaWiki-commits] [Gerrit] mediawiki...ORES[master]: Fix ORES API hook handlers

2017-12-28 Thread Ladsgroup (Code Review)
Ladsgroup has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400622 ) Change subject: Fix ORES API hook handlers .. Fix ORES API hook handlers While writing integration tests, I found out that I completely

[MediaWiki-commits] [Gerrit] pywikibot/core[master]: Creating daemonize_tests.py

2017-12-28 Thread Eisenhaus335 (Code Review)
Eisenhaus335 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400621 ) Change subject: Creating daemonize_tests.py .. Creating daemonize_tests.py Change-Id: I76893da106d981fe87c6610cf69f8d3173ec3fc3 --- M

[MediaWiki-commits] [Gerrit] pywikibot/core[master]: Creating daemonize_tests.py

2017-12-28 Thread Eisenhaus335 (Code Review)
Eisenhaus335 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400620 ) Change subject: Creating daemonize_tests.py .. Creating daemonize_tests.py Change-Id: I33f7d7bc1f794c83f07dacd93ce5abe4a124bf15 --- M

[MediaWiki-commits] [Gerrit] mediawiki...SocialProfile[master]: Clean up permission checks in special pages

2017-12-28 Thread SamanthaNguyen (Code Review)
SamanthaNguyen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400619 ) Change subject: Clean up permission checks in special pages .. Clean up permission checks in special pages This patch helps cleans

[MediaWiki-commits] [Gerrit] mediawiki...WikidataPageBanner[master]: Fix function names in @covers

2017-12-28 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/400611 ) Change subject: Fix function names in @covers .. Fix function names in @covers Needs to contain a class name Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Remove duplicate getTitle call in RevisionStore::getNextRevi...

2017-12-28 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/400578 ) Change subject: Remove duplicate getTitle call in RevisionStore::getNextRevision .. Remove duplicate getTitle call in

[MediaWiki-commits] [Gerrit] mediawiki...TwoColConflict[master]: Use :: instead of -> in @covers

2017-12-28 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/400612 ) Change subject: Use :: instead of -> in @covers .. Use :: instead of -> in @covers Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: [MCR] pass $queryFlags into RevisionStore::getTitle

2017-12-28 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/400577 ) Change subject: [MCR] pass $queryFlags into RevisionStore::getTitle .. [MCR] pass $queryFlags into RevisionStore::getTitle

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Remove three deprecated functions from the Revision class.

2017-12-28 Thread Matthewrbowker (Code Review)
Matthewrbowker has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400618 ) Change subject: Remove three deprecated functions from the Revision class. .. Remove three deprecated functions from the Revision

[MediaWiki-commits] [Gerrit] pywikibot/core[master]: Made download_dump.py download process atomic

2017-12-28 Thread Ryan10145 (Code Review)
Ryan10145 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400616 ) Change subject: Made download_dump.py download process atomic .. Made download_dump.py download process atomic Bug: T183675 Change-Id:

[MediaWiki-commits] [Gerrit] pywikibot/core[master]: Add kwargs tp changeRank

2017-12-28 Thread Smalyshev (Code Review)
Smalyshev has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400617 ) Change subject: Add kwargs tp changeRank .. Add kwargs tp changeRank This will allow to set summaries when changing rank. Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Use ExtensionRegistry instead of class_exists

2017-12-28 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/400398 ) Change subject: Use ExtensionRegistry instead of class_exists .. Use ExtensionRegistry instead of class_exists Bug: T183096

[MediaWiki-commits] [Gerrit] mediawiki...Echo[master]: Use ExtensionRegistry instead of class_exists

2017-12-28 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/400395 ) Change subject: Use ExtensionRegistry instead of class_exists .. Use ExtensionRegistry instead of class_exists Bug: T183096

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Remove leading backslashes from "use \…" tags

2017-12-28 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/400586 ) Change subject: Remove leading backslashes from "use \…" tags .. Remove leading backslashes from "use \…" tags Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: icinga: script to send custom SMS to Icinga contacts

2017-12-28 Thread Dzahn (Code Review)
Dzahn has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400615 ) Change subject: icinga: script to send custom SMS to Icinga contacts .. icinga: script to send custom SMS to Icinga contacts Bug: T82937

[MediaWiki-commits] [Gerrit] mediawiki...CirrusSearch[master]: Use ExtensionRegistry instead of class_exists

2017-12-28 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/400576 ) Change subject: Use ExtensionRegistry instead of class_exists .. Use ExtensionRegistry instead of class_exists Bug: T183096

[MediaWiki-commits] [Gerrit] mediawiki...Translate[master]: Migrate GettextFFS keyAlgorithm default value to simple

2017-12-28 Thread Phantom42 (Code Review)
Phantom42 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400614 ) Change subject: Migrate GettextFFS keyAlgorithm default value to simple .. Migrate GettextFFS keyAlgorithm default value to simple The

[MediaWiki-commits] [Gerrit] translatewiki[master]: Update groups GettextFFS keyAlgorithm

2017-12-28 Thread Phantom42 (Code Review)
Phantom42 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400613 ) Change subject: Update groups GettextFFS keyAlgorithm .. Update groups GettextFFS keyAlgorithm This is a part of migration of GettextFFS

[MediaWiki-commits] [Gerrit] mediawiki...TwoColConflict[master]: Use :: instead of -> in @covers

2017-12-28 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400612 ) Change subject: Use :: instead of -> in @covers .. Use :: instead of -> in @covers Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Newsletter[master]: Fix broken API edit after notifyPublishers change

2017-12-28 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/400610 ) Change subject: Fix broken API edit after notifyPublishers change .. Fix broken API edit after notifyPublishers change

[MediaWiki-commits] [Gerrit] mediawiki...WikivoteMapsYandex[master]: Install mediawiki/maps over composer

2017-12-28 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/393107 ) Change subject: Install mediawiki/maps over composer .. Install mediawiki/maps over composer Extension is on github Test

[MediaWiki-commits] [Gerrit] mediawiki...WikidataPageBanner[master]: Fix function names in @covers

2017-12-28 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400611 ) Change subject: Fix function names in @covers .. Fix function names in @covers Needs to contain a class name Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Newsletter[master]: Fix broken API edit after notifyPublishers change

2017-12-28 Thread 01tonythomas (Code Review)
01tonythomas has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400610 ) Change subject: Fix broken API edit after notifyPublishers change .. Fix broken API edit after notifyPublishers change Change-Id:

[MediaWiki-commits] [Gerrit] translatewiki[master]: [puppet] Pin elasticsearch to avoid cron spam

2017-12-28 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/400608 ) Change subject: [puppet] Pin elasticsearch to avoid cron spam .. [puppet] Pin elasticsearch to avoid cron spam Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Newsletter[master]: Unit test NewsletterDb::removePublisher

2017-12-28 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/400609 ) Change subject: Unit test NewsletterDb::removePublisher .. Unit test NewsletterDb::removePublisher Bug: T183616 Change-Id:

[MediaWiki-commits] [Gerrit] integration/uprightdiff[debian]: uprightdiff (1.3.0-1) unstable; urgency=medium

2017-12-28 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/387521 ) Change subject: uprightdiff (1.3.0-1) unstable; urgency=medium .. uprightdiff (1.3.0-1) unstable; urgency=medium Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...EventBus[master]: Fix unintentionally created global functions in EventBusHooks

2017-12-28 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/400571 ) Change subject: Fix unintentionally created global functions in EventBusHooks .. Fix unintentionally created global functions

[MediaWiki-commits] [Gerrit] mediawiki...Newsletter[master]: Unit test NewsletterDb::removePublisher

2017-12-28 Thread Ryan10145 (Code Review)
Ryan10145 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400609 ) Change subject: Unit test NewsletterDb::removePublisher .. Unit test NewsletterDb::removePublisher Bug: T183616 Change-Id:

[MediaWiki-commits] [Gerrit] translatewiki[master]: [puppet] Pin elasticsearch to avoid cron spam

2017-12-28 Thread Nikerabbit (Code Review)
Nikerabbit has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400608 ) Change subject: [puppet] Pin elasticsearch to avoid cron spam .. [puppet] Pin elasticsearch to avoid cron spam Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...ORES[master]: Clean up ThresholdLookup, make the cache key use model version

2017-12-28 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/400196 ) Change subject: Clean up ThresholdLookup, make the cache key use model version .. Clean up ThresholdLookup, make the cache key

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Revert "[MCR] Add and use $title param to RevisionStore getP...

2017-12-28 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400604 ) Change subject: Revert "[MCR] Add and use $title param to RevisionStore getPrevious/Next" .. Revert "[MCR] Add and use $title param to

[MediaWiki-commits] [Gerrit] mediawiki...CirrusSearch[master]: Remove leading backslashes from "use \…" tags

2017-12-28 Thread Thiemo Kreuz (WMDE) (Code Review)
Thiemo Kreuz (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400607 ) Change subject: Remove leading backslashes from "use \…" tags .. Remove leading backslashes from "use \…" tags Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Improve 1-letter variable names in MutableContext and implem...

2017-12-28 Thread Thiemo Kreuz (WMDE) (Code Review)
Thiemo Kreuz (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400606 ) Change subject: Improve 1-letter variable names in MutableContext and implementations .. Improve 1-letter variable names in

[MediaWiki-commits] [Gerrit] mediawiki...EventBus[master]: Revert "Pass a Title to Revision::newFromId in onRevisionIns...

2017-12-28 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400603 ) Change subject: Revert "Pass a Title to Revision::newFromId in onRevisionInsertComplete" .. Revert "Pass a Title to Revision::newFromId

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Revert "[MCR] Add optional $title param to Revision byId met...

2017-12-28 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400602 ) Change subject: Revert "[MCR] Add optional $title param to Revision byId methods" .. Revert "[MCR] Add optional $title param to Revision

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Add lfn.wikipedia.org to RESTBase

2017-12-28 Thread Jayprakash (Code Review)
Jayprakash has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400601 ) Change subject: Add lfn.wikipedia.org to RESTBase .. Add lfn.wikipedia.org to RESTBase Bug: T183561 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Newsletter[master]: Unit test NewsletterDb::updateMainPage

2017-12-28 Thread Divadsn (Code Review)
Divadsn has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400600 ) Change subject: Unit test NewsletterDb::updateMainPage .. Unit test NewsletterDb::updateMainPage Bug: T183620 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...SemanticGenealogy[master]: Remove obvious, non-helpful documentation snippets

2017-12-28 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/400574 ) Change subject: Remove obvious, non-helpful documentation snippets .. Remove obvious, non-helpful documentation snippets

[MediaWiki-commits] [Gerrit] mediawiki...Newsletter[master]: Improve visual hierarchy on Newsletter page

2017-12-28 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/400451 ) Change subject: Improve visual hierarchy on Newsletter page .. Improve visual hierarchy on Newsletter page Bug: T180982

[MediaWiki-commits] [Gerrit] pywikibot/core[master]: Creating daemonize_tests.py

2017-12-28 Thread Eisenhaus335 (Code Review)
Eisenhaus335 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400599 ) Change subject: Creating daemonize_tests.py .. Creating daemonize_tests.py Change-Id: Idc867df606a8cfa2d392d41b67710bed2f3570b5 --- M

[MediaWiki-commits] [Gerrit] operations...scap[master]: add wmflabs config for dumps scap

2017-12-28 Thread ArielGlenn (Code Review)
ArielGlenn has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400598 ) Change subject: add wmflabs config for dumps scap .. add wmflabs config for dumps scap Change-Id:

[MediaWiki-commits] [Gerrit] pywikibot/core[master]: Creating daemonize_tests.py

2017-12-28 Thread Eisenhaus335 (Code Review)
Eisenhaus335 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400597 ) Change subject: Creating daemonize_tests.py .. Creating daemonize_tests.py Change-Id: Icc6e72f8067c4da5e07abaf76b0e3d23859a6a6b --- M

[MediaWiki-commits] [Gerrit] pywikibot/core[master]: Creating daemonize_tests.py

2017-12-28 Thread Eisenhaus335 (Code Review)
Eisenhaus335 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400596 ) Change subject: Creating daemonize_tests.py .. Creating daemonize_tests.py Change-Id: I21adc517a98b8c966bd39a915fd5896b1db4b694 --- M

[MediaWiki-commits] [Gerrit] pywikibot/core[master]: Creating daemonize_tests.py

2017-12-28 Thread Eisenhaus335 (Code Review)
Eisenhaus335 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400595 ) Change subject: Creating daemonize_tests.py .. Creating daemonize_tests.py Change-Id: I1099f775a0f51bbfebb4349239ea8447d0b61b81 --- M

[MediaWiki-commits] [Gerrit] pywikibot/core[master]: Creating daemonize_tests.py

2017-12-28 Thread Eisenhaus335 (Code Review)
Eisenhaus335 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400594 ) Change subject: Creating daemonize_tests.py .. Creating daemonize_tests.py Change-Id: I1ba1dd5a814054b2da9ef5d3d997f710f42d85bf --- M

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Remove some obvious, self-explaining PHPDoc snippets

2017-12-28 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/400569 ) Change subject: Remove some obvious, self-explaining PHPDoc snippets .. Remove some obvious, self-explaining PHPDoc snippets

[MediaWiki-commits] [Gerrit] pywikibot/core[master]: Creating daemonize_tests.py

2017-12-28 Thread Eisenhaus335 (Code Review)
Eisenhaus335 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400593 ) Change subject: Creating daemonize_tests.py .. Creating daemonize_tests.py Change-Id: Ied5109832bf4523bec95bab9e6c89a632169fa5f --- M

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Add @covers tags API tests without them

2017-12-28 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/400127 ) Change subject: Add @covers tags API tests without them .. Add @covers tags API tests without them Change-Id:

[MediaWiki-commits] [Gerrit] pywikibot/core[master]: Creating daemonize_tests.py

2017-12-28 Thread Eisenhaus335 (Code Review)
Eisenhaus335 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400592 ) Change subject: Creating daemonize_tests.py .. Creating daemonize_tests.py Change-Id: I3fb8d7d9963c0ff034c3d3aa3c19161d0b2b9030 --- M

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Add @covers tags to languages tests

2017-12-28 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/400487 ) Change subject: Add @covers tags to languages tests .. Add @covers tags to languages tests I removed comments that merely

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Add @covers tags to miscellaneous tests (#2)

2017-12-28 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/400486 ) Change subject: Add @covers tags to miscellaneous tests (#2) .. Add @covers tags to miscellaneous tests (#2) Change-Id:

[MediaWiki-commits] [Gerrit] operations...mwbzutils[master]: update for stretch build of same source

2017-12-28 Thread ArielGlenn (Code Review)
ArielGlenn has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/400590 ) Change subject: update for stretch build of same source .. update for stretch build of same source Change-Id:

[MediaWiki-commits] [Gerrit] pywikibot/core[master]: Creating daemonzie_tests.py

2017-12-28 Thread Eisenhaus335 (Code Review)
Eisenhaus335 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400591 ) Change subject: Creating daemonzie_tests.py .. Creating daemonzie_tests.py Change-Id: I012da1d7740990f072337b0525b5873c35b0c16f --- M

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Add @coversNothing in places where @covers does not apply

2017-12-28 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/400492 ) Change subject: Add @coversNothing in places where @covers does not apply .. Add @coversNothing in places where @covers does

[MediaWiki-commits] [Gerrit] operations...mwbzutils[master]: update for stretch build of same source

2017-12-28 Thread ArielGlenn (Code Review)
ArielGlenn has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400590 ) Change subject: update for stretch build of same source .. update for stretch build of same source Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Simplify autocomplete attribute in HTMLForm

2017-12-28 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/280938 ) Change subject: Simplify autocomplete attribute in HTMLForm .. Simplify autocomplete attribute in HTMLForm Follows-up 7489a3e8

[MediaWiki-commits] [Gerrit] mediawiki...Newsletter[master]: Allow newsletters to have non-mainspace main pages

2017-12-28 Thread Pppery (Code Review)
Pppery has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400589 ) Change subject: Allow newsletters to have non-mainspace main pages .. Allow newsletters to have non-mainspace main pages Bug: T183752

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Start using RevisionRecord in favor of Revision in trivial c...

2017-12-28 Thread Thiemo Kreuz (WMDE) (Code Review)
Thiemo Kreuz (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400588 ) Change subject: Start using RevisionRecord in favor of Revision in trivial cases .. Start using RevisionRecord in favor of

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Improve (weak and strict) type hints invarious places

2017-12-28 Thread Thiemo Kreuz (WMDE) (Code Review)
Thiemo Kreuz (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400587 ) Change subject: Improve (weak and strict) type hints invarious places .. Improve (weak and strict) type hints invarious places

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Remove leading backslashes from "use \…" tags

2017-12-28 Thread Thiemo Kreuz (WMDE) (Code Review)
Thiemo Kreuz (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400586 ) Change subject: Remove leading backslashes from "use \…" tags .. Remove leading backslashes from "use \…" tags Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Remove very, very old disabled test cases and todos

2017-12-28 Thread Thiemo Kreuz (WMDE) (Code Review)
Thiemo Kreuz (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400585 ) Change subject: Remove very, very old disabled test cases and todos .. Remove very, very old disabled test cases and todos

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Simplify documentation headers of includes/widgets/…Widget.p...

2017-12-28 Thread Thiemo Kreuz (WMDE) (Code Review)
Thiemo Kreuz (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400584 ) Change subject: Simplify documentation headers of includes/widgets/…Widget.php files .. Simplify documentation headers of

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Remove self-explaining "section heading" comments from classes

2017-12-28 Thread Thiemo Kreuz (WMDE) (Code Review)
Thiemo Kreuz (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400583 ) Change subject: Remove self-explaining "section heading" comments from classes .. Remove self-explaining "section heading"

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Remove @param comments that literally repeat what the code says

2017-12-28 Thread Thiemo Kreuz (WMDE) (Code Review)
Thiemo Kreuz (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400582 ) Change subject: Remove @param comments that literally repeat what the code says .. Remove @param comments that literally repeat

[MediaWiki-commits] [Gerrit] mediawiki...Cite[master]: Remove some obscure comments

2017-12-28 Thread Thiemo Kreuz (WMDE) (Code Review)
Thiemo Kreuz (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400581 ) Change subject: Remove some obscure comments .. Remove some obscure comments A good bunch of these comments literally repeats

[MediaWiki-commits] [Gerrit] mediawiki...Newsletter[master]: Cleanup and unify class level PHPDoc blocks

2017-12-28 Thread Thiemo Kreuz (WMDE) (Code Review)
Thiemo Kreuz (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400580 ) Change subject: Cleanup and unify class level PHPDoc blocks .. Cleanup and unify class level PHPDoc blocks This unifies

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Set 'watchcreations' preference to true by default on Commons

2017-12-28 Thread Urbanecm (Code Review)
Urbanecm has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400579 ) Change subject: Set 'watchcreations' preference to true by default on Commons .. Set 'watchcreations' preference to true by default on

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Remove duplicate getTitle call in RevisionStore::getNextRevi...

2017-12-28 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400578 ) Change subject: Remove duplicate getTitle call in RevisionStore::getNextRevision .. Remove duplicate getTitle call in

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: [MCR] pass $queryFlags into RevisionStore::getTitle

2017-12-28 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400577 ) Change subject: [MCR] pass $queryFlags into RevisionStore::getTitle .. [MCR] pass $queryFlags into RevisionStore::getTitle Bug: T183716

[MediaWiki-commits] [Gerrit] mediawiki...ContentTranslation[master]: Remove @file and @ingroup annotations in comments

2017-12-28 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/400425 ) Change subject: Remove @file and @ingroup annotations in comments .. Remove @file and @ingroup annotations in comments

[MediaWiki-commits] [Gerrit] mediawiki...Translate[master]: statsbar: Update colors according to WikmediaUI palette

2017-12-28 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/388379 ) Change subject: statsbar: Update colors according to WikmediaUI palette .. statsbar: Update colors according to WikmediaUI

[MediaWiki-commits] [Gerrit] mediawiki...CirrusSearch[master]: Use ExtensionRegistry instead of class_exists

2017-12-28 Thread Thiemo Kreuz (WMDE) (Code Review)
Thiemo Kreuz (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400576 ) Change subject: Use ExtensionRegistry instead of class_exists .. Use ExtensionRegistry instead of class_exists Bug: T183096

[MediaWiki-commits] [Gerrit] mediawiki...CirrusSearch[master]: Remove some superfluous parameter descriptions

2017-12-28 Thread Thiemo Kreuz (WMDE) (Code Review)
Thiemo Kreuz (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400575 ) Change subject: Remove some superfluous parameter descriptions .. Remove some superfluous parameter descriptions These text

[MediaWiki-commits] [Gerrit] mediawiki...SemanticGenealogy[master]: Remove obvious, non-helpful documentation snippets

2017-12-28 Thread Thiemo Kreuz (WMDE) (Code Review)
Thiemo Kreuz (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400574 ) Change subject: Remove obvious, non-helpful documentation snippets .. Remove obvious, non-helpful documentation snippets

[MediaWiki-commits] [Gerrit] mediawiki...EducationProgram[master]: Slightly improve some type hints in PHPDoc blocks

2017-12-28 Thread Thiemo Kreuz (WMDE) (Code Review)
Thiemo Kreuz (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400573 ) Change subject: Slightly improve some type hints in PHPDoc blocks .. Slightly improve some type hints in PHPDoc blocks

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseQualityConstraints[master]: Add missing @param docs and such

2017-12-28 Thread Thiemo Kreuz (WMDE) (Code Review)
Thiemo Kreuz (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400572 ) Change subject: Add missing @param docs and such .. Add missing @param docs and such This also removes some redundant bits of

[MediaWiki-commits] [Gerrit] mediawiki...EventBus[master]: Fix unintentionally created global functions in EventBusHooks

2017-12-28 Thread Phantom42 (Code Review)
Phantom42 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400571 ) Change subject: Fix unintentionally created global functions in EventBusHooks .. Fix unintentionally created global functions in

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Remove spaces from the "Wikibase …" extension names

2017-12-28 Thread Thiemo Kreuz (WMDE) (Code Review)
Thiemo Kreuz (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400570 ) Change subject: Remove spaces from the "Wikibase …" extension names .. Remove spaces from the "Wikibase …" extension names

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Remove some obvious, self-explaining PHPDoc snippets

2017-12-28 Thread Thiemo Kreuz (WMDE) (Code Review)
Thiemo Kreuz (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400569 ) Change subject: Remove some obvious, self-explaining PHPDoc snippets .. Remove some obvious, self-explaining PHPDoc snippets

[MediaWiki-commits] [Gerrit] mediawiki...Cognate[master]: Update inline documentation

2017-12-28 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/400566 ) Change subject: Update inline documentation .. Update inline documentation Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Add @covers tags to database tests

2017-12-28 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/400490 ) Change subject: Add @covers tags to database tests .. Add @covers tags to database tests Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: tests: Complete test coverage of HtmlArmor

2017-12-28 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/400485 ) Change subject: tests: Complete test coverage of HtmlArmor .. tests: Complete test coverage of HtmlArmor Change-Id:

[MediaWiki-commits] [Gerrit] pywikibot/core[master]: Update git submodules

2017-12-28 Thread Dvorapa (Code Review)
Dvorapa has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400568 ) Change subject: Update git submodules .. Update git submodules * Update scripts/i18n from branch 'master' - Localisation updates from

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Remove useless StatusTest::testCanConstruct()

2017-12-28 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/400488 ) Change subject: Remove useless StatusTest::testCanConstruct() .. Remove useless StatusTest::testCanConstruct() Neither Status,

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Remove resolved todo from MWNamespace test

2017-12-28 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/400489 ) Change subject: Remove resolved todo from MWNamespace test .. Remove resolved todo from MWNamespace test The todo was added by

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Improve @covers for TemplateParserTest

2017-12-28 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/400491 ) Change subject: Improve @covers for TemplateParserTest .. Improve @covers for TemplateParserTest The current @covers tags for

[MediaWiki-commits] [Gerrit] mediawiki...Cognate[master]: Update inline documentation

2017-12-28 Thread Thiemo Kreuz (WMDE) (Code Review)
Thiemo Kreuz (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400566 ) Change subject: Update inline documentation .. Update inline documentation Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Cognate[master]: Add more strict type hints to hook handlers

2017-12-28 Thread Thiemo Kreuz (WMDE) (Code Review)
Thiemo Kreuz (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400567 ) Change subject: Add more strict type hints to hook handlers .. Add more strict type hints to hook handlers Thi spatch also

[MediaWiki-commits] [Gerrit] translatewiki[master]: [puppet] Manage mailman with librarian-puppet

2017-12-28 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/400565 ) Change subject: [puppet] Manage mailman with librarian-puppet .. [puppet] Manage mailman with librarian-puppet As a bonus make

[MediaWiki-commits] [Gerrit] translatewiki[master]: [puppet] Add puppet-lint and make pass

2017-12-28 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/400564 ) Change subject: [puppet] Add puppet-lint and make pass .. [puppet] Add puppet-lint and make pass make test now passes except

  1   2   >