[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Tests for Revision::userCanBitfield

2017-11-10 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/390424 ) Change subject: Tests for Revision::userCanBitfield .. Tests for Revision::userCanBitfield Bug: T180210 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Test for Revision::newKnownCurrent

2017-11-10 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/390412 ) Change subject: Test for Revision::newKnownCurrent .. Test for Revision::newKnownCurrent Bug: T180210 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Make Revision::testIsUnpatrolled more reliable

2017-11-10 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/390405 ) Change subject: Make Revision::testIsUnpatrolled more reliable .. Make Revision::testIsUnpatrolled more reliable Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Tests for Revision::decompressRevisionText

2017-11-10 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/390399 ) Change subject: Tests for Revision::decompressRevisionText .. Tests for Revision::decompressRevisionText Bug: T180210 Change-Id:

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Disable AdvancedSearch on deployment.beta

2017-11-10 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/390392 ) Change subject: Disable AdvancedSearch on deployment.beta .. Disable AdvancedSearch on deployment.beta See if AdvancedSearch caused

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Enable AdvancedSearch on dewiki

2017-11-10 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/390387 ) Change subject: Enable AdvancedSearch on dewiki .. Enable AdvancedSearch on dewiki Date: 23 Nov 2017 Bug: T180128 Change-Id:

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Add AdvancedSearch to extension-list

2017-11-10 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/390385 ) Change subject: Add AdvancedSearch to extension-list .. Add AdvancedSearch to extension-list Bug: T180147 Change-Id:

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Enable AdvancedSearch on group0

2017-11-10 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/390386 ) Change subject: Enable AdvancedSearch on group0 .. Enable AdvancedSearch on group0 Bug: T180147 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Add tests for various simple Revision get and is methods

2017-11-09 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/390228 ) Change subject: Add tests for various simple Revision get and is methods .. Add tests for various simple Revision get and is methods

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Add tests for Revision::getTitle

2017-11-09 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/390219 ) Change subject: Add tests for Revision::getTitle .. Add tests for Revision::getTitle This method is touched in

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Add tests for Revision::getParentLengths

2017-11-09 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/390215 ) Change subject: Add tests for Revision::getParentLengths .. Add tests for Revision::getParentLengths This method name is quite

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.31.0-wmf.7]: Add render moved paragraphs marker in diff view

2017-11-08 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/389969 ) Change subject: Add render moved paragraphs marker in diff view .. Add render moved paragraphs marker in diff view This overwrites the

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[wmf/1.31.0-wmf.7]: Swap submodules to Phabricator instead of Github

2017-11-07 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/389754 ) Change subject: Swap submodules to Phabricator instead of Github .. Swap submodules to Phabricator instead of Github We can't deploy from

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Remove Shared Cache settings from Wikibase-buildentry

2017-11-07 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/389691 ) Change subject: Remove Shared Cache settings from Wikibase-buildentry .. Remove Shared Cache settings from Wikibase-buildentry In

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Remove wmgWikibaseUseConfigFromWikidataBuild

2017-11-07 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/389690 ) Change subject: Remove wmgWikibaseUseConfigFromWikidataBuild .. Remove wmgWikibaseUseConfigFromWikidataBuild Bug: T176948 Change-Id:

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Load wikibase build from mediawiki-config for wikidataclient

2017-11-07 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/389688 ) Change subject: Load wikibase build from mediawiki-config for wikidataclient .. Load wikibase build from mediawiki-config for

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: wmgWikibaseUseConfigFromWikidataBuild flase for all of PROD

2017-11-07 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/389689 ) Change subject: wmgWikibaseUseConfigFromWikidataBuild flase for all of PROD .. wmgWikibaseUseConfigFromWikidataBuild flase for all of PROD

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Load wikibase build from mediawiki-config for wikidatawiki

2017-11-07 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/389685 ) Change subject: Load wikibase build from mediawiki-config for wikidatawiki .. Load wikibase build from mediawiki-config for wikidatawiki

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Load wikibase build from mediawiki-config for group0 & group1

2017-11-07 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/389687 ) Change subject: Load wikibase build from mediawiki-config for group0 & group1 .. Load wikibase build from mediawiki-config for group0 &

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Load wikibase build from mediawiki-config for hewiki

2017-11-07 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/389686 ) Change subject: Load wikibase build from mediawiki-config for hewiki .. Load wikibase build from mediawiki-config for hewiki Bug: T176948

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: wmgWikibaseUseConfigFromWikidataBuild flase for all of BETA

2017-11-07 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/389684 ) Change subject: wmgWikibaseUseConfigFromWikidataBuild flase for all of BETA .. wmgWikibaseUseConfigFromWikidataBuild flase for all of BETA

[MediaWiki-commits] [Gerrit] integration/config[master]: zuul: add noop jobs for new analytics/wmde/WDCM-* repos

2017-11-03 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/388423 ) Change subject: zuul: add noop jobs for new analytics/wmde/WDCM-* repos .. zuul: add noop jobs for new analytics/wmde/WDCM-* repos

[MediaWiki-commits] [Gerrit] mediawiki/vendor[master]: Wikibase: wikibase/data-model-services: 3.8.0

2017-11-03 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/388414 ) Change subject: Wikibase: wikibase/data-model-services: 3.8.0 .. Wikibase: wikibase/data-model-services: 3.8.0 Bug: T175139 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/vendor[master]: Wikibase: wikibase/internal-serialization: 2.7.0

2017-11-03 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/388412 ) Change subject: Wikibase: wikibase/internal-serialization: 2.7.0 .. Wikibase: wikibase/internal-serialization: 2.7.0 Bug: T175140

[MediaWiki-commits] [Gerrit] mediawiki/vendor[master]: Wikibase: data-values/serialization: 1.2.2

2017-11-03 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/388409 ) Change subject: Wikibase: data-values/serialization: 1.2.2 .. Wikibase: data-values/serialization: 1.2.2 Bug: T175133 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/vendor[master]: Wikibase: data-values/geo: 2.1.1

2017-11-03 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/388407 ) Change subject: Wikibase: data-values/geo: 2.1.1 .. Wikibase: data-values/geo: 2.1.1 Bug: T175135 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/vendor[master]: Wikibase: data-values/time: 0.8.6

2017-11-03 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/388406 ) Change subject: Wikibase: data-values/time: 0.8.6 .. Wikibase: data-values/time: 0.8.6 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/vendor[master]: Wikibase: data-values/common: 0.4.1

2017-11-03 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/388405 ) Change subject: Wikibase: data-values/common: 0.4.1 .. Wikibase: data-values/common: 0.4.1 Bug: T175132 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/vendor[master]: Wikibase: data-values/interfaces: 0.2.5

2017-11-03 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/388402 ) Change subject: Wikibase: data-values/interfaces: 0.2.5 .. Wikibase: data-values/interfaces: 0.2.5 Bug: T175129 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/vendor[master]: Wikibase: data-values/data-values: 1.1.0

2017-11-02 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/388145 ) Change subject: Wikibase: data-values/data-values: 1.1.0 .. Wikibase: data-values/data-values: 1.1.0 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/vendor[master]: Wikibase: serialization/serialization: 3.2.1

2017-11-02 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/388125 ) Change subject: Wikibase: serialization/serialization: 3.2.1 .. Wikibase: serialization/serialization: 3.2.1 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Update view/lib/wikibase-data-model submodule URL

2017-11-02 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/388119 ) Change subject: Update view/lib/wikibase-data-model submodule URL .. Update view/lib/wikibase-data-model submodule URL The current URL

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Configurable Special:Version VCS info cache time

2017-11-02 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/388049 ) Change subject: Configurable Special:Version VCS info cache time .. Configurable Special:Version VCS info cache time On beta we can set

[MediaWiki-commits] [Gerrit] operations/puppet[production]: WIP DNM role and profile for wdcm dashboards

2017-10-30 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/387211 ) Change subject: WIP DNM role and profile for wdcm dashboards .. WIP DNM role and profile for wdcm dashboards Change-Id:

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Revert "Set wgWikiDiff2MovedParagraphDetectionCutoff for gro...

2017-10-30 Thread Addshore (Code Review)
Hello Urbanecm, jenkins-bot, WMDE-Fisch, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/387232 to review the following change. Change subject: Revert "Set wgWikiDiff2MovedParagraphDetectionCutoff for group0"

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Set wgWikiDiff2MovedParagraphDetectionCutoff for group0

2017-10-30 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/387198 ) Change subject: Set wgWikiDiff2MovedParagraphDetectionCutoff for group0 .. Set wgWikiDiff2MovedParagraphDetectionCutoff for group0 Bug:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Refactor BlockTest

2017-10-25 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/386425 ) Change subject: Refactor BlockTest .. Refactor BlockTest Something is holding state and interfering with RevisionUnitTest from within

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: HistoryPager add missing $tagFilter class property

2017-10-25 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/386345 ) Change subject: HistoryPager add missing $tagFilter class property .. HistoryPager add missing $tagFilter class property Change-Id:

[MediaWiki-commits] [Gerrit] integration/config[master]: Remove unused zuul-cloner-docker

2017-10-18 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384962 ) Change subject: Remove unused zuul-cloner-docker .. Remove unused zuul-cloner-docker Change-Id: I66258b1406081f0266db3c4461e8a5543c22c3db

[MediaWiki-commits] [Gerrit] operations/puppet[production]: ci: jenkins, allow access to computer/.*/builds

2017-10-18 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384960 ) Change subject: ci: jenkins, allow access to computer/.*/builds .. ci: jenkins, allow access to computer/.*/builds Bug: T178458

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Add filtertags to ci/slave/labs/docker

2017-10-17 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384889 ) Change subject: Add filtertags to ci/slave/labs/docker .. Add filtertags to ci/slave/labs/docker Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Revision tests, make test for constructFromRowArray a unit test

2017-10-17 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384692 ) Change subject: Revision tests, make test for constructFromRowArray a unit test .. Revision tests, make test for constructFromRowArray a

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: RevisionIntegrationTest more newFromArchiveRow tests

2017-10-17 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384687 ) Change subject: RevisionIntegrationTest more newFromArchiveRow tests .. RevisionIntegrationTest more newFromArchiveRow tests There were a

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: RevisionUnitTest::testConstructFromArray @covers tags

2017-10-17 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384685 ) Change subject: RevisionUnitTest::testConstructFromArray @covers tags .. RevisionUnitTest::testConstructFromArray @covers tags Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...WikimediaEvents[master]: Remove onBeforeInitializeWMDECampaign

2017-10-17 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384681 ) Change subject: Remove onBeforeInitializeWMDECampaign .. Remove onBeforeInitializeWMDECampaign Change-Id:

[MediaWiki-commits] [Gerrit] integration/config[master]: docker: mediawiki-phan use phan/phan instead of etsy/phan

2017-10-17 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384680 ) Change subject: docker: mediawiki-phan use phan/phan instead of etsy/phan .. docker: mediawiki-phan use phan/phan instead of etsy/phan

[MediaWiki-commits] [Gerrit] integration/config[master]: Remove mediawiki-core-php70-phan-jessie

2017-10-17 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384676 ) Change subject: Remove mediawiki-core-php70-phan-jessie .. Remove mediawiki-core-php70-phan-jessie Change-Id:

[MediaWiki-commits] [Gerrit] integration/config[master]: mediawiki-core-php70-phan-docker job

2017-10-17 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384672 ) Change subject: mediawiki-core-php70-phan-docker job .. mediawiki-core-php70-phan-docker job Change-Id:

[MediaWiki-commits] [Gerrit] integration/config[master]: Use mediawiki-core-php70-phan-docker for core

2017-10-17 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384673 ) Change subject: Use mediawiki-core-php70-phan-docker for core .. Use mediawiki-core-php70-phan-docker for core Change-Id:

[MediaWiki-commits] [Gerrit] integration/config[master]: Remove mwext-php70-phan-jessie

2017-10-16 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384615 ) Change subject: Remove mwext-php70-phan-jessie .. Remove mwext-php70-phan-jessie Change-Id: I35c117a57c00ff6a6c0a6b2925cb31e99e77da79 ---

[MediaWiki-commits] [Gerrit] integration/config[master]: Switch from mwext-php70-phan-jessie to mwext-php70-phan-docker

2017-10-16 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384614 ) Change subject: Switch from mwext-php70-phan-jessie to mwext-php70-phan-docker .. Switch from mwext-php70-phan-jessie to

[MediaWiki-commits] [Gerrit] integration/config[master]: final umask fixes for mwext-php70-phan-docker job

2017-10-16 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384597 ) Change subject: final umask fixes for mwext-php70-phan-docker job .. final umask fixes for mwext-php70-phan-docker job Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: ci: add mediawiki core and vendor to gitcache for docker slaves

2017-10-16 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384570 ) Change subject: ci: add mediawiki core and vendor to gitcache for docker slaves .. ci: add mediawiki core and vendor to gitcache for

[MediaWiki-commits] [Gerrit] integration/config[master]: zuul parameter_functions mwext-php70-phan-jessie* to mwext-p...

2017-10-16 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384565 ) Change subject: zuul parameter_functions mwext-php70-phan-jessie* to mwext-php70-phan* .. zuul parameter_functions

[MediaWiki-commits] [Gerrit] integration/config[master]: rename mwext-php70-phan-jessie-docker > mwext-php70-phan-docker

2017-10-16 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384548 ) Change subject: rename mwext-php70-phan-jessie-docker > mwext-php70-phan-docker .. rename mwext-php70-phan-jessie-docker >

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: RevisionUnitTest for fetchFromConds

2017-10-14 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384251 ) Change subject: RevisionUnitTest for fetchFromConds .. RevisionUnitTest for fetchFromConds Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: RevisionIntegrationTest for newFromPageId

2017-10-14 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384212 ) Change subject: RevisionIntegrationTest for newFromPageId .. RevisionIntegrationTest for newFromPageId Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: RevisionUnitTest for various getters and setters

2017-10-14 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384219 ) Change subject: RevisionUnitTest for various getters and setters .. RevisionUnitTest for various getters and setters getId setId

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: RevisionIntegrationTest for newFromArchiveRow with ContentHa...

2017-10-14 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384213 ) Change subject: RevisionIntegrationTest for newFromArchiveRow with ContentHandlerUseDB .. RevisionIntegrationTest for newFromArchiveRow

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: RevisionUnittest for select*Fields methods

2017-10-14 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384218 ) Change subject: RevisionUnittest for select*Fields methods .. RevisionUnittest for select*Fields methods Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: RevisionUnitTest for userJoinCond and pageJoinCond

2017-10-14 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384217 ) Change subject: RevisionUnitTest for userJoinCond and pageJoinCond .. RevisionUnitTest for userJoinCond and pageJoinCond Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: RevisionIntegrationTest for loadFromTitle

2017-10-14 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384215 ) Change subject: RevisionIntegrationTest for loadFromTitle .. RevisionIntegrationTest for loadFromTitle Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: RevisionIntegrationTest for loadFromTimestamp

2017-10-14 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384216 ) Change subject: RevisionIntegrationTest for loadFromTimestamp .. RevisionIntegrationTest for loadFromTimestamp Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: RevisionIntegrationTest for loadFromId & loadFromPageId

2017-10-14 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384214 ) Change subject: RevisionIntegrationTest for loadFromId & loadFromPageId .. RevisionIntegrationTest for loadFromId & loadFromPageId

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Cleanup page creation in RevisionIntegrationTest

2017-10-14 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384067 ) Change subject: Cleanup page creation in RevisionIntegrationTest .. Cleanup page creation in RevisionIntegrationTest Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Split Revision tests into Unit & Integration classes

2017-10-12 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383826 ) Change subject: Split Revision tests into Unit & Integration classes .. Split Revision tests into Unit & Integration classes Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Delete RevisionStorageTestContentHandlerUseDB

2017-10-11 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383590 ) Change subject: Delete RevisionStorageTestContentHandlerUseDB .. Delete RevisionStorageTestContentHandlerUseDB Due to this test file not

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: RevisionStorageTest, use MediaWikiTestCase methods for setti...

2017-10-11 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383569 ) Change subject: RevisionStorageTest, use MediaWikiTestCase methods for setting globals .. RevisionStorageTest, use MediaWikiTestCase

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: RevisionStorageTest, add tests for Revision::newFromTitle

2017-10-11 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383567 ) Change subject: RevisionStorageTest, add tests for Revision::newFromTitle .. RevisionStorageTest, add tests for Revision::newFromTitle

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Revision split __construct method

2017-10-11 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383559 ) Change subject: Revision split __construct method .. Revision split __construct method This makes the logic much easier to follow and

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Revision, test and fix __construct exceptions

2017-10-11 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383554 ) Change subject: Revision, test and fix __construct exceptions .. Revision, test and fix __construct exceptions This adds tests for each

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: RevisionStorageTest code style fixes

2017-10-10 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383380 ) Change subject: RevisionStorageTest code style fixes .. RevisionStorageTest code style fixes Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: RevisionTest refactor test dataProviders

2017-10-10 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383377 ) Change subject: RevisionTest refactor test dataProviders .. RevisionTest refactor test dataProviders Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Add $mText to TextContent

2017-10-10 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383371 ) Change subject: Add $mText to TextContent .. Add $mText to TextContent Change-Id: I1e1f652e4ef6d02bc76105407cb23975625560cd --- M

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: RevisionTest code style fixes & file split

2017-10-10 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383370 ) Change subject: RevisionTest code style fixes & file split .. RevisionTest code style fixes & file split Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...TwoColConflict[master]: Show a message when simulate page loaded while BF disabled

2017-10-09 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383166 ) Change subject: Show a message when simulate page loaded while BF disabled .. Show a message when simulate page loaded while BF disabled

[MediaWiki-commits] [Gerrit] mediawiki...FileImporter[master]: Remove empty FileImporterHooks

2017-10-09 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383099 ) Change subject: Remove empty FileImporterHooks .. Remove empty FileImporterHooks Change-Id: I605f8e6bfe91bc99e20563400a5d4ef1828b951f ---

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: Revert "Remove mentions of StubObject, just for typehinting"

2017-10-05 Thread Addshore (Code Review)
Hello Chad, Krinkle, MaxSem, jenkins-bot, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/382497 to review the following change. Change subject: Revert "Remove mentions of StubObject, just for typehinting"

[MediaWiki-commits] [Gerrit] mediawiki...JsonConfig[master]: Revert "Remove references to StubUserLang, it's going away"

2017-10-05 Thread Addshore (Code Review)
Hello Chad, MaxSem, jenkins-bot, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/382500 to review the following change. Change subject: Revert "Remove references to StubUserLang, it's going away"

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Revert "Remove some remaining mentions of unstubbing from core"

2017-10-05 Thread Addshore (Code Review)
Hello Aaron Schulz, Chad, Krinkle, C. Scott Ananian, MaxSem, jenkins-bot, Anomie, Jackmcbarn, Zoranzoki21, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/382496 to review the following change. Change subject: Revert "Remove some remaining mentions of

[MediaWiki-commits] [Gerrit] mediawiki...ParserFunctions[master]: Revert "Language objects aren't stubbed anymore"

2017-10-05 Thread Addshore (Code Review)
Hello Chad, Krinkle, MaxSem, jenkins-bot, Jforrester, Jackmcbarn, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/382498 to review the following change. Change subject: Revert "Language objects aren't stubbed anymore"

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: Revert "Remove references to StubUserLang, it's going away"

2017-10-05 Thread Addshore (Code Review)
Hello Chad, MaxSem, jenkins-bot, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/382499 to review the following change. Change subject: Revert "Remove references to StubUserLang, it's going away"

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Revert "Stop stubbing StubUserLang"

2017-10-05 Thread Addshore (Code Review)
Hello Chad, Krinkle, C. Scott Ananian, jenkins-bot, MaxSem, Jackmcbarn, Zoranzoki21, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/382478 to review the following change. Change subject: Revert "Stop stubbing StubUserLang"

[MediaWiki-commits] [Gerrit] mediawiki...TwoColConflict[wmf/1.31.0-wmf.2]: Dont register simulate page when not enabled as a BF

2017-10-05 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/382475 ) Change subject: Dont register simulate page when not enabled as a BF .. Dont register simulate page when not enabled as a BF (take2)

[MediaWiki-commits] [Gerrit] mediawiki...TwoColConflict[master]: Dont run onSpecialPage_initList if MW_NO_SESSION defined

2017-10-05 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/382453 ) Change subject: Dont run onSpecialPage_initList if MW_NO_SESSION defined .. Dont run onSpecialPage_initList if MW_NO_SESSION defined Bug:

[MediaWiki-commits] [Gerrit] mediawiki...TwoColConflict[master]: onSpecialPage_initList get user from context & check type

2017-10-05 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/382432 ) Change subject: onSpecialPage_initList get user from context & check type .. onSpecialPage_initList get user from context & check type

[MediaWiki-commits] [Gerrit] mediawiki...TwoColConflict[wmf/1.31.0-wmf.2]: Revert "Dont register simulate page when not enabled as a BF"

2017-10-05 Thread Addshore (Code Review)
Addshore has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/382417 ) Change subject: Revert "Dont register simulate page when not enabled as a BF" .. Revert "Dont register simulate page when not

[MediaWiki-commits] [Gerrit] mediawiki...TwoColConflict[wmf/1.31.0-wmf.2]: Revert "Dont register simulate page when not enabled as a BF"

2017-10-05 Thread Addshore (Code Review)
Hello Tobias Gritschacher, jenkins-bot, WMDE-Fisch, Andrew-WMDE, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/382417 to review the following change. Change subject: Revert "Dont register simulate page when not enabled as a BF"

[MediaWiki-commits] [Gerrit] mediawiki...TwoColConflict[wmf/1.31.0-wmf.2]: Fix SimulateTwoColEditConflict when using a page with ns

2017-10-05 Thread Addshore (Code Review)
Addshore has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/382404 ) Change subject: Fix SimulateTwoColEditConflict when using a page with ns .. Fix SimulateTwoColEditConflict when using a page with

[MediaWiki-commits] [Gerrit] mediawiki...TwoColConflict[wmf/1.31.0-wmf.2]: Dont register simulate page when not enabled as a BF

2017-10-05 Thread Addshore (Code Review)
Addshore has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/382405 ) Change subject: Dont register simulate page when not enabled as a BF .. Dont register simulate page when not enabled as a BF

[MediaWiki-commits] [Gerrit] mediawiki...TwoColConflict[master]: Fix phpcs warning

2017-10-05 Thread Addshore (Code Review)
Addshore has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/382412 ) Change subject: Fix phpcs warning .. Fix phpcs warning Change-Id: Ia75b966d12b244c3b798813fb777692b904ef64a --- M

[MediaWiki-commits] [Gerrit] mediawiki...TwoColConflict[master]: Fix phpcs warning

2017-10-05 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/382412 ) Change subject: Fix phpcs warning .. Fix phpcs warning Change-Id: Ia75b966d12b244c3b798813fb777692b904ef64a --- M

[MediaWiki-commits] [Gerrit] mediawiki...WikimediaEvents[wmf/1.31.0-wmf.2]: WMDE: update $campaignStartTimestamp

2017-10-05 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/382406 ) Change subject: WMDE: update $campaignStartTimestamp .. WMDE: update $campaignStartTimestamp Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...WikimediaEvents[wmf/1.31.0-wmf.1]: WMDE: update $campaignStartTimestamp

2017-10-05 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/382407 ) Change subject: WMDE: update $campaignStartTimestamp .. WMDE: update $campaignStartTimestamp Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...TwoColConflict[wmf/1.31.0-wmf.2]: Fix SimulateTwoColEditConflict when using a page with ns

2017-10-05 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/382404 ) Change subject: Fix SimulateTwoColEditConflict when using a page with ns .. Fix SimulateTwoColEditConflict when using a page with ns

[MediaWiki-commits] [Gerrit] mediawiki...TwoColConflict[wmf/1.31.0-wmf.2]: Dont register simulate page when not enabled as a BF

2017-10-05 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/382405 ) Change subject: Dont register simulate page when not enabled as a BF .. Dont register simulate page when not enabled as a BF Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...TwoColConflict[master]: Dont register simulate page when not enabled as a BF

2017-10-05 Thread Addshore (Code Review)
Addshore has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/382137 ) Change subject: Dont register simulate page when not enabled as a BF .. Dont register simulate page when not enabled as a BF

[MediaWiki-commits] [Gerrit] mediawiki...TwoColConflict[master]: Fix SimulateTwoColEditConflict when using a page with ns

2017-10-05 Thread Addshore (Code Review)
Addshore has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/382138 ) Change subject: Fix SimulateTwoColEditConflict when using a page with ns .. Fix SimulateTwoColEditConflict when using a page with

[MediaWiki-commits] [Gerrit] mediawiki...WikimediaEvents[master]: WMDE: update $campaignStartTimestamp

2017-10-05 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/382399 ) Change subject: WMDE: update $campaignStartTimestamp .. WMDE: update $campaignStartTimestamp Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...TwoColConflict[master]: DNM JENKINS VALIDATION

2017-10-04 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/382142 ) Change subject: DNM JENKINS VALIDATION .. DNM JENKINS VALIDATION Change-Id: I408af778cc61869ac8439ff2d21cacde3b386037 --- M

<    1   2   3   4   5   6   7   8   9   10   >