[MediaWiki-commits] [Gerrit] mediawiki...Cognate[master]: recalculateCognateNormalizedHashes.php use numRows() instead...

2017-08-23 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/373265 ) Change subject: recalculateCognateNormalizedHashes.php use numRows() instead of count() .. recalculateCognateNormalizedHashes.php use numR

[MediaWiki-commits] [Gerrit] mediawiki...Cognate[master]: recalculateCognateNormalizedHashes.php output "work done" in...

2017-08-23 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/373262 ) Change subject: recalculateCognateNormalizedHashes.php output "work done" in dry-mode .. recalculateCognateNormalizedHashes.php output "wo

[MediaWiki-commits] [Gerrit] mediawiki...Cognate[master]: Add output about dry-run mode to recalculateCognateNormalize...

2017-08-23 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/373258 ) Change subject: Add output about dry-run mode to recalculateCognateNormalizedHashes.php .. Add output about dry-run mode to recalculateCog

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Add seperate ensure for testwiki in wikidata crons

2017-08-18 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/372525 ) Change subject: Add seperate ensure for testwiki in wikidata crons .. Add seperate ensure for testwiki in wikidata crons Bug: T173357 Chan

[MediaWiki-commits] [Gerrit] mediawiki...RevisionSlider[master]: Reintroduce hover and bar clicking - AGAIN

2017-08-17 Thread Addshore (Code Review)
Hello Tobias Gritschacher, WMDE-Fisch, jenkins-bot, Andrew-WMDE, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/372385 to review the following change. Change subject: Reintroduce hover and bar clicking - AGAIN

[MediaWiki-commits] [Gerrit] mediawiki...RevisionSlider[wmf/1.30.0-wmf.14]: Revert "Reintroduce hover and bar clicking"

2017-08-17 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/372384 ) Change subject: Revert "Reintroduce hover and bar clicking" .. Revert "Reintroduce hover and bar clicking" We want to make an announcement

[MediaWiki-commits] [Gerrit] integration/config[master]: WIP DNM contint-mediawiki-extensions-phan

2017-08-13 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/371708 ) Change subject: WIP DNM contint-mediawiki-extensions-phan .. WIP DNM contint-mediawiki-extensions-phan Change-Id: I1e6106a1fa26c8afdd76c49

[MediaWiki-commits] [Gerrit] mediawiki...ElectronPdfService[master]: DNM jenkins job validation

2017-08-10 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/371108 ) Change subject: DNM jenkins job validation .. DNM jenkins job validation Change-Id: Ibf81b3b6a8b1ec76ecb0300d4b781a8bfc9ab23e --- M README

[MediaWiki-commits] [Gerrit] integration/config[master]: Get phan version from composer.json

2017-08-10 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/371097 ) Change subject: Get phan version from composer.json .. Get phan version from composer.json Change-Id: Ie2c2e0fd5b880ab73d9d7dab0686361304d

[MediaWiki-commits] [Gerrit] mediawiki/vendor[master]: Fix json file spaces to tabs

2017-08-09 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/370853 ) Change subject: Fix json file spaces to tabs .. Fix json file spaces to tabs Change-Id: I818476a4238191af4996ac9ec9cfa9cb52f075b7 --- M co

[MediaWiki-commits] [Gerrit] mediawiki...WikimediaMaintenance[master]: Add Newsletter extension

2017-08-09 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/370848 ) Change subject: Add Newsletter extension .. Add Newsletter extension Bug: T110170 Change-Id: I6f6216c7ee34648cae9d574ba9c345b598f95ae1 Dep

[MediaWiki-commits] [Gerrit] mediawiki...Newsletter[master]: Update nl_newsletters.sql and kill old files

2017-08-09 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/370847 ) Change subject: Update nl_newsletters.sql and kill old files .. Update nl_newsletters.sql and kill old files Change-Id: I28d6996bcf583a7b5

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Add @since tag to TrackingCategories class

2017-08-04 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/370220 ) Change subject: Add @since tag to TrackingCategories class .. Add @since tag to TrackingCategories class Change-Id: I30f5004db3d53a87fc7c4

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Split ConfiguredReadOnlyMode into own file

2017-08-04 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/370219 ) Change subject: Split ConfiguredReadOnlyMode into own file .. Split ConfiguredReadOnlyMode into own file Change-Id: I7c12a571bb5ce76c132a7

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Make Block.php protected members private

2017-08-04 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/370218 ) Change subject: Make Block.php protected members private .. Make Block.php protected members private Change-Id: I236b4d4ab124155fcf9d92393

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: @since tag for Block::getSystemBlockType & systemBlockType p...

2017-08-04 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/370216 ) Change subject: @since tag for Block::getSystemBlockType & systemBlockType private .. @since tag for Block::getSystemBlockType & systemBlo

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Add @sice tag to $wgShortPagesNamespaceBlacklist

2017-08-04 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/370212 ) Change subject: Add @sice tag to $wgShortPagesNamespaceBlacklist .. Add @sice tag to $wgShortPagesNamespaceBlacklist Followup for: I10b484

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Add @since tag for Title::getTalkPageIfDefined

2017-08-04 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/370211 ) Change subject: Add @since tag for Title::getTalkPageIfDefined .. Add @since tag for Title::getTalkPageIfDefined Folow up to: I6d2613d8f71

[MediaWiki-commits] [Gerrit] operations/puppet[production]: statistics::wmde move graphite files into own directory

2017-08-03 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/369885 ) Change subject: statistics::wmde move graphite files into own directory .. statistics::wmde move graphite files into own directory Change-

[MediaWiki-commits] [Gerrit] operations/puppet[production]: statistics::wmde::graphite fix logrotate name

2017-08-03 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/369886 ) Change subject: statistics::wmde::graphite fix logrotate name .. statistics::wmde::graphite fix logrotate name Change-Id: If74d1f64612a63e

[MediaWiki-commits] [Gerrit] operations/puppet[production]: statistics::wmde cleanup directory usage

2017-08-03 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/369884 ) Change subject: statistics::wmde cleanup directory usage .. statistics::wmde cleanup directory usage Change-Id: I014804fc23fde8ee70113bf60

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Factor graphite class out of statistics::wmde

2017-08-03 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/369857 ) Change subject: Factor graphite class out of statistics::wmde .. Factor graphite class out of statistics::wmde Change-Id: Ie059f42e778b689

[MediaWiki-commits] [Gerrit] wikidata/build-resources[master]: build: bump grunt and drop grunt-cli#

2017-08-03 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/369856 ) Change subject: build: bump grunt and drop grunt-cli# .. build: bump grunt and drop grunt-cli# grunt 1.x now includes a CLI command, hence

[MediaWiki-commits] [Gerrit] mediawiki...WikimediaEvents[master]: Remove WMDE Summer campaign hook

2017-07-31 Thread Addshore (Code Review)
Hello WMDE-leszek, WMDE-jand, Tobias Gritschacher, GoranSMilovanovic, WMDE-Fisch, jenkins-bot, Thiemo Mättig (WMDE), I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/368703 to review the following change. Change subject: Remove WMDE Summer campaign hook .

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Remove WMDE log Channel

2017-07-31 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/368701 ) Change subject: Remove WMDE log Channel .. Remove WMDE log Channel Bug: T168635 Change-Id: Ib1a761c0a364af6c2d16cd23cdd1406a3cadae86 --- M

[MediaWiki-commits] [Gerrit] mediawiki/vendor[master]: Wikibase: "wikibase/data-model-services": "3.8.0"

2017-07-28 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/368385 ) Change subject: Wikibase: "wikibase/data-model-services": "3.8.0" .. Wikibase: "wikibase/data-model-services": "3.8.0" Change-Id: Ic6f8c1f

[MediaWiki-commits] [Gerrit] mediawiki/vendor[master]: Wikibase: "wikibase/internal-serialization": "2.4.0"

2017-07-28 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/368384 ) Change subject: Wikibase: "wikibase/internal-serialization": "2.4.0" .. Wikibase: "wikibase/internal-serialization": "2.4.0" Change-Id: Ib

[MediaWiki-commits] [Gerrit] mediawiki/vendor[master]: Wikibase: "wikibase/data-model-serialization": "2.4.0"

2017-07-28 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/368382 ) Change subject: Wikibase: "wikibase/data-model-serialization": "2.4.0" .. Wikibase: "wikibase/data-model-serialization": "2.4.0" Change-Id

[MediaWiki-commits] [Gerrit] mediawiki/vendor[master]: Wikibase: "wikibase/data-model": "7.0.0"

2017-07-28 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/368381 ) Change subject: Wikibase: "wikibase/data-model": "7.0.0" .. Wikibase: "wikibase/data-model": "7.0.0" Change-Id: I6de040fa52f4e70de33c963b8

[MediaWiki-commits] [Gerrit] mediawiki/vendor[master]: Wikibase: "data-values/javascript": "0.8.4"

2017-07-28 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/368380 ) Change subject: Wikibase: "data-values/javascript": "0.8.4" .. Wikibase: "data-values/javascript": "0.8.4" Change-Id: Ida5bac2f8a7e3175bbb

[MediaWiki-commits] [Gerrit] mediawiki/vendor[master]: Wikibase: "data-values/serialization": "1.2.1"

2017-07-28 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/368375 ) Change subject: Wikibase: "data-values/serialization": "1.2.1" .. Wikibase: "data-values/serialization": "1.2.1" Change-Id: I6858c3d66a74d

[MediaWiki-commits] [Gerrit] mediawiki/vendor[master]: Wikibase: "data-values/common": "0.3.1"

2017-07-28 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/368373 ) Change subject: Wikibase: "data-values/common": "0.3.1" .. Wikibase: "data-values/common": "0.3.1" Change-Id: I91bac9bc3dc215bf3b8c138e5ae

[MediaWiki-commits] [Gerrit] mediawiki/vendor[master]: Wikibase: "data-values/data-types": "1.0.0"

2017-07-28 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/368374 ) Change subject: Wikibase: "data-values/data-types": "1.0.0" .. Wikibase: "data-values/data-types": "1.0.0" Change-Id: If4dce3361e868ca3bc8

[MediaWiki-commits] [Gerrit] mediawiki/vendor[master]: Wikibase: "data-values/interfaces": "0.2.2"

2017-07-28 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/368371 ) Change subject: Wikibase: "data-values/interfaces": "0.2.2" .. Wikibase: "data-values/interfaces": "0.2.2" Change-Id: Id1fb9d892c44cd510bf

[MediaWiki-commits] [Gerrit] mediawiki/vendor[master]: Wikibase: "data-values/data-values": "1.0.0"

2017-07-28 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/368372 ) Change subject: Wikibase: "data-values/data-values": "1.0.0" .. Wikibase: "data-values/data-values": "1.0.0" Change-Id: Ife17982fb9687dc9d

[MediaWiki-commits] [Gerrit] mediawiki/vendor[master]: Wikibase: "serialization/serialization": "3.2.1"

2017-07-28 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/368369 ) Change subject: Wikibase: "serialization/serialization": "3.2.1" .. Wikibase: "serialization/serialization": "3.2.1" Change-Id: I25a57f4

[MediaWiki-commits] [Gerrit] mediawiki...Wikidata[wmf/1.30.0-wmf.10]: DNM JENKINS JOB VALIDATION

2017-07-27 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/368315 ) Change subject: DNM JENKINS JOB VALIDATION .. DNM JENKINS JOB VALIDATION Change-Id: Iae1dabb0cdbc3dcb33451c9cb8eaf0e90ff265a1 --- M README

[MediaWiki-commits] [Gerrit] mediawiki...Wikidata[wmf/1.30.0-wmf.10]: WB: Move injection of RC records to a separate job.

2017-07-27 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/368312 ) Change subject: WB: Move injection of RC records to a separate job. .. WB: Move injection of RC records to a separate job. Backport for 1.

[MediaWiki-commits] [Gerrit] mediawiki...Cognate[master]: DNM Add normalization of U+02BC

2017-07-27 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/368205 ) Change subject: DNM Add normalization of U+02BC .. DNM Add normalization of U+02BC DEPLOY: This will require repopulation of the tables. I

[MediaWiki-commits] [Gerrit] mediawiki...Cognate[master]: Add comments showing which chars are normalized

2017-07-27 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/368203 ) Change subject: Add comments showing which chars are normalized .. Add comments showing which chars are normalized Change-Id: I81b9db76574

[MediaWiki-commits] [Gerrit] wikidata/build-resources[master]: Add dep on composer/installers

2017-07-19 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/366232 ) Change subject: Add dep on composer/installers .. Add dep on composer/installers This was previously pulled in my DataValuesjavaScript but

[MediaWiki-commits] [Gerrit] mediawiki...RevisionSlider[REL1_27]: Set MW version dependency to 1.27

2017-07-19 Thread Addshore (Code Review)
Addshore has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/366210 ) Change subject: Set MW version dependency to 1.27 .. Set MW version dependency to 1.27 Change-Id: I42655fb001f5c5328872bf58fe474de

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Revert "Remove time command from statistics::wmde crons"

2017-07-17 Thread Addshore (Code Review)
Hello RobH, jenkins-bot, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/365662 to review the following change. Change subject: Revert "Remove time command from statistics::wmde crons" .. Re

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Remove time command from statistics::wmde crons

2017-07-14 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/365264 ) Change subject: Remove time command from statistics::wmde crons .. Remove time command from statistics::wmde crons It looks like this can'

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Fix api_log_dir for statistics wmde

2017-07-13 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/365001 ) Change subject: Fix api_log_dir for statistics wmde .. Fix api_log_dir for statistics wmde It looks like this directory changed as a resul

[MediaWiki-commits] [Gerrit] mediawiki...FileImporter[master]: Add more logging in HttpApiLookup::actuallyGetApiUrl

2017-07-13 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/364984 ) Change subject: Add more logging in HttpApiLookup::actuallyGetApiUrl .. Add more logging in HttpApiLookup::actuallyGetApiUrl Change-Id: I9

[MediaWiki-commits] [Gerrit] analytics...scripts[production]: Fix facebook.php

2017-07-12 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/364853 ) Change subject: Fix facebook.php .. Fix facebook.php Change-Id: Ida5d90313e11844361172bd6e3c83c4317a552ca --- M src/wikidata/social/facebo

[MediaWiki-commits] [Gerrit] analytics...scripts[master]: Fix facebook.php

2017-07-12 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/364852 ) Change subject: Fix facebook.php .. Fix facebook.php Change-Id: Ida5d90313e11844361172bd6e3c83c4317a552ca --- M src/wikidata/social/facebo

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Factor out getEditFontClass in EditPage

2017-07-12 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/364785 ) Change subject: Factor out getEditFontClass in EditPage .. Factor out getEditFontClass in EditPage Change-Id: I27d868437035ab4b77899dce498

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Enable Newsletter on mediawikiwiki

2017-07-12 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/364734 ) Change subject: Enable Newsletter on mediawikiwiki .. Enable Newsletter on mediawikiwiki Bug: T110170 Change-Id: If7cee2c9d2f07a06f09ba0c1

[MediaWiki-commits] [Gerrit] mediawiki/vendor[master]: Add Wikibase deps

2017-07-12 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/364712 ) Change subject: Add Wikibase deps .. Add Wikibase deps Change-Id: I043fac26083e163edfd3d7f2e172932ade4da32f --- M composer.json M composer

[MediaWiki-commits] [Gerrit] analytics...scripts[production]: Use INI_SCANNER_RAW in parse_ini_file

2017-07-12 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/364686 ) Change subject: Use INI_SCANNER_RAW in parse_ini_file .. Use INI_SCANNER_RAW in parse_ini_file Bug: T170282 Change-Id: I596d4605f9459a2581

[MediaWiki-commits] [Gerrit] analytics...scripts[master]: Use INI_SCANNER_RAW in parse_ini_file

2017-07-12 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/364685 ) Change subject: Use INI_SCANNER_RAW in parse_ini_file .. Use INI_SCANNER_RAW in parse_ini_file Bug: T170282 Change-Id: I596d4605f9459a2581

[MediaWiki-commits] [Gerrit] mediawiki...Wikidata[master]: B

2017-07-11 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/364597 ) Change subject: B .. B Change-Id: I4123790d71c3eeac9b9cedabf61f429851e969cc --- M WikibaseClient.settings.php M WikibaseRepo.settings.php

[MediaWiki-commits] [Gerrit] mediawiki...Wikidata[master]: Update to current wmf/1.30.0-wmf.7

2017-07-11 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/364520 ) Change subject: Update to current wmf/1.30.0-wmf.7 .. Update to current wmf/1.30.0-wmf.7 Change-Id: I6f3aa84c5a92a3321715a179c624db917a6e8

[MediaWiki-commits] [Gerrit] mediawiki...FileImporter[master]: Display error when core would change the title

2017-07-11 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/364490 ) Change subject: Display error when core would change the title .. Display error when core would change the title For titles that include a

[MediaWiki-commits] [Gerrit] mediawiki...FileImporter[master]: ChangeFileNameForm show user provided value if present

2017-07-11 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/364474 ) Change subject: ChangeFileNameForm show user provided value if present .. ChangeFileNameForm show user provided value if present When ente

[MediaWiki-commits] [Gerrit] mediawiki...FileImporter[master]: Use TitleParser in ImportPlanValidator & check

2017-07-11 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/364470 ) Change subject: Use TitleParser in ImportPlanValidator & check .. Use TitleParser in ImportPlanValidator & check ImportPlanValidator now c

[MediaWiki-commits] [Gerrit] mediawiki...FileImporter[master]: WIP DNM moving without http

2017-07-10 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/364253 ) Change subject: WIP DNM moving without http .. WIP DNM moving without http Bug: T161012 Change-Id: I6d8985c3fd23e4922bd2e1b1e7fbf636937fda

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Fix spaces ot tabs for WMDE log line

2017-07-10 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/364184 ) Change subject: Fix spaces ot tabs for WMDE log line .. Fix spaces ot tabs for WMDE log line Change-Id: I743be36eb48e3e3acc35597cc3b73098f

[MediaWiki-commits] [Gerrit] mediawiki...CentralAuth[wmf/1.30.0-wmf.7]: Revert "Fix handling of password hash upgrade on login"

2017-07-10 Thread Addshore (Code Review)
Hello Legoktm, jenkins-bot, Anomie, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/364182 to review the following change. Change subject: Revert "Fix handling of password hash upgrade on login"

[MediaWiki-commits] [Gerrit] mediawiki...WikimediaEvents[wmf/1.30.0-wmf.7]: WMDE Summer campaign - Add hook

2017-07-10 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/364172 ) Change subject: WMDE Summer campaign - Add hook .. WMDE Summer campaign - Add hook This is a modified version of the code that was added i

[MediaWiki-commits] [Gerrit] mediawiki...FileImporter[master]: Make sure a page is created as part of first operation

2017-07-06 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363599 ) Change subject: Make sure a page is created as part of first operation .. Make sure a page is created as part of first operation Prior to

[MediaWiki-commits] [Gerrit] mediawiki...FileImporter[master]: Fix 3 test namespaces

2017-07-06 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363589 ) Change subject: Fix 3 test namespaces .. Fix 3 test namespaces Change-Id: Ie792a3382c32e40b3b13999e11687c748816ec43 --- M tests/phpunit/Re

[MediaWiki-commits] [Gerrit] mediawiki...FileImporter[master]: Fix ApiDetailRetriever for foreign file namespaces

2017-07-06 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363588 ) Change subject: Fix ApiDetailRetriever for foreign file namespaces .. Fix ApiDetailRetriever for foreign file namespaces Also adds tests

[MediaWiki-commits] [Gerrit] mediawiki...FileImporter[master]: WIP rollback changes on failure

2017-07-05 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363321 ) Change subject: WIP rollback changes on failure .. WIP rollback changes on failure Bug: T147451 Change-Id: I70ee30fd24fcac9cb2b41fed7e4e84

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Add FileBackend_doOperations hook

2017-07-05 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363320 ) Change subject: Add FileBackend_doOperations hook .. Add FileBackend_doOperations hook Change-Id: I8baad8707879617186bbabf72042f189a5a9dba

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Factor OldRevisionImporter & WikiRevisionOldRevision out of ...

2017-07-04 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363286 ) Change subject: Factor OldRevisionImporter & WikiRevisionOldRevision out of WikiRevision .. Factor OldRevisionImporter & WikiRevisionOldRe

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: WIP factor UploadImporter out of WikiRevision

2017-07-04 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363284 ) Change subject: WIP factor UploadImporter out of WikiRevision .. WIP factor UploadImporter out of WikiRevision Change-Id: I4a6c573fc0a69b0

[MediaWiki-commits] [Gerrit] mediawiki...FileImporter[master]: Refactor UploadBase interaction & add tests

2017-07-04 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363228 ) Change subject: Refactor UploadBase interaction & add tests .. Refactor UploadBase interaction & add tests Change-Id: I7cf7f54222d7b3ed8d1

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Allow install.php to run env-checks with no db

2017-07-04 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363225 ) Change subject: Allow install.php to run env-checks with no db .. Allow install.php to run env-checks with no db Bug: T169668 Change-Id: I

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Don't ask for password for env-checks in install.php

2017-07-04 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363223 ) Change subject: Don't ask for password for env-checks in install.php .. Don't ask for password for env-checks in install.php Bug: T169669

[MediaWiki-commits] [Gerrit] mediawiki...Cognate[master]: Stop ignoring PhanTypeMismatchArgument phan issue

2017-07-04 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363221 ) Change subject: Stop ignoring PhanTypeMismatchArgument phan issue .. Stop ignoring PhanTypeMismatchArgument phan issue It looks like this

[MediaWiki-commits] [Gerrit] integration/config[master]: Use phan version 0.8

2017-07-04 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363222 ) Change subject: Use phan version 0.8 .. Use phan version 0.8 This still can't be included in the composer.json as it requires php7 which m

[MediaWiki-commits] [Gerrit] integration/config[master]: Add extension-phan-generic to FileImporter

2017-07-04 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363220 ) Change subject: Add extension-phan-generic to FileImporter .. Add extension-phan-generic to FileImporter Depends-On: Iafa2f82e7c31972e2b68

[MediaWiki-commits] [Gerrit] mediawiki...FileImporter[master]: Only use FileChunkSaver in HttpRequestExecutor

2017-07-04 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363219 ) Change subject: Only use FileChunkSaver in HttpRequestExecutor .. Only use FileChunkSaver in HttpRequestExecutor This was taken extracted

[MediaWiki-commits] [Gerrit] analytics...scripts[production]: Remove 2 betafeatures that are not in wgBetaFeaturesWhitelist

2017-07-04 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363209 ) Change subject: Remove 2 betafeatures that are not in wgBetaFeaturesWhitelist .. Remove 2 betafeatures that are not in wgBetaFeaturesWhitel

[MediaWiki-commits] [Gerrit] analytics...scripts[master]: Remove 2 betafeatures that are not in wgBetaFeaturesWhitelist

2017-07-04 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363208 ) Change subject: Remove 2 betafeatures that are not in wgBetaFeaturesWhitelist .. Remove 2 betafeatures that are not in wgBetaFeaturesWhitel

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: DNM Remove wm?gRevisionSliderBetaFeature

2017-07-04 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363207 ) Change subject: DNM Remove wm?gRevisionSliderBetaFeature .. DNM Remove wm?gRevisionSliderBetaFeature The Depends-On patch should be merged

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: DNM remove wgRevisionSliderAlternateSlider

2017-07-04 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363206 ) Change subject: DNM remove wgRevisionSliderAlternateSlider .. DNM remove wgRevisionSliderAlternateSlider The Depends-on patch removes the

[MediaWiki-commits] [Gerrit] analytics...scripts[production]: Remove revisionslider form bf list

2017-07-04 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363203 ) Change subject: Remove revisionslider form bf list .. Remove revisionslider form bf list BF code removed in: Iad2e34e2f906777c7ba0e22e245d

[MediaWiki-commits] [Gerrit] analytics...scripts[master]: Remove revisionslider form bf list

2017-07-04 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363202 ) Change subject: Remove revisionslider form bf list .. Remove revisionslider form bf list Change-Id: Ib4fa68c6c1a3652c74ca7fce61ac7b607ff84

[MediaWiki-commits] [Gerrit] mediawiki...FileImporter[master]: Add phan config

2017-07-04 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363190 ) Change subject: Add phan config .. Add phan config Change-Id: Iafa2f82e7c31972e2b6809eb9578510b1152ab5b --- A tests/phan/config.php A test

[MediaWiki-commits] [Gerrit] mediawiki...FileImporter[master]: ImportPlanValidator, perform checks in UploadBase::getTitle

2017-07-04 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363183 ) Change subject: ImportPlanValidator, perform checks in UploadBase::getTitle .. ImportPlanValidator, perform checks in UploadBase::getTitle

[MediaWiki-commits] [Gerrit] mediawiki...FileImporter[master]: WIP rolling back failed imports

2017-07-04 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363179 ) Change subject: WIP rolling back failed imports .. WIP rolling back failed imports Bug: T147451 Change-Id: I109520afdb96c87fb196c06e4746d0

[MediaWiki-commits] [Gerrit] mediawiki...FileImporter[master]: Move left over MW Remote services to correct Wiring

2017-07-04 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363173 ) Change subject: Move left over MW Remote services to correct Wiring .. Move left over MW Remote services to correct Wiring Change-Id: I0d9

[MediaWiki-commits] [Gerrit] mediawiki...FileImporter[master]: Add ImportPlanFactory

2017-07-04 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363172 ) Change subject: Add ImportPlanFactory .. Add ImportPlanFactory ImportPlans are always constructed by the factory now. This code can now be

[MediaWiki-commits] [Gerrit] mediawiki...FileImporter[master]: Show file extension in preview & edit pages

2017-07-03 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363029 ) Change subject: Show file extension in preview & edit pages .. Show file extension in preview & edit pages Triggered by comment @: https:/

[MediaWiki-commits] [Gerrit] mediawiki...FileImporter[master]: Allow recovery from invalid chars in title exception

2017-07-03 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363020 ) Change subject: Allow recovery from invalid chars in title exception .. Allow recovery from invalid chars in title exception Change-Id: Ib

[MediaWiki-commits] [Gerrit] mediawiki...FileImporter[master]: Check planned titles against wfStripIllegalFilenameChars

2017-07-03 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363009 ) Change subject: Check planned titles against wfStripIllegalFilenameChars .. Check planned titles against wfStripIllegalFilenameChars Bug:

[MediaWiki-commits] [Gerrit] mediawiki...FileImporter[master]: Change of file extension case is allowed

2017-07-03 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363008 ) Change subject: Change of file extension case is allowed .. Change of file extension case is allowed Bug: T163500 Change-Id: If5113c09504f

[MediaWiki-commits] [Gerrit] mediawiki...FileImporter[master]: Make sure planned title has an extension.

2017-07-03 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363007 ) Change subject: Make sure planned title has an extension. .. Make sure planned title has an extension. This also catches issues where user

[MediaWiki-commits] [Gerrit] mediawiki...FileImporter[master]: Followup to I1610f8359bc8a930a4990fccc74ddbec61be1218

2017-07-03 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/362969 ) Change subject: Followup to I1610f8359bc8a930a4990fccc74ddbec61be1218 .. Followup to I1610f8359bc8a930a4990fccc74ddbec61be1218 Change-Id:

[MediaWiki-commits] [Gerrit] labs...wikibugs2[master]: Add User-Addshore to ##add

2017-07-03 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/362962 ) Change subject: Add User-Addshore to ##add .. Add User-Addshore to ##add Change-Id: Idab1888f2ee33c1e47fd4485b283866df38238e5 --- M channe

[MediaWiki-commits] [Gerrit] mediawiki...FileImporter[master]: Docs & Cleanup of namespaces

2017-06-30 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/362449 ) Change subject: Docs & Cleanup of namespaces .. Docs & Cleanup of namespaces - Add an explanations / walkthrough of the process to the Rea

[MediaWiki-commits] [Gerrit] mediawiki...FileImporter[master]: Add ImportPlanValidatorTest & move Title check to ImportPlan...

2017-06-30 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/362433 ) Change subject: Add ImportPlanValidatorTest & move Title check to ImportPlanValidator .. Add ImportPlanValidatorTest & move Title check to

[MediaWiki-commits] [Gerrit] mediawiki...FileImporter[master]: Fix construction of TitleConflictException

2017-06-30 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/362430 ) Change subject: Fix construction of TitleConflictException .. Fix construction of TitleConflictException Change-Id: Idbcddc402a2fdffcb6de1

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: TidyDriverBase::validate throws an exception

2017-06-30 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/362407 ) Change subject: TidyDriverBase::validate throws an exception .. TidyDriverBase::validate throws an exception Change-Id: I05e31c757ed92323f

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Update phan issues & estimated counts

2017-06-30 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/362406 ) Change subject: Update phan issues & estimated counts .. Update phan issues & estimated counts Since the last update there is a total of 5

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Enable Newsletter on mediawikiwiki

2017-06-30 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/362394 ) Change subject: Enable Newsletter on mediawikiwiki .. Enable Newsletter on mediawikiwiki Bug: T110170 Change-Id: I1045e70cc2401e4c565ecf76

<    1   2   3   4   5   6   7   8   9   10   >