[MediaWiki-commits] [Gerrit] [WIP] Some decoupling of GatewayPage from GatewayType - change (mediawiki...DonationInterface)

2016-07-24 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/300804 Change subject: [WIP] Some decoupling of GatewayPage from GatewayType .. [WIP] Some decoupling of GatewayPage from GatewayType GatewayType is

[MediaWiki-commits] [Gerrit] Error checking - change (wikimedia...SmashPig)

2016-07-24 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/300766 Change subject: Error checking .. Error checking Change-Id: Ie55277d62fefeae0c6633dde311698ad98e017c7 --- M

[MediaWiki-commits] [Gerrit] Singleton PDO For the pending database - change (wikimedia...SmashPig)

2016-07-24 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/300745 Change subject: Singleton PDO For the pending database .. Singleton PDO For the pending database More convenient for testing. Note that we

[MediaWiki-commits] [Gerrit] Remove WorldPay - change (wikimedia...crm)

2016-07-23 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/300707 Change subject: Remove WorldPay .. Remove WorldPay Change-Id: Ib00387c20bf576f40d486139199617c8a743df09 --- D

[MediaWiki-commits] [Gerrit] [WIP] Convert orphan rectifier to use the PendingDatabase - change (mediawiki...DonationInterface)

2016-07-20 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/300173 Change subject: [WIP] Convert orphan rectifier to use the PendingDatabase .. [WIP] Convert orphan rectifier to use the PendingDatabase

[MediaWiki-commits] [Gerrit] Method to override configuration with data - change (wikimedia...SmashPig)

2016-07-20 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/300171 Change subject: Method to override configuration with data .. Method to override configuration with data Change-Id:

[MediaWiki-commits] [Gerrit] update DonationInterface submodule - change (mediawiki/core)

2016-07-20 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/300102 Change subject: update DonationInterface submodule .. update DonationInterface submodule Change-Id: I2da8357f6ee8c7f7e36346600bbd887987553727

[MediaWiki-commits] [Gerrit] Disable Adyen JCB - change (mediawiki...DonationInterface)

2016-07-20 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/300098 Change subject: Disable Adyen JCB .. Disable Adyen JCB Bug: T140691 Change-Id: Id33c06c478eef1220bd61726150ed0b357565748 --- M

[MediaWiki-commits] [Gerrit] Disable Adyen JCB - change (mediawiki...DonationInterface)

2016-07-20 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/300096 Change subject: Disable Adyen JCB .. Disable Adyen JCB Bug: T140691 Change-Id: Id33c06c478eef1220bd61726150ed0b357565748 --- M

[MediaWiki-commits] [Gerrit] Snapshot of pcoombe's campaign statistics tools - change (wikimedia...tools)

2016-07-20 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/300090 Change subject: Snapshot of pcoombe's campaign statistics tools .. Snapshot of pcoombe's campaign statistics tools Note that this is not

[MediaWiki-commits] [Gerrit] Implement fetch oldest - change (wikimedia...SmashPig)

2016-07-20 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/300073 Change subject: Implement fetch oldest .. Implement fetch oldest This is useful for processors that aren't expecting specific messages, like

[MediaWiki-commits] [Gerrit] Change PendingDatabase signatures - change (wikimedia...SmashPig)

2016-07-20 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/300063 Change subject: Change PendingDatabase signatures .. Change PendingDatabase signatures * Return normalized message rather than the database

[MediaWiki-commits] [Gerrit] Reword docs; stop doing popAtomic(function () {}) - change (wikimedia...php-queue)

2016-07-20 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/300054 Change subject: Reword docs; stop doing popAtomic(function () {}) .. Reword docs; stop doing popAtomic(function () {}) Change-Id:

[MediaWiki-commits] [Gerrit] Use pop when we don't need transactionality - change (wikimedia...SmashPig)

2016-07-20 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/300053 Change subject: Use pop when we don't need transactionality .. Use pop when we don't need transactionality Try to extinguish the

[MediaWiki-commits] [Gerrit] [WIP] Convert orphan rectifier to use the PendingDatabase - change (mediawiki...DonationInterface)

2016-07-19 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/299915 Change subject: [WIP] Convert orphan rectifier to use the PendingDatabase .. [WIP] Convert orphan rectifier to use the PendingDatabase Bug:

[MediaWiki-commits] [Gerrit] Create pending_db_orphan_rectifier branch for forked deployment - change (mediawiki...DonationInterface)

2016-07-19 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/299914 Change subject: Create pending_db_orphan_rectifier branch for forked deployment .. Create pending_db_orphan_rectifier branch for forked

[MediaWiki-commits] [Gerrit] Depend on SmashPig; use looser caret versioning - change (mediawiki...DonationInterface)

2016-07-19 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/299913 Change subject: Depend on SmashPig; use looser caret versioning .. Depend on SmashPig; use looser caret versioning Change-Id:

[MediaWiki-commits] [Gerrit] Kill 'limbo' queue - change (mediawiki...DonationInterface)

2016-07-19 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/299873 Change subject: Kill 'limbo' queue .. Kill 'limbo' queue Totally useless. Make 'pending' the default for setLimboMessage. Bug: T133195

[MediaWiki-commits] [Gerrit] Remove RapidHTML - change (mediawiki...DonationInterface)

2016-07-19 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/299876 Change subject: Remove RapidHTML .. Remove RapidHTML Feels glorious, doesn't it? Bug: T86248 Change-Id:

[MediaWiki-commits] [Gerrit] Remove WorldPay adapter - change (mediawiki...DonationInterface)

2016-07-19 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/299875 Change subject: Remove WorldPay adapter .. Remove WorldPay adapter Change-Id: Idaec0617c1dbb796ececa4661a40d3a0c4a0c087 --- M

[MediaWiki-commits] [Gerrit] update DonationInterface submodule - change (mediawiki/core)

2016-07-19 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/299877 Change subject: update DonationInterface submodule .. update DonationInterface submodule Change-Id: I31a868dba275f2a32c2dc96dcae33e13d2d1345d

[MediaWiki-commits] [Gerrit] Localisation updates from https://translatewiki.net. - change (mediawiki...DonationInterface)

2016-07-19 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/299874 Change subject: Localisation updates from https://translatewiki.net. .. Localisation updates from https://translatewiki.net. Change-Id:

[MediaWiki-commits] [Gerrit] [WIP] Pending queue supports delete and fetch - change (wikimedia...SmashPig)

2016-07-18 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/299691 Change subject: [WIP] Pending queue supports delete and fetch .. [WIP] Pending queue supports delete and fetch Bug: T131275 Change-Id:

[MediaWiki-commits] [Gerrit] [WIP] Move PendingDatabase into its own class - change (wikimedia...SmashPig)

2016-07-18 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/299686 Change subject: [WIP] Move PendingDatabase into its own class .. [WIP] Move PendingDatabase into its own class Bug: T131275 Bug: T130897

[MediaWiki-commits] [Gerrit] Version number indicates fundraising patches - change (mediawiki/core)

2016-07-18 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/299679 Change subject: Version number indicates fundraising patches .. Version number indicates fundraising patches Change-Id:

[MediaWiki-commits] [Gerrit] Update submodules to REL1_27 - change (mediawiki/core)

2016-07-18 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/299676 Change subject: Update submodules to REL1_27 .. Update submodules to REL1_27 Change-Id: Ic04aefa59d9aef57a03d672a61303303f520b940 --- M

[MediaWiki-commits] [Gerrit] Skip tests on the DonationInterface deployment branch - change (integration/config)

2016-07-18 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/299618 Change subject: Skip tests on the DonationInterface deployment branch .. Skip tests on the DonationInterface deployment branch Change-Id:

[MediaWiki-commits] [Gerrit] Disable Friesland and Bunq bank - change (mediawiki...DonationInterface)

2016-07-18 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/299601 Change subject: Disable Friesland and Bunq bank .. Disable Friesland and Bunq bank We haven't committed to supporting these banks, yet.

[MediaWiki-commits] [Gerrit] Redisable Knab - change (mediawiki...DonationInterface)

2016-07-18 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/299599 Change subject: Redisable Knab .. Redisable Knab Change-Id: Ibc207ea56218fc634eddabd9fb7d85bd8ce83fbb --- M

[MediaWiki-commits] [Gerrit] Force bad encodings to approximate UTF-8 - change (mediawiki...DonationInterface)

2016-07-16 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/299352 Change subject: Force bad encodings to approximate UTF-8 .. Force bad encodings to approximate UTF-8 In case the message cannot be

[MediaWiki-commits] [Gerrit] [WIP] Reproduce Ingenico name encoding bug - change (mediawiki...DonationInterface)

2016-07-16 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/299350 Change subject: [WIP] Reproduce Ingenico name encoding bug .. [WIP] Reproduce Ingenico name encoding bug Bug: T140515 Change-Id:

[MediaWiki-commits] [Gerrit] update DonationInterface submodule - change (mediawiki/core)

2016-07-16 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/299303 Change subject: update DonationInterface submodule .. update DonationInterface submodule Change-Id: I17f6b3db05fa05b59bfac949d9fde765f7bff75d

[MediaWiki-commits] [Gerrit] Log json_encode errors - change (mediawiki...DonationInterface)

2016-07-16 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/299302 Change subject: Log json_encode errors .. Log json_encode errors When completed donation logging fails, we want to know what's up. TODO:

[MediaWiki-commits] [Gerrit] [WIP] Test for logCompleted - change (mediawiki...DonationInterface)

2016-07-16 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/299298 Change subject: [WIP] Test for logCompleted .. [WIP] Test for logCompleted Change-Id: Ib7a1133579b3661fa5faafc64a1e9121a5222d32 --- M

[MediaWiki-commits] [Gerrit] [WIP] Log json_encode errors - change (mediawiki...DonationInterface)

2016-07-16 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/299297 Change subject: [WIP] Log json_encode errors .. [WIP] Log json_encode errors When completed donation logging fails, we want to know what's

[MediaWiki-commits] [Gerrit] Logging to debug my logging - change (mediawiki...DonationInterface)

2016-07-16 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/299295 Change subject: Logging to debug my logging .. Logging to debug my logging  Bug: Change-Id: Id2046340f21bd62192e4b280d2ce1df848e5aad7 --- M

[MediaWiki-commits] [Gerrit] update DonationInterface submodule - change (mediawiki/core)

2016-07-16 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/299291 Change subject: update DonationInterface submodule .. update DonationInterface submodule Change-Id: Ib4ecfbc03384abe1dc306c24b8ca1e5cce6cb275

[MediaWiki-commits] [Gerrit] Log completed donations - change (mediawiki...DonationInterface)

2016-07-16 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/299290 Change subject: Log completed donations .. Log completed donations This is to debug an active issue where the queue message body is missing,

[MediaWiki-commits] [Gerrit] Fix typo masking gateway validation tests - change (mediawiki...DonationInterface)

2016-07-16 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/299289 Change subject: Fix typo masking gateway validation tests .. Fix typo masking gateway validation tests They were failing as "risky".

[MediaWiki-commits] [Gerrit] Wrap test global manipulations in setMwGlobals - change (mediawiki...DonationInterface)

2016-07-16 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/299288 Change subject: Wrap test global manipulations in setMwGlobals .. Wrap test global manipulations in setMwGlobals This prevents us from

[MediaWiki-commits] [Gerrit] Remove a Worldpay test - change (mediawiki...DonationInterface)

2016-07-16 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/299287 Change subject: Remove a Worldpay test .. Remove a Worldpay test It was failing. Delete with prejudice. Change-Id:

[MediaWiki-commits] [Gerrit] Log completed donations - change (mediawiki...DonationInterface)

2016-07-16 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/299280 Change subject: Log completed donations .. Log completed donations This is to debug an active issue, and would ideally generalize how we log

[MediaWiki-commits] [Gerrit] Merge master into deployment - change (wikimedia...crm)

2016-07-15 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/299264 Change subject: Merge master into deployment .. Merge master into deployment 0e9fe98226120eb0edd5c57e493bc6e697f84a38 Don't assume configured

[MediaWiki-commits] [Gerrit] [WIP] Remove RapidHTML - change (mediawiki...DonationInterface)

2016-07-15 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/299263 Change subject: [WIP] Remove RapidHTML .. [WIP] Remove RapidHTML Change-Id: Ic569153e9205c5691074c0a3580a7004f9268893 --- M

[MediaWiki-commits] [Gerrit] Fail if the message body is missing - change (wikimedia...crm)

2016-07-15 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/299261 Change subject: Fail if the message body is missing .. Fail if the message body is missing Bug: T140515 Change-Id:

[MediaWiki-commits] [Gerrit] Make the fundraising 1.27 tests mandatory - change (integration/config)

2016-07-15 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/299200 Change subject: Make the fundraising 1.27 tests mandatory .. Make the fundraising 1.27 tests mandatory Bug: T138016 Change-Id:

[MediaWiki-commits] [Gerrit] [DO NOT MERGE] Random stab in the dark at helping with T132449 - change (mediawiki/vagrant)

2016-07-15 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/299186 Change subject: [DO NOT MERGE] Random stab in the dark at helping with T132449 .. [DO NOT MERGE] Random stab in the dark at helping with

[MediaWiki-commits] [Gerrit] Run DonationInterface LintYaml job via composer-test - change (integration/config)

2016-07-15 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/299185 Change subject: Run DonationInterface LintYaml job via composer-test .. Run DonationInterface LintYaml job via composer-test Change-Id:

[MediaWiki-commits] [Gerrit] [WIP] Use traits to consolidate TestingAdapters - change (mediawiki...DonationInterface)

2016-07-15 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/299150 Change subject: [WIP] Use traits to consolidate TestingAdapters .. [WIP] Use traits to consolidate TestingAdapters Note that traits require

[MediaWiki-commits] [Gerrit] Remove WorldPay adapter - change (mediawiki...DonationInterface)

2016-07-13 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/298903 Change subject: Remove WorldPay adapter .. Remove WorldPay adapter Change-Id: Idaec0617c1dbb796ececa4661a40d3a0c4a0c087 --- M

[MediaWiki-commits] [Gerrit] Reuse server-side validations in getClientSideValidations - change (mediawiki...DonationInterface)

2016-07-13 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/298898 Change subject: Reuse server-side validations in getClientSideValidations .. Reuse server-side validations in getClientSideValidations

[MediaWiki-commits] [Gerrit] Remove WorldPay ResourceLoader modules - change (mediawiki...DonationInterface)

2016-07-13 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/298893 Change subject: Remove WorldPay ResourceLoader modules .. Remove WorldPay ResourceLoader modules Change-Id:

[MediaWiki-commits] [Gerrit] Note some more Fundraising gotchas - change (mediawiki/vagrant)

2016-07-13 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/298824 Change subject: Note some more Fundraising gotchas .. Note some more Fundraising gotchas Change-Id: I95119df9da49771b0406b23d1ff71ada6a4af800

[MediaWiki-commits] [Gerrit] Bump version number - change (mediawiki...DonationInterface)

2016-07-12 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/298668 Change subject: Bump version number .. Bump version number Change-Id: Id1e1d7448fdc640e8d168e8d3fa6b5442d9411f1 --- M extension.json 1 file

[MediaWiki-commits] [Gerrit] remove unused modules; comments - change (mediawiki...DonationInterface)

2016-07-12 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/298669 Change subject: remove unused modules; comments .. remove unused modules; comments Change-Id: Ia857e37828be694b21f9462fb24ba7640d957f4f --- M

[MediaWiki-commits] [Gerrit] Remove unused rtbt RapidHtml forms - change (mediawiki...DonationInterface)

2016-07-12 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/298667 Change subject: Remove unused rtbt RapidHtml forms .. Remove unused rtbt RapidHtml forms Change-Id: Ib5a5c4f679316436d632a5b3d87ea9ee0fc5da8e

[MediaWiki-commits] [Gerrit] DRY workaround - change (mediawiki...DonationInterface)

2016-07-12 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/298670 Change subject: DRY workaround .. DRY workaround Use the already calculated value rather than repeat a conditional. Change-Id:

[MediaWiki-commits] [Gerrit] [WIP] Display issuers dropdown - change (mediawiki...DonationInterface)

2016-07-12 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/298641 Change subject: [WIP] Display issuers dropdown .. [WIP] Display issuers dropdown Change-Id: Ie8713ab87f8e0a9777818b564e2807335517 --- M

[MediaWiki-commits] [Gerrit] [WIP] rtbt methods support getAvailableSubmethods; display l... - change (mediawiki...DonationInterface)

2016-07-12 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/298633 Change subject: [WIP] rtbt methods support getAvailableSubmethods; display logo for only submethod .. [WIP] rtbt methods support

[MediaWiki-commits] [Gerrit] Remove unused forms - change (mediawiki...DonationInterface)

2016-07-12 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/298547 Change subject: Remove unused forms .. Remove unused forms * bt is done through AstroPay * dd unused since 2014 * ew unused since Jan 2015 *

[MediaWiki-commits] [Gerrit] Delist Special:CodeReview - change (operations/mediawiki-config)

2016-07-12 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/298544 Change subject: Delist Special:CodeReview .. Delist Special:CodeReview Bug: T116948 Change-Id: I8ffd8b67ab92d9b15140d5a20173c0e9fdff46f3 ---

[MediaWiki-commits] [Gerrit] Delist Special:CodeReview - change (mediawiki...CodeReview)

2016-07-12 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/298509 Change subject: Delist Special:CodeReview .. Delist Special:CodeReview Leave CodeReview available as an archive (at least until we can dump a

[MediaWiki-commits] [Gerrit] [WIP] Loosen version requirements to allow for updates - change (wikimedia...crm)

2016-07-12 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/298420 Change subject: [WIP] Loosen version requirements to allow for updates .. [WIP] Loosen version requirements to allow for updates Change-Id:

[MediaWiki-commits] [Gerrit] Switch to caret semantic versioning - change (wikimedia...SmashPig)

2016-07-12 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/298418 Change subject: Switch to caret semantic versioning .. Switch to caret semantic versioning There's at least one urgent security update in

[MediaWiki-commits] [Gerrit] Whitelist a bunch of RSS feeds for Fundraising Tech to play ... - change (operations/mediawiki-config)

2016-07-11 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/298399 Change subject: Whitelist a bunch of RSS feeds for Fundraising Tech to play with .. Whitelist a bunch of RSS feeds for Fundraising Tech to

[MediaWiki-commits] [Gerrit] Support verbose logging for cURL - change (mediawiki...DonationInterface)

2016-07-11 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/298395 Change subject: Support verbose logging for cURL .. Support verbose logging for cURL To be used sparingly. To debug a specific gateway, set

[MediaWiki-commits] [Gerrit] Merge REL1_25 into fundraising/REL1_25 - change (mediawiki/core)

2016-07-11 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/298320 Change subject: Merge REL1_25 into fundraising/REL1_25 .. Merge REL1_25 into fundraising/REL1_25 Change-Id:

[MediaWiki-commits] [Gerrit] Use the decoded array to access message content - change (wikimedia...crm)

2016-07-11 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/298306 Change subject: Use the decoded array to access message content .. Use the decoded array to access message content Change-Id:

[MediaWiki-commits] [Gerrit] update DonationInterface submodule - change (mediawiki/core)

2016-07-07 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/297927 Change subject: update DonationInterface submodule .. update DonationInterface submodule Change-Id: I9b4563cc6b3d96e6dc4852086cf9317b9588902d

[MediaWiki-commits] [Gerrit] update DonationInterface submodule - change (mediawiki/core)

2016-07-07 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/297923 Change subject: update DonationInterface submodule .. update DonationInterface submodule Change-Id: Id531d359cda6c24f982f28f11f3705661bbc5145

[MediaWiki-commits] [Gerrit] Merge master into deployment - change (mediawiki...DonationInterface)

2016-07-07 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/297922 Change subject: Merge master into deployment .. Merge master into deployment dc888095e4c5ecbdbe44f4ddc420a5a30822164d Whitespace cleanup

[MediaWiki-commits] [Gerrit] Clean up style complaints (to squash) - change (mediawiki...DonationInterface)

2016-07-07 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/297857 Change subject: Clean up style complaints (to squash) .. Clean up style complaints (to squash) Change-Id:

[MediaWiki-commits] [Gerrit] Merge master into deployment - change (wikimedia...SmashPig)

2016-07-07 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/297835 Change subject: Merge master into deployment .. Merge master into deployment bfcc0d5c4228f76f85d787adc19f44738ff19e94 replace busted

[MediaWiki-commits] [Gerrit] Finish futzing with styles - change (mediawiki...DonationInterface)

2016-07-07 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/297833 Change subject: Finish futzing with styles .. Finish futzing with styles Change-Id: Iee5d4553f866c1bbd9dde9d9c0696b52700238ba --- M

[MediaWiki-commits] [Gerrit] Remove deprecated "position" directives - change (mediawiki...DonationInterface)

2016-07-07 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/297827 Change subject: Remove deprecated "position" directives .. Remove deprecated "position" directives Change-Id:

[MediaWiki-commits] [Gerrit] Whitespace cleanup - change (mediawiki...DonationInterface)

2016-07-07 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/297823 Change subject: Whitespace cleanup .. Whitespace cleanup Change-Id: I55840c9fc4f66418ff1f2d7d4f9b004352baf9d3 --- M

[MediaWiki-commits] [Gerrit] Merge master into deployment - change (mediawiki...DonationInterface)

2016-07-07 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/297815 Change subject: Merge master into deployment .. Merge master into deployment 9b025ce1172fa1516dbec6b334fa5dbd2eb18570 Adyen signature

[MediaWiki-commits] [Gerrit] Update DonationInterface submodule - change (mediawiki/core)

2016-07-07 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/297816 Change subject: Update DonationInterface submodule .. Update DonationInterface submodule Change-Id: I78de211acd743d72f8534d27e1b36a77845eae6f

[MediaWiki-commits] [Gerrit] [WIP] Move RapidHtml inline loader statements to the server ... - change (mediawiki...DonationInterface)

2016-07-07 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/297808 Change subject: [WIP] Move RapidHtml inline loader statements to the server side .. [WIP] Move RapidHtml inline loader statements to the

[MediaWiki-commits] [Gerrit] (FR #1070) Drupal registry supports namespaces - change (wikimedia...drupal)

2016-07-05 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/297522 Change subject: (FR #1070) Drupal registry supports namespaces .. (FR #1070) Drupal registry supports namespaces Change-Id:

[MediaWiki-commits] [Gerrit] Check in custom hack to register namespaced classes - change (wikimedia...drupal)

2016-07-05 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/297521 Change subject: Check in custom hack to register namespaced classes .. Check in custom hack to register namespaced classes Change-Id:

[MediaWiki-commits] [Gerrit] Remove composer.lock file - change (mediawiki/core)

2016-07-05 Thread Awight (Code Review)
Awight has submitted this change and it was merged. Change subject: Remove composer.lock file .. Remove composer.lock file Bug: T139395 Change-Id: Iaeebebcc853bd623b76aec9a1a4af2a0867ef8cf --- D composer.lock 1 file changed, 0

[MediaWiki-commits] [Gerrit] Cheap yaml lint job. - change (mediawiki...DonationInterface)

2016-06-30 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/296775 Change subject: Cheap yaml lint job. .. Cheap yaml lint job. Change-Id: Iaaad8cfd31c02871824b1c018e99d91836637195 --- M composer.json A

[MediaWiki-commits] [Gerrit] [WIP] Terrible lint:yaml glue - change (mediawiki...DonationInterface)

2016-06-30 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/296766 Change subject: [WIP] Terrible lint:yaml glue .. [WIP] Terrible lint:yaml glue Nothing about this is okay. Forensic purposes only.

[MediaWiki-commits] [Gerrit] Typo in regex: suggestive antipattern. - change (integration/config)

2016-06-24 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/295952 Change subject: Typo in regex: suggestive antipattern. .. Typo in regex: suggestive antipattern. Don't dot. Change-Id:

[MediaWiki-commits] [Gerrit] [WIP] Need to lint some yaml - change (integration/config)

2016-06-24 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/295950 Change subject: [WIP] Need to lint some yaml .. [WIP] Need to lint some yaml We're relying on a big tree of yaml configuration now, and it

[MediaWiki-commits] [Gerrit] Add some lint tasks for fundraising repos: prepare for Jessie - change (integration/config)

2016-06-24 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/295949 Change subject: Add some lint tasks for fundraising repos: prepare for Jessie .. Add some lint tasks for fundraising repos: prepare for Jessie

[MediaWiki-commits] [Gerrit] Composer validation fixup - change (wikimedia...php-queue)

2016-06-24 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/295948 Change subject: Composer validation fixup .. Composer validation fixup Change-Id: I25e80d1dc06c61692500531a83eaecefd8d60796 --- M

[MediaWiki-commits] [Gerrit] DO NOT MERGE: Dummy commit for validating Zuul config - change (wikimedia...SmashPig)

2016-06-24 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/295933 Change subject: DO NOT MERGE: Dummy commit for validating Zuul config .. DO NOT MERGE: Dummy commit for validating Zuul config Change-Id:

[MediaWiki-commits] [Gerrit] DO NOT MERGE: Dummy commit for validating Zuul config - change (wikimedia...SmashPig)

2016-06-24 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/295931 Change subject: DO NOT MERGE: Dummy commit for validating Zuul config .. DO NOT MERGE: Dummy commit for validating Zuul config Change-Id:

[MediaWiki-commits] [Gerrit] Make composer validation happier - change (wikimedia...SmashPig)

2016-06-24 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/295928 Change subject: Make composer validation happier .. Make composer validation happier Loosen some seemingly unnecessary exact version

[MediaWiki-commits] [Gerrit] Don't run PHPUnit on SmashPig's deployment branch - change (integration/config)

2016-06-24 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/295921 Change subject: Don't run PHPUnit on SmashPig's deployment branch .. Don't run PHPUnit on SmashPig's deployment branch Cos the tests have

[MediaWiki-commits] [Gerrit] Forgot a "use" statement - change (wikimedia...SmashPig)

2016-06-23 Thread Awight (Code Review)
Awight has submitted this change and it was merged. Change subject: Forgot a "use" statement .. Forgot a "use" statement Change-Id: Ia442969ea93ba362d2c64c4621d02cdc456bee14 --- M Core/DataStores/JsonSerializableObject.php 1

[MediaWiki-commits] [Gerrit] Forgot a "use" statement - change (wikimedia...SmashPig)

2016-06-23 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/295689 Change subject: Forgot a "use" statement .. Forgot a "use" statement Change-Id: Ia442969ea93ba362d2c64c4621d02cdc456bee14 --- M

[MediaWiki-commits] [Gerrit] Forgot a "use" statement - change (wikimedia...SmashPig)

2016-06-23 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/295688 Change subject: Forgot a "use" statement .. Forgot a "use" statement Change-Id: Ia442969ea93ba362d2c64c4621d02cdc456bee14 --- M

[MediaWiki-commits] [Gerrit] Don't requeue non-existent pending message - change (wikimedia...SmashPig)

2016-06-23 Thread Awight (Code Review)
Awight has submitted this change and it was merged. Change subject: Don't requeue non-existent pending message .. Don't requeue non-existent pending message Silly new ACTION_MISSING constant Change-Id:

[MediaWiki-commits] [Gerrit] Downgrade serialization exception to warning - change (wikimedia...SmashPig)

2016-06-23 Thread Awight (Code Review)
Awight has submitted this change and it was merged. Change subject: Downgrade serialization exception to warning .. Downgrade serialization exception to warning Allow the serialization to continue--this indicates a coding

[MediaWiki-commits] [Gerrit] Downgrade serialization exception to warning - change (wikimedia...SmashPig)

2016-06-23 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/295686 Change subject: Downgrade serialization exception to warning .. Downgrade serialization exception to warning Allow the serialization to

[MediaWiki-commits] [Gerrit] Don't requeue non-existent pending message - change (wikimedia...SmashPig)

2016-06-23 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/295685 Change subject: Don't requeue non-existent pending message .. Don't requeue non-existent pending message Silly new ACTION_MISSING constant

[MediaWiki-commits] [Gerrit] Don't requeue non-existent pending message - change (wikimedia...SmashPig)

2016-06-23 Thread Awight (Code Review)
Awight has submitted this change and it was merged. Change subject: Don't requeue non-existent pending message .. Don't requeue non-existent pending message Silly new ACTION_MISSING constant Change-Id:

<    2   3   4   5   6   7   8   9   10   11   >