[MediaWiki-commits] [Gerrit] fix pod install warnings - change (apps...wikipedia)

2015-04-06 Thread Bgerstle (Code Review)
Bgerstle has uploaded a new change for review. https://gerrit.wikimedia.org/r/202037 Change subject: fix pod install warnings .. fix pod install warnings Running pod install was resulting in warnings about unknown UUIDs

[MediaWiki-commits] [Gerrit] makefile: add easy button to install dependencies - change (apps...wikipedia)

2015-04-06 Thread Bgerstle (Code Review)
Bgerstle has uploaded a new change for review. https://gerrit.wikimedia.org/r/202051 Change subject: makefile: add easy button to install dependencies .. makefile: add easy button to install dependencies - Add brew-install

[MediaWiki-commits] [Gerrit] Update credits to include new team members. - change (apps...wikipedia)

2015-04-03 Thread Bgerstle (Code Review)
Bgerstle has submitted this change and it was merged. Change subject: Update credits to include new team members. .. Update credits to include new team members. Change-Id: I22b3e5fbc78c393d31aa731b14190ee7938be2e9 --- M

[MediaWiki-commits] [Gerrit] Merge PR#9 - change (apps...wikipedia)

2015-04-02 Thread Bgerstle (Code Review)
Bgerstle has uploaded a new change for review. https://gerrit.wikimedia.org/r/201579 Change subject: Merge PR#9 .. Merge PR#9 fastlane project refinements Bug: T94769 Change-Id: I58b903cda4f55c9f6d8be72a1d5a7cdce70a83af

[MediaWiki-commits] [Gerrit] makefile: fix clean goal - change (apps...wikipedia)

2015-04-02 Thread Bgerstle (Code Review)
Bgerstle has uploaded a new change for review. https://gerrit.wikimedia.org/r/201578 Change subject: makefile: fix clean goal .. makefile: fix clean goal Change-Id: I8d3538f76f96502cd1237e795479919890d40d32 --- M Makefile 1

[MediaWiki-commits] [Gerrit] ignore mobileprovision and fix early return - change (apps...wikipedia)

2015-04-02 Thread Bgerstle (Code Review)
Bgerstle has uploaded a new change for review. https://gerrit.wikimedia.org/r/201577 Change subject: ignore mobileprovision and fix early return .. ignore mobileprovision and fix early return Change-Id:

[MediaWiki-commits] [Gerrit] re-add schemes - change (apps...wikipedia)

2015-04-02 Thread Bgerstle (Code Review)
Bgerstle has uploaded a new change for review. https://gerrit.wikimedia.org/r/201576 Change subject: re-add schemes .. re-add schemes Change-Id: Ic7a33d9a52ffc9b4d24671034706422d2ff78ed0 --- A

[MediaWiki-commits] [Gerrit] cleanup project fastfile - change (apps...wikipedia)

2015-04-02 Thread Bgerstle (Code Review)
Bgerstle has uploaded a new change for review. https://gerrit.wikimedia.org/r/201608 Change subject: cleanup project fastfile .. cleanup project fastfile Bug: T94769 Change-Id: I301d72138ed4ffbf710df5840368581f2a26b3c6 ---

[MediaWiki-commits] [Gerrit] remove beta.xcconfig - change (apps...wikipedia)

2015-04-02 Thread Bgerstle (Code Review)
Bgerstle has uploaded a new change for review. https://gerrit.wikimedia.org/r/201574 Change subject: remove beta.xcconfig .. remove beta.xcconfig Change-Id: Iafb8efabd729e3898b6ca7c18118bb710c9a05ab --- D BetaConfig.xcconfig

[MediaWiki-commits] [Gerrit] clean up FastFile and set vim filetype - change (apps...wikipedia)

2015-04-02 Thread Bgerstle (Code Review)
Bgerstle has uploaded a new change for review. https://gerrit.wikimedia.org/r/201573 Change subject: clean up FastFile and set vim filetype .. clean up FastFile and set vim filetype Change-Id:

[MediaWiki-commits] [Gerrit] remove extra schemes and double check old data model inclusion - change (apps...wikipedia)

2015-04-02 Thread Bgerstle (Code Review)
Bgerstle has uploaded a new change for review. https://gerrit.wikimedia.org/r/201572 Change subject: remove extra schemes and double check old data model inclusion .. remove extra schemes and double check old data model

[MediaWiki-commits] [Gerrit] update Gemfile and ignore fastflane artifacts - change (apps...wikipedia)

2015-04-02 Thread Bgerstle (Code Review)
Bgerstle has uploaded a new change for review. https://gerrit.wikimedia.org/r/201571 Change subject: update Gemfile and ignore fastflane artifacts .. update Gemfile and ignore fastflane artifacts Change-Id:

[MediaWiki-commits] [Gerrit] remove conflict markers - change (apps...wikipedia)

2015-04-02 Thread Bgerstle (Code Review)
Bgerstle has uploaded a new change for review. https://gerrit.wikimedia.org/r/201575 Change subject: remove conflict markers .. remove conflict markers Change-Id: Ie0990bf083c11e611c8ea3e1e5da8180902ce818 --- M .gitignore 1

[MediaWiki-commits] [Gerrit] paginate image info requests - change (apps...wikipedia)

2015-03-31 Thread Bgerstle (Code Review)
Bgerstle has uploaded a new change for review. https://gerrit.wikimedia.org/r/200905 Change subject: paginate image info requests .. paginate image info requests Bug: T91124 Change-Id:

[MediaWiki-commits] [Gerrit] all migrated articles editable fix - change (apps...wikipedia)

2015-03-27 Thread Bgerstle (Code Review)
Bgerstle has uploaded a new change for review. https://gerrit.wikimedia.org/r/200225 Change subject: all migrated articles editable fix .. all migrated articles editable fix We weren't properly setting article.editable

[MediaWiki-commits] [Gerrit] use pessimistic version specifiers - change (apps...wikipedia)

2015-03-23 Thread Bgerstle (Code Review)
Bgerstle has uploaded a new change for review. https://gerrit.wikimedia.org/r/199160 Change subject: use pessimistic version specifiers .. use pessimistic version specifiers the ~ specifier allows updates of unspecified

[MediaWiki-commits] [Gerrit] set article imageURL and save image list - change (apps...wikipedia)

2015-03-20 Thread Bgerstle (Code Review)
Bgerstle has uploaded a new change for review. https://gerrit.wikimedia.org/r/198432 Change subject: set article imageURL and save image list .. set article imageURL and save image list The article's lead image (imageURL)

[MediaWiki-commits] [Gerrit] Fix NSDateFormatter issues - change (apps...wikipedia)

2015-03-17 Thread Bgerstle (Code Review)
Bgerstle has uploaded a new change for review. https://gerrit.wikimedia.org/r/197387 Change subject: Fix NSDateFormatter issues .. Fix NSDateFormatter issues We were failing to parse timestamps when the device was set to

[MediaWiki-commits] [Gerrit] implement RTL support for gallery - change (apps...wikipedia)

2015-03-16 Thread Bgerstle (Code Review)
Bgerstle has uploaded a new change for review. https://gerrit.wikimedia.org/r/197268 Change subject: implement RTL support for gallery .. implement RTL support for gallery - Flip gallery images (swipe to the left to

[MediaWiki-commits] [Gerrit] clean up image gallery - change (apps...wikipedia)

2015-03-10 Thread Bgerstle (Code Review)
Bgerstle has uploaded a new change for review. https://gerrit.wikimedia.org/r/195614 Change subject: clean up image gallery .. clean up image gallery Linting and fixed WMFGradientView.gradientLayer retain policy. Change-Id:

[MediaWiki-commits] [Gerrit] make image gallery check for and store images to disk - change (apps...wikipedia)

2015-03-10 Thread Bgerstle (Code Review)
Bgerstle has uploaded a new change for review. https://gerrit.wikimedia.org/r/195790 Change subject: make image gallery check for and store images to disk .. make image gallery check for and store images to disk Previously

[MediaWiki-commits] [Gerrit] center images w/ white background - change (apps...wikipedia)

2015-03-09 Thread Bgerstle (Code Review)
Bgerstle has uploaded a new change for review. https://gerrit.wikimedia.org/r/195254 Change subject: center images w/ white background .. center images w/ white background images are centered w/ a white background, so that

[MediaWiki-commits] [Gerrit] uncrustify pass to fix linting errors - change (apps...wikipedia)

2015-03-06 Thread Bgerstle (Code Review)
Bgerstle has uploaded a new change for review. https://gerrit.wikimedia.org/r/194875 Change subject: uncrustify pass to fix linting errors .. uncrustify pass to fix linting errors Change-Id:

[MediaWiki-commits] [Gerrit] fix testing target - change (apps...wikipedia)

2015-03-06 Thread Bgerstle (Code Review)
Bgerstle has uploaded a new change for review. https://gerrit.wikimedia.org/r/194873 Change subject: fix testing target .. fix testing target Change-Id: I2fe617fa1b0d739b627e0575899ba6dc90b96d46 --- M

[MediaWiki-commits] [Gerrit] fix for missing image info when URLs have extra path extension - change (apps...wikipedia)

2015-03-04 Thread Bgerstle (Code Review)
Bgerstle has uploaded a new change for review. https://gerrit.wikimedia.org/r/194355 Change subject: fix for missing image info when URLs have extra path extension .. fix for missing image info when URLs have extra path

[MediaWiki-commits] [Gerrit] Uncrustify strikes back—with a vengeance - change (apps...wikipedia)

2015-03-03 Thread Bgerstle (Code Review)
Bgerstle has uploaded a new change for review. https://gerrit.wikimedia.org/r/194250 Change subject: Uncrustify strikes back—with a vengeance .. Uncrustify strikes back—with a vengeance Change-Id:

[MediaWiki-commits] [Gerrit] add Makefile - change (apps...wikipedia)

2015-03-03 Thread Bgerstle (Code Review)
Bgerstle has uploaded a new change for review. https://gerrit.wikimedia.org/r/194257 Change subject: add Makefile .. add Makefile main targets: * check-deps: check that dependencies are installed * get-deps: install (some)

[MediaWiki-commits] [Gerrit] associate images using URLs - change (apps...wikipedia)

2015-03-02 Thread Bgerstle (Code Review)
Bgerstle has uploaded a new change for review. https://gerrit.wikimedia.org/r/193863 Change subject: associate images using URLs .. associate images using URLs - Use source URLs to determine whether image info corresponds to

[MediaWiki-commits] [Gerrit] remove MediaWikiKit tests from xcscheme - change (apps...wikipedia)

2015-03-01 Thread Bgerstle (Code Review)
Bgerstle has uploaded a new change for review. https://gerrit.wikimedia.org/r/193764 Change subject: remove MediaWikiKit tests from xcscheme .. remove MediaWikiKit tests from xcscheme Change-Id:

[MediaWiki-commits] [Gerrit] refactor subview searching categories - change (apps...wikipedia)

2015-02-27 Thread Bgerstle (Code Review)
Bgerstle has uploaded a new change for review. https://gerrit.wikimedia.org/r/193389 Change subject: refactor subview searching categories .. refactor subview searching categories - renamed category methods to use wmf_

[MediaWiki-commits] [Gerrit] image gallery design updates - change (apps...wikipedia)

2015-02-27 Thread Bgerstle (Code Review)
Bgerstle has uploaded a new change for review. https://gerrit.wikimedia.org/r/193419 Change subject: image gallery design updates .. image gallery design updates - tweak layout styling of gallery chrome - tweak metadata

[MediaWiki-commits] [Gerrit] fix issue causing large images to not be rerouted to WMF cache - change (apps...wikipedia)

2015-02-27 Thread Bgerstle (Code Review)
Bgerstle has uploaded a new change for review. https://gerrit.wikimedia.org/r/191894 Change subject: fix issue causing large images to not be rerouted to WMF cache .. fix issue causing large images to not be rerouted to WMF

[MediaWiki-commits] [Gerrit] Fix iOS 6 image gallery rotation - change (apps...wikipedia)

2015-02-26 Thread Bgerstle (Code Review)
Bgerstle has uploaded a new change for review. https://gerrit.wikimedia.org/r/193292 Change subject: Fix iOS 6 image gallery rotation .. Fix iOS 6 image gallery rotation Also: - modify project settings to cause compiler

[MediaWiki-commits] [Gerrit] fix Xcodeproj code signing - change (apps...wikipedia)

2015-02-19 Thread Bgerstle (Code Review)
Bgerstle has uploaded a new change for review. https://gerrit.wikimedia.org/r/191763 Change subject: fix Xcodeproj code signing .. fix Xcodeproj code signing Use Developer identity for Debug and Distribution for release, and

[MediaWiki-commits] [Gerrit] fixes unit testing target - change (apps...wikipedia)

2015-02-18 Thread Bgerstle (Code Review)
Bgerstle has uploaded a new change for review. https://gerrit.wikimedia.org/r/191534 Change subject: fixes unit testing target .. fixes unit testing target Change-Id: Ie8dc444ffdf99e62009cd9ccf53373e56125d2c6 --- M

[MediaWiki-commits] [Gerrit] image gallery - change (apps...wikipedia)

2015-02-17 Thread Bgerstle (Code Review)
Bgerstle has uploaded a new change for review. https://gerrit.wikimedia.org/r/188583 Change subject: image gallery .. image gallery - [x] show gallery w/ placeholders immediately, fetching metadata afterwards - [x] give

[MediaWiki-commits] [Gerrit] fix xcode scheme so it doesn't build test targets all the time - change (apps...wikipedia)

2015-02-02 Thread Bgerstle (Code Review)
Bgerstle has uploaded a new change for review. https://gerrit.wikimedia.org/r/188218 Change subject: fix xcode scheme so it doesn't build test targets all the time .. fix xcode scheme so it doesn't build test targets all the

[MediaWiki-commits] [Gerrit] remove cocoapods notes.txt - change (apps...wikipedia)

2015-02-02 Thread Bgerstle (Code Review)
Bgerstle has uploaded a new change for review. https://gerrit.wikimedia.org/r/188093 Change subject: remove cocoapods notes.txt .. remove cocoapods notes.txt Change-Id: I1a9b64570a35902e424d2ddab88735564380937b --- D

[MediaWiki-commits] [Gerrit] remove cocoapods notes.txt test.xcconfig from .xcodeproj - change (apps...wikipedia)

2015-02-02 Thread Bgerstle (Code Review)
Bgerstle has uploaded a new change for review. https://gerrit.wikimedia.org/r/188095 Change subject: remove cocoapods notes.txt test.xcconfig from .xcodeproj .. remove cocoapods notes.txt test.xcconfig from .xcodeproj

[MediaWiki-commits] [Gerrit] add unit testing target - change (apps...wikipedia)

2015-01-30 Thread Bgerstle (Code Review)
Bgerstle has uploaded a new change for review. https://gerrit.wikimedia.org/r/187828 Change subject: add unit testing target .. add unit testing target - adds test for NSArray+Predicate to (partially) test pods integration

[MediaWiki-commits] [Gerrit] fix visual and web regressions - change (apps...wikipedia)

2015-01-30 Thread Bgerstle (Code Review)
Bgerstle has uploaded a new change for review. https://gerrit.wikimedia.org/r/187873 Change subject: fix visual and web regressions .. fix visual and web regressions Turns out the assets folder we deleted wasn't all

[MediaWiki-commits] [Gerrit] add localized account creation error msgs - change (apps...wikipedia)

2015-01-15 Thread Bgerstle (Code Review)
Bgerstle has uploaded a new change for review. https://gerrit.wikimedia.org/r/185190 Change subject: add localized account creation error msgs .. add localized account creation error msgs Change-Id:

[MediaWiki-commits] [Gerrit] add test txt file - change (apps...wikipedia)

2015-01-12 Thread Bgerstle (Code Review)
Bgerstle has uploaded a new change for review. https://gerrit.wikimedia.org/r/184498 Change subject: add test txt file .. add test txt file Change-Id: I6b402e40d51041e78f2c65b16b7c902c8c9f7815 --- A test.txt 1 file changed,

<    1   2