[MediaWiki-commits] [Gerrit] mediawiki...release[master]: Remove weird cli protection from make-wmf-branch

2017-12-18 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399112 ) Change subject: Remove weird cli protection from make-wmf-branch .. Remove weird cli protection from make-wmf-branch Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...release[master]: WIP: make-release: Rewrite make-branches as branch

2017-12-18 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399111 ) Change subject: WIP: make-release: Rewrite make-branches as branch .. WIP: make-release: Rewrite make-branches as branch Trying to fold

[MediaWiki-commits] [Gerrit] mediawiki/core[REL1_27]: Add REL1_27 submodules for bundled extensions/skins/vendor

2017-12-18 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399102 ) Change subject: Add REL1_27 submodules for bundled extensions/skins/vendor .. Add REL1_27 submodules for bundled extensions/skins/vendor

[MediaWiki-commits] [Gerrit] operations/puppet[production]: scap: Set bin_dir globally to /usr/bin

2017-12-15 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398606 ) Change subject: scap: Set bin_dir globally to /usr/bin .. scap: Set bin_dir globally to /usr/bin This setting is a weird relic from back when

[MediaWiki-commits] [Gerrit] mediawiki...LiquidThreads[master]: Don't throw an exception when passed a bogus feed type

2017-12-14 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398409 ) Change subject: Don't throw an exception when passed a bogus feed type .. Don't throw an exception when passed a bogus feed type Just assume

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Get rid of clearly unloved refresh-dblist

2017-12-14 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398400 ) Change subject: Get rid of clearly unloved refresh-dblist .. Get rid of clearly unloved refresh-dblist Nobody uses it. You know how I can

[MediaWiki-commits] [Gerrit] mediawiki...WikimediaMaintenance[master]: Swap MEDIAWIKI_DBLIST_DIR for MEDIAWIKI_DEPLOYMENT_DIR

2017-12-14 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398395 ) Change subject: Swap MEDIAWIKI_DBLIST_DIR for MEDIAWIKI_DEPLOYMENT_DIR .. Swap MEDIAWIKI_DBLIST_DIR for MEDIAWIKI_DEPLOYMENT_DIR

[MediaWiki-commits] [Gerrit] mediawiki...ORES[wmf/1.31.0-wmf.12]: Avoid notice when oresm_name property doesn't exist

2017-12-14 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398383 ) Change subject: Avoid notice when oresm_name property doesn't exist .. Avoid notice when oresm_name property doesn't exist Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...ORES[master]: Avoid notice when oresm_name property doesn't exist

2017-12-14 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398381 ) Change subject: Avoid notice when oresm_name property doesn't exist .. Avoid notice when oresm_name property doesn't exist Change-Id:

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: group2 to wmf.12

2017-12-14 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398329 ) Change subject: group2 to wmf.12 .. group2 to wmf.12 Change-Id: I4c18ea87f65d15e3294c4fc39a1bea85d956c038 --- M wikiversions.json 1 file

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: group1 to wmf.12

2017-12-13 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398115 ) Change subject: group1 to wmf.12 .. group1 to wmf.12 Change-Id: Iee5765c438193a24476b9a824617b05e05dbc3e6 --- M php M wikiversions.json 2

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Limit to no more than 3 cached revisions

2017-12-13 Thread Chad (Code Review)
Chad has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/395048 ) Change subject: Limit to no more than 3 cached revisions .. Limit to no more than 3 cached revisions Bug: T182013 Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Releases jenkins: Ensure php-curl is present (version doesn'...

2017-12-12 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/397993 ) Change subject: Releases jenkins: Ensure php-curl is present (version doesn't matter) .. Releases jenkins: Ensure php-curl is present

[MediaWiki-commits] [Gerrit] mediawiki...release[master]: Fix typo from previous commit, and clean up branching logic

2017-12-12 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/397975 ) Change subject: Fix typo from previous commit, and clean up branching logic .. Fix typo from previous commit, and clean up branching logic -

[MediaWiki-commits] [Gerrit] mediawiki...release[master]: More descriptive failure

2017-12-12 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/397972 ) Change subject: More descriptive failure .. More descriptive failure Change-Id: I4ac7e56c2235f0ae48681a318a7548fac0bb1624 --- M

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Releases: Also include release tools for releasing

2017-12-12 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/397895 ) Change subject: Releases: Also include release tools for releasing .. Releases: Also include release tools for releasing Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Releases jenkins: Only clone MediaWiki core, and make it a b...

2017-12-12 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/397891 ) Change subject: Releases jenkins: Only clone MediaWiki core, and make it a bare clone .. Releases jenkins: Only clone MediaWiki core, and

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: group0 to wmf.12

2017-12-12 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/397873 ) Change subject: group0 to wmf.12 .. group0 to wmf.12 Change-Id: I39c558333b6d0f2b6e41d52e0a8e96871a62b2c2 --- M wikiversions.json 1 file

[MediaWiki-commits] [Gerrit] mediawiki...release[master]: Removing git-logs. Doesn't work and dubiously useful

2017-12-12 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/397864 ) Change subject: Removing git-logs. Doesn't work and dubiously useful .. Removing git-logs. Doesn't work and dubiously useful Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...release[master]: make-release-notes: Also allow passing the user/password fro...

2017-12-12 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/397744 ) Change subject: make-release-notes: Also allow passing the user/password from the CLI .. make-release-notes: Also allow passing the

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: group2 to wmf.11

2017-12-07 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/396071 ) Change subject: group2 to wmf.11 .. group2 to wmf.11 Change-Id: I6275f083014b1e53647a68ec2584df3eb352591e --- M wikiversions.json 1 file

[MediaWiki-commits] [Gerrit] mediawiki...WikidataPageBanner[wmf/1.31.0-wmf.11]: ParserOutput::setRawText() isn't a function

2017-12-06 Thread Chad (Code Review)
Chad has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/395857 ) Change subject: ParserOutput::setRawText() isn't a function .. ParserOutput::setRawText() isn't a function It's just called

[MediaWiki-commits] [Gerrit] mediawiki...WikidataPageBanner[master]: ParserOutput::setRawText() isn't a function

2017-12-06 Thread Chad (Code Review)
Chad has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/395834 ) Change subject: ParserOutput::setRawText() isn't a function .. ParserOutput::setRawText() isn't a function It's just called

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Revert "Revert "Group1 to wmf.11""

2017-12-06 Thread Chad (Code Review)
Hello jenkins-bot, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/395862 to review the following change. Change subject: Revert "Revert "Group1 to wmf.11"" .. Revert "Revert "Group1 to

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Revert "Group1 to wmf.11"

2017-12-06 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395829 ) Change subject: Revert "Group1 to wmf.11" .. Revert "Group1 to wmf.11" This reverts commit e25b96ec5f64389258c0c73cff3d57e47ce02c47.

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Group1 to wmf.11

2017-12-06 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395823 ) Change subject: Group1 to wmf.11 .. Group1 to wmf.11 Change-Id: Ief1f839716ce68dc88cf5234ce1f5715f33fef3a --- M php M wikiversions.json 2

[MediaWiki-commits] [Gerrit] operations...gerrit[master]: Gerrit 2.14.6

2017-12-06 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395820 ) Change subject: Gerrit 2.14.6 .. Gerrit 2.14.6 Change-Id: Ia671a72eef92682e31ef61806c3ce02207d0fc31 --- M gerrit.war M

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: group0 to wmf.11

2017-12-05 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395607 ) Change subject: group0 to wmf.11 .. group0 to wmf.11 Change-Id: Iaa0db9fd7523a2729d2e8dce4e5e686804175f85 --- M wikiversions.json 1 file

[MediaWiki-commits] [Gerrit] mediawiki...release[master]: You basically should never use special_extensions.

2017-12-04 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395060 ) Change subject: You basically should never use special_extensions. .. You basically should never use special_extensions. If you do, I will

[MediaWiki-commits] [Gerrit] mediawiki...CirrusSearch[wmf/1.31.0-wmf.10]: Swap Maintenance::error() for fatalError()

2017-12-04 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395041 ) Change subject: Swap Maintenance::error() for fatalError() .. Swap Maintenance::error() for fatalError() The former is deprecated when

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Adding new symlink for all dblists

2017-12-04 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395035 ) Change subject: Adding new symlink for all dblists .. Adding new symlink for all dblists Sort of what I started in I40efaf8, but let's do the

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Remove some old symlinks from noc

2017-12-04 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395033 ) Change subject: Remove some old symlinks from noc .. Remove some old symlinks from noc Change-Id: Ia4b856e49a656569abbb432d40551ddf46d4b3ca

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.31.0-wmf.10]: Revert "Special:Preferences: Use OOjs UI" and follow-ups

2017-12-04 Thread Chad (Code Review)
Chad has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/394874 ) Change subject: Revert "Special:Preferences: Use OOjs UI" and follow-ups .. Revert "Special:Preferences: Use OOjs UI" and follow-ups

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Remove AdvancedSearch inclusion in beta, it's in prod

2017-12-04 Thread Chad (Code Review)
Chad has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/394504 ) Change subject: Remove AdvancedSearch inclusion in beta, it's in prod .. Remove AdvancedSearch inclusion in beta, it's in prod

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.31.0-wmf.10]: Revert "Special:Preferences: Use OOjs UI" and follow-ups

2017-12-03 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394874 ) Change subject: Revert "Special:Preferences: Use OOjs UI" and follow-ups .. Revert "Special:Preferences: Use OOjs UI" and follow-ups The

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Add gitlab.com to Phab proxy whitelist

2017-12-01 Thread Chad (Code Review)
Hello 20after4, Halfak, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/394640 to review the following change. Change subject: Add gitlab.com to Phab proxy whitelist .. Add gitlab.com to

[MediaWiki-commits] [Gerrit] mediawiki...Collection[master]: Remove ancient back-compat for MW < 1.25

2017-12-01 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394628 ) Change subject: Remove ancient back-compat for MW < 1.25 .. Remove ancient back-compat for MW < 1.25 Change-Id:

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Remove AdvancedSearch inclusion in beta, it's in prod

2017-11-30 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394504 ) Change subject: Remove AdvancedSearch inclusion in beta, it's in prod .. Remove AdvancedSearch inclusion in beta, it's in prod Change-Id:

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Remove timeless inclusion in labs, prod has it

2017-11-30 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394503 ) Change subject: Remove timeless inclusion in labs, prod has it .. Remove timeless inclusion in labs, prod has it Change-Id:

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Remove ArticleCreationWorkflow from extension-list-labs, it'...

2017-11-30 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394501 ) Change subject: Remove ArticleCreationWorkflow from extension-list-labs, it's in prod .. Remove ArticleCreationWorkflow from

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Remove some dumb headers with my name in it

2017-11-30 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394500 ) Change subject: Remove some dumb headers with my name in it .. Remove some dumb headers with my name in it Change-Id:

[MediaWiki-commits] [Gerrit] labs...wikibugs2[master]: All-Users and All-Projects to #wikimedia-releng reporting

2017-11-30 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394498 ) Change subject: All-Users and All-Projects to #wikimedia-releng reporting .. All-Users and All-Projects to #wikimedia-releng reporting

[MediaWiki-commits] [Gerrit] All-Projects[refs/meta/config]: Enable lfs on mediawiki/services/ores/editquality

2017-11-30 Thread Chad (Code Review)
Chad has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/394198 ) Change subject: Enable lfs on mediawiki/services/ores/editquality .. Enable lfs on mediawiki/services/ores/editquality set limit to

[MediaWiki-commits] [Gerrit] mediawiki...CirrusSearch[master]: Swap Maintenance::error() for fatalError()

2017-11-30 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394410 ) Change subject: Swap Maintenance::error() for fatalError() .. Swap Maintenance::error() for fatalError() The former is deprecated when

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: group2 to wmf.10

2017-11-30 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394389 ) Change subject: group2 to wmf.10 .. group2 to wmf.10 Change-Id: Ibdd246b0ac7ec80f3d30e980ae0a6a52f5d603e5 --- M wikiversions.json 1 file

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Beta: Moving all docroots to standard-docroot

2017-11-29 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394203 ) Change subject: Beta: Moving all docroots to standard-docroot .. Beta: Moving all docroots to standard-docroot Now that we've unified all the

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Move all dblists on noc to dblists/ directory, rather than i...

2017-11-29 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394199 ) Change subject: Move all dblists on noc to dblists/ directory, rather than individually .. Move all dblists on noc to dblists/ directory,

[MediaWiki-commits] [Gerrit] All-Projects[refs/meta/config]: Enable git-lfs for research/ores/wheels

2017-11-29 Thread Chad (Code Review)
Chad has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/394179 ) Change subject: Enable git-lfs for research/ores/wheels .. Enable git-lfs for research/ores/wheels Bug: T181678 Change-Id:

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: group1 to wmf.10

2017-11-29 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394089 ) Change subject: group1 to wmf.10 .. group1 to wmf.10 Change-Id: Iaa51b537d650b89f32bcf5e75d16ecb915e5c144 --- M php M wikiversions.json 2

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Remove aawiki from group0, it's weird

2017-11-28 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/393844 ) Change subject: Remove aawiki from group0, it's weird .. Remove aawiki from group0, it's weird Change-Id:

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Add closed wikis to group0

2017-11-28 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/393827 ) Change subject: Add closed wikis to group0 .. Add closed wikis to group0 group0 is sadly too small of a sample to actually get any insight

[MediaWiki-commits] [Gerrit] operations...gerrit[master]: Gerrit: Add wmf branding to PolyGerrit

2017-11-28 Thread Chad (Code Review)
Chad has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/393753 ) Change subject: Gerrit: Add wmf branding to PolyGerrit .. Gerrit: Add wmf branding to PolyGerrit We have to use a plugin to do this

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: group0 to wmf.10

2017-11-28 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/393817 ) Change subject: group0 to wmf.10 .. group0 to wmf.10 Change-Id: I2d79b274376c004e179731710aebba2423f1cbfd --- M wikiversions.json 1 file

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: scap prep: Don't copy the patch dir if it already exists

2017-11-28 Thread Chad (Code Review)
Hello Thcipriani, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/393815 to review the following change. Change subject: scap prep: Don't copy the patch dir if it already exists .. scap

[MediaWiki-commits] [Gerrit] wikimedia/annualreport[master]: Update .gitreview ; )

2017-11-27 Thread Chad (Code Review)
Chad has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/389896 ) Change subject: Update .gitreview ;) .. Update .gitreview ;) Change-Id: I97e8fa1ccff7efc416b3e0479d5d720d818bf73f --- M .gitreview 1

[MediaWiki-commits] [Gerrit] mediawiki...SemanticPageMaker[master]: Remove weird MW < 1.14 support for NS_FILE not existing

2017-11-23 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/393153 ) Change subject: Remove weird MW < 1.14 support for NS_FILE not existing .. Remove weird MW < 1.14 support for NS_FILE not existing Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...SemanticImageAnnotator[master]: Remove absolutely bizarre support for MW versions < 1.14

2017-11-23 Thread Chad (Code Review)
Hello Reedy, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/393147 to review the following change. Change subject: Remove absolutely bizarre support for MW versions < 1.14 .. Remove

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: wgPageImagesExpandOpenSearchXml: drop intermediate $wmg setting

2017-11-23 Thread Chad (Code Review)
Hello Reedy, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/393122 to review the following change. Change subject: wgPageImagesExpandOpenSearchXml: drop intermediate $wmg setting ..

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: keys: Remove keys of former release managers from keys.txt

2017-11-22 Thread Chad (Code Review)
Chad has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/392463 ) Change subject: keys: Remove keys of former release managers from keys.txt .. keys: Remove keys of former release managers from

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: keys: Document usage of gpg --fetch-keys to import all keys

2017-11-22 Thread Chad (Code Review)
Chad has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/392464 ) Change subject: keys: Document usage of gpg --fetch-keys to import all keys .. keys: Document usage of gpg --fetch-keys to import all

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: keys: Note that Chris, Mark and Markus are no longer releasi...

2017-11-22 Thread Chad (Code Review)
Chad has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/392462 ) Change subject: keys: Note that Chris, Mark and Markus are no longer releasing new versions .. keys: Note that Chris, Mark and Markus

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: noc: Use local static favicon location instead of external one

2017-11-22 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/392927 ) Change subject: noc: Use local static favicon location instead of external one .. noc: Use local static favicon location instead of external

[MediaWiki-commits] [Gerrit] mediawiki...AdvancedSearch[wmf/1.31.0-wmf.8]: Fix main style issues with timeless skin

2017-11-22 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/392869 ) Change subject: Fix main style issues with timeless skin .. Fix main style issues with timeless skin - fixed fieldset layout - adjusted input

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: updatewikiversions: Only attempt symlink change if needed

2017-11-21 Thread Chad (Code Review)
Hello Thcipriani, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/392723 to review the following change. Change subject: updatewikiversions: Only attempt symlink change if needed ..

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Revert "group2 to wmf.8"

2017-11-20 Thread Chad (Code Review)
Hello Urbanecm, jenkins-bot, Zoranzoki21, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/392531 to review the following change. Change subject: Revert "group2 to wmf.8" .. Revert "group2

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Revert "group2 to wmf.8"

2017-11-20 Thread Chad (Code Review)
Chad has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/392531 ) Change subject: Revert "group2 to wmf.8" .. Revert "group2 to wmf.8" This reverts commit de22b99c6c38961d9d466f78d5d2b07ef314fc04.

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: group2 to wmf.8

2017-11-20 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/392467 ) Change subject: group2 to wmf.8 .. group2 to wmf.8 Change-Id: Ie2f182d6c9549da4e1a51e705384780b923518b1 --- M wikiversions.json 1 file

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: wikidatawiki to wmf.8

2017-11-20 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/392466 ) Change subject: wikidatawiki to wmf.8 .. wikidatawiki to wmf.8 Change-Id: I58666dd1e30e2dd016758afc8b16126f4a06db1b --- M wikiversions.json 1

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Move role::gerrit::server to just role::gerrit

2017-11-17 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/392095 ) Change subject: Move role::gerrit::server to just role::gerrit .. Move role::gerrit::server to just role::gerrit It's kinda redundant and a

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.31.0-wmf.8]: Revert "resources: Remove deprecated 'jquery.placeholder' mo...

2017-11-16 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391855 ) Change subject: Revert "resources: Remove deprecated 'jquery.placeholder' module" .. Revert "resources: Remove deprecated

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.31.0-wmf.8]: Revert "resources: Remove the deprecated 'jquery.badge' module"

2017-11-16 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391854 ) Change subject: Revert "resources: Remove the deprecated 'jquery.badge' module" .. Revert "resources: Remove the deprecated 'jquery.badge'

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Clean up branch referencing logic, should fix scap prep on m...

2017-11-15 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391745 ) Change subject: Clean up branch referencing logic, should fix scap prep on master .. Clean up branch referencing logic, should fix scap prep

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.31.0-wmf.8]: SECURITY: Handle -{}- syntax in attributes safely

2017-11-15 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391738 ) Change subject: SECURITY: Handle -{}- syntax in attributes safely .. SECURITY: Handle -{}- syntax in attributes safely Previously, if one had

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.31.0-wmf.8]: SECURITY: XSS in langconverter when regex hits pcre.backtrac...

2017-11-15 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391733 ) Change subject: SECURITY: XSS in langconverter when regex hits pcre.backtrack_limit .. SECURITY: XSS in langconverter when regex hits

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.31.0-wmf.8]: SECURITY: Escape internal error message

2017-11-15 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391730 ) Change subject: SECURITY: Escape internal error message .. SECURITY: Escape internal error message This message contains the request url,

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.31.0-wmf.8]: SECURITY: Ensure Message::rawParams can't lead to XSS

2017-11-15 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391720 ) Change subject: SECURITY: Ensure Message::rawParams can't lead to XSS .. SECURITY: Ensure Message::rawParams can't lead to XSS If you used

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.31.0-wmf.8]: SECURITY: API: Avoid some silliness with browser-guessed fil...

2017-11-15 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391714 ) Change subject: SECURITY: API: Avoid some silliness with browser-guessed filenames .. SECURITY: API: Avoid some silliness with

[MediaWiki-commits] [Gerrit] integration/config[master]: Use --jobs in git submodule update jobs

2017-11-15 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391712 ) Change subject: Use --jobs in git submodule update jobs .. Use --jobs in git submodule update jobs 8 is usually a sane number of jobs to fork

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.31.0-wmf.8]: SECURITY: Add throttling for BotPasswords authentication att...

2017-11-15 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391709 ) Change subject: SECURITY: Add throttling for BotPasswords authentication attempts .. SECURITY: Add throttling for BotPasswords authentication

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Use lfs plugin for lfs support

2017-11-15 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391635 ) Change subject: Use lfs plugin for lfs support .. Use lfs plugin for lfs support Change-Id: I866269e97209b48b539e670d74153f4b01066bf8 --- M

[MediaWiki-commits] [Gerrit] All-Projects[refs/meta/config]: Testing gerrit lfs using it on test/gerrit-ping

2017-11-15 Thread Chad (Code Review)
Chad has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/385239 ) Change subject: Testing gerrit lfs using it on test/gerrit-ping .. Testing gerrit lfs using it on test/gerrit-ping Change-Id:

[MediaWiki-commits] [Gerrit] operations...gerrit[master]: Adding lfs plugin @ 2.13.9

2017-11-15 Thread Chad (Code Review)
Chad has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/391625 ) Change subject: Adding lfs plugin @ 2.13.9 .. Adding lfs plugin @ 2.13.9 Change-Id: I47c495efab43f654153fb1596ff8a889ff8af4bd --- A

[MediaWiki-commits] [Gerrit] operations...gerrit[master]: Adding lfs plugin @ 2.13.9

2017-11-15 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391625 ) Change subject: Adding lfs plugin @ 2.13.9 .. Adding lfs plugin @ 2.13.9 Change-Id: I47c495efab43f654153fb1596ff8a889ff8af4bd --- A

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: group1 to wmf.8

2017-11-15 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391591 ) Change subject: group1 to wmf.8 .. group1 to wmf.8 Change-Id: I621d50c17b91b0cdb575d1177ff15467bad553e9 --- M php M wikiversions.json 2 files

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: search.wikimedia.org: Add robots.txt, tell them to stay away

2017-11-14 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391470 ) Change subject: search.wikimedia.org: Add robots.txt, tell them to stay away .. search.wikimedia.org: Add robots.txt, tell them to stay away

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Remove www.*.org symlinks

2017-11-14 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391355 ) Change subject: Remove www.*.org symlinks .. Remove www.*.org symlinks All of the apache config just references docroot/wwwportal directly

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: extract2.php: Stop allowing the www portal templates

2017-11-14 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391353 ) Change subject: extract2.php: Stop allowing the www portal templates .. extract2.php: Stop allowing the www portal templates None of them

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Don't bother symlinking mobilelanding.php

2017-11-14 Thread Chad (Code Review)
Chad has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/391349 ) Change subject: Don't bother symlinking mobilelanding.php .. Don't bother symlinking mobilelanding.php It's only used by a single

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Don't bother symlinking mobilelanding.php

2017-11-14 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391349 ) Change subject: Don't bother symlinking mobilelanding.php .. Don't bother symlinking mobilelanding.php It's only used by a single docroot

[MediaWiki-commits] [Gerrit] mediawiki...release[master]: make-release: Remove old pre-semver support

2017-11-14 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391290 ) Change subject: make-release: Remove old pre-semver support .. make-release: Remove old pre-semver support Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.31.0-wmf.8]: Fix up logging grouping in ApiStashEdit

2017-11-14 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391259 ) Change subject: Fix up logging grouping in ApiStashEdit .. Fix up logging grouping in ApiStashEdit Change-Id:

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: group0 to wmf.8

2017-11-14 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391258 ) Change subject: group0 to wmf.8 .. group0 to wmf.8 Change-Id: I183fd96a1fd3c980b8d069000501703c8034816b --- M wikiversions.json 1 file

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Swap to Phabricator mirror for DataTypes JS repo

2017-11-14 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391239 ) Change subject: Swap to Phabricator mirror for DataTypes JS repo .. Swap to Phabricator mirror for DataTypes JS repo Change-Id:

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: WIP: search.wikimedia.org: Stop supporting non-Wikipedias

2017-11-09 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/390358 ) Change subject: WIP: search.wikimedia.org: Stop supporting non-Wikipedias .. WIP: search.wikimedia.org: Stop supporting non-Wikipedias Best

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: search.wikimedia.org: Clean up result returning logic

2017-11-09 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/390357 ) Change subject: search.wikimedia.org: Clean up result returning logic .. search.wikimedia.org: Clean up result returning logic - We don't

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: search.wikimedia.org: Don't bail on bad $site or $lang params

2017-11-09 Thread Chad (Code Review)
Chad has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/390352 ) Change subject: search.wikimedia.org: Don't bail on bad $site or $lang params .. search.wikimedia.org: Don't bail on bad $site or

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: search.wikimedia.org: Remove silly configuration switch for ...

2017-11-09 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/390354 ) Change subject: search.wikimedia.org: Remove silly configuration switch for caching .. search.wikimedia.org: Remove silly configuration

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: search.wikimedia.org: Nicer handling of bad search parameter

2017-11-09 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/390353 ) Change subject: search.wikimedia.org: Nicer handling of bad search parameter .. search.wikimedia.org: Nicer handling of bad search parameter

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: search.wikimedia.org: Don't bail on bad $site or $lang params

2017-11-09 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/390352 ) Change subject: search.wikimedia.org: Don't bail on bad $site or $lang params .. search.wikimedia.org: Don't bail on bad $site or $lang params

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: search.wikimedia.org: simplify limit handling

2017-11-09 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/390347 ) Change subject: search.wikimedia.org: simplify limit handling .. search.wikimedia.org: simplify limit handling Just silently fall back to

<    1   2   3   4   5   6   7   8   9   10   >