[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Stop shadowing Response

2017-04-12 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/348012 ) Change subject: Stop shadowing Response .. Stop shadowing Response Already a class in same NS that extends the Symfony one Hat tip to

[MediaWiki-commits] [Gerrit] mediawiki/core[fundraising/REL1_27]: New black and white WMF favicon

2017-04-12 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/347904 ) Change subject: New black and white WMF favicon .. New black and white WMF favicon Deployment note - coordinate with comms, also deploy a

[MediaWiki-commits] [Gerrit] mediawiki/core[fundraising/REL1_27]: Use the ultra-crushed versions of the new logos

2017-04-12 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/347902 ) Change subject: Use the ultra-crushed versions of the new logos .. Use the ultra-crushed versions of the new logos Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[fundraising/REL1_27]: Add new black and white logo in 3 sizes

2017-04-12 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/347878 ) Change subject: Add new black and white logo in 3 sizes .. Add new black and white logo in 3 sizes Change-Id:

[MediaWiki-commits] [Gerrit] wikimedia...tools[deploy]: Merge branch 'master' into deploy

2017-04-11 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/347789 ) Change subject: Merge branch 'master' into deploy .. Merge branch 'master' into deploy ddc70dd Don't crash on missing ct_id Change-Id:

[MediaWiki-commits] [Gerrit] wikimedia...tools[master]: Don't crash on missing ct_id

2017-04-11 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/347787 ) Change subject: Don't crash on missing ct_id .. Don't crash on missing ct_id Some records we'll ignore have none, let's not send failmail

[MediaWiki-commits] [Gerrit] wikimedia...crm[master]: Get rid of subscription paths

2017-04-11 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/347772 ) Change subject: Get rid of subscription paths .. Get rid of subscription paths No need to change these in the UI, and most were'nt actually

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Use constants for HTTP status codes

2017-04-10 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/347524 ) Change subject: Use constants for HTTP status codes .. Use constants for HTTP status codes Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[fundraising/REL1_27]: Update DonationInterface submodule

2017-04-10 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/347458 ) Change subject: Update DonationInterface submodule .. Update DonationInterface submodule Get the width=device-width viewport value

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[deployment]: Merge branch 'master' into deployment

2017-04-10 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/347454 ) Change subject: Merge branch 'master' into deployment .. Merge branch 'master' into deployment 3be550e Add width=device-width to forms

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: Add width=device-width to forms viewport meta

2017-04-10 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/347448 ) Change subject: Add width=device-width to forms viewport meta .. Add width=device-width to forms viewport meta This is currently being

[MediaWiki-commits] [Gerrit] mediawiki/core[fundraising/REL1_27]: Merge branch 'REL1_27' into fundraising/REL1_27

2017-04-10 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/347411 ) Change subject: Merge branch 'REL1_27' into fundraising/REL1_27 .. Merge branch 'REL1_27' into fundraising/REL1_27 Get 1.27.2 updates, and

[MediaWiki-commits] [Gerrit] mediawiki/vendor[fundraising/REL1_27]: Update lessphp, use autoload_static

2017-04-10 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/347410 ) Change subject: Update lessphp, use autoload_static .. Update lessphp, use autoload_static No more php53lint to get tripped up by static

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[deployment]: Merge branch 'master' into deployment

2017-04-10 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/347406 ) Change subject: Merge branch 'master' into deployment .. Merge branch 'master' into deployment And make vendor match currently deployed

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: Reset SmashPig lib to currently deployed version

2017-04-10 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/347405 ) Change subject: Reset SmashPig lib to currently deployed version .. Reset SmashPig lib to currently deployed version Rather than version

[MediaWiki-commits] [Gerrit] wikimedia...DjangoBannerStats[master]: Use correct UDP_LOG_PATH

2017-04-07 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/347131 ) Change subject: Use correct UDP_LOG_PATH .. Use correct UDP_LOG_PATH From django.conf.settings, not default fundraiser.settings Change-Id:

[MediaWiki-commits] [Gerrit] wikimedia...DjangoBannerStats[master]: Add debugging output to recent file parsing

2017-04-07 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/347125 ) Change subject: Add debugging output to recent file parsing .. Add debugging output to recent file parsing Change-Id:

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: Add text to assertions

2017-04-06 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/346922 ) Change subject: Add text to assertions .. Add text to assertions Change-Id: I0352db2bcfab288e394954a823456c04e1b3c42a --- M

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: Add host name to failmail subject

2017-04-04 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/346482 ) Change subject: Add host name to failmail subject .. Add host name to failmail subject Would be cool to template this stuff. What else would

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: Add run-job[pid] to example syslog format

2017-04-04 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/346479 ) Change subject: Add run-job[pid] to example syslog format .. Add run-job[pid] to example syslog format Bug: T162189 Change-Id:

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: WIP cache directory lookup 404s

2017-03-30 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/345790 ) Change subject: WIP cache directory lookup 404s .. WIP cache directory lookup 404s These are legitimate responses in REST-ese. Don't

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: Merge environment, don't clobber

2017-03-30 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/345768 ) Change subject: Merge environment, don't clobber .. Merge environment, don't clobber Change-Id: Ide20e2ad2724715833fa2a7b15be08e7d3b7272c

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Break out unofficial iDEAL status lookup

2017-03-30 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/345696 ) Change subject: Break out unofficial iDEAL status lookup .. Break out unofficial iDEAL status lookup Maybe someone else can use this, but we

[MediaWiki-commits] [Gerrit] mediawiki...vendor[master]: Update smashpig

2017-03-30 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/345566 ) Change subject: Update smashpig .. Update smashpig get https default for iDEAL lookup Change-Id: I85357b25ec3d4e6e070e2957c789dd031b816751

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: Update smashpig

2017-03-30 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/345565 ) Change subject: Update smashpig .. Update smashpig get https default for iDEAL lookup Change-Id: I73fdff4f627f326daeb9ca4fc5c973702b961b96

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: WIP stream subprocess stdout to log file

2017-03-29 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/345424 ) Change subject: WIP stream subprocess stdout to log file .. WIP stream subprocess stdout to log file Change-Id:

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: Fix logging.config import

2017-03-28 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/345259 ) Change subject: Fix logging.config import .. Fix logging.config import *shrug* Change-Id: Ied1f9c31067b0ed43ec43e2f6c6cff96313fd20d --- M

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: Show jobs with invalid configuration in --list-jobs

2017-03-28 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/345258 ) Change subject: Show jobs with invalid configuration in --list-jobs .. Show jobs with invalid configuration in --list-jobs Change-Id:

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: WIP still output when killed

2017-03-27 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/345082 ) Change subject: WIP still output when killed .. WIP still output when killed Really should fix that exit_code issue now Also, test will need

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: Test for environment parameter

2017-03-27 Thread Ejegg (Code Review)
Ejegg has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/344501 ) Change subject: Test for environment parameter .. Test for environment parameter Change-Id:

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: Fixes suggested by thcipriani

2017-03-27 Thread Ejegg (Code Review)
Ejegg has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/343965 ) Change subject: Fixes suggested by thcipriani .. Fixes suggested by thcipriani Change-Id: I03592650c63907ffa4e14a1a136372bff3038f79

[MediaWiki-commits] [Gerrit] wikimedia...tools[master]: WIP Test audit data for Express Checkout refunds

2017-03-24 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344727 ) Change subject: WIP Test audit data for Express Checkout refunds .. WIP Test audit data for Express Checkout refunds Looks like the Item ID

[MediaWiki-commits] [Gerrit] wikimedia...tools[master]: Fix dictionary comparison

2017-03-24 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344725 ) Change subject: Fix dictionary comparison .. Fix dictionary comparison Oops! sorted(dict) was just leaving us with the keys Change-Id:

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Example refund IPNs from express checkout

2017-03-24 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344701 ) Change subject: Example refund IPNs from express checkout .. Example refund IPNs from express checkout Bug: T161121 Change-Id:

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Use https endpoint for iDEAL availability

2017-03-24 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344684 ) Change subject: Use https endpoint for iDEAL availability .. Use https endpoint for iDEAL availability Bug: T161153 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[fundraising/REL1_27]: Add blank index.html

2017-03-24 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344670 ) Change subject: Add blank index.html .. Add blank index.html Change-Id: I48d3ffa71a04a719969bb69900fdcc091f72a2c8 --- A index.html 1 file

[MediaWiki-commits] [Gerrit] wikimedia...crm[deployment]: Pull in orphan rectifier hotfix

2017-03-24 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344654 ) Change subject: Pull in orphan rectifier hotfix .. Pull in orphan rectifier hotfix Minimal vendor update Change-Id:

[MediaWiki-commits] [Gerrit] wikimedia...vendor[master]: [HOTFIX] Patch orphan rectifier to drop non-cc records

2017-03-24 Thread Ejegg (Code Review)
Ejegg has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/344552 ) Change subject: [HOTFIX] Patch orphan rectifier to drop non-cc records .. [HOTFIX] Patch orphan rectifier to drop non-cc records

[MediaWiki-commits] [Gerrit] mediawiki/core[fundraising/REL1_27]: Update DonationInterface submodule

2017-03-23 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344497 ) Change subject: Update DonationInterface submodule .. Update DonationInterface submodule Change-Id:

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: Copy example configuration to docs during install

2017-03-23 Thread Ejegg (Code Review)
Ejegg has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/344273 ) Change subject: Copy example configuration to docs during install .. Copy example configuration to docs during install Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...vendor[master]: Update SmashPig lib

2017-03-23 Thread Ejegg (Code Review)
Ejegg has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/344454 ) Change subject: Update SmashPig lib .. Update SmashPig lib Change-Id: I5c8ffb254fa143c52f760fcbafa64840bac45757 --- M

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[deployment]: Merge branch 'master' into deployment

2017-03-23 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344455 ) Change subject: Merge branch 'master' into deployment .. Merge branch 'master' into deployment And update vendor badf7d0 Localisation

[MediaWiki-commits] [Gerrit] mediawiki...vendor[master]: Update SmashPig lib

2017-03-23 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344454 ) Change subject: Update SmashPig lib .. Update SmashPig lib Change-Id: I5c8ffb254fa143c52f760fcbafa64840bac45757 --- M

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: Update SmashPig

2017-03-23 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344453 ) Change subject: Update SmashPig .. Update SmashPig Get the iDEAL availability hack Change-Id: I1a3d2cbb5a3a9f917249c8bda3a28322efb9ee3f ---

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Headers default to empty array, not null

2017-03-23 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344430 ) Change subject: Headers default to empty array, not null .. Headers default to empty array, not null Prevents an e_notice if user doesn't

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: Comments and cleanup for config

2017-03-23 Thread Ejegg (Code Review)
Ejegg has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/344057 ) Change subject: Comments and cleanup for config .. Comments and cleanup for config Change-Id:

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Hack to get availability straight from iDEAL

2017-03-22 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344272 ) Change subject: Hack to get availability straight from iDEAL .. Hack to get availability straight from iDEAL If noone vetoes this, maybe put

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: Comments and cleanup for config

2017-03-21 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344057 ) Change subject: Comments and cleanup for config .. Comments and cleanup for config Change-Id: Ia1afe7fe3770866d33781a4cd4626a46a5aae09a ---

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: Move some things into global config

2017-03-21 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344046 ) Change subject: Move some things into global config .. Move some things into global config Change-Id:

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: WIP config object

2017-03-21 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/343922 ) Change subject: WIP config object .. WIP config object Change-Id: I64d0e15af51415cc7537d8e2acbe7d5a90ab4f84 TODO: what else is there that

[MediaWiki-commits] [Gerrit] mediawiki/core[fundraising/REL1_27]: Update DonationInterface submodule

2017-03-20 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/343774 ) Change subject: Update DonationInterface submodule .. Update DonationInterface submodule Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[deployment]: Merge branch 'master' into deployment

2017-03-20 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/343732 ) Change subject: Merge branch 'master' into deployment .. Merge branch 'master' into deployment And update vendor a1ec96b Copy accepted

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: Update smashpig lib

2017-03-20 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/343699 ) Change subject: Update smashpig lib .. Update smashpig lib Get the memcache expiry workaround Change-Id:

[MediaWiki-commits] [Gerrit] wikimedia...crm[master]: Split out queue tests

2017-03-17 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/343421 ) Change subject: Split out queue tests .. Split out queue tests Separate files for one-time donations, recurring, and refunds TODO: better

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: Global config

2017-03-17 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/343417 ) Change subject: Global config .. Global config Defaults for everything go in /etc/fundraising/crash-override.yaml Change-Id:

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: Send failmail

2017-03-17 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/343365 ) Change subject: Send failmail .. Send failmail Change-Id: I987df527c07e95b5bde31c89118d72681673d94a TODO: check the send args in tests --- M

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Enable mcrypt extension on CI slaves

2017-03-16 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/343223 ) Change subject: Enable mcrypt extension on CI slaves .. Enable mcrypt extension on CI slaves This is required for the upstream version of

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: Correct failopen test

2017-03-16 Thread Ejegg (Code Review)
Ejegg has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/342970 ) Change subject: Correct failopen test .. Correct failopen test Change-Id: I2316941b63079c8a7845cf957091c72ddfdda8d1 --- M

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: test failopen; py2

2017-03-16 Thread Ejegg (Code Review)
Ejegg has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/342969 ) Change subject: test failopen; py2 .. test failopen; py2 Change-Id: Id33866f7887aa404f453cf5ced6307fd83e2c2fd --- M

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: Tests for the lock module

2017-03-16 Thread Ejegg (Code Review)
Ejegg has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/342968 ) Change subject: Tests for the lock module .. Tests for the lock module Change-Id: I242a42518e1eaab5c8b039af2ac75615db9d01cc --- M

[MediaWiki-commits] [Gerrit] wikimedia...crm[deployment]: Merge branch 'master' into deployment

2017-03-16 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/343125 ) Change subject: Merge branch 'master' into deployment .. Merge branch 'master' into deployment And update vendor submodule for

[MediaWiki-commits] [Gerrit] wikimedia...crm[master]: Update civicrm subrepo

2017-03-16 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/343123 ) Change subject: Update civicrm subrepo .. Update civicrm subrepo 91d02f7 CRM-20061 Add tables as a parameter on the revert api abcc6c3

[MediaWiki-commits] [Gerrit] wikimedia...vendor[master]: Update to using autoload_static

2017-03-16 Thread Ejegg (Code Review)
Ejegg has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/343119 ) Change subject: Update to using autoload_static .. Update to using autoload_static Supposed to give us a slight performance boost on

[MediaWiki-commits] [Gerrit] wikimedia...vendor[master]: Update to using autoload_static

2017-03-16 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/343119 ) Change subject: Update to using autoload_static .. Update to using autoload_static Supposed to give us a slight performance boost on PHP5.6

[MediaWiki-commits] [Gerrit] wikimedia...civicrm[master]: Restore autoload_static

2017-03-16 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/343118 ) Change subject: Restore autoload_static .. Restore autoload_static php53lint is dead, and we're upgrading to 5.6 Wh! Change-Id:

[MediaWiki-commits] [Gerrit] wikimedia...crm[master]: WIP detect normalized paypal messages in queue consumer

2017-03-15 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/342896 ) Change subject: WIP detect normalized paypal messages in queue consumer .. WIP detect normalized paypal messages in queue consumer Needs

[MediaWiki-commits] [Gerrit] wikimedia...tools[master]: Cast a wider net when searching for ct_id

2017-03-15 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/342893 ) Change subject: Cast a wider net when searching for ct_id .. Cast a wider net when searching for ct_id Change-Id:

[MediaWiki-commits] [Gerrit] wikimedia...tools[master]: WIP stop denormalizing paypal recurring messages in audit

2017-03-14 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/342693 ) Change subject: WIP stop denormalizing paypal recurring messages in audit .. WIP stop denormalizing paypal recurring messages in audit

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Work around Memcache not expiring some things

2017-03-10 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/342266 ) Change subject: Work around Memcache not expiring some things .. Work around Memcache not expiring some things Memcache sometimes holds

[MediaWiki-commits] [Gerrit] mediawiki/core[fundraising/REL1_27]: Update DonationInterface submodule

2017-03-06 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/341375 ) Change subject: Update DonationInterface submodule .. Update DonationInterface submodule Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[deployment]: Merge branch 'master' into deployment

2017-03-06 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/341367 ) Change subject: Merge branch 'master' into deployment .. Merge branch 'master' into deployment 4ed8897 Use HashBag instead of EmptyBag

[MediaWiki-commits] [Gerrit] wikimedia...crm[master]: Just zap the comment

2017-03-02 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/340912 ) Change subject: Just zap the comment .. Just zap the comment Still getting an unknown DB error on prod. :( Flail... Change-Id:

[MediaWiki-commits] [Gerrit] wikimedia...crm[deployment]: Merge branch 'master' into deployment

2017-03-02 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/340910 ) Change subject: Merge branch 'master' into deployment .. Merge branch 'master' into deployment 4cf6fcf Fix busted SQL comment Change-Id:

[MediaWiki-commits] [Gerrit] wikimedia...crm[master]: Fix busted SQL comment

2017-03-02 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/340908 ) Change subject: Fix busted SQL comment .. Fix busted SQL comment -- needs to be at the start of the line, oops! Change-Id:

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Split error check into own function

2017-03-02 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/340905 ) Change subject: Split error check into own function .. Split error check into own function Thanks for the best practices nudge, Scrutinizer!

[MediaWiki-commits] [Gerrit] wikimedia...crm[deployment]: Merge branch 'master' into deployment

2017-03-02 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/340899 ) Change subject: Merge branch 'master' into deployment .. Merge branch 'master' into deployment 07ff70d Create table of blank addresses.

[MediaWiki-commits] [Gerrit] wikimedia...crm[master]: Extend fix to contacts that have been touched

2017-03-02 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/340897 ) Change subject: Extend fix to contacts that have been touched .. Extend fix to contacts that have been touched Civi nukes the sort and

[MediaWiki-commits] [Gerrit] wikimedia...crm[master]: Fix missing names

2017-03-02 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/340891 ) Change subject: Fix missing names .. Fix missing names Turns out we WERE filling in the sort name field after all. Nice to have that

[MediaWiki-commits] [Gerrit] wikimedia...crm[master]: WIP Test more fields on import

2017-03-02 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/340885 ) Change subject: WIP Test more fields on import .. WIP Test more fields on import Errr, dang. I thought this would fail without being rebased

[MediaWiki-commits] [Gerrit] wikimedia...crm[master]: WIP only cry DUPLICATE if there's no change

2017-03-02 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/340810 ) Change subject: WIP only cry DUPLICATE if there's no change .. WIP only cry DUPLICATE if there's no change Still need to change rest of the

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[deployment]: Merge branch 'master' into deployment

2017-03-02 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/340773 ) Change subject: Merge branch 'master' into deployment .. Merge branch 'master' into deployment Also delete tests and update libs ebf4488

[MediaWiki-commits] [Gerrit] mediawiki...vendor[master]: Missed some files in the last commit

2017-03-02 Thread Ejegg (Code Review)
Ejegg has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/340772 ) Change subject: Missed some files in the last commit .. Missed some files in the last commit Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...vendor[master]: Missed some files in the last commit

2017-03-02 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/340772 ) Change subject: Missed some files in the last commit .. Missed some files in the last commit Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: Update SmashPig library

2017-02-23 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/339489 ) Change subject: Update SmashPig library .. Update SmashPig library Get some Ingenico error handling Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: Set SmashPig logging prefix

2017-02-23 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/339484 ) Change subject: Set SmashPig logging prefix .. Set SmashPig logging prefix Not perfect, as it happens after any SmashPig library calls that

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Throw SmashPig exception on Ingenico API errors

2017-02-22 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/339331 ) Change subject: Throw SmashPig exception on Ingenico API errors .. Throw SmashPig exception on Ingenico API errors Instead of letting the

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: Use HashBag instead of EmptyBag

2017-02-22 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/339330 ) Change subject: Use HashBag instead of EmptyBag .. Use HashBag instead of EmptyBag If the local cluster cache is an EmptyBagOfStuff, fall

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: Another SmashPig initialization fix

2017-02-22 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/339329 ) Change subject: Another SmashPig initialization fix .. Another SmashPig initialization fix Need to initialize the logger too. We should

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Throw a descendent of SmashPig exception on cURL fail

2017-02-22 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/339273 ) Change subject: Throw a descendent of SmashPig exception on cURL fail .. Throw a descendent of SmashPig exception on cURL fail Instead of a

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: Fixes for iDEAL/PSR-6 caching

2017-02-21 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/339107 ) Change subject: Fixes for iDEAL/PSR-6 caching .. Fixes for iDEAL/PSR-6 caching Autoload, constructor name and visibility, break statement

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Reduce Configuration use in BankPaymentProvider

2017-02-16 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/338306 ) Change subject: Reduce Configuration use in BankPaymentProvider .. Reduce Configuration use in BankPaymentProvider Provide cache params as

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Move Ingenico base API wrapper functions to own class

2017-02-16 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/338303 ) Change subject: Move Ingenico base API wrapper functions to own class .. Move Ingenico base API wrapper functions to own class Tests for

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Get some static Config access out of Authenticator

2017-02-16 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/338300 ) Change subject: Get some static Config access out of Authenticator .. Get some static Config access out of Authenticator Provide credentials

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Factory for payment providers

2017-02-16 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/338296 ) Change subject: Factory for payment providers .. Factory for payment providers Don't make anybody new() up the PaymentProvider classes or

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: Use dependency injection to get BankPaymentProvider

2017-02-16 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/338277 ) Change subject: Use dependency injection to get BankPaymentProvider .. Use dependency injection to get BankPaymentProvider This way we don't

[MediaWiki-commits] [Gerrit] wikimedia...crm[master]: Normalized subscr_ messages for tests

2017-02-16 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/338145 ) Change subject: Normalized subscr_ messages for tests .. Normalized subscr_ messages for tests This is what the messages coming out of the

[MediaWiki-commits] [Gerrit] wikimedia...vendor[master]: Update PHPMailer

2017-02-15 Thread Ejegg (Code Review)
Ejegg has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/337960 ) Change subject: Update PHPMailer .. Update PHPMailer Change-Id: I57f02bc76164dcd78d4b937bcddfd828ef2b4634 --- M

[MediaWiki-commits] [Gerrit] wikimedia...crm[deployment]: Merge branch 'master' into deployment

2017-02-15 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/337964 ) Change subject: Merge branch 'master' into deployment .. Merge branch 'master' into deployment And update 'vendor' submodule afd2d95 Fix

[MediaWiki-commits] [Gerrit] wikimedia...vendor[master]: Update PHPMailer

2017-02-15 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/337960 ) Change subject: Update PHPMailer .. Update PHPMailer Change-Id: I57f02bc76164dcd78d4b937bcddfd828ef2b4634 --- M composer/installed.json M

[MediaWiki-commits] [Gerrit] wikimedia...crm[master]: Update PHPMailer to 5.2.22

2017-02-15 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/337929 ) Change subject: Update PHPMailer to 5.2.22 .. Update PHPMailer to 5.2.22 Bug: T158214 Change-Id: I3f4f0bee86e69cb47d4c0fba0f542a7133afeb53

<    4   5   6   7   8   9   10   11   12   13   >