[MediaWiki-commits] [Gerrit] Make UnresolvedRedirectException derive from UnresolvedEntit... - change (mediawiki...Wikibase)

2015-09-17 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/239082 Change subject: Make UnresolvedRedirectException derive from UnresolvedEntityRedirectException .. Make UnresolvedRedirectException

[MediaWiki-commits] [Gerrit] Rename UnresolvedRedirectException -> RevisionedUnresolvedRe... - change (mediawiki...Wikibase)

2015-09-17 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/239084 Change subject: Rename UnresolvedRedirectException -> RevisionedUnresolvedRedirectException .. Rename UnresolvedRedirectException ->

[MediaWiki-commits] [Gerrit] Remove no longer needed RedirectResolvingEntityLookup and En... - change (mediawiki...Wikibase)

2015-09-17 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/239085 Change subject: Remove no longer needed RedirectResolvingEntityLookup and EntityRedirectResolvingDecorator .. Remove no longer needed

[MediaWiki-commits] [Gerrit] Remove unused local var - change (mediawiki...Wikibase)

2015-09-16 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/238695 Change subject: Remove unused local var .. Remove unused local var Change-Id: Ibfb9f75c169801405aaff84fe74588c0b118a9ad --- M

[MediaWiki-commits] [Gerrit] Actually import some type hints - change (mediawiki...Wikibase)

2015-09-16 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/238700 Change subject: Actually import some type hints .. Actually import some type hints Else they do not help the tools... Change-Id:

[MediaWiki-commits] [Gerrit] Remove wrong arg from testParseDocName - change (mediawiki...Wikibase)

2015-09-16 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/238702 Change subject: Remove wrong arg from testParseDocName .. Remove wrong arg from testParseDocName Change-Id:

[MediaWiki-commits] [Gerrit] Remove dead code and reduce scope - change (mediawiki...Wikibase)

2015-09-16 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/238696 Change subject: Remove dead code and reduce scope .. Remove dead code and reduce scope Change-Id:

[MediaWiki-commits] [Gerrit] Remove odd third argument from assertFalse/True - change (mediawiki...Wikibase)

2015-09-16 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/238707 Change subject: Remove odd third argument from assertFalse/True .. Remove odd third argument from assertFalse/True Change-Id:

[MediaWiki-commits] [Gerrit] Remove funny argument o doom - change (mediawiki...Wikibase)

2015-09-16 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/238717 Change subject: Remove funny argument o doom .. Remove funny argument o doom Change-Id: I81685b812b7ca59f070132a2564360adff54d0c7 ---

[MediaWiki-commits] [Gerrit] Remove dead code - change (mediawiki...Wikibase)

2015-09-16 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/238722 Change subject: Remove dead code .. Remove dead code Change-Id: If8e91a7cae2575c0b5401ac9a50e4dd1b8c05429 --- D

[MediaWiki-commits] [Gerrit] Simplification in ClaimDifference - change (mediawiki...Wikibase)

2015-09-16 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/238724 Change subject: Simplification in ClaimDifference .. Simplification in ClaimDifference Change-Id:

[MediaWiki-commits] [Gerrit] Remove dead code from PublishStashedFileJob - change (mediawiki/core)

2015-09-16 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/238721 Change subject: Remove dead code from PublishStashedFileJob .. Remove dead code from PublishStashedFileJob Change-Id:

[MediaWiki-commits] [Gerrit] Add missing parameter - change (mediawiki...Wikibase)

2015-09-16 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/238718 Change subject: Add missing parameter .. Add missing parameter There is a call to this method that provides a third argument that is

[MediaWiki-commits] [Gerrit] Remove dead argument in SpecialEditTags - change (mediawiki/core)

2015-09-16 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/238720 Change subject: Remove dead argument in SpecialEditTags .. Remove dead argument in SpecialEditTags Change-Id:

[MediaWiki-commits] [Gerrit] Remove dead argument - change (mediawiki/core)

2015-09-16 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/238719 Change subject: Remove dead argument .. Remove dead argument Change-Id: Ib0bb2733284262c233e6de4c7645f0b215690156 --- M

[MediaWiki-commits] [Gerrit] Decrease field visibility - change (mediawiki...Wikibase)

2015-09-16 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/238725 Change subject: Decrease field visibility .. Decrease field visibility Change-Id: I65d244912ee340b72ce0512264ed9f44cc5170e8 --- M

[MediaWiki-commits] [Gerrit] Decrease field visibility - change (mediawiki...Wikibase)

2015-09-16 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/238726 Change subject: Decrease field visibility .. Decrease field visibility Change-Id: Ia1aba8a4903943f020981dac8ca916cdf15ce318 --- M

[MediaWiki-commits] [Gerrit] Remove dead local var in IndexPager - change (mediawiki/core)

2015-09-16 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/238760 Change subject: Remove dead local var in IndexPager .. Remove dead local var in IndexPager Change-Id:

[MediaWiki-commits] [Gerrit] Add missing argument to dieDebug call so it does not die - change (mediawiki/core)

2015-09-16 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/238756 Change subject: Add missing argument to dieDebug call so it does not die .. Add missing argument to dieDebug call so it does not die

[MediaWiki-commits] [Gerrit] Specify compat with DMS 3.x - change (mediawiki...WikibaseQuality)

2015-09-16 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/238764 Change subject: Specify compat with DMS 3.x .. Specify compat with DMS 3.x Change-Id: I008d9be3a89461204df2830d9c1ebd7504058087 --- M

[MediaWiki-commits] [Gerrit] Remove deal local vars in ApiRevisionDelete - change (mediawiki/core)

2015-09-16 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/238761 Change subject: Remove deal local vars in ApiRevisionDelete .. Remove deal local vars in ApiRevisionDelete Change-Id:

[MediaWiki-commits] [Gerrit] Remove deal local var - change (mediawiki/core)

2015-09-16 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/238758 Change subject: Remove deal local var .. Remove deal local var Change-Id: I209166eab10b870de3d31ac1e551fd759459243a --- M

[MediaWiki-commits] [Gerrit] Add missing argument to makeLoaderImplementScript - change (mediawiki/core)

2015-09-16 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/238757 Change subject: Add missing argument to makeLoaderImplementScript .. Add missing argument to makeLoaderImplementScript Change-Id:

[MediaWiki-commits] [Gerrit] Use DM Services 3.x - change (mediawiki...Wikibase)

2015-09-16 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/238754 Change subject: Use DM Services 3.x .. Use DM Services 3.x Change-Id: Ie33df90e71026683fb65ff497075fbb781fd4ad5 --- M composer.json 1

[MediaWiki-commits] [Gerrit] Specify compatibility with DMS 3.x - change (mediawiki...WikibaseQualityConstraints)

2015-09-16 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/238765 Change subject: Specify compatibility with DMS 3.x .. Specify compatibility with DMS 3.x Change-Id:

[MediaWiki-commits] [Gerrit] Remove old copy of RestrictedEntityLookup - change (mediawiki...Wikibase)

2015-09-14 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/238130 Change subject: Remove old copy of RestrictedEntityLookup .. Remove old copy of RestrictedEntityLookup Task T108286 Change-Id:

[MediaWiki-commits] [Gerrit] Remove old copy of RedirectResolvingEntityLookup and always ... - change (mediawiki...Wikibase)

2015-09-14 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/238119 Change subject: Remove old copy of RedirectResolvingEntityLookup and always use the new one .. Remove old copy of

[MediaWiki-commits] [Gerrit] Remove old copy of EntityRedirectResolvingDecorator - change (mediawiki...Wikibase)

2015-09-14 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/238122 Change subject: Remove old copy of EntityRedirectResolvingDecorator .. Remove old copy of EntityRedirectResolvingDecorator Change-Id:

[MediaWiki-commits] [Gerrit] Remove old copy of TermBuffer interface - change (mediawiki...Wikibase)

2015-09-14 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/238127 Change subject: Remove old copy of TermBuffer interface .. Remove old copy of TermBuffer interface Change-Id:

[MediaWiki-commits] [Gerrit] Remove old copy of PropertyLabelResolver interface - change (mediawiki...Wikibase)

2015-09-14 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/238128 Change subject: Remove old copy of PropertyLabelResolver interface .. Remove old copy of PropertyLabelResolver interface Change-Id:

[MediaWiki-commits] [Gerrit] Remove return of void method results - change (mediawiki/core)

2015-09-07 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/236704 Change subject: Remove return of void method results .. Remove return of void method results Change-Id:

[MediaWiki-commits] [Gerrit] Remove unused parameter in DjVuImage - change (mediawiki/core)

2015-09-07 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/236703 Change subject: Remove unused parameter in DjVuImage .. Remove unused parameter in DjVuImage Change-Id:

[MediaWiki-commits] [Gerrit] Update TravisCI config to use hhvm rather than hhvm-nightly - change (mediawiki/core)

2015-09-07 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/236586 Change subject: Update TravisCI config to use hhvm rather than hhvm-nightly .. Update TravisCI config to use hhvm rather than

[MediaWiki-commits] [Gerrit] Update TravisCI config to use hhvm rather than hhvm-nightly - change (mediawiki/core)

2015-09-07 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/236588 Change subject: Update TravisCI config to use hhvm rather than hhvm-nightly .. Update TravisCI config to use hhvm rather than

[MediaWiki-commits] [Gerrit] Write TravisCI build matrix in more readable and extandable ... - change (mediawiki/core)

2015-09-07 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/236595 Change subject: Write TravisCI build matrix in more readable and extandable manner .. Write TravisCI build matrix in more readable

[MediaWiki-commits] [Gerrit] Remove dead private methods - change (mediawiki/core)

2015-09-07 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/236601 Change subject: Remove dead private methods .. Remove dead private methods Change-Id: Id49df6d16ce06c7bb00f1aaba75b64093c91c7ae --- M

[MediaWiki-commits] [Gerrit] Inject LanguageFallbackChainFactory into OutputFormatValueFo... - change (mediawiki...Wikibase)

2015-09-07 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/236608 Change subject: Inject LanguageFallbackChainFactory into OutputFormatValueFormatterFactory .. Inject LanguageFallbackChainFactory

[MediaWiki-commits] [Gerrit] Remove unused private field in MagicWordArray - change (mediawiki/core)

2015-09-07 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/236610 Change subject: Remove unused private field in MagicWordArray .. Remove unused private field in MagicWordArray Change-Id:

[MediaWiki-commits] [Gerrit] Make MWExceptionHandler work with PHP7s exception changes - change (mediawiki/core)

2015-09-07 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/236592 Change subject: Make MWExceptionHandler work with PHP7s exception changes .. Make MWExceptionHandler work with PHP7s exception changes

[MediaWiki-commits] [Gerrit] Add PHP7 build to TravisCI - change (mediawiki/core)

2015-09-07 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/236596 Change subject: Add PHP7 build to TravisCI .. Add PHP7 build to TravisCI Change-Id: I83231801f8618e2cf85bac6a262bba0250adcfab --- M

[MediaWiki-commits] [Gerrit] Remove unused private methods in FauxRequest - change (mediawiki/core)

2015-09-07 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/236603 Change subject: Remove unused private methods in FauxRequest .. Remove unused private methods in FauxRequest Change-Id:

[MediaWiki-commits] [Gerrit] Remove commented out code in SpecialExport - change (mediawiki/core)

2015-09-07 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/236602 Change subject: Remove commented out code in SpecialExport .. Remove commented out code in SpecialExport Change-Id:

[MediaWiki-commits] [Gerrit] Git remove unused private field - change (mediawiki/core)

2015-09-07 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/236606 Change subject: Git remove unused private field .. Git remove unused private field Change-Id:

[MediaWiki-commits] [Gerrit] Remove unused private field in OutputPage - change (mediawiki/core)

2015-09-07 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/236609 Change subject: Remove unused private field in OutputPage .. Remove unused private field in OutputPage Change-Id:

[MediaWiki-commits] [Gerrit] Remove dead local var in ApiQueryAllDeletedRevisions - change (mediawiki/core)

2015-09-07 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/236612 Change subject: Remove dead local var in ApiQueryAllDeletedRevisions .. Remove dead local var in ApiQueryAllDeletedRevisions Need

[MediaWiki-commits] [Gerrit] Remove dead local vars in UsercreateTemplate - change (mediawiki/core)

2015-09-07 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/236611 Change subject: Remove dead local vars in UsercreateTemplate .. Remove dead local vars in UsercreateTemplate Change-Id:

[MediaWiki-commits] [Gerrit] Remove not needed global imports in BitmapHandler - change (mediawiki/core)

2015-09-07 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/236613 Change subject: Remove not needed global imports in BitmapHandler .. Remove not needed global imports in BitmapHandler Change-Id:

[MediaWiki-commits] [Gerrit] Remove dead local var in ApiQueryUserInfo - change (mediawiki/core)

2015-09-07 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/236614 Change subject: Remove dead local var in ApiQueryUserInfo .. Remove dead local var in ApiQueryUserInfo Change-Id:

[MediaWiki-commits] [Gerrit] Remove dead argument in LinkSearchPage - change (mediawiki/core)

2015-09-07 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/236615 Change subject: Remove dead argument in LinkSearchPage .. Remove dead argument in LinkSearchPage Change-Id:

[MediaWiki-commits] [Gerrit] protected -> private in repo/ - change (mediawiki...Wikibase)

2015-09-06 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/236490 Change subject: protected -> private in repo/ .. protected -> private in repo/ Change-Id: I3dbe3f7840d22a5eeb4c51aa996436372165def2

[MediaWiki-commits] [Gerrit] protected -> private in TextInjector - change (mediawiki...Wikibase)

2015-09-06 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/236426 Change subject: protected -> private in TextInjector .. protected -> private in TextInjector Change-Id:

[MediaWiki-commits] [Gerrit] Help type inferrence - change (mediawiki...Wikibase)

2015-09-05 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/236364 Change subject: Help type inferrence .. Help type inferrence Change-Id: Ib549c8daeecf20e60275e7ce046c4f831f31545c --- M

[MediaWiki-commits] [Gerrit] Add fixme for possible fatal / OCP violation - change (mediawiki...Wikibase)

2015-09-05 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/236365 Change subject: Add fixme for possible fatal / OCP violation .. Add fixme for possible fatal / OCP violation Change-Id:

[MediaWiki-commits] [Gerrit] Do not use FQN - change (mediawiki...Wikibase)

2015-09-05 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/236369 Change subject: Do not use FQN .. Do not use FQN Change-Id: Ifd55f9a5cf082da02e84ba7a7cb7b7b69c38c536 --- M

[MediaWiki-commits] [Gerrit] Remove dead arguments - change (mediawiki...Wikibase)

2015-09-05 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/236370 Change subject: Remove dead arguments .. Remove dead arguments Change-Id: I13be19cb7b3f815d1b5a5ad027b70ea29b067d9a --- M

[MediaWiki-commits] [Gerrit] Remove unused private field - change (mediawiki...Wikibase)

2015-09-05 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/236376 Change subject: Remove unused private field .. Remove unused private field Change-Id: I8aa6779e76cf1fcf2dd2131fc28d2cf3bbe29afc --- M

[MediaWiki-commits] [Gerrit] Import class rather than using FQN - change (mediawiki...Wikibase)

2015-09-05 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/236373 Change subject: Import class rather than using FQN .. Import class rather than using FQN Change-Id:

[MediaWiki-commits] [Gerrit] Remove unused Lib imports - change (mediawiki...Wikibase)

2015-09-05 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/236374 Change subject: Remove unused Lib imports .. Remove unused Lib imports Change-Id: I4ef929eeadc9484c44f80fbf4783967b17848abe --- M

[MediaWiki-commits] [Gerrit] Remove not needed unit - change (mediawiki...Wikibase)

2015-09-05 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/236378 Change subject: Remove not needed unit .. Remove not needed unit Change-Id: I738c02491b21948c7e0044a456f1b717df1ddb6a --- M

[MediaWiki-commits] [Gerrit] Remove dead code in testDeleteLinksOfItem - change (mediawiki...Wikibase)

2015-09-05 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/236375 Change subject: Remove dead code in testDeleteLinksOfItem .. Remove dead code in testDeleteLinksOfItem Change-Id:

[MediaWiki-commits] [Gerrit] Remove dead setter - change (mediawiki...Wikibase)

2015-09-05 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/236388 Change subject: Remove dead setter .. Remove dead setter Change-Id: Ibd4e614e2da5b7836c9b0f32f6590dd9087921be --- M

[MediaWiki-commits] [Gerrit] Do not use FQNs where not needed - change (mediawiki...Wikibase)

2015-09-05 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/236368 Change subject: Do not use FQNs where not needed .. Do not use FQNs where not needed Change-Id:

[MediaWiki-commits] [Gerrit] Remove dead function arg - change (mediawiki...Wikibase)

2015-09-05 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/236377 Change subject: Remove dead function arg .. Remove dead function arg Change-Id: I2f2fa641e42289d729b63a66e9530a8e023d50d8 --- M

[MediaWiki-commits] [Gerrit] Remove not needed continue statement - change (mediawiki...Wikibase)

2015-09-05 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/236380 Change subject: Remove not needed continue statement .. Remove not needed continue statement Change-Id:

[MediaWiki-commits] [Gerrit] Add missing comma - change (mediawiki...Wikibase)

2015-09-05 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/236381 Change subject: Add missing comma .. Add missing comma Change-Id: I2f33baf633003eabdaf77c8955c3b2fd4a669dc2 --- M

[MediaWiki-commits] [Gerrit] Remove dead code - change (mediawiki...Wikibase)

2015-09-05 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/236362 Change subject: Remove dead code .. Remove dead code Change-Id: If7feeeb6825fa79efe3ccead5d66f253c7ad5083 --- M

[MediaWiki-commits] [Gerrit] Explicitly define dependency - change (mediawiki...Wikibase)

2015-09-05 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/236361 Change subject: Explicitly define dependency .. Explicitly define dependency Change-Id: Ic855a7acef40aaad2ccd45045b5fcbb44743ca3d ---

[MediaWiki-commits] [Gerrit] Remove unused import in WikibaseDataAccessTestItemSetUpHelper - change (mediawiki...Wikibase)

2015-09-05 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/236371 Change subject: Remove unused import in WikibaseDataAccessTestItemSetUpHelper .. Remove unused import in

[MediaWiki-commits] [Gerrit] Stop using deprecated core method in getInterwikiCodeFromSit... - change (mediawiki...Wikibase)

2015-09-05 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/236372 Change subject: Stop using deprecated core method in getInterwikiCodeFromSiteProvider .. Stop using deprecated core method in

[MediaWiki-commits] [Gerrit] Remove unused parameters in view tests - change (mediawiki...Wikibase)

2015-09-05 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/236384 Change subject: Remove unused parameters in view tests .. Remove unused parameters in view tests Change-Id:

[MediaWiki-commits] [Gerrit] Remove dead parameter - change (mediawiki...Wikibase)

2015-09-05 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/236385 Change subject: Remove dead parameter .. Remove dead parameter Change-Id: I5d11cb0897690570ee3be775be630f184184f3f6 --- M

[MediaWiki-commits] [Gerrit] Remove EntiEntity::getNewEntity - change (mediawiki...Wikibase)

2015-09-05 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/236386 Change subject: Remove EntiEntity::getNewEntity .. Remove EntiEntity::getNewEntity Change-Id:

[MediaWiki-commits] [Gerrit] Remove dead local var - change (mediawiki...Wikibase)

2015-09-05 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/236363 Change subject: Remove dead local var .. Remove dead local var Change-Id: Ib10568daca0bada24c309759dc49ef9dbb4f973b --- M

[MediaWiki-commits] [Gerrit] Split method and improve type checking - change (mediawiki...Wikibase)

2015-09-05 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/236366 Change subject: Split method and improve type checking .. Split method and improve type checking Change-Id:

[MediaWiki-commits] [Gerrit] Do not return void method result - change (mediawiki...Wikibase)

2015-09-05 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/236367 Change subject: Do not return void method result .. Do not return void method result Change-Id:

[MediaWiki-commits] [Gerrit] Remove unused imports in view/ - change (mediawiki...Wikibase)

2015-09-05 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/236382 Change subject: Remove unused imports in view/ .. Remove unused imports in view/ Change-Id: I0dc4b1d6e157d1ee65183bc123752f73998b5c4b

[MediaWiki-commits] [Gerrit] Add fixme about OCP violation in view/ - change (mediawiki...Wikibase)

2015-09-05 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/236383 Change subject: Add fixme about OCP violation in view/ .. Add fixme about OCP violation in view/ Change-Id:

[MediaWiki-commits] [Gerrit] Remove unused imports in WikibaseLuaBindings - change (mediawiki...Wikibase)

2015-09-02 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/235610 Change subject: Remove unused imports in WikibaseLuaBindings .. Remove unused imports in WikibaseLuaBindings Change-Id:

[MediaWiki-commits] [Gerrit] Document all the exceptions EntityTitleLookup and implementa... - change (mediawiki...Wikibase)

2015-09-02 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/235626 Change subject: Document all the exceptions EntityTitleLookup and implementation actually throw .. Document all the exceptions

[MediaWiki-commits] [Gerrit] Make WikiPageEntityRedirectLookup match its interfaces contract - change (mediawiki...Wikibase)

2015-09-02 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/235627 Change subject: Make WikiPageEntityRedirectLookup match its interfaces contract .. Make WikiPageEntityRedirectLookup match its

[MediaWiki-commits] [Gerrit] Add usage warning to MockRepository - change (mediawiki...Wikibase)

2015-09-02 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/235628 Change subject: Add usage warning to MockRepository .. Add usage warning to MockRepository Change-Id:

[MediaWiki-commits] [Gerrit] Use version 2.x of serialization components - change (mediawiki...Wikibase)

2015-09-02 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/235457 Change subject: Use version 2.x of serialization components .. Use version 2.x of serialization components Change-Id:

[MediaWiki-commits] [Gerrit] Do not use deprecated class alias - change (mediawiki...Wikibase)

2015-09-01 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/235270 Change subject: Do not use deprecated class alias .. Do not use deprecated class alias Change-Id:

[MediaWiki-commits] [Gerrit] Inject LanguageFallbackChainFactory into OutputFormatValueFo... - change (mediawiki...Wikibase)

2015-09-01 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/235271 Change subject: Inject LanguageFallbackChainFactory into OutputFormatValueFormatterFactory .. Inject LanguageFallbackChainFactory

[MediaWiki-commits] [Gerrit] Spacing of doom - change (mediawiki...Wikibase)

2015-08-12 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/231007 Change subject: Spacing of doom .. Spacing of doom Change-Id: I7c9bf478fa5ba75f95616969cd3df3b4cc518ec4 --- M

[MediaWiki-commits] [Gerrit] Optimized repo imports - change (mediawiki...Wikibase)

2015-08-12 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/231033 Change subject: Optimized repo imports .. Optimized repo imports Change-Id: I7e87fac99f8aff5730e1b692049d079be98bf6b3 --- M

[MediaWiki-commits] [Gerrit] Stop using deprecated class alias in SetClaim - change (mediawiki...Wikibase)

2015-08-12 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/231038 Change subject: Stop using deprecated class alias in SetClaim .. Stop using deprecated class alias in SetClaim Change-Id:

[MediaWiki-commits] [Gerrit] Stop using deprecated class alias in ClaimDifferenceVisualizer - change (mediawiki...Wikibase)

2015-08-12 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/231036 Change subject: Stop using deprecated class alias in ClaimDifferenceVisualizer .. Stop using deprecated class alias in

[MediaWiki-commits] [Gerrit] Stop using deprecated method in generateSitelinksChangeOps - change (mediawiki...Wikibase)

2015-08-12 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/231041 Change subject: Stop using deprecated method in generateSitelinksChangeOps .. Stop using deprecated method in

[MediaWiki-commits] [Gerrit] Remove not needed check in SnakValidator and stop using depr... - change (mediawiki...Wikibase)

2015-08-12 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/231037 Change subject: Remove not needed check in SnakValidator and stop using deprecated alias .. Remove not needed check in SnakValidator

[MediaWiki-commits] [Gerrit] Remove broken import - change (mediawiki...Wikibase)

2015-08-12 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/231034 Change subject: Remove broken import .. Remove broken import Change-Id: I23c1bba1816f672a42b3b1352c718fac6f458ee4 --- M

[MediaWiki-commits] [Gerrit] Remove dead code from EntityDataSerializationService - change (mediawiki...Wikibase)

2015-08-12 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/231035 Change subject: Remove dead code from EntityDataSerializationService .. Remove dead code from EntityDataSerializationService

[MediaWiki-commits] [Gerrit] Remove unused imports in lib - change (mediawiki...Wikibase)

2015-08-12 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/230997 Change subject: Remove unused imports in lib .. Remove unused imports in lib Change-Id: Ibb6cc7ab814f64b457c2328c208fe765b0e35473 ---

[MediaWiki-commits] [Gerrit] Remove not used argument - change (mediawiki...Wikibase)

2015-08-12 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/231000 Change subject: Remove not used argument .. Remove not used argument Change-Id: Idbb9fff3eb02469df5d7c50d66b1ebd7ab238a71 --- M

[MediaWiki-commits] [Gerrit] Remove deprecated method usage - change (mediawiki...Wikibase)

2015-08-12 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/230999 Change subject: Remove deprecated method usage .. Remove deprecated method usage Change-Id: I318eeca0d74a23e9d9ed2dd88b09d7a38d04b41f

[MediaWiki-commits] [Gerrit] Split code added to method off into its own method - change (mediawiki...Wikibase)

2015-08-11 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Split code added to method off into its own method .. Split code added to method off into its own method Change-Id:

[MediaWiki-commits] [Gerrit] Remove not needed nesting - change (mediawiki...Wikibase)

2015-08-07 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/230043 Change subject: Remove not needed nesting .. Remove not needed nesting Change-Id: Ib5d64393964631e070fd6d8b1cbc2f767c0d85ef --- M

[MediaWiki-commits] [Gerrit] Improve wording of method - change (mediawiki...Wikibase)

2015-08-07 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/230044 Change subject: Improve wording of method .. Improve wording of method Change-Id: I6348d27f8b1db5f13ee0209d6b827d4f94c29089 --- M

[MediaWiki-commits] [Gerrit] Remove dead interface - change (mediawiki...Wikibase)

2015-08-07 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/230045 Change subject: Remove dead interface .. Remove dead interface Change-Id: Ib8c8beb80e1098674db24a338313a494271f0237 --- M

[MediaWiki-commits] [Gerrit] Move PropertyLabelNotResolvedException to client - change (mediawiki...Wikibase)

2015-08-07 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/230062 Change subject: Move PropertyLabelNotResolvedException to client .. Move PropertyLabelNotResolvedException to client Change-Id:

<    1   2   3   4   5   6   7   8   9   10   >