[MediaWiki-commits] [Gerrit] Update InternalSerialization version - change (mediawiki...Wikibase)

2014-06-16 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/139878 Change subject: Update InternalSerialization version .. Update InternalSerialization version Change-Id:

[MediaWiki-commits] [Gerrit] WIP use DataModel 1.0 - change (mediawiki...Wikibase)

2014-06-14 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/139599 Change subject: WIP use DataModel 1.0 .. WIP use DataModel 1.0 Change-Id: I259a045cd2432d901ffb6ab419117b0aaa6f4d82 --- M

[MediaWiki-commits] [Gerrit] Remove last usages of EntityId::newFromPrefixedId from Lib - change (mediawiki...Wikibase)

2014-06-14 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/139600 Change subject: Remove last usages of EntityId::newFromPrefixedId from Lib .. Remove last usages of EntityId::newFromPrefixedId from

[MediaWiki-commits] [Gerrit] Remove last usages of EntityId::newFromPrefixedId from Repo - change (mediawiki...Wikibase)

2014-06-14 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/139601 Change subject: Remove last usages of EntityId::newFromPrefixedId from Repo .. Remove last usages of EntityId::newFromPrefixedId from

[MediaWiki-commits] [Gerrit] Don't redlink deleted items - change (mediawiki...Wikibase)

2014-06-14 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Don't redlink deleted items .. Don't redlink deleted items Bug: 65002 Change-Id: Ib9b6e8a0d9f55e958f54f02c5cb6bca7d2c28de3 --- M

[MediaWiki-commits] [Gerrit] Inline deprected code in deprecated class - change (mediawiki...Wikibase)

2014-06-14 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/139607 Change subject: Inline deprected code in deprecated class .. Inline deprected code in deprecated class Change-Id:

[MediaWiki-commits] [Gerrit] Do not use deprecated method for equality check - change (mediawiki...Wikibase)

2014-06-14 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/139608 Change subject: Do not use deprecated method for equality check .. Do not use deprecated method for equality check Change-Id:

[MediaWiki-commits] [Gerrit] WIP stop using deprecated methods in EntityChange - change (mediawiki...Wikibase)

2014-06-14 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/139610 Change subject: WIP stop using deprecated methods in EntityChange .. WIP stop using deprecated methods in EntityChange Change-Id:

[MediaWiki-commits] [Gerrit] Refactoring/optimizing SpecialUnconnectedPages - change (mediawiki...Wikibase)

2014-06-12 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Refactoring/optimizing SpecialUnconnectedPages .. Refactoring/optimizing SpecialUnconnectedPages Some basic refactoring. Dropping unneeded code.

[MediaWiki-commits] [Gerrit] Use new serializers for entity serialization - change (mediawiki...Wikibase)

2014-06-11 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/138821 Change subject: Use new serializers for entity serialization .. Use new serializers for entity serialization Change-Id:

[MediaWiki-commits] [Gerrit] Some cleanup in PropertyInfoTableBuilder - change (mediawiki...Wikibase)

2014-06-10 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/138582 Change subject: Some cleanup in PropertyInfoTableBuilder .. Some cleanup in PropertyInfoTableBuilder Change-Id:

[MediaWiki-commits] [Gerrit] Cleanup in PropertyInfoTableBuilderTest - change (mediawiki...Wikibase)

2014-06-10 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/138583 Change subject: Cleanup in PropertyInfoTableBuilderTest .. Cleanup in PropertyInfoTableBuilderTest Change-Id:

[MediaWiki-commits] [Gerrit] Move ValueParserFactory out of ParseValue api module - change (mediawiki...Wikibase)

2014-06-10 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Move ValueParserFactory out of ParseValue api module .. Move ValueParserFactory out of ParseValue api module Change-Id:

[MediaWiki-commits] [Gerrit] Expand tooltip details fast - change (mediawiki...Wikibase)

2014-06-10 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Expand tooltip details fast .. Expand tooltip details fast There is no reason to slow this down so much. The collapsed details part usually contains a

[MediaWiki-commits] [Gerrit] WIP - Add internal serialization - change (mediawiki...Wikibase)

2014-06-09 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/138310 Change subject: WIP - Add internal serialization .. WIP - Add internal serialization Change-Id:

[MediaWiki-commits] [Gerrit] Some cleanup in ChangeOpsMergeTest - change (mediawiki...Wikibase)

2014-06-09 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/138315 Change subject: Some cleanup in ChangeOpsMergeTest .. Some cleanup in ChangeOpsMergeTest Change-Id:

[MediaWiki-commits] [Gerrit] Make wblinktitles return a prefixed id - change (mediawiki...Wikibase)

2014-06-08 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Make wblinktitles return a prefixed id .. Make wblinktitles return a prefixed id I couldn't find anything on github relying on this returning an

[MediaWiki-commits] [Gerrit] Minor cleanup in WikibaseDiffOpFactory - change (mediawiki...Wikibase)

2014-06-07 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/138158 Change subject: Minor cleanup in WikibaseDiffOpFactory .. Minor cleanup in WikibaseDiffOpFactory Change-Id:

[MediaWiki-commits] [Gerrit] Stop using deprecated stuff in ParserOutputJsConfigBuilderTest - change (mediawiki...Wikibase)

2014-06-07 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/138159 Change subject: Stop using deprecated stuff in ParserOutputJsConfigBuilderTest .. Stop using deprecated stuff in

[MediaWiki-commits] [Gerrit] Cleanup in ClaimModificationHelperTest - change (mediawiki...Wikibase)

2014-06-07 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/138160 Change subject: Cleanup in ClaimModificationHelperTest .. Cleanup in ClaimModificationHelperTest Change-Id:

[MediaWiki-commits] [Gerrit] Cleanup in MakeGlobalVariablesScriptHandlerTest - change (mediawiki...Wikibase)

2014-06-07 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/138161 Change subject: Cleanup in MakeGlobalVariablesScriptHandlerTest .. Cleanup in MakeGlobalVariablesScriptHandlerTest Change-Id:

[MediaWiki-commits] [Gerrit] Improve namespace usage - change (mediawiki...Wikibase)

2014-06-06 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/137882 Change subject: Improve namespace usage .. Improve namespace usage Change-Id: Ic312e3ec1005edd9150f3b1d3b67a3ddbecdd007 --- M

[MediaWiki-commits] [Gerrit] Cleanup in EntityContent and derivatives - change (mediawiki...Wikibase)

2014-06-06 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/138047 Change subject: Cleanup in EntityContent and derivatives .. Cleanup in EntityContent and derivatives Change-Id:

[MediaWiki-commits] [Gerrit] Remove bad Item construction from LangLinkHandlerTest - change (mediawiki...Wikibase)

2014-06-06 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/138074 Change subject: Remove bad Item construction from LangLinkHandlerTest .. Remove bad Item construction from LangLinkHandlerTest

[MediaWiki-commits] [Gerrit] Remove bad Item construction from WikiPageEntityStoreTest - change (mediawiki...Wikibase)

2014-06-06 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/138094 Change subject: Remove bad Item construction from WikiPageEntityStoreTest .. Remove bad Item construction from WikiPageEntityStoreTest

[MediaWiki-commits] [Gerrit] Cleanup in EntityContent and derivatives - change (mediawiki...Wikibase)

2014-06-06 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Cleanup in EntityContent and derivatives .. Cleanup in EntityContent and derivatives Change-Id: I5024f20ca052cd91f0f20c7d1b5f1325c4ce4cf8 --- M

[MediaWiki-commits] [Gerrit] Minor cleanup in ItemContent. - change (mediawiki...Wikibase)

2014-06-06 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Minor cleanup in ItemContent. .. Minor cleanup in ItemContent. Change-Id: I952319a32b3355b24d2eafae06f8899e024b7033 --- M

[MediaWiki-commits] [Gerrit] Require DataModel 0.8.1 and not only the 0.8 branch - change (mediawiki...Wikibase)

2014-06-06 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Require DataModel 0.8.1 and not only the 0.8 branch .. Require DataModel 0.8.1 and not only the 0.8 branch Change-Id:

[MediaWiki-commits] [Gerrit] Remove dead global ref - change (mediawiki...Wikibase)

2014-06-06 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/138127 Change subject: Remove dead global ref .. Remove dead global ref Change-Id: Ia2b470a975746f459caa411caae4db20811ec941 --- M

[MediaWiki-commits] [Gerrit] Remove unused vars - change (mediawiki...Wikibase)

2014-06-06 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/138128 Change subject: Remove unused vars .. Remove unused vars Change-Id: I7790d581d29e1cd6c66b111251602701b062c56b --- M

[MediaWiki-commits] [Gerrit] Remove unused field - change (mediawiki...Wikibase)

2014-06-06 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/138129 Change subject: Remove unused field .. Remove unused field Change-Id: Id1df8ac1baf69aeac5c3622bbbd001e5cf674721 --- M

[MediaWiki-commits] [Gerrit] Deprecate EntityFactory - change (mediawiki...Wikibase)

2014-06-06 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/138130 Change subject: Deprecate EntityFactory .. Deprecate EntityFactory Change-Id: I87884343bd5abb07601c02120fdd9fb158d4e2a1 --- M

[MediaWiki-commits] [Gerrit] Remove call to Item::newFromArray - change (mediawiki...Wikibase)

2014-06-06 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/138132 Change subject: Remove call to Item::newFromArray .. Remove call to Item::newFromArray Change-Id:

[MediaWiki-commits] [Gerrit] Do not use Fingerprint methods that will change in 1.0 - change (mediawiki...Wikibase)

2014-06-06 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/138133 Change subject: Do not use Fingerprint methods that will change in 1.0 .. Do not use Fingerprint methods that will change in 1.0

[MediaWiki-commits] [Gerrit] Merge Set context language in EntityContentDiffViewTest - change (mediawiki...Wikibase)

2014-06-05 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/137722 Change subject: Merge Set context language in EntityContentDiffViewTest .. Merge Set context language in EntityContentDiffViewTest

[MediaWiki-commits] [Gerrit] Merge Set context language in EntityContentDiffViewTest - change (mediawiki...Wikibase)

2014-06-05 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/137723 Change subject: Merge Set context language in EntityContentDiffViewTest .. Merge Set context language in EntityContentDiffViewTest

[MediaWiki-commits] [Gerrit] Use DataModel 0.8 - change (mediawiki...Wikibase)

2014-06-05 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/137738 Change subject: Use DataModel 0.8 .. Use DataModel 0.8 Change-Id: Ibb33b54f2e8f50e9c72cfd8827b06ec69791d1f6 --- M composer.json 1

[MediaWiki-commits] [Gerrit] Use DataValues Time 0.6.x - change (mediawiki...Wikibase)

2014-06-05 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/137749 Change subject: Use DataValues Time 0.6.x .. Use DataValues Time 0.6.x Change-Id: Iddbe847182ad1629d26e292da0f3640be80db8ac --- M

[MediaWiki-commits] [Gerrit] Remove silly comment - change (mediawiki...Wikibase)

2014-06-05 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/137845 Change subject: Remove silly comment .. Remove silly comment Change-Id: I9d0b434e7ce7ca470311108d3899b865339f82a6 --- M

[MediaWiki-commits] [Gerrit] Improve ClientSiteLinkLookupTest - change (mediawiki...Wikibase)

2014-06-05 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/137857 Change subject: Improve ClientSiteLinkLookupTest .. Improve ClientSiteLinkLookupTest Change-Id:

[MediaWiki-commits] [Gerrit] Basic cleanup inLangLinkHandlerTest - change (mediawiki...Wikibase)

2014-06-05 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/137859 Change subject: Basic cleanup inLangLinkHandlerTest .. Basic cleanup inLangLinkHandlerTest Change-Id:

[MediaWiki-commits] [Gerrit] Do not derive from MediaWikiTestCase for no good reason - change (mediawiki...Wikibase)

2014-06-05 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/137860 Change subject: Do not derive from MediaWikiTestCase for no good reason .. Do not derive from MediaWikiTestCase for no good reason

[MediaWiki-commits] [Gerrit] Fix Item construction in LanguageLinkBadgeDisplayTest - change (mediawiki...Wikibase)

2014-06-05 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/137861 Change subject: Fix Item construction in LanguageLinkBadgeDisplayTest .. Fix Item construction in LanguageLinkBadgeDisplayTest

[MediaWiki-commits] [Gerrit] Remove usages of deprecated Item construction from MockRepos... - change (mediawiki...Wikibase)

2014-06-05 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/137865 Change subject: Remove usages of deprecated Item construction from MockRepositoryTest .. Remove usages of deprecated Item

[MediaWiki-commits] [Gerrit] Remove most deprecated Item construction from ChangeOpsMerge... - change (mediawiki...Wikibase)

2014-06-05 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/137866 Change subject: Remove most deprecated Item construction from ChangeOpsMergeTest .. Remove most deprecated Item construction from

[MediaWiki-commits] [Gerrit] Remove bad Item construction from WikiPageEntityStoreTest - change (mediawiki...Wikibase)

2014-06-05 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/137867 Change subject: Remove bad Item construction from WikiPageEntityStoreTest .. Remove bad Item construction from WikiPageEntityStoreTest

[MediaWiki-commits] [Gerrit] Remove silly ref to ItemContent - change (mediawiki...Wikibase)

2014-06-05 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/137870 Change subject: Remove silly ref to ItemContent .. Remove silly ref to ItemContent Change-Id:

[MediaWiki-commits] [Gerrit] Repeat ItemContent removal in ChangeOpQualifierRemoveTest - change (mediawiki...Wikibase)

2014-06-05 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/137871 Change subject: Repeat ItemContent removal in ChangeOpQualifierRemoveTest .. Repeat ItemContent removal in ChangeOpQualifierRemoveTest

[MediaWiki-commits] [Gerrit] Deprecate ItemContent::newFromArray - change (mediawiki...Wikibase)

2014-06-05 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/137872 Change subject: Deprecate ItemContent::newFromArray .. Deprecate ItemContent::newFromArray Change-Id:

[MediaWiki-commits] [Gerrit] Remove silly ItemContent ref from ChangeOpStatementRankTest - change (mediawiki...Wikibase)

2014-06-05 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/137873 Change subject: Remove silly ItemContent ref from ChangeOpStatementRankTest .. Remove silly ItemContent ref from

[MediaWiki-commits] [Gerrit] Minor cleanup in ItemContent - change (mediawiki...Wikibase)

2014-06-05 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/137874 Change subject: Minor cleanup in ItemContent .. Minor cleanup in ItemContent Change-Id: I952319a32b3355b24d2eafae06f8899e024b7033 ---

[MediaWiki-commits] [Gerrit] Remove dead code from PropertyContent - change (mediawiki...Wikibase)

2014-06-05 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/137875 Change subject: Remove dead code from PropertyContent .. Remove dead code from PropertyContent Change-Id:

[MediaWiki-commits] [Gerrit] Remove silly ItemContent ref from ChangeOpQualifierTest - change (mediawiki...Wikibase)

2014-06-05 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/137876 Change subject: Remove silly ItemContent ref from ChangeOpQualifierTest .. Remove silly ItemContent ref from ChangeOpQualifierTest

[MediaWiki-commits] [Gerrit] Remove sillt ItemContent ref in ChangeOpReferenceRemoveTest - change (mediawiki...Wikibase)

2014-06-05 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/137877 Change subject: Remove sillt ItemContent ref in ChangeOpReferenceRemoveTest .. Remove sillt ItemContent ref in

[MediaWiki-commits] [Gerrit] Remove silly ItemCOntent refs in ChangeOpReferenceTest - change (mediawiki...Wikibase)

2014-06-05 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/137878 Change subject: Remove silly ItemCOntent refs in ChangeOpReferenceTest .. Remove silly ItemCOntent refs in ChangeOpReferenceTest

[MediaWiki-commits] [Gerrit] Clean some of the insanity in EntityChangeTest - change (mediawiki...Wikibase)

2014-06-05 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/137881 Change subject: Clean some of the insanity in EntityChangeTest .. Clean some of the insanity in EntityChangeTest Change-Id:

[MediaWiki-commits] [Gerrit] Move Repo specific test to Repo - change (mediawiki...Wikibase)

2014-06-03 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/137037 Change subject: Move Repo specific test to Repo .. Move Repo specific test to Repo Change-Id:

[MediaWiki-commits] [Gerrit] Move HttpAccept classes out of lib/utils to the package wher... - change (mediawiki...Wikibase)

2014-06-03 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/137048 Change subject: Move HttpAccept classes out of lib/utils to the package where they are used .. Move HttpAccept classes out of

[MediaWiki-commits] [Gerrit] Reduce visibility scope - change (mediawiki...Wikibase)

2014-06-03 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/137067 Change subject: Reduce visibility scope .. Reduce visibility scope Change-Id: I35e303c54a3248879b1e83ff9e6934da20d0b88a --- M

[MediaWiki-commits] [Gerrit] Make namespace usage more consistent - change (mediawiki...Wikibase)

2014-06-03 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/137066 Change subject: Make namespace usage more consistent .. Make namespace usage more consistent Change-Id:

[MediaWiki-commits] [Gerrit] Reduce visibility scope - change (mediawiki...Wikibase)

2014-06-03 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/137072 Change subject: Reduce visibility scope .. Reduce visibility scope Change-Id: I29878bfddb1fddb2498b9df5e3edf6d2011bba4c --- M

[MediaWiki-commits] [Gerrit] Remove TODO - change (mediawiki...Wikibase)

2014-06-03 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/137074 Change subject: Remove TODO .. Remove TODO Change-Id: I665d0c7a4c0eb9913f9b2474325b6100344bf0fc --- M

[MediaWiki-commits] [Gerrit] Cleanup in Chunck* classes - change (mediawiki...Wikibase)

2014-06-03 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/137075 Change subject: Cleanup in Chunck* classes .. Cleanup in Chunck* classes Change-Id: I7275b46e42cd8fa2551c565dded68c1b1a0b230a --- M

[MediaWiki-commits] [Gerrit] Do not needlesly use copy in SiteLinkCommentCreatorTest - change (mediawiki...Wikibase)

2014-06-03 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/137148 Change subject: Do not needlesly use copy in SiteLinkCommentCreatorTest .. Do not needlesly use copy in SiteLinkCommentCreatorTest

[MediaWiki-commits] [Gerrit] Fix violation of method contract in SpecialSetSiteLink - change (mediawiki...Wikibase)

2014-06-03 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/137154 Change subject: Fix violation of method contract in SpecialSetSiteLink .. Fix violation of method contract in SpecialSetSiteLink The

[MediaWiki-commits] [Gerrit] Create deep clones - change (mediawiki...Wikibase)

2014-06-03 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/137159 Change subject: Create deep clones .. Create deep clones Change-Id: I07d1854a7ee0e3686d6a9369fe0d196bddcbba2c --- M

[MediaWiki-commits] [Gerrit] Remove usages of highly deprecated Property::newEmpty - change (mediawiki...Wikibase)

2014-06-02 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Remove usages of highly deprecated Property::newEmpty .. Remove usages of highly deprecated Property::newEmpty Change-Id:

[MediaWiki-commits] [Gerrit] Update namespace refs - change (mediawiki...Wikibase)

2014-06-02 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/136772 Change subject: Update namespace refs .. Update namespace refs Change-Id: I16e970698cbd6c16b633b1dbc8f143bc7acfe494 --- M

[MediaWiki-commits] [Gerrit] Improve type hint - change (mediawiki...Wikibase)

2014-06-02 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/136773 Change subject: Improve type hint .. Improve type hint Change-Id: Ic42c1a0d19432301e89e52950af037526bb77ad3 --- M

[MediaWiki-commits] [Gerrit] Update class name - change (mediawiki...Wikibase)

2014-06-02 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/136774 Change subject: Update class name .. Update class name Change-Id: I1a5eb15de7f94fb46b9f9b5f8ae336f8e58f6950 --- M

[MediaWiki-commits] [Gerrit] Update refs to Diff classes - change (mediawiki...Wikibase)

2014-06-02 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/136775 Change subject: Update refs to Diff classes .. Update refs to Diff classes Change-Id: I97249519a936233a547dcc8f2ea3d2af3f702d93 --- M

[MediaWiki-commits] [Gerrit] Fix type hint and simplify method - change (mediawiki...Wikibase)

2014-06-02 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/136776 Change subject: Fix type hint and simplify method .. Fix type hint and simplify method Change-Id:

[MediaWiki-commits] [Gerrit] Update imports in SiteLinkCommentCreator - change (mediawiki...Wikibase)

2014-06-02 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/136778 Change subject: Update imports in SiteLinkCommentCreator .. Update imports in SiteLinkCommentCreator Change-Id:

[MediaWiki-commits] [Gerrit] Update SimpleSiteLink - SiteLink - change (mediawiki...Wikibase)

2014-06-02 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/136779 Change subject: Update SimpleSiteLink - SiteLink .. Update SimpleSiteLink - SiteLink Change-Id:

[MediaWiki-commits] [Gerrit] Remove not needed singleton call - change (mediawiki...Wikibase)

2014-06-02 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/136781 Change subject: Remove not needed singleton call .. Remove not needed singleton call Change-Id:

[MediaWiki-commits] [Gerrit] Remove silly test - change (mediawiki...Wikibase)

2014-06-02 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/136785 Change subject: Remove silly test .. Remove silly test Change-Id: Iafe6492b434c300ef3f375e089c751dde2f5b318 --- M

[MediaWiki-commits] [Gerrit] Remove unused code that can now be implemented better - change (mediawiki...Wikibase)

2014-06-02 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/136787 Change subject: Remove unused code that can now be implemented better .. Remove unused code that can now be implemented better

[MediaWiki-commits] [Gerrit] Clean up ChangeOps related validation code - change (mediawiki...Wikibase)

2014-06-02 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Clean up ChangeOps related validation code .. Clean up ChangeOps related validation code This is a direct follow-up to my comments in patch

[MediaWiki-commits] [Gerrit] Move thing only used in repo from lib to repo - change (mediawiki...Wikibase)

2014-06-02 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/136824 Change subject: Move thing only used in repo from lib to repo .. Move thing only used in repo from lib to repo Still in the wrong NS

[MediaWiki-commits] [Gerrit] Fix type hint - change (mediawiki...Wikibase)

2014-06-02 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/136825 Change subject: Fix type hint .. Fix type hint Change-Id: If29388a299781c13a36fc26a15413094310db210 --- M

[MediaWiki-commits] [Gerrit] Cleanup in SnakConstructionService - change (mediawiki...Wikibase)

2014-06-02 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/136826 Change subject: Cleanup in SnakConstructionService .. Cleanup in SnakConstructionService Change-Id:

[MediaWiki-commits] [Gerrit] Cleanup in SnakFactory - change (mediawiki...Wikibase)

2014-06-02 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/136827 Change subject: Cleanup in SnakFactory .. Cleanup in SnakFactory Change-Id: I51ec0578f019a5be32e02c44509ab1619ad012bc --- M

[MediaWiki-commits] [Gerrit] Move ChangeNotifier from Lib to Repo - change (mediawiki...Wikibase)

2014-06-02 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/136828 Change subject: Move ChangeNotifier from Lib to Repo .. Move ChangeNotifier from Lib to Repo Change-Id:

[MediaWiki-commits] [Gerrit] Move special page code out of Lib - change (mediawiki...Wikibase)

2014-06-02 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/136834 Change subject: Move special page code out of Lib .. Move special page code out of Lib This moves SpecialWikibaseQueryPage and

[MediaWiki-commits] [Gerrit] Remove unused method - change (mediawiki...Wikibase)

2014-06-02 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/136893 Change subject: Remove unused method .. Remove unused method Change-Id: I26948ac6b10116ea86a87ae0b4a3eb9ecefcaad6 --- M

[MediaWiki-commits] [Gerrit] Remove WikibaseRepo access from ChangeNotifier - change (mediawiki...Wikibase)

2014-06-02 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/136894 Change subject: Remove WikibaseRepo access from ChangeNotifier .. Remove WikibaseRepo access from ChangeNotifier Change-Id:

[MediaWiki-commits] [Gerrit] Add constructor docs for WikibaseLuaBindings - change (mediawiki...Wikibase)

2014-06-02 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/136907 Change subject: Add constructor docs for WikibaseLuaBindings .. Add constructor docs for WikibaseLuaBindings Change-Id:

[MediaWiki-commits] [Gerrit] Fix NS of class - change (mediawiki...Wikibase)

2014-06-02 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/136909 Change subject: Fix NS of class .. Fix NS of class Change-Id: I419db6d6aa3bf55d0ad26cbd7ebbef71ddb54a0f --- M

[MediaWiki-commits] [Gerrit] Move GenericEventDispatcher and DispatchingEntityStoreWatche... - change (mediawiki...Wikibase)

2014-06-02 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/136911 Change subject: Move GenericEventDispatcher and DispatchingEntityStoreWatcher out of Lib .. Move GenericEventDispatcher and

[MediaWiki-commits] [Gerrit] Remove only usage of V4GuidGenerator from Client - change (mediawiki...Wikibase)

2014-06-02 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/136914 Change subject: Remove only usage of V4GuidGenerator from Client .. Remove only usage of V4GuidGenerator from Client Step towards

[MediaWiki-commits] [Gerrit] Merge Fix NS of class - change (mediawiki...Wikibase)

2014-06-02 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/136918 Change subject: Merge Fix NS of class .. Merge Fix NS of class Change-Id: I42615024676a06e3737fb29f51a4b009c0d7066b --- M

[MediaWiki-commits] [Gerrit] Remove dead code - change (mediawiki...Wikibase)

2014-06-02 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/136923 Change subject: Remove dead code .. Remove dead code Change-Id: Icb5276302540d1487f25f37a2cf7b6c04316805a --- M

[MediaWiki-commits] [Gerrit] Cleanup in PropertyView - change (mediawiki...Wikibase)

2014-06-02 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/136925 Change subject: Cleanup in PropertyView .. Cleanup in PropertyView Change-Id: I20eedd88c7119d4beb8679d35fea23f248031b22 --- M

[MediaWiki-commits] [Gerrit] Cleanup in TermSqlIndexTest - change (mediawiki...Wikibase)

2014-06-02 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/136927 Change subject: Cleanup in TermSqlIndexTest .. Cleanup in TermSqlIndexTest Change-Id: Ibb913a9bdedbab380c1176c24a4818f6c15d4db0 --- M

[MediaWiki-commits] [Gerrit] Remove unused referenced and stop using deprecated aliases - change (mediawiki...Wikibase)

2014-06-02 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/136930 Change subject: Remove unused referenced and stop using deprecated aliases .. Remove unused referenced and stop using deprecated

[MediaWiki-commits] [Gerrit] Remove highly deprecated method - change (mediawiki...Wikibase)

2014-05-30 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/136498 Change subject: Remove highly deprecated method .. Remove highly deprecated method Change-Id:

[MediaWiki-commits] [Gerrit] Remove usages of highly deprecated Property::newEmpty - change (mediawiki...Wikibase)

2014-05-30 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/136499 Change subject: Remove usages of highly deprecated Property::newEmpty .. Remove usages of highly deprecated Property::newEmpty

[MediaWiki-commits] [Gerrit] Remove and deprecate code based on deprecated concepts - change (mediawiki...Wikibase)

2014-05-30 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/136506 Change subject: Remove and deprecate code based on deprecated concepts .. Remove and deprecate code based on deprecated concepts

[MediaWiki-commits] [Gerrit] Remove silly not needed second argument - change (mediawiki...Wikibase)

2014-05-30 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/136509 Change subject: Remove silly not needed second argument .. Remove silly not needed second argument Change-Id:

[MediaWiki-commits] [Gerrit] Improvements to method updateMockRepo - change (mediawiki...Wikibase)

2014-05-30 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/136510 Change subject: Improvements to method updateMockRepo .. Improvements to method updateMockRepo Change-Id:

<    3   4   5   6   7   8   9   10   11   12   >