[MediaWiki-commits] [Gerrit] mediawiki...WikimediaEvents[master]: build: Replace jshint/jscs with eslint

2017-11-01 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/387972 ) Change subject: build: Replace jshint/jscs with eslint .. build: Replace jshint/jscs with eslint Change-Id: Ic85a99fa261ac27549bcaa4a94a211

[MediaWiki-commits] [Gerrit] integration/jenkins[master]: Re-enable $wgAutoloadAttemptLowercase for older branches

2017-11-01 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/387971 ) Change subject: Re-enable $wgAutoloadAttemptLowercase for older branches .. Re-enable $wgAutoloadAttemptLowercase for older branches Follow

[MediaWiki-commits] [Gerrit] mediawiki...NavigationTiming[wmf/1.31.0-wmf.6]: Send value zero for unload and redirecting

2017-11-01 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/387915 ) Change subject: Send value zero for unload and redirecting .. Send value zero for unload and redirecting The median stackable values are wr

[MediaWiki-commits] [Gerrit] mediawiki/core[REL1_29]: importDump.php: Declare uploadCount property

2017-11-01 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/387884 ) Change subject: importDump.php: Declare uploadCount property .. importDump.php: Declare uploadCount property Bug: T174255 Change-Id: Ic5014

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.31.0-wmf.6]: resourceloader: Remove outdated readyState handler for base ...

2017-11-01 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/387856 ) Change subject: resourceloader: Remove outdated readyState handler for base modules request .. resourceloader: Remove outdated readyState h

[MediaWiki-commits] [Gerrit] integration/docroot[master]: cover: Render progress-bar before directory names

2017-10-31 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/387769 ) Change subject: cover: Render progress-bar before directory names .. cover: Render progress-bar before directory names This should improve

[MediaWiki-commits] [Gerrit] mediawiki...ArticleFeedbackv5[master]: Remove reference to jquery.placeholder

2017-10-31 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/387757 ) Change subject: Remove reference to jquery.placeholder .. Remove reference to jquery.placeholder This module isn't actually used, but still

[MediaWiki-commits] [Gerrit] mediawiki...ImageMetrics[master]: Update tests to be compatible with QUnit 2

2017-10-31 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/387756 ) Change subject: Update tests to be compatible with QUnit 2 .. Update tests to be compatible with QUnit 2 Remove deprecated expectCount para

[MediaWiki-commits] [Gerrit] oojs/ui[master]: Revert "README: Fix Doxygen markup"

2017-10-31 Thread Krinkle (Code Review)
Hello jenkins-bot, VolkerE, Jforrester, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/387753 to review the following change. Change subject: Revert "README: Fix Doxygen markup" .. Revert "

[MediaWiki-commits] [Gerrit] mediawiki...ImageMetrics[master]: Remove use of 'mediaWikiLoadStart'

2017-10-30 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/387510 ) Change subject: Remove use of 'mediaWikiLoadStart' .. Remove use of 'mediaWikiLoadStart' Schema 'ImageMetricsLoadingTime' documents fallbac

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: resourceloader: Remove outdated readyState handler for base ...

2017-10-30 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/387509 ) Change subject: resourceloader: Remove outdated readyState handler for base modules request .. resourceloader: Remove outdated readyState h

[MediaWiki-commits] [Gerrit] oojs/core[master]: Generate clover.xml with code coverage results

2017-10-26 Thread Krinkle (Code Review)
Krinkle has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/386570 ) Change subject: Generate clover.xml with code coverage results .. Generate clover.xml with code coverage results Bug: T179051 Chang

[MediaWiki-commits] [Gerrit] oojs/core[master]: build: Test against Safari 7, Safari 6 is no longer around

2017-10-26 Thread Krinkle (Code Review)
Krinkle has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/386664 ) Change subject: build: Test against Safari 7, Safari 6 is no longer around .. build: Test against Safari 7, Safari 6 is no longer ar

[MediaWiki-commits] [Gerrit] labs...guc[master]: frontend: Restore loader indicator when landing from permalink

2017-10-25 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/386434 ) Change subject: frontend: Restore loader indicator when landing from permalink .. frontend: Restore loader indicator when landing from perma

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: API: Include setupSkinUserCss in prop=modules for useskin mode

2017-10-24 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/386327 ) Change subject: API: Include setupSkinUserCss in prop=modules for useskin mode .. API: Include setupSkinUserCss in prop=modules for useskin

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: API: Add tests for useskin parameter of ApiParse

2017-10-24 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/386326 ) Change subject: API: Add tests for useskin parameter of ApiParse .. API: Add tests for useskin parameter of ApiParse Change-Id: If3dff7be5c

[MediaWiki-commits] [Gerrit] mediawiki...NavigationTiming[wmf/1.31.0-wmf.5]: Do not filter out zero values.

2017-10-24 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/386247 ) Change subject: Do not filter out zero values. .. Do not filter out zero values. Bug: T178479 Change-Id: I0d178cf43c78c0c4db8ae137ce14c35fc

[MediaWiki-commits] [Gerrit] labs...guc[master]: [WIP] Add demo page for testing styles and layout

2017-10-22 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/385928 ) Change subject: [WIP] Add demo page for testing styles and layout .. [WIP] Add demo page for testing styles and layout Change-Id: I87de962d

[MediaWiki-commits] [Gerrit] labs...guc[master]: frontend: Disable the submit button when loading, instead of...

2017-10-22 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/385926 ) Change subject: frontend: Disable the submit button when loading, instead of hiding .. frontend: Disable the submit button when loading, in

[MediaWiki-commits] [Gerrit] labs...guc[master]: Output: Fix unclosed element from ChronologyOutput

2017-10-22 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/385925 ) Change subject: Output: Fix unclosed element from ChronologyOutput .. Output: Fix unclosed element from ChronologyOutput Follows-up 0900b

[MediaWiki-commits] [Gerrit] labs...guc[master]: Modernise layout and remove (broken) Tool Labs logo

2017-10-22 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/385927 ) Change subject: Modernise layout and remove (broken) Tool Labs logo .. Modernise layout and remove (broken) Tool Labs logo While very abstr

[MediaWiki-commits] [Gerrit] labs...guc[master]: Add LICENSE

2017-10-22 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/385853 ) Change subject: Add LICENSE .. Add LICENSE Change-Id: I310c76ed8f2284eda5e851fd8c609de0d8f201dc --- A LICENSE M index.php M resources/front

[MediaWiki-commits] [Gerrit] mediawiki...WikimediaMaintenance[wmf/1.31.0-wmf.4]: Sort the job counts in descending size order

2017-10-20 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/385396 ) Change subject: Sort the job counts in descending size order .. Sort the job counts in descending size order Change-Id: I8737795e69eb5c99be

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: resourceloader: Introduce metric for backend response timing

2017-10-16 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384644 ) Change subject: resourceloader: Introduce metric for backend response timing .. resourceloader: Introduce metric for backend response timing

[MediaWiki-commits] [Gerrit] mediawiki/core[REL1_30]: Ensure only strings are passed to mysql_real_escape_string()

2017-10-16 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384550 ) Change subject: Ensure only strings are passed to mysql_real_escape_string() .. Ensure only strings are passed to mysql_real_escape_string()

[MediaWiki-commits] [Gerrit] mediawiki/core[REL1_29]: Ensure only strings are passed to mysql_real_escape_string()

2017-10-16 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384551 ) Change subject: Ensure only strings are passed to mysql_real_escape_string() .. Ensure only strings are passed to mysql_real_escape_string()

[MediaWiki-commits] [Gerrit] mediawiki/core[REL1_29]: Remove use of implicitGroupBy() in ActiveUsersPager

2017-10-16 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384549 ) Change subject: Remove use of implicitGroupBy() in ActiveUsersPager .. Remove use of implicitGroupBy() in ActiveUsersPager Bug: T160298 Cha

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: deferred: Introduce OuterScopeUpdate

2017-10-12 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383912 ) Change subject: deferred: Introduce OuterScopeUpdate .. deferred: Introduce OuterScopeUpdate This allows scheduling of updates that need to

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: deferred: Improve DeferredUpdates test coverage

2017-10-12 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383911 ) Change subject: deferred: Improve DeferredUpdates test coverage .. deferred: Improve DeferredUpdates test coverage From 1% of lines to 12%

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: [WIP] Local hacks

2017-10-11 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383758 ) Change subject: [WIP] Local hacks .. [WIP] Local hacks * expiry=500 so I can fish the url out of vagrant/logs/mediawiki-runJobs.log and t

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: SpecialRunJobs: Use normal OutputPage and built-in async mode

2017-10-11 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383737 ) Change subject: SpecialRunJobs: Use normal OutputPage and built-in async mode .. SpecialRunJobs: Use normal OutputPage and built-in async mo

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: SpecialRunJobs: Remove unused JSON response

2017-10-11 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383736 ) Change subject: SpecialRunJobs: Remove unused JSON response .. SpecialRunJobs: Remove unused JSON response In preparation of making Special

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: noc: Make css/base.css shared between index, db and conf views

2017-10-10 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383399 ) Change subject: noc: Make css/base.css shared between index, db and conf views .. noc: Make css/base.css shared between index, db and conf v

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: noc: Remove unused Vector CSS

2017-10-10 Thread Krinkle (Code Review)
Krinkle has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/383396 ) Change subject: noc: Remove unused Vector CSS .. noc: Remove unused Vector CSS * Search bar. * Personal bar. * Preferences tabs. *

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: noc: Remove bugzilla-ish css/index.css and images/index/

2017-10-10 Thread Krinkle (Code Review)
Krinkle has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/383395 ) Change subject: noc: Remove bugzilla-ish css/index.css and images/index/ .. noc: Remove bugzilla-ish css/index.css and images/index/

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: noc: Remove unused Vector CSS

2017-10-10 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383396 ) Change subject: noc: Remove unused Vector CSS .. noc: Remove unused Vector CSS * Search bar. * Personal bar. * Preferences tabs. * External

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: noc: Remove bugzilla-ish css/index.css and images/index/

2017-10-10 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383395 ) Change subject: noc: Remove bugzilla-ish css/index.css and images/index/ .. noc: Remove bugzilla-ish css/index.css and images/index/ Two se

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: noc: Remove unused bugzilla-ish global.css

2017-10-10 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383394 ) Change subject: noc: Remove unused bugzilla-ish global.css .. noc: Remove unused bugzilla-ish global.css These selectors either all don't m

[MediaWiki-commits] [Gerrit] mediawiki...Equivset[master]: readme: Fix for compat with Doxygen Markdown

2017-10-09 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383303 ) Change subject: readme: Fix for compat with Doxygen Markdown .. readme: Fix for compat with Doxygen Markdown The tripple-backtick syntax

[MediaWiki-commits] [Gerrit] performance/docroot[master]: index: Change footer link to team page on mediawiki.org

2017-10-09 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383288 ) Change subject: index: Change footer link to team page on mediawiki.org .. index: Change footer link to team page on mediawiki.org The Wiki

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: tests: Commit initial version of TestSettings.php

2017-10-08 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383041 ) Change subject: tests: Commit initial version of TestSettings.php .. tests: Commit initial version of TestSettings.php * Store in the tests

[MediaWiki-commits] [Gerrit] integration/jenkins[master]: mwconf: Use built-in TestSettings.php instead when available

2017-10-08 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383040 ) Change subject: mwconf: Use built-in TestSettings.php instead when available .. mwconf: Use built-in TestSettings.php instead when available

[MediaWiki-commits] [Gerrit] integration/jenkins[master]: mwconf: Merge 00_set_debug_log into 00_dev_settings

2017-10-08 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383039 ) Change subject: mwconf: Merge 00_set_debug_log into 00_dev_settings .. mwconf: Merge 00_set_debug_log into 00_dev_settings Bug: T177669 Cha

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: [WIP] Implement structured footer content

2017-10-06 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/382887 ) Change subject: [WIP] Implement structured footer content .. [WIP] Implement structured footer content This the footer link logic structure

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.31.0-wmf.2]: jquery.ui: Fix various jQuery Migrate warnings

2017-10-06 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/382768 ) Change subject: jquery.ui: Fix various jQuery Migrate warnings .. jquery.ui: Fix various jQuery Migrate warnings These are the most common

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: installer: Add comments to purgeCache()

2017-10-05 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/382633 ) Change subject: installer: Add comments to purgeCache() .. installer: Add comments to purgeCache() Change-Id: I791f220b49e3e1c7d6df9ccab7d7

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: jquery.ui: Fix various jQuery Migrate warnings

2017-10-05 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/382553 ) Change subject: jquery.ui: Fix various jQuery Migrate warnings .. jquery.ui: Fix various jQuery Migrate warnings These are the most common

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.31.0-wmf.2]: jquery-migrate: Disable console.trace() call by default

2017-10-05 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/382530 ) Change subject: jquery-migrate: Disable console.trace() call by default .. jquery-migrate: Disable console.trace() call by default They are

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.31.0-wmf.2]: jquery-migrate: Remove redundant PATCH note for Deferred bug

2017-10-05 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/382529 ) Change subject: jquery-migrate: Remove redundant PATCH note for Deferred bug .. jquery-migrate: Remove redundant PATCH note for Deferred bug

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: jquery-migrate: Disable console.trace() call by default

2017-10-05 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/382519 ) Change subject: jquery-migrate: Disable console.trace() call by default .. jquery-migrate: Disable console.trace() call by default They are

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: jquery-migrate: Remove redundant PATCH note for Deferred bug

2017-10-05 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/382518 ) Change subject: jquery-migrate: Remove redundant PATCH note for Deferred bug .. jquery-migrate: Remove redundant PATCH note for Deferred bug

[MediaWiki-commits] [Gerrit] integration/docroot[master]: zuul: Same duration for mini graphs and link to Grafana

2017-10-04 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/382325 ) Change subject: zuul: Same duration for mini graphs and link to Grafana .. zuul: Same duration for mini graphs and link to Grafana * Some o

[MediaWiki-commits] [Gerrit] mediawiki...TimedMediaHandler[wmf/1.31.0-wmf.2]: Use prop(, false) instead of removeAttr() to change properties

2017-10-04 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/382319 ) Change subject: Use prop(, false) instead of removeAttr() to change properties .. Use prop(, false) instead of removeAttr() to change proper

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: mediawiki.notification: Move offset() computation to next frame

2017-10-04 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/382230 ) Change subject: mediawiki.notification: Move offset() computation to next frame .. mediawiki.notification: Move offset() computation to next

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: mediawiki.notification: Refactor $.ready handler and init()

2017-10-04 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/382229 ) Change subject: mediawiki.notification: Refactor $.ready handler and init() .. mediawiki.notification: Refactor $.ready handler and init()

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: mediawiki.notification: Use css() instead of slow show()/hide()

2017-10-04 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/382228 ) Change subject: mediawiki.notification: Use css() instead of slow show()/hide() .. mediawiki.notification: Use css() instead of slow show()/

[MediaWiki-commits] [Gerrit] mediawiki...PageTriage[master]: Change use of deprecated jQuery.fn.hover() to on()

2017-10-04 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/382196 ) Change subject: Change use of deprecated jQuery.fn.hover() to on() .. Change use of deprecated jQuery.fn.hover() to on() Fixes: > JQMIGRATE

[MediaWiki-commits] [Gerrit] mediawiki...LiquidThreads[master]: Use on() instead of deprecated on()

2017-10-04 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/382194 ) Change subject: Use on() instead of deprecated on() .. Use on() instead of deprecated on() Fixes: > JQMIGRATE: jQuery.fn.bind() is deprecat

[MediaWiki-commits] [Gerrit] mediawiki...TimedMediaHandler[master]: Use prop(, false) instead of removeAttr() to change properties

2017-10-04 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/382191 ) Change subject: Use prop(, false) instead of removeAttr() to change properties .. Use prop(, false) instead of removeAttr() to change proper

[MediaWiki-commits] [Gerrit] mediawiki...Translate[master]: Revert "Use Language type hint in hooks"

2017-10-03 Thread Krinkle (Code Review)
Hello Fomafix, jenkins-bot, Nikerabbit, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/382093 to review the following change. Change subject: Revert "Use Language type hint in hooks" .. Rev

[MediaWiki-commits] [Gerrit] mediawiki...Translate[wmf/1.31.0-wmf.2]: Revert "Use Language type hint in hooks"

2017-10-03 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/382095 ) Change subject: Revert "Use Language type hint in hooks" .. Revert "Use Language type hint in hooks" This reverts commit d8572921ee11e0

[MediaWiki-commits] [Gerrit] mediawiki...Wigo3[master]: Remove ancient PARSERFIRSTCALLINIT support

2017-10-03 Thread Krinkle (Code Review)
Krinkle has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/382075 ) Change subject: Remove ancient PARSERFIRSTCALLINIT support .. Remove ancient PARSERFIRSTCALLINIT support Some whitespace removal to

[MediaWiki-commits] [Gerrit] mediawiki...TimedMediaHandler[wmf/1.31.0-wmf.2]: Fix jQuery.fn.bind() call in mw.MediaWikiPlayer.loader.js

2017-10-03 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/382089 ) Change subject: Fix jQuery.fn.bind() call in mw.MediaWikiPlayer.loader.js .. Fix jQuery.fn.bind() call in mw.MediaWikiPlayer.loader.js This

[MediaWiki-commits] [Gerrit] mediawiki...TimedMediaHandler[wmf/1.30.0-wmf.19]: Fix jQuery.fn.bind() call in mw.MediaWikiPlayer.loader.js

2017-10-03 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/382088 ) Change subject: Fix jQuery.fn.bind() call in mw.MediaWikiPlayer.loader.js .. Fix jQuery.fn.bind() call in mw.MediaWikiPlayer.loader.js This

[MediaWiki-commits] [Gerrit] mediawiki...TimedMediaHandler[master]: Fix jQuery.fn.bind() call in mw.MediaWikiPlayer.loader.js

2017-10-03 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/382087 ) Change subject: Fix jQuery.fn.bind() call in mw.MediaWikiPlayer.loader.js .. Fix jQuery.fn.bind() call in mw.MediaWikiPlayer.loader.js This

[MediaWiki-commits] [Gerrit] mediawiki...SemanticPageMaker[master]: Remove MediaWiki 1.11 compat

2017-10-03 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/382071 ) Change subject: Remove MediaWiki 1.11 compat .. Remove MediaWiki 1.11 compat ParserFirstCallInit added in 1.12 (10 years ago) Change-Id: I

[MediaWiki-commits] [Gerrit] mediawiki...WikiObjectModel[master]: Remove MediaWiki 1.11 compat

2017-10-03 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/382070 ) Change subject: Remove MediaWiki 1.11 compat .. Remove MediaWiki 1.11 compat ParserFirstCallInit added in 1.12 (10 years ago) Change-Id: I

[MediaWiki-commits] [Gerrit] mediawiki...ExtTab[master]: Remove redundant $wgParser->_unstub() call

2017-10-03 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/382068 ) Change subject: Remove redundant $wgParser->_unstub() call .. Remove redundant $wgParser->_unstub() call It will unstub by itself (if it ha

[MediaWiki-commits] [Gerrit] mediawiki...LiquidThreads[master]: Remove call to non-existant $wgOut->_unstub()

2017-10-03 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/382066 ) Change subject: Remove call to non-existant $wgOut->_unstub() .. Remove call to non-existant $wgOut->_unstub() This hasn't been a stub for

[MediaWiki-commits] [Gerrit] mediawiki...EventLogging[master]: build: Remove unsupported --use-mirrors from pip command

2017-10-03 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/382039 ) Change subject: build: Remove unsupported --use-mirrors from pip command .. build: Remove unsupported --use-mirrors from pip command Travis

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: resourceloader: Add unit test for ClientHtml::makeLoad sync=...

2017-10-03 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/382022 ) Change subject: resourceloader: Add unit test for ClientHtml::makeLoad sync=>true .. resourceloader: Add unit test for ClientHtml::makeLoad

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: phpunit: Include all raw modules in detection of illegal dep...

2017-10-03 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/382021 ) Change subject: phpunit: Include all raw modules in detection of illegal dependencies .. phpunit: Include all raw modules in detection of i

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: mw.loader: Use Array#indexOf directly instead of jQuery.inArray

2017-09-30 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/381533 ) Change subject: mw.loader: Use Array#indexOf directly instead of jQuery.inArray .. mw.loader: Use Array#indexOf directly instead of jQuery.i

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: mw.loader: Return consistent object shape from splitModuleKey()

2017-09-30 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/381532 ) Change subject: mw.loader: Return consistent object shape from splitModuleKey() .. mw.loader: Return consistent object shape from splitModul

[MediaWiki-commits] [Gerrit] operations/puppet[production]: puppetmaster: hacks to fix puppet logstash

2017-09-28 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/381279 ) Change subject: puppetmaster: hacks to fix puppet logstash .. puppetmaster: hacks to fix puppet logstash Change-Id: Ifd697fbb81f26d78ae7c36

[MediaWiki-commits] [Gerrit] operations/puppet[production]: errorpage: Set explicit height on logo image

2017-09-28 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/381275 ) Change subject: errorpage: Set explicit height on logo image .. errorpage: Set explicit height on logo image This prevents the browser from

[MediaWiki-commits] [Gerrit] operations/puppet[production]: errorpage: Migrate from back-compat wmf.png to wmf-logo.png

2017-09-28 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/381274 ) Change subject: errorpage: Migrate from back-compat wmf.png to wmf-logo.png .. errorpage: Migrate from back-compat wmf.png to wmf-logo.png

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: objectcache: Improve WANObjectCache test coverage

2017-09-28 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/381270 ) Change subject: objectcache: Improve WANObjectCache test coverage .. objectcache: Improve WANObjectCache test coverage class WANObjectCache

[MediaWiki-commits] [Gerrit] labs...guc[master]: Fix undefined variable clusterNr

2017-09-27 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/381020 ) Change subject: Fix undefined variable clusterNr .. Fix undefined variable clusterNr Bug: T176831 Change-Id: I0bdb31c4b8d94906bd346a405c93b

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Update jQuery Migrate to v3.0.1

2017-09-26 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/380884 ) Change subject: Update jQuery Migrate to v3.0.1 .. Update jQuery Migrate to v3.0.1 * Fixes IE9 issues with console.log. * Add warning for $

[MediaWiki-commits] [Gerrit] labs...guc[master]: Centralise database hostname handling

2017-09-26 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/380873 ) Change subject: Centralise database hostname handling .. Centralise database hostname handling * Remove deadcode for $cluster as integer. *

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: objectcache: Improve WANObjectCache test coverage

2017-09-25 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/380657 ) Change subject: objectcache: Improve WANObjectCache test coverage .. objectcache: Improve WANObjectCache test coverage class WANObjectCache

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: resourceloader: Remove deprecated MessageBlobStore::insertMe...

2017-09-25 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/380559 ) Change subject: resourceloader: Remove deprecated MessageBlobStore::insertMessageBlob .. resourceloader: Remove deprecated MessageBlobStore

[MediaWiki-commits] [Gerrit] operations/puppet[production]: mediawiki/hhvm: Move fatal-error.php to Puppet

2017-09-22 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/379953 ) Change subject: mediawiki/hhvm: Move fatal-error.php to Puppet .. mediawiki/hhvm: Move fatal-error.php to Puppet Moved here from operations

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Enable jQuery 3 on Wiktionary sites

2017-09-22 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/379947 ) Change subject: Enable jQuery 3 on Wiktionary sites .. Enable jQuery 3 on Wiktionary sites Bug: T124742 Change-Id: I48cedceab210518eb64f752

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Enable jQuery 3 on all wikis

2017-09-22 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/379949 ) Change subject: Enable jQuery 3 on all wikis .. Enable jQuery 3 on all wikis This effectively enables it for Wikipedia sites and various sp

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Enable jQuery 3 on most group1 wikis (non-Wikipedia)

2017-09-22 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/379948 ) Change subject: Enable jQuery 3 on most group1 wikis (non-Wikipedia) .. Enable jQuery 3 on most group1 wikis (non-Wikipedia) Bug: T124742 C

[MediaWiki-commits] [Gerrit] mediawiki...WikimediaEvents[master]: Various minor no-op cleaning (conventions, perf)

2017-09-22 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/379943 ) Change subject: Various minor no-op cleaning (conventions, perf) .. Various minor no-op cleaning (conventions, perf) * Consistently use `/*

[MediaWiki-commits] [Gerrit] mediawiki...WikimediaEvents[master]: ext.wikimediaEvents.statsd: Return early in case of DNT

2017-09-22 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/379944 ) Change subject: ext.wikimediaEvents.statsd: Return early in case of DNT .. ext.wikimediaEvents.statsd: Return early in case of DNT Change-I

[MediaWiki-commits] [Gerrit] operations/puppet[production]: [WIP] webperf: Add navtiming tests to puppet.git:/tox.ini

2017-09-22 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/379830 ) Change subject: [WIP] webperf: Add navtiming tests to puppet.git:/tox.ini .. [WIP] webperf: Add navtiming tests to puppet.git:/tox.ini Chan

[MediaWiki-commits] [Gerrit] operations/puppet[production]: webperf: Fix crash when event contains browser_major:null

2017-09-22 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/379820 ) Change subject: webperf: Fix crash when event contains browser_major:null .. webperf: Fix crash when event contains browser_major:null We a

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: mw.loader: Simplify getVersion and getState

2017-09-21 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/379688 ) Change subject: mw.loader: Simplify getVersion and getState .. mw.loader: Simplify getVersion and getState This undefined check no longer m

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: resourceloader: Use ES5 Array#filter instead of jQuery.grep

2017-09-21 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/379681 ) Change subject: resourceloader: Use ES5 Array#filter instead of jQuery.grep .. resourceloader: Use ES5 Array#filter instead of jQuery.grep

[MediaWiki-commits] [Gerrit] mediawiki/vagrant[master]: Enable dummy statsv URL for wikimediaevents

2017-09-21 Thread Krinkle (Code Review)
Krinkle has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/379516 ) Change subject: Enable dummy statsv URL for wikimediaevents .. Enable dummy statsv URL for wikimediaevents The requests 404, but it

[MediaWiki-commits] [Gerrit] mediawiki...TimedMediaHandler[master]: Use jQuery on/off instead of deprecated bind/unbind

2017-09-20 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/379452 ) Change subject: Use jQuery on/off instead of deprecated bind/unbind .. Use jQuery on/off instead of deprecated bind/unbind Bug: T169385 Cha

[MediaWiki-commits] [Gerrit] mediawiki...EventLogging[master]: Update DNT check to support IE 11 and Safari 7

2017-09-19 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/379129 ) Change subject: Update DNT check to support IE 11 and Safari 7 .. Update DNT check to support IE 11 and Safari 7 Change-Id: Ie2341ffe6a596e

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Setup: Merge PreConfigSetup into Setup.php

2017-09-19 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/378986 ) Change subject: Setup: Merge PreConfigSetup into Setup.php .. Setup: Merge PreConfigSetup into Setup.php Follows-up 41ea7e2fefff65. The fo

[MediaWiki-commits] [Gerrit] mediawiki...EventLogging[master]: ext.eventLogging.subscriber: Don't wait for "load" if it alr...

2017-09-18 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/378804 ) Change subject: ext.eventLogging.subscriber: Don't wait for "load" if it already happened .. ext.eventLogging.subscriber: Don't wait for "l

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Enable jQuery 3 on commons.wikimedia.org

2017-09-18 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/378803 ) Change subject: Enable jQuery 3 on commons.wikimedia.org .. Enable jQuery 3 on commons.wikimedia.org Change-Id: Ibb70fc6b7f0497683d99a32158

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Enable jQuery 3 on metawiki

2017-09-18 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/378802 ) Change subject: Enable jQuery 3 on metawiki .. Enable jQuery 3 on metawiki Bug: T124742 Change-Id: Ie7531a88e0351b60e5f80423767e5acbf400d55

<    1   2   3   4   5   6   7   8   9   10   >