Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/387972 )
Change subject: build: Replace jshint/jscs with eslint
..
build: Replace jshint/jscs with eslint
Change-Id: Ic85a99fa261ac27549bcaa4a94a211
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/387971 )
Change subject: Re-enable $wgAutoloadAttemptLowercase for older branches
..
Re-enable $wgAutoloadAttemptLowercase for older branches
Follow
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/387915 )
Change subject: Send value zero for unload and redirecting
..
Send value zero for unload and redirecting
The median stackable values are wr
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/387884 )
Change subject: importDump.php: Declare uploadCount property
..
importDump.php: Declare uploadCount property
Bug: T174255
Change-Id: Ic5014
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/387856 )
Change subject: resourceloader: Remove outdated readyState handler for base
modules request
..
resourceloader: Remove outdated readyState h
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/387769 )
Change subject: cover: Render progress-bar before directory names
..
cover: Render progress-bar before directory names
This should improve
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/387757 )
Change subject: Remove reference to jquery.placeholder
..
Remove reference to jquery.placeholder
This module isn't actually used, but still
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/387756 )
Change subject: Update tests to be compatible with QUnit 2
..
Update tests to be compatible with QUnit 2
Remove deprecated expectCount para
Hello jenkins-bot, VolkerE, Jforrester,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/387753
to review the following change.
Change subject: Revert "README: Fix Doxygen markup"
..
Revert "
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/387510 )
Change subject: Remove use of 'mediaWikiLoadStart'
..
Remove use of 'mediaWikiLoadStart'
Schema 'ImageMetricsLoadingTime' documents fallbac
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/387509 )
Change subject: resourceloader: Remove outdated readyState handler for base
modules request
..
resourceloader: Remove outdated readyState h
Krinkle has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/386570 )
Change subject: Generate clover.xml with code coverage results
..
Generate clover.xml with code coverage results
Bug: T179051
Chang
Krinkle has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/386664 )
Change subject: build: Test against Safari 7, Safari 6 is no longer around
..
build: Test against Safari 7, Safari 6 is no longer ar
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/386434 )
Change subject: frontend: Restore loader indicator when landing from permalink
..
frontend: Restore loader indicator when landing from perma
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/386327 )
Change subject: API: Include setupSkinUserCss in prop=modules for useskin mode
..
API: Include setupSkinUserCss in prop=modules for useskin
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/386326 )
Change subject: API: Add tests for useskin parameter of ApiParse
..
API: Add tests for useskin parameter of ApiParse
Change-Id: If3dff7be5c
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/386247 )
Change subject: Do not filter out zero values.
..
Do not filter out zero values.
Bug: T178479
Change-Id: I0d178cf43c78c0c4db8ae137ce14c35fc
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/385928 )
Change subject: [WIP] Add demo page for testing styles and layout
..
[WIP] Add demo page for testing styles and layout
Change-Id: I87de962d
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/385926 )
Change subject: frontend: Disable the submit button when loading, instead of
hiding
..
frontend: Disable the submit button when loading, in
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/385925 )
Change subject: Output: Fix unclosed element from ChronologyOutput
..
Output: Fix unclosed element from ChronologyOutput
Follows-up 0900b
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/385927 )
Change subject: Modernise layout and remove (broken) Tool Labs logo
..
Modernise layout and remove (broken) Tool Labs logo
While very abstr
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/385853 )
Change subject: Add LICENSE
..
Add LICENSE
Change-Id: I310c76ed8f2284eda5e851fd8c609de0d8f201dc
---
A LICENSE
M index.php
M resources/front
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/385396 )
Change subject: Sort the job counts in descending size order
..
Sort the job counts in descending size order
Change-Id: I8737795e69eb5c99be
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/384644 )
Change subject: resourceloader: Introduce metric for backend response timing
..
resourceloader: Introduce metric for backend response timing
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/384550 )
Change subject: Ensure only strings are passed to mysql_real_escape_string()
..
Ensure only strings are passed to mysql_real_escape_string()
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/384551 )
Change subject: Ensure only strings are passed to mysql_real_escape_string()
..
Ensure only strings are passed to mysql_real_escape_string()
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/384549 )
Change subject: Remove use of implicitGroupBy() in ActiveUsersPager
..
Remove use of implicitGroupBy() in ActiveUsersPager
Bug: T160298
Cha
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/383912 )
Change subject: deferred: Introduce OuterScopeUpdate
..
deferred: Introduce OuterScopeUpdate
This allows scheduling of updates that need to
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/383911 )
Change subject: deferred: Improve DeferredUpdates test coverage
..
deferred: Improve DeferredUpdates test coverage
From 1% of lines to 12%
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/383758 )
Change subject: [WIP] Local hacks
..
[WIP] Local hacks
* expiry=500 so I can fish the url out of vagrant/logs/mediawiki-runJobs.log
and t
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/383737 )
Change subject: SpecialRunJobs: Use normal OutputPage and built-in async mode
..
SpecialRunJobs: Use normal OutputPage and built-in async mo
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/383736 )
Change subject: SpecialRunJobs: Remove unused JSON response
..
SpecialRunJobs: Remove unused JSON response
In preparation of making Special
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/383399 )
Change subject: noc: Make css/base.css shared between index, db and conf views
..
noc: Make css/base.css shared between index, db and conf v
Krinkle has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/383396 )
Change subject: noc: Remove unused Vector CSS
..
noc: Remove unused Vector CSS
* Search bar.
* Personal bar.
* Preferences tabs.
*
Krinkle has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/383395 )
Change subject: noc: Remove bugzilla-ish css/index.css and images/index/
..
noc: Remove bugzilla-ish css/index.css and images/index/
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/383396 )
Change subject: noc: Remove unused Vector CSS
..
noc: Remove unused Vector CSS
* Search bar.
* Personal bar.
* Preferences tabs.
* External
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/383395 )
Change subject: noc: Remove bugzilla-ish css/index.css and images/index/
..
noc: Remove bugzilla-ish css/index.css and images/index/
Two se
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/383394 )
Change subject: noc: Remove unused bugzilla-ish global.css
..
noc: Remove unused bugzilla-ish global.css
These selectors either all don't m
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/383303 )
Change subject: readme: Fix for compat with Doxygen Markdown
..
readme: Fix for compat with Doxygen Markdown
The tripple-backtick syntax
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/383288 )
Change subject: index: Change footer link to team page on mediawiki.org
..
index: Change footer link to team page on mediawiki.org
The Wiki
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/383041 )
Change subject: tests: Commit initial version of TestSettings.php
..
tests: Commit initial version of TestSettings.php
* Store in the tests
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/383040 )
Change subject: mwconf: Use built-in TestSettings.php instead when available
..
mwconf: Use built-in TestSettings.php instead when available
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/383039 )
Change subject: mwconf: Merge 00_set_debug_log into 00_dev_settings
..
mwconf: Merge 00_set_debug_log into 00_dev_settings
Bug: T177669
Cha
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/382887 )
Change subject: [WIP] Implement structured footer content
..
[WIP] Implement structured footer content
This the footer link logic structure
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/382768 )
Change subject: jquery.ui: Fix various jQuery Migrate warnings
..
jquery.ui: Fix various jQuery Migrate warnings
These are the most common
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/382633 )
Change subject: installer: Add comments to purgeCache()
..
installer: Add comments to purgeCache()
Change-Id: I791f220b49e3e1c7d6df9ccab7d7
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/382553 )
Change subject: jquery.ui: Fix various jQuery Migrate warnings
..
jquery.ui: Fix various jQuery Migrate warnings
These are the most common
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/382530 )
Change subject: jquery-migrate: Disable console.trace() call by default
..
jquery-migrate: Disable console.trace() call by default
They are
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/382529 )
Change subject: jquery-migrate: Remove redundant PATCH note for Deferred bug
..
jquery-migrate: Remove redundant PATCH note for Deferred bug
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/382519 )
Change subject: jquery-migrate: Disable console.trace() call by default
..
jquery-migrate: Disable console.trace() call by default
They are
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/382518 )
Change subject: jquery-migrate: Remove redundant PATCH note for Deferred bug
..
jquery-migrate: Remove redundant PATCH note for Deferred bug
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/382325 )
Change subject: zuul: Same duration for mini graphs and link to Grafana
..
zuul: Same duration for mini graphs and link to Grafana
* Some o
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/382319 )
Change subject: Use prop(, false) instead of removeAttr() to change properties
..
Use prop(, false) instead of removeAttr() to change proper
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/382230 )
Change subject: mediawiki.notification: Move offset() computation to next frame
..
mediawiki.notification: Move offset() computation to next
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/382229 )
Change subject: mediawiki.notification: Refactor $.ready handler and init()
..
mediawiki.notification: Refactor $.ready handler and init()
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/382228 )
Change subject: mediawiki.notification: Use css() instead of slow show()/hide()
..
mediawiki.notification: Use css() instead of slow show()/
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/382196 )
Change subject: Change use of deprecated jQuery.fn.hover() to on()
..
Change use of deprecated jQuery.fn.hover() to on()
Fixes:
> JQMIGRATE
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/382194 )
Change subject: Use on() instead of deprecated on()
..
Use on() instead of deprecated on()
Fixes:
> JQMIGRATE: jQuery.fn.bind() is deprecat
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/382191 )
Change subject: Use prop(, false) instead of removeAttr() to change properties
..
Use prop(, false) instead of removeAttr() to change proper
Hello Fomafix, jenkins-bot, Nikerabbit,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/382093
to review the following change.
Change subject: Revert "Use Language type hint in hooks"
..
Rev
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/382095 )
Change subject: Revert "Use Language type hint in hooks"
..
Revert "Use Language type hint in hooks"
This reverts commit d8572921ee11e0
Krinkle has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/382075 )
Change subject: Remove ancient PARSERFIRSTCALLINIT support
..
Remove ancient PARSERFIRSTCALLINIT support
Some whitespace removal to
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/382089 )
Change subject: Fix jQuery.fn.bind() call in mw.MediaWikiPlayer.loader.js
..
Fix jQuery.fn.bind() call in mw.MediaWikiPlayer.loader.js
This
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/382088 )
Change subject: Fix jQuery.fn.bind() call in mw.MediaWikiPlayer.loader.js
..
Fix jQuery.fn.bind() call in mw.MediaWikiPlayer.loader.js
This
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/382087 )
Change subject: Fix jQuery.fn.bind() call in mw.MediaWikiPlayer.loader.js
..
Fix jQuery.fn.bind() call in mw.MediaWikiPlayer.loader.js
This
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/382071 )
Change subject: Remove MediaWiki 1.11 compat
..
Remove MediaWiki 1.11 compat
ParserFirstCallInit added in 1.12 (10 years ago)
Change-Id: I
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/382070 )
Change subject: Remove MediaWiki 1.11 compat
..
Remove MediaWiki 1.11 compat
ParserFirstCallInit added in 1.12 (10 years ago)
Change-Id: I
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/382068 )
Change subject: Remove redundant $wgParser->_unstub() call
..
Remove redundant $wgParser->_unstub() call
It will unstub by itself (if it ha
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/382066 )
Change subject: Remove call to non-existant $wgOut->_unstub()
..
Remove call to non-existant $wgOut->_unstub()
This hasn't been a stub for
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/382039 )
Change subject: build: Remove unsupported --use-mirrors from pip command
..
build: Remove unsupported --use-mirrors from pip command
Travis
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/382022 )
Change subject: resourceloader: Add unit test for ClientHtml::makeLoad
sync=>true
..
resourceloader: Add unit test for ClientHtml::makeLoad
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/382021 )
Change subject: phpunit: Include all raw modules in detection of illegal
dependencies
..
phpunit: Include all raw modules in detection of i
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/381533 )
Change subject: mw.loader: Use Array#indexOf directly instead of jQuery.inArray
..
mw.loader: Use Array#indexOf directly instead of jQuery.i
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/381532 )
Change subject: mw.loader: Return consistent object shape from splitModuleKey()
..
mw.loader: Return consistent object shape from splitModul
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/381279 )
Change subject: puppetmaster: hacks to fix puppet logstash
..
puppetmaster: hacks to fix puppet logstash
Change-Id: Ifd697fbb81f26d78ae7c36
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/381275 )
Change subject: errorpage: Set explicit height on logo image
..
errorpage: Set explicit height on logo image
This prevents the browser from
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/381274 )
Change subject: errorpage: Migrate from back-compat wmf.png to wmf-logo.png
..
errorpage: Migrate from back-compat wmf.png to wmf-logo.png
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/381270 )
Change subject: objectcache: Improve WANObjectCache test coverage
..
objectcache: Improve WANObjectCache test coverage
class WANObjectCache
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/381020 )
Change subject: Fix undefined variable clusterNr
..
Fix undefined variable clusterNr
Bug: T176831
Change-Id: I0bdb31c4b8d94906bd346a405c93b
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/380884 )
Change subject: Update jQuery Migrate to v3.0.1
..
Update jQuery Migrate to v3.0.1
* Fixes IE9 issues with console.log.
* Add warning for $
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/380873 )
Change subject: Centralise database hostname handling
..
Centralise database hostname handling
* Remove deadcode for $cluster as integer.
*
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/380657 )
Change subject: objectcache: Improve WANObjectCache test coverage
..
objectcache: Improve WANObjectCache test coverage
class WANObjectCache
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/380559 )
Change subject: resourceloader: Remove deprecated
MessageBlobStore::insertMessageBlob
..
resourceloader: Remove deprecated MessageBlobStore
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/379953 )
Change subject: mediawiki/hhvm: Move fatal-error.php to Puppet
..
mediawiki/hhvm: Move fatal-error.php to Puppet
Moved here from operations
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/379947 )
Change subject: Enable jQuery 3 on Wiktionary sites
..
Enable jQuery 3 on Wiktionary sites
Bug: T124742
Change-Id: I48cedceab210518eb64f752
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/379949 )
Change subject: Enable jQuery 3 on all wikis
..
Enable jQuery 3 on all wikis
This effectively enables it for Wikipedia sites and various
sp
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/379948 )
Change subject: Enable jQuery 3 on most group1 wikis (non-Wikipedia)
..
Enable jQuery 3 on most group1 wikis (non-Wikipedia)
Bug: T124742
C
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/379943 )
Change subject: Various minor no-op cleaning (conventions, perf)
..
Various minor no-op cleaning (conventions, perf)
* Consistently use `/*
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/379944 )
Change subject: ext.wikimediaEvents.statsd: Return early in case of DNT
..
ext.wikimediaEvents.statsd: Return early in case of DNT
Change-I
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/379830 )
Change subject: [WIP] webperf: Add navtiming tests to puppet.git:/tox.ini
..
[WIP] webperf: Add navtiming tests to puppet.git:/tox.ini
Chan
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/379820 )
Change subject: webperf: Fix crash when event contains browser_major:null
..
webperf: Fix crash when event contains browser_major:null
We a
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/379688 )
Change subject: mw.loader: Simplify getVersion and getState
..
mw.loader: Simplify getVersion and getState
This undefined check no longer m
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/379681 )
Change subject: resourceloader: Use ES5 Array#filter instead of jQuery.grep
..
resourceloader: Use ES5 Array#filter instead of jQuery.grep
Krinkle has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/379516 )
Change subject: Enable dummy statsv URL for wikimediaevents
..
Enable dummy statsv URL for wikimediaevents
The requests 404, but it
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/379452 )
Change subject: Use jQuery on/off instead of deprecated bind/unbind
..
Use jQuery on/off instead of deprecated bind/unbind
Bug: T169385
Cha
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/379129 )
Change subject: Update DNT check to support IE 11 and Safari 7
..
Update DNT check to support IE 11 and Safari 7
Change-Id: Ie2341ffe6a596e
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/378986 )
Change subject: Setup: Merge PreConfigSetup into Setup.php
..
Setup: Merge PreConfigSetup into Setup.php
Follows-up 41ea7e2fefff65.
The fo
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/378804 )
Change subject: ext.eventLogging.subscriber: Don't wait for "load" if it
already happened
..
ext.eventLogging.subscriber: Don't wait for "l
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/378803 )
Change subject: Enable jQuery 3 on commons.wikimedia.org
..
Enable jQuery 3 on commons.wikimedia.org
Change-Id: Ibb70fc6b7f0497683d99a32158
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/378802 )
Change subject: Enable jQuery 3 on metawiki
..
Enable jQuery 3 on metawiki
Bug: T124742
Change-Id: Ie7531a88e0351b60e5f80423767e5acbf400d55
101 - 200 of 4836 matches
Mail list logo