[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Hiegyne: Remove unused global LESS vars wgMFThumbnailTiny an...

2017-07-21 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/366993 ) Change subject: Hiegyne: Remove unused global LESS vars wgMFThumbnailTiny and wgMFThumbnailSmall .. Hiegyne: Remove unused global LESS vars

[MediaWiki-commits] [Gerrit] mediawiki...XenForoAuth[master]: Avoid deprecated ResourceLoaderGetLessVars hook

2017-07-21 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/366992 ) Change subject: Avoid deprecated ResourceLoaderGetLessVars hook .. Avoid deprecated ResourceLoaderGetLessVars hook Bug: T140804 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: resourceloader: Soft-deprecate use of global LESS variables

2017-07-21 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/366990 ) Change subject: resourceloader: Soft-deprecate use of global LESS variables .. resourceloader: Soft-deprecate use of global LESS variables

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: rdbms: Refactor DatabaseTest

2017-07-20 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/366773 ) Change subject: rdbms: Refactor DatabaseTest .. rdbms: Refactor DatabaseTest * Move DatabaseTest and DatabaseSQLTest to libs, and remove

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: rdbms: Move DatabaseMysqlBaseTest to libs tests

2017-07-20 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/366772 ) Change subject: rdbms: Move DatabaseMysqlBaseTest to libs tests .. rdbms: Move DatabaseMysqlBaseTest to libs tests * Remove MediaWikiTestCa

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: maintenance: Consistently use hasOption() for boolean options

2017-07-19 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/366317 ) Change subject: maintenance: Consistently use hasOption() for boolean options .. maintenance: Consistently use hasOption() for boolean optio

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: maintenance: Add --dry-run option to deleteDefaultMessages.php

2017-07-18 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/366038 ) Change subject: maintenance: Add --dry-run option to deleteDefaultMessages.php .. maintenance: Add --dry-run option to deleteDefaultMessages

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: [WIP] resourceloader: Preload base modules request from star...

2017-07-17 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/365889 ) Change subject: [WIP] resourceloader: Preload base modules request from startup module .. [WIP] resourceloader: Preload base modules reques

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: [WIP] resourceloader: Add support for modules sending preloa...

2017-07-17 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/365888 ) Change subject: [WIP] resourceloader: Add support for modules sending preload headers .. [WIP] resourceloader: Add support for modules send

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: doc: Fix a few Example docs for PHP classes

2017-07-17 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/365885 ) Change subject: doc: Fix a few Example docs for PHP classes .. doc: Fix a few Example docs for PHP classes * "@example" is specifically for

[MediaWiki-commits] [Gerrit] integration/config[master]: Revert "test-skins should also run testsuite extensions"

2017-07-17 Thread Krinkle (Code Review)
Hello Paladox, Hashar, Pmiazga, Legoktm, jenkins-bot, Jdlrobson, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/365881 to review the following change. Change subject: Revert "test-skins should also run testsuite extensions" ..

[MediaWiki-commits] [Gerrit] mediawiki...Wikidata[master]: Backport 'qunit: Update testrunner' from Wikibase to Wikidata

2017-07-17 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/365864 ) Change subject: Backport 'qunit: Update testrunner' from Wikibase to Wikidata .. Backport 'qunit: Update testrunner' from Wikibase to Wikida

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: qunit: Update testrunner against changes in MediaWiki core

2017-07-17 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/365863 ) Change subject: qunit: Update testrunner against changes in MediaWiki core .. qunit: Update testrunner against changes in MediaWiki core Th

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Upgrade QUnit from v1.23.1 to v2.4.0

2017-07-17 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/365757 ) Change subject: Upgrade QUnit from v1.23.1 to v2.4.0 .. Upgrade QUnit from v1.23.1 to v2.4.0 Source https://code.jquery.com/qunit/qunit-2.

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: qunit: Prepare testrunner for QUnit 2

2017-07-17 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/365756 ) Change subject: qunit: Prepare testrunner for QUnit 2 .. qunit: Prepare testrunner for QUnit 2 * Nested modules: - Support for Sinon exte

[MediaWiki-commits] [Gerrit] mediawiki...EventLogging[master]: qunit: Avoid deprecated QUnit.asyncTest()

2017-07-17 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/365706 ) Change subject: qunit: Avoid deprecated QUnit.asyncTest() .. qunit: Avoid deprecated QUnit.asyncTest() * Return Promise where possible, oth

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: qunit: Add testrunner tests for nested modules and before/af...

2017-07-17 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/365688 ) Change subject: qunit: Add testrunner tests for nested modules and before/afterEach .. qunit: Add testrunner tests for nested modules and b

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: tests: Simplify Platform test beforeEach/afterEach logic

2017-07-17 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/365681 ) Change subject: tests: Simplify Platform test beforeEach/afterEach logic .. tests: Simplify Platform test beforeEach/afterEach logic * Remo

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Avoid deprecated QUnit.asyncTest() in ve.init.sa.Platform.test

2017-07-12 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/364938 ) Change subject: Avoid deprecated QUnit.asyncTest() in ve.init.sa.Platform.test .. Avoid deprecated QUnit.asyncTest() in ve.init.sa.Platform.

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: resourceloader: Avoid mw-exception log spam from PHPUnit tests

2017-07-12 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/364935 ) Change subject: resourceloader: Avoid mw-exception log spam from PHPUnit tests .. resourceloader: Avoid mw-exception log spam from PHPUnit t

[MediaWiki-commits] [Gerrit] mediawiki...MonoBook[master]: Remove "position: absolute" and z-index from #p-logo

2017-07-12 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/364934 ) Change subject: Remove "position: absolute" and z-index from #p-logo .. Remove "position: absolute" and z-index from #p-logo Follows-up (r2

[MediaWiki-commits] [Gerrit] mediawiki...CirrusSearch[master]: explore-similar: Use mw.util.getParamValue instead of mw.Uri

2017-07-12 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/364932 ) Change subject: explore-similar: Use mw.util.getParamValue instead of mw.Uri .. explore-similar: Use mw.util.getParamValue instead of mw.Uri

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: mediawiki.toc: Migrate test from deprecated asyncTest()

2017-07-11 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/364515 ) Change subject: mediawiki.toc: Migrate test from deprecated asyncTest() .. mediawiki.toc: Migrate test from deprecated asyncTest() Instead,

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: mw.loader: Avoid use of deprecated QUnit.asyncTest/QUnit.start

2017-07-11 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/364512 ) Change subject: mw.loader: Avoid use of deprecated QUnit.asyncTest/QUnit.start .. mw.loader: Avoid use of deprecated QUnit.asyncTest/QUnit.s

[MediaWiki-commits] [Gerrit] labs...guc[master]: i18n: Add docs for new results-lag-warning message

2017-07-10 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/364358 ) Change subject: i18n: Add docs for new results-lag-warning message .. i18n: Add docs for new results-lag-warning message Follows-up 38ad108

[MediaWiki-commits] [Gerrit] labs...guc[master]: api: Create q=replag API

2017-07-10 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/364356 ) Change subject: api: Create q=replag API .. api: Create q=replag API HTTP API for replag that is JSON-formatted, CORS-enabled, cacheable.

[MediaWiki-commits] [Gerrit] labs...guc[master]: frontend: Add warning if replag is high

2017-07-10 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/364357 ) Change subject: frontend: Add warning if replag is high .. frontend: Add warning if replag is high Bug: T170024 Change-Id: I745d568b07689e4

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: mw.loader: Log unknown modules in load() to console

2017-07-07 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/364006 ) Change subject: mw.loader: Log unknown modules in load() to console .. mw.loader: Log unknown modules in load() to console Follows-up If8ff

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: mw.loader: Skip modules in load() with unknown dependencies

2017-07-07 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/364005 ) Change subject: mw.loader: Skip modules in load() with unknown dependencies .. mw.loader: Skip modules in load() with unknown dependencies

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: resourceloader: Add unit tests for ResourceLoaderSkinModule

2017-07-07 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/364002 ) Change subject: resourceloader: Add unit tests for ResourceLoaderSkinModule .. resourceloader: Add unit tests for ResourceLoaderSkinModule

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseQualityConstraints[master]: Revert "Localisation updates from https://translatewiki.net."

2017-07-07 Thread Krinkle (Code Review)
Hello L10n-bot, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/364001 to review the following change. Change subject: Revert "Localisation updates from https://translatewiki.net."; .. Rever

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: qunit: Remove redundant conditional for sandbox teardown

2017-07-07 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363999 ) Change subject: qunit: Remove redundant conditional for sandbox teardown .. qunit: Remove redundant conditional for sandbox teardown Follow

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseQualityConstraints[master]: Update typehint for MediaWikiServices::getStatsdDataFactory

2017-07-07 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363998 ) Change subject: Update typehint for MediaWikiServices::getStatsdDataFactory .. Update typehint for MediaWikiServices::getStatsdDataFactory

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: statsd: Rename MediawikiStatsdDataFactory to IBufferingStats...

2017-07-07 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363997 ) Change subject: statsd: Rename MediawikiStatsdDataFactory to IBufferingStatsdDataFactory .. statsd: Rename MediawikiStatsdDataFactory to IB

[MediaWiki-commits] [Gerrit] labs...guc[master]: Use MediaWiki-like escaping for section link

2017-07-07 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363979 ) Change subject: Use MediaWiki-like escaping for section link .. Use MediaWiki-like escaping for section link Previously, an automatic edit

[MediaWiki-commits] [Gerrit] operations/puppet[production]: grafana: Fix broken "Total requests per minute" panel

2017-07-07 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363882 ) Change subject: grafana: Fix broken "Total requests per minute" panel .. grafana: Fix broken "Total requests per minute" panel This panel i

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: parser: Add unit tests for parser output flags ('showflags' ...

2017-07-06 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363758 ) Change subject: parser: Add unit tests for parser output flags ('showflags' option) .. parser: Add unit tests for parser output flags ('sho

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: parser: Add parser tests for 4 and 5 tildes in PST

2017-07-06 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363757 ) Change subject: parser: Add parser tests for 4 and 5 tildes in PST .. parser: Add parser tests for 4 and 5 tildes in PST Add logic in Parse

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: [WIP] deferred: Trying new tests without postActive flag

2017-07-06 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363664 ) Change subject: [WIP] deferred: Trying new tests without postActive flag .. [WIP] deferred: Trying new tests without postActive flag Change

[MediaWiki-commits] [Gerrit] mediawiki/vagrant[master]: eventlogging: Set base uri to "/event.gif"

2017-07-05 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363520 ) Change subject: eventlogging: Set base uri to "/event.gif" .. eventlogging: Set base uri to "/event.gif" Avoid hardcoding the host to local

[MediaWiki-commits] [Gerrit] operations...wikimedia-job-runner[master]: Archive old "wikimedia-job-runner" repo

2017-07-05 Thread Krinkle (Code Review)
Krinkle has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/363517 ) Change subject: Archive old "wikimedia-job-runner" repo .. Archive old "wikimedia-job-runner" repo This is in preparation for makin

[MediaWiki-commits] [Gerrit] integration/config[master]: Archive operations/debs/wikimedia-job-runner

2017-07-05 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363519 ) Change subject: Archive operations/debs/wikimedia-job-runner .. Archive operations/debs/wikimedia-job-runner See also I393eb7e8c5be910 Cha

[MediaWiki-commits] [Gerrit] operations...wikimedia-job-runner[master]: Archive old "wikimedia-job-runner" repo

2017-07-05 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363517 ) Change subject: Archive old "wikimedia-job-runner" repo .. Archive old "wikimedia-job-runner" repo This is in preparation for making the re

[MediaWiki-commits] [Gerrit] operations/puppet[production]: grafana: Add legend to dashboard varnish-aggregate-client-st...

2017-07-03 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363111 ) Change subject: grafana: Add legend to dashboard varnish-aggregate-client-status-codes .. grafana: Add legend to dashboard varnish-aggregat

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Skin: Use WANObjectCache for sitenotice caching

2017-06-30 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/362608 ) Change subject: Skin: Use WANObjectCache for sitenotice caching .. Skin: Use WANObjectCache for sitenotice caching * Move the md5() hash to

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Use LocalServerObjectCache service instead wfGetCache

2017-06-30 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/362607 ) Change subject: Use LocalServerObjectCache service instead wfGetCache .. Use LocalServerObjectCache service instead wfGetCache Follows-up 1

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: resourceloader: Minor documentation and coding style improve...

2017-06-30 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/362603 ) Change subject: resourceloader: Minor documentation and coding style improvements .. resourceloader: Minor documentation and coding style i

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Simplify and document SkinMinerva::getDefaultModules()

2017-06-30 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/362471 ) Change subject: Simplify and document SkinMinerva::getDefaultModules() .. Simplify and document SkinMinerva::getDefaultModules() * Put the

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: Remove no-op onSkinMinervaDefaultModules hook logic

2017-06-30 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/362469 ) Change subject: Remove no-op onSkinMinervaDefaultModules hook logic .. Remove no-op onSkinMinervaDefaultModules hook logic There is no long

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Remove no-op onSkinMinervaDefaultModules hook handler

2017-06-30 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/362470 ) Change subject: Remove no-op onSkinMinervaDefaultModules hook handler .. Remove no-op onSkinMinervaDefaultModules hook handler There is no

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Move wgBreakFrame client code from mediawiki.page.startup

2017-06-30 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/362465 ) Change subject: Move wgBreakFrame client code from mediawiki.page.startup .. Move wgBreakFrame client code from mediawiki.page.startup Foll

[MediaWiki-commits] [Gerrit] mediawiki...OpenStackManager[master]: Split ext.openstack.base JavaScript from ext.openstack style...

2017-06-29 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/362260 ) Change subject: Split ext.openstack.base JavaScript from ext.openstack style module .. Split ext.openstack.base JavaScript from ext.opensta

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: resourceloader: Improve ResourceLoaderClientHtmlTest tests

2017-06-28 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/362120 ) Change subject: resourceloader: Improve ResourceLoaderClientHtmlTest tests .. resourceloader: Improve ResourceLoaderClientHtmlTest tests Th

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: resourceloader: Restrict addModuleStyles() to type=styles mo...

2017-06-28 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/362121 ) Change subject: resourceloader: Restrict addModuleStyles() to type=styles modules .. resourceloader: Restrict addModuleStyles() to type=sty

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: jsminplus: Fix JSNode memory leak from 'continue' statements

2017-06-28 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/362117 ) Change subject: jsminplus: Fix JSNode memory leak from 'continue' statements .. jsminplus: Fix JSNode memory leak from 'continue' statements

[MediaWiki-commits] [Gerrit] operations/puppet[production]: xenon: Increase hourly retention from 1 to 14 days

2017-06-28 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/362114 ) Change subject: xenon: Increase hourly retention from 1 to 14 days .. xenon: Increase hourly retention from 1 to 14 days Current sizes: mw

[MediaWiki-commits] [Gerrit] performance/docroot[master]: build: Add package-lock.json (npm v5) to gitignore

2017-06-28 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/362112 ) Change subject: build: Add package-lock.json (npm v5) to gitignore .. build: Add package-lock.json (npm v5) to gitignore Change-Id: I717033

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Disable wgEnableJavaScriptTest on test2wiki

2017-06-28 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/362109 ) Change subject: Disable wgEnableJavaScriptTest on test2wiki .. Disable wgEnableJavaScriptTest on test2wiki When I added this special page i

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: filecache: Use current action instead of "view" only in outa...

2017-06-27 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361813 ) Change subject: filecache: Use current action instead of "view" only in outage mode .. filecache: Use current action instead of "view" only

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: resourceloader: Use "\n" instead of "; " as separator for scr...

2017-06-27 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361810 ) Change subject: resourceloader: Use "\n" instead of ";" as separator for scripts .. resourceloader: Use "\n" instead of ";" as separator for

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: resourceloader: Add more concat test cases for makeModuleRes...

2017-06-27 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361806 ) Change subject: resourceloader: Add more concat test cases for makeModuleResponse .. resourceloader: Add more concat test cases for makeMod

[MediaWiki-commits] [Gerrit] operations/puppet[production]: mediawiki: Remove broken wikidata.org/ontology Apache alias

2017-06-27 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361801 ) Change subject: mediawiki: Remove broken wikidata.org/ontology Apache alias .. mediawiki: Remove broken wikidata.org/ontology Apache alias

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: resourceloader: Add @covers for stripBom and makeModuleRespo...

2017-06-26 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361623 ) Change subject: resourceloader: Add @covers for stripBom and makeModuleResponse tests .. resourceloader: Add @covers for stripBom and makeM

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: resourceloader: Add basic tests for getScript() and buildCon...

2017-06-26 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361622 ) Change subject: resourceloader: Add basic tests for getScript() and buildContent() .. resourceloader: Add basic tests for getScript() and b

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: resourceloader: Add @covers for stripBom() test

2017-06-26 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361620 ) Change subject: resourceloader: Add @covers for stripBom() test .. resourceloader: Add @covers for stripBom() test Change-Id: I3403b6617121

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: resourceloader: Complete test coverage for FileModule::getTe...

2017-06-26 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361619 ) Change subject: resourceloader: Complete test coverage for FileModule::getTemplates() .. resourceloader: Complete test coverage for FileMod

[MediaWiki-commits] [Gerrit] integration/config[master]: Revert "Remove packages from Trusty instances"

2017-06-26 Thread Krinkle (Code Review)
Hello Paladox, Hashar, jenkins-bot, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/361496 to review the following change. Change subject: Revert "Remove packages from Trusty instances" .. R

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: mediawiki.Title: Remove needless $.type() and minor clean up

2017-06-23 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361196 ) Change subject: mediawiki.Title: Remove needless $.type() and minor clean up .. mediawiki.Title: Remove needless $.type() and minor clean up

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: resourceloader: Backport jquery-migrate.js patch for excepti...

2017-06-22 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/360999 ) Change subject: resourceloader: Backport jquery-migrate.js patch for exceptionHook .. resourceloader: Backport jquery-migrate.js patch for

[MediaWiki-commits] [Gerrit] rcstream[master]: Archive repository

2017-06-22 Thread Krinkle (Code Review)
Krinkle has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/360955 ) Change subject: Archive repository .. Archive repository This experimental port of RCStream from Python to Node.js was never finish

[MediaWiki-commits] [Gerrit] rcstream[master]: Archive repository

2017-06-22 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/360955 ) Change subject: Archive repository .. Archive repository This experimental port of RCStream from Python to Node.js was never finished and n

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: resourceloader: Add unit tests for ResourceLoader::isFileModule

2017-06-21 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/360693 ) Change subject: resourceloader: Add unit tests for ResourceLoader::isFileModule .. resourceloader: Add unit tests for ResourceLoader::isFile

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: static/images: Restore dimensions of wmf.png

2017-06-21 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/360652 ) Change subject: static/images: Restore dimensions of wmf.png .. static/images: Restore dimensions of wmf.png Follows-up 94703bf5ab3902b267d

[MediaWiki-commits] [Gerrit] mediawiki...examples[master]: Revert "API: Split description messages into summary + addit...

2017-06-20 Thread Krinkle (Code Review)
Hello jenkins-bot, Siebrand, Anomie, Jforrester, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/360356 to review the following change. Change subject: Revert "API: Split description messages into summary + additional text" ..

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: build: Remove Travis CI allow_failure for Postgres

2017-06-15 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/359245 ) Change subject: build: Remove Travis CI allow_failure for Postgres .. build: Remove Travis CI allow_failure for Postgres Now passing! Foll

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: mediawiki.storage: Document 'null' return from get()

2017-06-15 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/359244 ) Change subject: mediawiki.storage: Document 'null' return from get() .. mediawiki.storage: Document 'null' return from get() Follows-up 7da

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: benchmarks: Add reporting of resource usage

2017-06-15 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/359190 ) Change subject: benchmarks: Add reporting of resource usage .. benchmarks: Add reporting of resource usage Change-Id: Ied06766cd02b14d835ed

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: [WIP] benchmarks: Add benchmark for JSMinPlus

2017-06-15 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/359191 ) Change subject: [WIP] benchmarks: Add benchmark for JSMinPlus .. [WIP] benchmarks: Add benchmark for JSMinPlus Example usage > mwscript ma

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.30.0-wmf.5]: objectcache: Forward MultiWriteBagOStuff::makeKey to primary...

2017-06-15 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/359144 ) Change subject: objectcache: Forward MultiWriteBagOStuff::makeKey to primary backend .. objectcache: Forward MultiWriteBagOStuff::makeKey t

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: objectcache: Forward MultiWriteBagOStuff::makeKey to primary...

2017-06-14 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/358999 ) Change subject: objectcache: Forward MultiWriteBagOStuff::makeKey to primary backend .. objectcache: Forward MultiWriteBagOStuff::makeKey t

[MediaWiki-commits] [Gerrit] mediawiki...release[master]: make-deploy-notes: Update usage example

2017-06-12 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/358486 ) Change subject: make-deploy-notes: Update usage example .. make-deploy-notes: Update usage example Change-Id: I0fe174170c1e44f963d2fca19902

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: eventLogging: Use base 32 instead of 16 for fnv-encoded hash

2017-06-12 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/358447 ) Change subject: eventLogging: Use base 32 instead of 16 for fnv-encoded hash .. eventLogging: Use base 32 instead of 16 for fnv-encoded hash

[MediaWiki-commits] [Gerrit] operations/puppet[production]: [WIP] mediawiki: Fix error page template issues

2017-06-12 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/358430 ) Change subject: [WIP] mediawiki: Fix error page template issues .. [WIP] mediawiki: Fix error page template issues Follows-up f8c7814308d2.

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: RELEASE-NOTES: OutputPage::enableTOC was removed

2017-06-12 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/358404 ) Change subject: RELEASE-NOTES: OutputPage::enableTOC was removed .. RELEASE-NOTES: OutputPage::enableTOC was removed Follows-up c7e00974c7e

[MediaWiki-commits] [Gerrit] mediawiki/core[REL1_29]: Make DeferredUpdates detect LBFactory transaction rounds

2017-06-10 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/358172 ) Change subject: Make DeferredUpdates detect LBFactory transaction rounds .. Make DeferredUpdates detect LBFactory transaction rounds Previo

[MediaWiki-commits] [Gerrit] mediawiki/core[REL1_29]: Keep wgUsejQueryThree disabled by default.

2017-06-07 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/357664 ) Change subject: Keep wgUsejQueryThree disabled by default. .. Keep wgUsejQueryThree disabled by default. The process of discovering and res

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Keep wgUsejQueryThree disabled by default.

2017-06-07 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/357662 ) Change subject: Keep wgUsejQueryThree disabled by default. .. Keep wgUsejQueryThree disabled by default. The process of discovering and res

[MediaWiki-commits] [Gerrit] mediawiki...Gadgets[master]: Move gadget styles from main stylesheet request to site request

2017-06-07 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/357657 ) Change subject: Move gadget styles from main stylesheet request to site request .. Move gadget styles from main stylesheet request to site r

[MediaWiki-commits] [Gerrit] performance/docroot[master]: build: Update eslint-config-wikimedia to v0.4.0

2017-06-05 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/357200 ) Change subject: build: Update eslint-config-wikimedia to v0.4.0 .. build: Update eslint-config-wikimedia to v0.4.0 Further completes the au

[MediaWiki-commits] [Gerrit] oojs/core[master]: package.json: Tag v2.1.0

2017-05-30 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/356315 ) Change subject: package.json: Tag v2.1.0 .. package.json: Tag v2.1.0 Change-Id: I0b0cedf78d9707de0414ac7f995bb0e4aca31334 --- M package.jso

[MediaWiki-commits] [Gerrit] oojs/core[master]: Tag v2.1.0

2017-05-30 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/356310 ) Change subject: Tag v2.1.0 .. Tag v2.1.0 Change-Id: I71ef211f05e2ac4bb3342a68094cd5b54aca0ecf --- M History.md 1 file changed, 9 insertions

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: jquery.makeCollapsible: Restore considering empty as par...

2017-05-25 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/355715 ) Change subject: jquery.makeCollapsible: Restore considering empty as part of toggle .. jquery.makeCollapsible: Restore considering empty

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Revert "Creating new WMF 1.30.0-wmf.2 branch"

2017-05-25 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/355704 ) Change subject: Revert "Creating new WMF 1.30.0-wmf.2 branch" .. Revert "Creating new WMF 1.30.0-wmf.2 branch" Also revert the automatic "U

[MediaWiki-commits] [Gerrit] operations/puppet[production]: [WIP] varnish: Try to somehow embed errorpage template in VC...

2017-05-25 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/355652 ) Change subject: [WIP] varnish: Try to somehow embed errorpage template in VCL directly .. [WIP] varnish: Try to somehow embed errorpage tem

[MediaWiki-commits] [Gerrit] mediawiki/core[REL1_29]: rdbms: Add compat alias for renamed LBFactory class

2017-05-25 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/355610 ) Change subject: rdbms: Add compat alias for renamed LBFactory class .. rdbms: Add compat alias for renamed LBFactory class This was renamed

[MediaWiki-commits] [Gerrit] mediawiki...wikihiero[wmf/1.30.0-wmf.2]: Fix styles queue violation for "ext.wikihiero.Special"

2017-05-24 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/355441 ) Change subject: Fix styles queue violation for "ext.wikihiero.Special" .. Fix styles queue violation for "ext.wikihiero.Special" The same m

[MediaWiki-commits] [Gerrit] mediawiki...wikihiero[master]: Fix styles queue violation for "ext.wikihiero.Special"

2017-05-24 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/355439 ) Change subject: Fix styles queue violation for "ext.wikihiero.Special" .. Fix styles queue violation for "ext.wikihiero.Special" The same m

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.30.0-wmf.2]: Restore dependency on module 'mediawiki.page.startup'

2017-05-24 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/355437 ) Change subject: Restore dependency on module 'mediawiki.page.startup' .. Restore dependency on module 'mediawiki.page.startup' Module 'medi

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: rdbms: Add compat alias for renamed LBFactory class

2017-05-24 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/355422 ) Change subject: rdbms: Add compat alias for renamed LBFactory class .. rdbms: Add compat alias for renamed LBFactory class This was renamed

[MediaWiki-commits] [Gerrit] operations/puppet[production]: varnish: Switch browsersec to use errorpage template

2017-05-23 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/355338 ) Change subject: varnish: Switch browsersec to use errorpage template .. varnish: Switch browsersec to use errorpage template Follows-up b90

<    1   2   3   4   5   6   7   8   9   10   >