Mssola has uploaded a new change for review. https://gerrit.wikimedia.org/r/191852
Change subject: maintenance: Revert a workaround for an HHVM bug in readline() ...................................................................... maintenance: Revert a workaround for an HHVM bug in readline() The commit 97a802407ecc2455e938dc02accd43ebb86204ae added a workaround for a bug in HHVM. This issue has been closed, as can bee seen in: https://github.com/facebook/hhvm/issues/4776 Change-Id: Ia7f867ab60c8a89b9f8f35859127c79b1e1fde4f --- M maintenance/Maintenance.php 1 file changed, 1 insertion(+), 7 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/52/191852/1 diff --git a/maintenance/Maintenance.php b/maintenance/Maintenance.php index af14bb3..9b98b20 100644 --- a/maintenance/Maintenance.php +++ b/maintenance/Maintenance.php @@ -1207,13 +1207,7 @@ } if ( $isatty && function_exists( 'readline' ) ) { - $resp = readline( $prompt ); - if ( $resp === null ) { - // Workaround for https://github.com/facebook/hhvm/issues/4776 - return false; - } else { - return $resp; - } + return readline( $prompt ); } else { if ( $isatty ) { $st = self::readlineEmulation( $prompt ); -- To view, visit https://gerrit.wikimedia.org/r/191852 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia7f867ab60c8a89b9f8f35859127c79b1e1fde4f Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Mssola <mikisab...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
