[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Special:RC filter: hidehumans

2016-11-14 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/321479 Change subject: Special:RC filter: hidehumans .. Special:RC filter: hidehumans Allows showing only bot edits Will be used by the ERI

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: [PoC] 'hidemajor' RC filter

2016-11-08 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/320446 Change subject: [PoC] 'hidemajor' RC filter .. [PoC] 'hidemajor' RC filter 'hidemajor', along with the existing 'hideminor' RC filter, allow

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: [PoC] edit authorship RC filter

2016-11-08 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/320402 Change subject: [PoC] edit authorship RC filter .. [PoC] edit authorship RC filter 'editauthorship' is a superset of 'hidemyself'. It allows

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: Filter newOnly contribution in query instead of in formatter

2016-11-07 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/320201 Change subject: Filter newOnly contribution in query instead of in formatter .. Filter newOnly contribution in query instead of in formatter

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: DBError expects IDatabase|null as its first argument

2016-11-01 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/319088 Change subject: DBError expects IDatabase|null as its first argument .. DBError expects IDatabase|null as its first argument I came across

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: Browser tests: update beta feature selector

2016-10-24 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/317553 Change subject: Browser tests: update beta feature selector .. Browser tests: update beta feature selector Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: [WIP] Remove index layer

2016-10-18 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/316689 Change subject: [WIP] Remove index layer .. [WIP] Remove index layer Bug: T147058 Change-Id: I94fa23845797c94b84f062ffd97dce22a021e9c5 --- M

[MediaWiki-commits] [Gerrit] mediawiki...Echo[master]: [WIP] phpunit API tests for get notifications

2016-10-13 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/315702 Change subject: [WIP] phpunit API tests for get notifications .. [WIP] phpunit API tests for get notifications Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: Recompile templates

2016-10-04 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/314065 Change subject: Recompile templates .. Recompile templates Followup to I76979c38571e9e822899b20f3f2904c2b0d54d55 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...ORES[master]: [PoC] Produce ReviewStream from ORES extension

2016-10-03 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/313850 Change subject: [PoC] Produce ReviewStream from ORES extension .. [PoC] Produce ReviewStream from ORES extension Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/event-schemas[master]: Schema for ERI ReviewStream topic

2016-10-03 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/313848 Change subject: Schema for ERI ReviewStream topic .. Schema for ERI ReviewStream topic Change-Id: I302a5da7d4639403a4876ae7e6a8917a63883924

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: BoardMover: don't try to save a null edit

2016-09-27 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/313052 Change subject: BoardMover: don't try to save a null edit .. BoardMover: don't try to save a null edit BoardMover assists in the move of

[MediaWiki-commits] [Gerrit] mediawiki...EventBus[master]: Adding data needed by ERI

2016-09-22 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/312277 Change subject: Adding data needed by ERI .. Adding data needed by ERI user_edit_count user_registration rev_bytes_changes

[MediaWiki-commits] [Gerrit] mediawiki/event-schemas[master]: Adding fields needed by the ERI project

2016-09-22 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/312274 Change subject: Adding fields needed by the ERI project .. Adding fields needed by the ERI project user_edit_count user_registration

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: Don't crash when a revision is not found

2016-09-15 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/310961 Change subject: Don't crash when a revision is not found .. Don't crash when a revision is not found In some cases (to be discovered), the

[MediaWiki-commits] [Gerrit] mediawiki...Echo[master]: resetNotificationCount() from replica with no lag

2016-09-12 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/310063 Change subject: resetNotificationCount() from replica with no lag .. resetNotificationCount() from replica with no lag When notifications

[MediaWiki-commits] [Gerrit] mediawiki...Echo[master]: Actually insert target page entries when creating an Event

2016-09-12 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/310058 Change subject: Actually insert target page entries when creating an Event .. Actually insert target page entries when creating an Event

[MediaWiki-commits] [Gerrit] mediawiki...Echo[master]: Browser tests: wait for notifications to be loaded

2016-09-08 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/309296 Change subject: Browser tests: wait for notifications to be loaded .. Browser tests: wait for notifications to be loaded When waiting for

[MediaWiki-commits] [Gerrit] mediawiki...Echo[master]: [WIP] Remove etp_user

2016-09-07 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/309051 Change subject: [WIP] Remove etp_user .. [WIP] Remove etp_user Target page entries used to exist for each user that was notified for an

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: Show board description content only at the end

2016-09-06 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/308752 Change subject: Show board description content only at the end .. Show board description content only at the end Call widget.showContent(

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: Fix category update

2016-09-02 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/308184 Change subject: Fix category update .. Fix category update Following I1e90b56cc80041d70fb9158ac4f027285ad0f2c9 updates of board categories

[MediaWiki-commits] [Gerrit] mediawiki...Echo[master]: Provide title when parsing wikitext

2016-09-01 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/308115 Change subject: Provide title when parsing wikitext .. Provide title when parsing wikitext Bug: T141460 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: Allow moderating resolved topic

2016-09-01 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/308116 Change subject: Allow moderating resolved topic .. Allow moderating resolved topic * Add 'suppress' and 'delete' actions to resolved topic *

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: [WIP] Update Flow caching strategy for multi DC

2016-09-01 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/307951 Change subject: [WIP] Update Flow caching strategy for multi DC .. [WIP] Update Flow caching strategy for multi DC * Invalidate cache on

[MediaWiki-commits] [Gerrit] mediawiki...Echo[master]: Loading notifications starting with one big local bundle

2016-08-26 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/306901 Change subject: Loading notifications starting with one big local bundle .. Loading notifications starting with one big local bundle Redo of

[MediaWiki-commits] [Gerrit] mediawiki...Echo[master]: Get the overfetched before bundling to avoid removing the base

2016-08-24 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/306481 Change subject: Get the overfetched before bundling to avoid removing the base .. Get the overfetched before bundling to avoid removing the

[MediaWiki-commits] [Gerrit] mediawiki...Echo[master]: Don't select echo_event.*

2016-08-24 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/306465 Change subject: Don't select echo_event.* .. Don't select echo_event.* Removed fetchByTypesAndPage since it is now unused Fixed fetchByPage

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: Fix notification cleanup on post moderation

2016-08-12 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/304480 Change subject: Fix notification cleanup on post moderation .. Fix notification cleanup on post moderation Including 'flow-thank' in the

[MediaWiki-commits] [Gerrit] mediawiki...WikiLove[master]: Browser tests: update to mw-selenium 1.7.2 and https

2016-08-12 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/304467 Change subject: Browser tests: update to mw-selenium 1.7.2 and https .. Browser tests: update to mw-selenium 1.7.2 and https Bug: T129483

[MediaWiki-commits] [Gerrit] mediawiki...PageTriage[master]: Browser tests: update to mw-selenium 1.7.2 and https

2016-08-11 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/304307 Change subject: Browser tests: update to mw-selenium 1.7.2 and https .. Browser tests: update to mw-selenium 1.7.2 and https Bug: T129483

[MediaWiki-commits] [Gerrit] mediawiki...Echo[master]: Browser tests: update to mw-selenium 1.7.2 and https

2016-08-11 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/304305 Change subject: Browser tests: update to mw-selenium 1.7.2 and https .. Browser tests: update to mw-selenium 1.7.2 and https Bug: T129483

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Enabling thank-you-edit on beta for testing.

2016-08-09 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/303957 Change subject: Enabling thank-you-edit on beta for testing. .. Enabling thank-you-edit on beta for testing. Still disabled in prod. Bug:

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Revert "Temporarily disable thank-you-edit notifications"

2016-08-09 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/303890 Change subject: Revert "Temporarily disable thank-you-edit notifications" .. Revert "Temporarily disable thank-you-edit notifications" This

[MediaWiki-commits] [Gerrit] mediawiki...Echo[master]: Output wgNotificationsSpecialPageLinks js var even if no loc...

2016-08-05 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/303158 Change subject: Output wgNotificationsSpecialPageLinks js var even if no local notifications .. Output wgNotificationsSpecialPageLinks js

[MediaWiki-commits] [Gerrit] mediawiki...Echo[master]: Enable local bundles on mobile

2016-08-04 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/302927 Change subject: Enable local bundles on mobile .. Enable local bundles on mobile Have the 'bundle' param always controlled by the controller

[MediaWiki-commits] [Gerrit] mediawiki...Echo[master]: Mark all notifications in a foreign bundle as read

2016-08-03 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/302817 Change subject: Mark all notifications in a foreign bundle as read .. Mark all notifications in a foreign bundle as read Foreign

[MediaWiki-commits] [Gerrit] mediawiki...Echo[master]: Prevent duplicate thank-you-edit notifications

2016-08-03 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/302759 Change subject: Prevent duplicate thank-you-edit notifications .. Prevent duplicate thank-you-edit notifications Avoid duplicate by looking

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Keep $user->mEditCount up to date

2016-08-03 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/302722 Change subject: Keep $user->mEditCount up to date .. Keep $user->mEditCount up to date Whenever User::incEditCount() is called, this tries

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: Browser tests: fix notifications locator

2016-08-02 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/302518 Change subject: Browser tests: fix notifications locator .. Browser tests: fix notifications locator Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: Include style for bytes added/removes on history page

2016-08-02 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/302494 Change subject: Include style for bytes added/removes on history page .. Include style for bytes added/removes on history page Bug: T139503

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: Add patrol link to topic summary page

2016-08-02 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/302489 Change subject: Add patrol link to topic summary page .. Add patrol link to topic summary page Bug: T141834 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Echo[master]: Maintenance: moderate notifications linked to missing pages

2016-08-02 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/302480 Change subject: Maintenance: moderate notifications linked to missing pages .. Maintenance: moderate notifications linked to missing pages

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: [WIP] Fix patrolling links

2016-07-29 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/301868 Change subject: [WIP] Fix patrolling links .. [WIP] Fix patrolling links The patrolling link was missing data-mw="interface" for the JS to

[MediaWiki-commits] [Gerrit] mediawiki...EducationProgram[master]: Cleanup old notifications config

2016-07-29 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/301810 Change subject: Cleanup old notifications config .. Cleanup old notifications config Bug: T121612 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Echo[master]: Generate sample notifications: Education Program

2016-07-29 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/301809 Change subject: Generate sample notifications: Education Program .. Generate sample notifications: Education Program Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Echo[master]: Generate sample events: add 'reason' to user-rights

2016-07-28 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/301626 Change subject: Generate sample events: add 'reason' to user-rights .. Generate sample events: add 'reason' to user-rights Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Thanks[master]: flow-thank: add a target-page entry for the topic page

2016-07-28 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/301617 Change subject: flow-thank: add a target-page entry for the topic page .. flow-thank: add a target-page entry for the topic page The

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: Moderate events that don't have target-page entries

2016-07-28 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/301618 Change subject: Moderate events that don't have target-page entries .. Moderate events that don't have target-page entries Use EventMapper

[MediaWiki-commits] [Gerrit] mediawiki...Echo[master]: [WIP] Moderate notifications

2016-07-27 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/301382 Change subject: [WIP] Moderate notifications .. [WIP] Moderate notifications * When a page is deleted, moderate associated notifications.

[MediaWiki-commits] [Gerrit] mediawiki...Echo[master]: Process bundled notifications when the base is filtered out

2016-07-26 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/301187 Change subject: Process bundled notifications when the base is filtered out .. Process bundled notifications when the base is filtered out

[MediaWiki-commits] [Gerrit] mediawiki...Echo[master]: Paginate even if some events are filtered out

2016-07-25 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/300951 Change subject: Paginate even if some events are filtered out .. Paginate even if some events are filtered out When requesting

[MediaWiki-commits] [Gerrit] mediawiki...Echo[master]: Browser tests: update local url

2016-07-25 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/300941 Change subject: Browser tests: update local url .. Browser tests: update local url Change-Id: I9284acd37bfba51a53ddc1385eaad626e5592fa0 ---

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: Delete 'flow-thank' on moderated topic/post

2016-07-25 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/300898 Change subject: Delete 'flow-thank' on moderated topic/post .. Delete 'flow-thank' on moderated topic/post Bug: T93673 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Echo[master]: Special:Notifications (no-js): filter out deleted events

2016-07-25 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/300897 Change subject: Special:Notifications (no-js): filter out deleted events .. Special:Notifications (no-js): filter out deleted events

[MediaWiki-commits] [Gerrit] mediawiki/vagrant[master]: confirmedit: s/requires/require

2016-07-25 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/300869 Change subject: confirmedit: s/requires/require .. confirmedit: s/requires/require Change-Id: I872bb489a70877d533ac15abc1a6cca07275b4c0

[MediaWiki-commits] [Gerrit] Documentation for EventPresentationModel - change (mediawiki...Echo)

2016-07-21 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/300305 Change subject: Documentation for EventPresentationModel .. Documentation for EventPresentationModel Change-Id:

[MediaWiki-commits] [Gerrit] Exclude deleted event from UnreadNotificationPages API - change (mediawiki...Echo)

2016-07-21 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/300273 Change subject: Exclude deleted event from UnreadNotificationPages API .. Exclude deleted event from UnreadNotificationPages API Change-Id:

[MediaWiki-commits] [Gerrit] Cleanup old notification config - change (mediawiki...OpenStackManager)

2016-07-20 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/300072 Change subject: Cleanup old notification config .. Cleanup old notification config Bug: T121612 Change-Id:

[MediaWiki-commits] [Gerrit] Cleanup old notification config - change (mediawiki...ContentTranslation)

2016-07-20 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/300066 Change subject: Cleanup old notification config .. Cleanup old notification config Bug: T121612 Change-Id:

[MediaWiki-commits] [Gerrit] Cleanup old notification config - change (mediawiki...Thanks)

2016-07-20 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/300042 Change subject: Cleanup old notification config .. Cleanup old notification config * Remove unused formatters * Remove old formatter config

[MediaWiki-commits] [Gerrit] Cleanup old notifications config - change (mediawiki...Flow)

2016-07-20 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/300037 Change subject: Cleanup old notifications config .. Cleanup old notifications config * Remove old formatters * Remove old notifications

[MediaWiki-commits] [Gerrit] Remove deprecated formatter - change (mediawiki...Echo)

2016-07-20 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/300032 Change subject: Remove deprecated formatter .. Remove deprecated formatter Followup to I639b9d9906d3ff37021cb9b5ed3cb401354b5bd9 * Remove

[MediaWiki-commits] [Gerrit] Add tooltips to page filters - change (mediawiki...Echo)

2016-07-13 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/298730 Change subject: Add tooltips to page filters .. Add tooltips to page filters Bug: T139644 Change-Id:

[MediaWiki-commits] [Gerrit] Don't show 'start a new topic twice' - change (mediawiki...Flow)

2016-07-13 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/298722 Change subject: Don't show 'start a new topic twice' .. Don't show 'start a new topic twice' Include the style that controls the overlay on

[MediaWiki-commits] [Gerrit] Generate notifications: fix rollback session failure - change (mediawiki...Echo)

2016-07-12 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/298471 Change subject: Generate notifications: fix rollback session failure .. Generate notifications: fix rollback session failure Change-Id:

[MediaWiki-commits] [Gerrit] Use the right compact msg for flowusertalk-* expandable noti... - change (mediawiki...Flow)

2016-07-07 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/297888 Change subject: Use the right compact msg for flowusertalk-* expandable notifications .. Use the right compact msg for flowusertalk-*

[MediaWiki-commits] [Gerrit] Undefined property: stdClass::$event_deleted - change (mediawiki...Echo)

2016-07-07 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/297831 Change subject: Undefined property: stdClass::$event_deleted .. Undefined property: stdClass::$event_deleted Make sure this property is set

[MediaWiki-commits] [Gerrit] compact-header should be parse because it includes formatting - change (mediawiki...Echo)

2016-07-07 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/297821 Change subject: compact-header should be parse because it includes formatting .. compact-header should be parse because it includes

[MediaWiki-commits] [Gerrit] flow-post-reply: show compact header on one line - change (mediawiki...Flow)

2016-07-07 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/297820 Change subject: flow-post-reply: show compact header on one line .. flow-post-reply: show compact header on one line Bug: T139602 Change-Id:

[MediaWiki-commits] [Gerrit] Correct section (alert/message/all) - change (mediawiki...Echo)

2016-07-07 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/297792 Change subject: Correct section (alert/message/all) .. Correct section (alert/message/all) Fix issue where it said 'View x messages' in the

[MediaWiki-commits] [Gerrit] Simplify compact headers so they don't under- or over-parse - change (mediawiki...Flow)

2016-07-07 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/297788 Change subject: Simplify compact headers so they don't under- or over-parse .. Simplify compact headers so they don't under- or over-parse

[MediaWiki-commits] [Gerrit] Check for empty array before calling max() - change (mediawiki...Echo)

2016-07-07 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/297785 Change subject: Check for empty array before calling max() .. Check for empty array before calling max() When trying to find the max

[MediaWiki-commits] [Gerrit] Followup to I95dc3d70c8: Get rid of job queue entry for emai... - change (mediawiki...Echo)

2016-07-07 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/297780 Change subject: Followup to I95dc3d70c8: Get rid of job queue entry for email bundling .. Followup to I95dc3d70c8: Get rid of job queue

[MediaWiki-commits] [Gerrit] Special:Notifications JS even when no local notifications - change (mediawiki...Echo)

2016-07-06 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/297633 Change subject: Special:Notifications JS even when no local notifications .. Special:Notifications JS even when no local notifications

[MediaWiki-commits] [Gerrit] Sort bundled notifications by read status AND timestamp - change (mediawiki...Echo)

2016-07-06 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/297614 Change subject: Sort bundled notifications by read status AND timestamp .. Sort bundled notifications by read status AND timestamp

[MediaWiki-commits] [Gerrit] Followup Iae32cbf82cdb: Set width to Special:Notifications - change (mediawiki...Echo)

2016-07-06 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/297594 Change subject: Followup Iae32cbf82cdb: Set width to Special:Notifications .. Followup Iae32cbf82cdb: Set width to Special:Notifications

[MediaWiki-commits] [Gerrit] [WIP] Notification count: don't assume 'all' - change (mediawiki...Echo)

2016-07-05 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/297509 Change subject: [WIP] Notification count: don't assume 'all' .. [WIP] Notification count: don't assume 'all' Change-Id:

[MediaWiki-commits] [Gerrit] [WIP] Keep bundled notification compact header on one line - change (mediawiki...Echo)

2016-07-05 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/297431 Change subject: [WIP] Keep bundled notification compact header on one line .. [WIP] Keep bundled notification compact header on one line

[MediaWiki-commits] [Gerrit] Fix mark xwiki as read - change (mediawiki...Echo)

2016-07-04 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/297262 Change subject: Fix mark xwiki as read .. Fix mark xwiki as read Marking local or xwiki notifications as read are different operations that

[MediaWiki-commits] [Gerrit] Cleanup old notification formatting system - change (mediawiki...Echo)

2016-06-29 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/296641 Change subject: Cleanup old notification formatting system .. Cleanup old notification formatting system * Deprecated main entry-points *

[MediaWiki-commits] [Gerrit] Add missing diff link to some flow notifications - change (mediawiki...Flow)

2016-06-29 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/296592 Change subject: Add missing diff link to some flow notifications .. Add missing diff link to some flow notifications * flow-post-edited *

[MediaWiki-commits] [Gerrit] Fix foreign bundle count - change (mediawiki...Echo)

2016-06-29 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/296574 Change subject: Fix foreign bundle count .. Fix foreign bundle count Use foreign source reported notifications count instead of counting the

[MediaWiki-commits] [Gerrit] Show placeholder widget when there is no notifications - change (mediawiki...Echo)

2016-06-28 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/296437 Change subject: Show placeholder widget when there is no notifications .. Show placeholder widget when there is no notifications When there

[MediaWiki-commits] [Gerrit] Fix notice on flow history page - change (mediawiki...Flow)

2016-06-28 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/296426 Change subject: Fix notice on flow history page .. Fix notice on flow history page Change-Id: I93f55c384b9eb65a3eb0180352bb0ad720d99153 ---

[MediaWiki-commits] [Gerrit] Mention notification: don't repeat the section title at the ... - change (mediawiki...Echo)

2016-06-28 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/296397 Change subject: Mention notification: don't repeat the section title at the begining of the excerpt .. Mention notification: don't repeat

[MediaWiki-commits] [Gerrit] Don't send empty emails - change (mediawiki...Echo)

2016-06-28 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/296394 Change subject: Don't send empty emails .. Don't send empty emails If no notification can be rendered, don't send an email at all. Bug:

[MediaWiki-commits] [Gerrit] Browser tests: update local URL - change (mediawiki...Flow)

2016-06-27 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/296253 Change subject: Browser tests: update local URL .. Browser tests: update local URL Change-Id: I40298a562e3944ced386506d27539bf4a7892baa ---

[MediaWiki-commits] [Gerrit] Fix position of page filters in firefox - change (mediawiki...Echo)

2016-06-23 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/295752 Change subject: Fix position of page filters in firefox .. Fix position of page filters in firefox Bug: T138454 Change-Id:

[MediaWiki-commits] [Gerrit] Support for PlaceholderWidget with no link - change (mediawiki...Echo)

2016-06-22 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/29 Change subject: Support for PlaceholderWidget with no link .. Support for PlaceholderWidget with no link Bug: T137490 Change-Id:

[MediaWiki-commits] [Gerrit] [WIP] Split flow-* and flowusertalk-* notifications - change (mediawiki...Flow)

2016-06-22 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/295484 Change subject: [WIP] Split flow-* and flowusertalk-* notifications .. [WIP] Split flow-* and flowusertalk-* notifications It applies to: -

[MediaWiki-commits] [Gerrit] Improve client-side unread count estimation - change (mediawiki...Echo)

2016-06-21 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/295337 Change subject: Improve client-side unread count estimation .. Improve client-side unread count estimation - Remove duplicated counter

[MediaWiki-commits] [Gerrit] Define global transition vars before using them - change (mediawiki...Echo)

2016-06-21 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/295335 Change subject: Define global transition vars before using them .. Define global transition vars before using them Bug: T132954 Change-Id:

[MediaWiki-commits] [Gerrit] Try to extract an excerpt from a revision - change (mediawiki...Echo)

2016-06-17 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/294928 Change subject: Try to extract an excerpt from a revision .. Try to extract an excerpt from a revision Bug: T120152 Change-Id:

[MediaWiki-commits] [Gerrit] [WIP] Make thanks notifications expandable bundles - change (mediawiki...Thanks)

2016-06-16 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/294733 Change subject: [WIP] Make thanks notifications expandable bundles .. [WIP] Make thanks notifications expandable bundles * edit-thank *

[MediaWiki-commits] [Gerrit] Maintenance script generates edit-thank notifications - change (mediawiki...Echo)

2016-06-16 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/294731 Change subject: Maintenance script generates edit-thank notifications .. Maintenance script generates edit-thank notifications Bug: T120152

[MediaWiki-commits] [Gerrit] Notify topic watchers of topic-resolved/topic-reopened - change (mediawiki...Flow)

2016-06-16 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/294715 Change subject: Notify topic watchers of topic-resolved/topic-reopened .. Notify topic watchers of topic-resolved/topic-reopened Change-Id:

[MediaWiki-commits] [Gerrit] Don't set title for user-rights notifications - change (mediawiki...Echo)

2016-06-14 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/294321 Change subject: Don't set title for user-rights notifications .. Don't set title for user-rights notifications Same as

[MediaWiki-commits] [Gerrit] Don't mark alerts as read when seen - change (mediawiki...Echo)

2016-06-14 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/294300 Change subject: Don't mark alerts as read when seen .. Don't mark alerts as read when seen This is done the quick way by just turning off a

[MediaWiki-commits] [Gerrit] Allow the primary link to set all bundled notifications as read - change (mediawiki...Echo)

2016-06-13 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/294120 Change subject: Allow the primary link to set all bundled notifications as read .. Allow the primary link to set all bundled notifications as

[MediaWiki-commits] [Gerrit] Make notifications expandable - change (mediawiki...Flow)

2016-06-09 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. https://gerrit.wikimedia.org/r/293505 Change subject: Make notifications expandable .. Make notifications expandable * flow-new-topic * flowusertalk-new-topic TODO *

<    1   2   3   4   5   6   >