[MediaWiki-commits] [Gerrit] ApiParse: Forbig section=new when using page, pageid, or oldid - change (mediawiki/core)

2015-03-25 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/199798 Change subject: ApiParse: Forbig section=new when using page, pageid, or oldid .. ApiParse: Forbig section=new when using page, pageid, or

[MediaWiki-commits] [Gerrit] Use wgExtensionFunctions instead of SetupAfterCache hook - change (mediawiki...TimedMediaHandler)

2015-03-21 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/198486 Change subject: Use wgExtensionFunctions instead of SetupAfterCache hook .. Use wgExtensionFunctions instead of SetupAfterCache hook Bug:

[MediaWiki-commits] [Gerrit] API: Pass pageId as intval to avoid error in XML output - change (mediawiki...TimedMediaHandler)

2015-03-21 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/198522 Change subject: API: Pass pageId as intval to avoid error in XML output .. API: Pass pageId as intval to avoid error in XML output T57743

[MediaWiki-commits] [Gerrit] TimedText: Remove unneeded dependency on jquery.ui.dialog - change (mediawiki...TimedMediaHandler)

2015-03-21 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/198525 Change subject: TimedText: Remove unneeded dependency on jquery.ui.dialog .. TimedText: Remove unneeded dependency on jquery.ui.dialog Bug:

[MediaWiki-commits] [Gerrit] ApiParse: Fix parse of new section title - change (mediawiki/core)

2015-03-19 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/198092 Change subject: ApiParse: Fix parse of new section title .. ApiParse: Fix parse of new section title Mirror how EditPage transforms a new

[MediaWiki-commits] [Gerrit] Live preview: Disable if there is no wpTextbox1 - change (mediawiki/core)

2015-03-19 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/198107 Change subject: Live preview: Disable if there is no wpTextbox1 .. Live preview: Disable if there is no wpTextbox1 ProofreadPage has custom

[MediaWiki-commits] [Gerrit] Pass context to FormatMetadata class on ImagePage - change (mediawiki...TimedMediaHandler)

2015-03-16 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/197211 Change subject: Pass context to FormatMetadata class on ImagePage .. Pass context to FormatMetadata class on ImagePage Follow up to:

[MediaWiki-commits] [Gerrit] Add JSHint to CategoryTree - change (mediawiki...CategoryTree)

2015-03-15 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/196876 Change subject: Add JSHint to CategoryTree .. Add JSHint to CategoryTree Bug: T65112 Change-Id: Ib10f4b043fab5b3163f6e343ae5ff926300b60c8 ---

[MediaWiki-commits] [Gerrit] Improve TMH styling - change (mediawiki...TimedMediaHandler)

2015-03-15 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/196883 Change subject: Improve TMH styling .. Improve TMH styling * Add a new RL module for styling media containers when there is no JS. This

[MediaWiki-commits] [Gerrit] Remove jscsrc since it's not so useful here - change (mediawiki...CategoryTree)

2015-03-15 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/196891 Change subject: Remove jscsrc since it's not so useful here .. Remove jscsrc since it's not so useful here Also rm Qunit as a global, since

[MediaWiki-commits] [Gerrit] Insert link: trim whitespace from the external link - change (mediawiki...WikiEditor)

2015-03-15 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/196966 Change subject: Insert link: trim whitespace from the external link .. Insert link: trim whitespace from the external link Bug: T25499

[MediaWiki-commits] [Gerrit] LivePreview: Support section=new for preview - change (mediawiki/core)

2015-03-12 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/196443 Change subject: LivePreview: Support section=new for preview .. LivePreview: Support section=new for preview Reproduce the new section

[MediaWiki-commits] [Gerrit] ApiParse: Support previewing section=new - change (mediawiki/core)

2015-03-10 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/195695 Change subject: ApiParse: Support previewing section=new .. ApiParse: Support previewing section=new When live previewing a 'new' section, we

[MediaWiki-commits] [Gerrit] AUTHORS: Add my own name - change (oojs/ui)

2015-03-10 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/195771 Change subject: AUTHORS: Add my own name .. AUTHORS: Add my own name Change-Id: I357a4417114fb5bf0d39e7d9fc00fc72f9fdaef8 --- M AUTHORS.txt 1

[MediaWiki-commits] [Gerrit] VE: Apply overflow fix on header - change (mediawiki...MobileFrontend)

2015-03-02 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/193984 Change subject: VE: Apply overflow fix on header .. VE: Apply overflow fix on header Without this, the bottom border can cross over any

[MediaWiki-commits] [Gerrit] Bring back hatnotes - change (mediawiki...MobileFrontend)

2015-02-28 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/193560 Change subject: Bring back hatnotes .. Bring back hatnotes Undo I6b972be and I559281d dablink and rellink classes were partly replaced by

[MediaWiki-commits] [Gerrit] LivePreview: Notifiy user about errors - change (mediawiki/core)

2015-02-28 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/193578 Change subject: LivePreview: Notifiy user about errors .. LivePreview: Notifiy user about errors Bug: T90490 Change-Id:

[MediaWiki-commits] [Gerrit] LivePreview: Use setTimeout to delay rendering of MathJax - change (mediawiki...Math)

2015-02-26 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/193270 Change subject: LivePreview: Use setTimeout to delay rendering of MathJax .. LivePreview: Use setTimeout to delay rendering of MathJax

[MediaWiki-commits] [Gerrit] ComboBox: Use combobox role - change (oojs/ui)

2015-02-22 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/192186 Change subject: ComboBox: Use combobox role .. ComboBox: Use combobox role This let's screenreaders know that this is actually a combobox that

[MediaWiki-commits] [Gerrit] Check MwEmbed dependency only before it is needed - change (mediawiki...TimedMediaHandler)

2015-02-20 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/191997 Change subject: Check MwEmbed dependency only before it is needed .. Check MwEmbed dependency only before it is needed Fix dependency check to

[MediaWiki-commits] [Gerrit] Preferences: Use mediawiki.confirmCloseWindow module - change (mediawiki/core)

2015-02-18 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/191490 Change subject: Preferences: Use mediawiki.confirmCloseWindow module .. Preferences: Use mediawiki.confirmCloseWindow module This logic was

[MediaWiki-commits] [Gerrit] SelectWidget: listbox wrapper role, state on contents - change (oojs/ui)

2015-01-30 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/187655 Change subject: SelectWidget: listbox wrapper role, state on contents .. SelectWidget: listbox wrapper role, state on contents SelectWidgets

[MediaWiki-commits] [Gerrit] ButtonOptionWidget: Add the TabIndexedElement mixin - change (oojs/ui)

2015-01-29 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/187652 Change subject: ButtonOptionWidget: Add the TabIndexedElement mixin .. ButtonOptionWidget: Add the TabIndexedElement mixin This element should

[MediaWiki-commits] [Gerrit] Remove superfluos role=text from TextInputWidget - change (oojs/ui)

2015-01-28 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/187298 Change subject: Remove superfluos role=text from TextInputWidget .. Remove superfluos role=text from TextInputWidget The wrapped input and

[MediaWiki-commits] [Gerrit] Remove disabled buttons from keyboard navigation flow - change (oojs/ui)

2015-01-28 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/187274 Change subject: Remove disabled buttons from keyboard navigation flow .. Remove disabled buttons from keyboard navigation flow Disabled

[MediaWiki-commits] [Gerrit] Add aria-pressed to ToggleButtonWidget - change (oojs/ui)

2015-01-28 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/187315 Change subject: Add aria-pressed to ToggleButtonWidget .. Add aria-pressed to ToggleButtonWidget The pressed active state needs to be

[MediaWiki-commits] [Gerrit] Set aria-disabled on the Widget - change (oojs/ui)

2015-01-28 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/187163 Change subject: Set aria-disabled on the Widget .. Set aria-disabled on the Widget This is to fix accessibility for those screenreaders that

[MediaWiki-commits] [Gerrit] Toolbar: Reset lineheight for character cells - change (mediawiki...WikiEditor)

2015-01-06 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/183051 Change subject: Toolbar: Reset lineheight for character cells .. Toolbar: Reset lineheight for character cells Bug: T78354 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki.feedback: improve error handling - change (mediawiki/core)

2014-12-08 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/178178 Change subject: mediawiki.feedback: improve error handling .. mediawiki.feedback: improve error handling Some loose ends with the rewrite to

[MediaWiki-commits] [Gerrit] Toolbar help: Make magic word from help string a param - change (mediawiki...WikiEditor)

2014-12-08 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/178180 Change subject: Toolbar help: Make magic word from help string a param .. Toolbar help: Make magic word from help string a param Instead of

[MediaWiki-commits] [Gerrit] [WIP] Only return CORS headers in the response as required - change (mediawiki/core)

2014-12-04 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/177545 Change subject: [WIP] Only return CORS headers in the response as required .. [WIP] Only return CORS headers in the response as required -

[MediaWiki-commits] [Gerrit] Remove previewDialog - change (mediawiki...WikiEditor)

2014-11-30 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/176512 Change subject: Remove previewDialog .. Remove previewDialog This was never launched, and is no longer working either. Change-Id:

[MediaWiki-commits] [Gerrit] (bug 39643) Allow 0 as the content of syntaxhighlight - change (mediawiki...SyntaxHighlight_GeSHi)

2014-11-29 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/176479 Change subject: (bug 39643) Allow 0 as the content of syntaxhighlight .. (bug 39643) Allow 0 as the content of syntaxhighlight The empty()

[MediaWiki-commits] [Gerrit] Add setContents to textSelection impl of CodeEditor - change (mediawiki...CodeEditor)

2014-11-29 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/176480 Change subject: Add setContents to textSelection impl of CodeEditor .. Add setContents to textSelection impl of CodeEditor Change-Id:

[MediaWiki-commits] [Gerrit] Add error dialog handler on wikipage.content hook - change (mediawiki...Scribunto)

2014-11-20 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/174665 Change subject: Add error dialog handler on wikipage.content hook .. Add error dialog handler on wikipage.content hook Bug: 73618 Change-Id:

[MediaWiki-commits] [Gerrit] Fix undefined error on end of play of native audio - change (mediawiki...TimedMediaHandler)

2014-11-19 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/174407 Change subject: Fix undefined error on end of play of native audio .. Fix undefined error on end of play of native audio Untested Bug: 56353

[MediaWiki-commits] [Gerrit] Remove superfluous parseInt() - change (mediawiki...TimedMediaHandler)

2014-11-18 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/174097 Change subject: Remove superfluous parseInt() .. Remove superfluous parseInt() Requires testing. If this was for rounding, we should use

[MediaWiki-commits] [Gerrit] Dependency fix - change (mediawiki...TimedMediaHandler)

2014-11-18 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/174300 Change subject: Dependency fix .. Dependency fix Change-Id: Id6d15f0110032c7c31f909d072529a9c56908942 --- M TimedMediaHandler.hooks.php 1 file

[MediaWiki-commits] [Gerrit] Support WebM Vorbis files in the player - change (mediawiki...TimedMediaHandler)

2014-11-18 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/174325 Change subject: Support WebM Vorbis files in the player .. Support WebM Vorbis files in the player Bug: 72996 Change-Id:

[MediaWiki-commits] [Gerrit] Missing , in variables declaration - change (mediawiki...TimedMediaHandler)

2014-11-17 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/173820 Change subject: Missing , in variables declaration .. Missing , in variables declaration Follow up to Change:

[MediaWiki-commits] [Gerrit] JSCS cleanup for timed media handler - change (mediawiki...TimedMediaHandler)

2014-11-15 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/173509 Change subject: JSCS cleanup for timed media handler .. JSCS cleanup for timed media handler Change-Id:

[MediaWiki-commits] [Gerrit] Make the private modules of TMH pass jshint - change (mediawiki...TimedMediaHandler)

2014-11-15 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/173513 Change subject: Make the private modules of TMH pass jshint .. Make the private modules of TMH pass jshint Change-Id:

[MediaWiki-commits] [Gerrit] Use postWithEditToken to make the reset transcode request - change (mediawiki...TimedMediaHandler)

2014-11-15 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/173537 Change subject: Use postWithEditToken to make the reset transcode request .. Use postWithEditToken to make the reset transcode request

[MediaWiki-commits] [Gerrit] Fix an undeclared and an incorrect RL dependency - change (mediawiki...TimedMediaHandler)

2014-11-15 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/173538 Change subject: Fix an undeclared and an incorrect RL dependency .. Fix an undeclared and an incorrect RL dependency Change-Id:

[MediaWiki-commits] [Gerrit] Fix Lua comment blocks and string blocks. - change (mediawiki...SyntaxHighlight_GeSHi)

2014-11-13 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/173104 Change subject: Fix Lua comment blocks and string blocks. .. Fix Lua comment blocks and string blocks. - Match comments non-greedily instead

[MediaWiki-commits] [Gerrit] [WIP] Turn MwEmbed loaderscripts into modules - change (mediawiki...MwEmbedSupport)

2014-11-11 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/172556 Change subject: [WIP] Turn MwEmbed loaderscripts into modules .. [WIP] Turn MwEmbed loaderscripts into modules Change-Id:

[MediaWiki-commits] [Gerrit] Preview: Add content clears after side-by-side preview - change (mediawiki...WikiEditor)

2014-11-10 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/172318 Change subject: Preview: Add content clears after side-by-side preview .. Preview: Add content clears after side-by-side preview Change-Id:

[MediaWiki-commits] [Gerrit] [WIP] Improve live loading - change (mediawiki...TimedMediaHandler)

2014-11-10 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/172421 Change subject: [WIP] Improve live loading .. [WIP] Improve live loading Needs more work on the loader scripts. Bug: 72675 Change-Id:

[MediaWiki-commits] [Gerrit] Parser: Add bdi to the whitelist for TOC links - change (mediawiki/core)

2014-11-02 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/170589 Change subject: Parser: Add bdi to the whitelist for TOC links .. Parser: Add bdi to the whitelist for TOC links Bug: 72884 Change-Id:

[MediaWiki-commits] [Gerrit] Revert Add SVG versions of toolbar icons - change (mediawiki...WikiEditor)

2014-10-26 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/168821 Change subject: Revert Add SVG versions of toolbar icons .. Revert Add SVG versions of toolbar icons There were issues with shadows, and the

[MediaWiki-commits] [Gerrit] Drafts: this time using indexeddb - change (mediawiki/core)

2014-09-10 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/159626 Change subject: Drafts: this time using indexeddb .. Drafts: this time using indexeddb Advantadges: - doesn't fill up storage - fully async

[MediaWiki-commits] [Gerrit] Flickr: The community does not consider UW uploads verified - change (mediawiki...UploadWizard)

2014-09-06 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/158887 Change subject: Flickr: The community does not consider UW uploads verified .. Flickr: The community does not consider UW uploads verified

[MediaWiki-commits] [Gerrit] Feedback: Use a proper URL for the feedback page link - change (mediawiki...UploadWizard)

2014-09-06 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/158896 Change subject: Feedback: Use a proper URL for the feedback page link .. Feedback: Use a proper URL for the feedback page link Change-Id:

[MediaWiki-commits] [Gerrit] Replace deprecated wikiGetLink with mw.util.getUrl - change (mediawiki...WikiLove)

2014-09-05 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/158656 Change subject: Replace deprecated wikiGetLink with mw.util.getUrl .. Replace deprecated wikiGetLink with mw.util.getUrl Change-Id:

[MediaWiki-commits] [Gerrit] Rewrite to use mediawiki.api - change (mediawiki...WikiLove)

2014-09-05 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/158664 Change subject: Rewrite to use mediawiki.api .. Rewrite to use mediawiki.api mediawiki.ap has edittoken retry, seems useful here. Change-Id:

[MediaWiki-commits] [Gerrit] Pass jshint - change (mediawiki...WikiLove)

2014-09-05 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/158774 Change subject: Pass jshint .. Pass jshint Change-Id: I0278575038308f8cee03096a14253b9987bba727 --- A .jshintrc M

[MediaWiki-commits] [Gerrit] wikilove passes jshint after I0278575 - change (integration/zuul-config)

2014-09-05 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/158777 Change subject: wikilove passes jshint after I0278575 .. wikilove passes jshint after I0278575 Bug: 61645 Change-Id:

[MediaWiki-commits] [Gerrit] Set $wasPosted = true for recursive API access - change (mediawiki...WikiLove)

2014-09-05 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/158785 Change subject: Set $wasPosted = true for recursive API access .. Set $wasPosted = true for recursive API access Having an API module

[MediaWiki-commits] [Gerrit] Set $wasPosted = true for recursive API access - change (mediawiki...WikiLove)

2014-09-05 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/158786 Change subject: Set $wasPosted = true for recursive API access .. Set $wasPosted = true for recursive API access Having an API module

[MediaWiki-commits] [Gerrit] [Do not merge] HTML5: Use header element to wrap our headi... - change (mediawiki/core)

2014-09-03 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/158087 Change subject: [Do not merge] HTML5: Use header element to wrap our headings. .. [Do not merge] HTML5: Use header element to wrap our

[MediaWiki-commits] [Gerrit] Add a jQuery promise lib around indexedDB - change (mediawiki/core)

2014-09-02 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/157818 Change subject: Add a jQuery promise lib around indexedDB .. Add a jQuery promise lib around indexedDB Added

[MediaWiki-commits] [Gerrit] Categories: Don't suggest empty or old categories - change (mediawiki...VisualEditor)

2014-08-26 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/156250 Change subject: Categories: Don't suggest empty or old categories .. Categories: Don't suggest empty or old categories The categories table

[MediaWiki-commits] [Gerrit] TemplateParser: Fix whitespace trim - change (mediawiki...CommonsMetadata)

2014-08-23 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/155901 Change subject: TemplateParser: Fix whitespace trim .. TemplateParser: Fix whitespace trim Bug: 57458 Change-Id:

[MediaWiki-commits] [Gerrit] Compactlinks: Use an actual button to build a button - change (mediawiki...UniversalLanguageSelector)

2014-08-14 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/154041 Change subject: Compactlinks: Use an actual button to build a button .. Compactlinks: Use an actual button to build a button Change-Id:

[MediaWiki-commits] [Gerrit] Dialogs: Reset values of file insertion dialog properly - change (mediawiki...WikiEditor)

2014-08-14 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/154123 Change subject: Dialogs: Reset values of file insertion dialog properly .. Dialogs: Reset values of file insertion dialog properly Bug: 67111

[MediaWiki-commits] [Gerrit] Undefined function mw.log.error - change (mediawiki...CodeEditor)

2014-08-14 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/154128 Change subject: Undefined function mw.log.error .. Undefined function mw.log.error Bug: 68557 Change-Id:

[MediaWiki-commits] [Gerrit] jquery.tablesorter: Only look at th's for headers - change (mediawiki/core)

2014-08-07 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/152225 Change subject: jquery.tablesorter: Only look at th's for headers .. jquery.tablesorter: Only look at th's for headers If there would be td

[MediaWiki-commits] [Gerrit] jquery.tablesorter: Limit the scope of two variables - change (mediawiki/core)

2014-08-07 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/152774 Change subject: jquery.tablesorter: Limit the scope of two variables .. jquery.tablesorter: Limit the scope of two variables No functional

[MediaWiki-commits] [Gerrit] QUnit: fix swapped expected/actual fields - change (mediawiki/core)

2014-08-06 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/152121 Change subject: QUnit: fix swapped expected/actual fields .. QUnit: fix swapped expected/actual fields Change-Id:

[MediaWiki-commits] [Gerrit] jquery.textSelection: re-add iframe check due to regression - change (mediawiki/core)

2014-07-28 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/150009 Change subject: jquery.textSelection: re-add iframe check due to regression .. jquery.textSelection: re-add iframe check due to regression

[MediaWiki-commits] [Gerrit] jquery.textSelection: register an alt implementation - change (mediawiki/core)

2014-07-28 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/150032 Change subject: jquery.textSelection: register an alt implementation .. jquery.textSelection: register an alt implementation At times we

[MediaWiki-commits] [Gerrit] Split jquery.textSelection and WikiEditor api overrides - change (mediawiki...CodeEditor)

2014-07-28 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/150037 Change subject: Split jquery.textSelection and WikiEditor api overrides .. Split jquery.textSelection and WikiEditor api overrides This

[MediaWiki-commits] [Gerrit] jquery.textSelection: Add setContents function - change (mediawiki/core)

2014-07-26 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/149529 Change subject: jquery.textSelection: Add setContents function .. jquery.textSelection: Add setContents function This function is specified in

[MediaWiki-commits] [Gerrit] [WIP] user settings api - change (mediawiki/core)

2014-07-16 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/146784 Change subject: [WIP] user settings api .. [WIP] user settings api OK, this is totally not finished, not tested, broken etc. but I wanted to

[MediaWiki-commits] [Gerrit] Allow on the fly loading of language modes - change (mediawiki...CodeEditor)

2014-07-10 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/145327 Change subject: Allow on the fly loading of language modes .. Allow on the fly loading of language modes Change-Id:

[MediaWiki-commits] [Gerrit] Ace: Update to 08-07-2014 - change (mediawiki...CodeEditor)

2014-07-08 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/144780 Change subject: Ace: Update to 08-07-2014 .. Ace: Update to 08-07-2014 Updated to

[MediaWiki-commits] [Gerrit] ToC: float left should also clear other left floats - change (mediawiki...MobileFrontend)

2014-06-24 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/141754 Change subject: ToC: float left should also clear other left floats .. ToC: float left should also clear other left floats Change-Id:

[MediaWiki-commits] [Gerrit] Disable CodeEditor on mobile - change (mediawiki...CodeEditor)

2014-06-23 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/141385 Change subject: Disable CodeEditor on mobile .. Disable CodeEditor on mobile Disabled on our known android/iphone/ipod UAs, because of Bug

[MediaWiki-commits] [Gerrit] Toolbar: Only show on WikiText pages - change (mediawiki/core)

2014-06-22 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/141293 Change subject: Toolbar: Only show on WikiText pages .. Toolbar: Only show on WikiText pages The toolbar is highly specific to Wikitext

[MediaWiki-commits] [Gerrit] Only add WikiEditor for content model WikiText - change (mediawiki...WikiEditor)

2014-06-22 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/141296 Change subject: Only add WikiEditor for content model WikiText .. Only add WikiEditor for content model WikiText Together with solving bug

[MediaWiki-commits] [Gerrit] Link dialog: do basic URI validation - change (mediawiki...WikiEditor)

2014-06-22 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/141367 Change subject: Link dialog: do basic URI validation .. Link dialog: do basic URI validation This isn't very sophisticated, but it will handle

[MediaWiki-commits] [Gerrit] Migrate VE icon from VE extension - change (mediawiki...Math)

2014-06-21 Thread TheDJ (Code Review)
TheDJ has submitted this change and it was merged. Change subject: Migrate VE icon from VE extension .. Migrate VE icon from VE extension Removed from VE with Ic8074be2. Change-Id: I33cdb6204b4abc44398ecedd65f7d9251e73e9b0

[MediaWiki-commits] [Gerrit] Replace jQuery.browser with jquery.client - change (mediawiki...LiquidThreads)

2014-06-17 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/140205 Change subject: Replace jQuery.browser with jquery.client .. Replace jQuery.browser with jquery.client Bug: 65679 Change-Id:

[MediaWiki-commits] [Gerrit] Replace obsolete live() with $( document ).on() - change (mediawiki...LiquidThreads)

2014-06-17 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/140221 Change subject: Replace obsolete live() with $( document ).on() .. Replace obsolete live() with $( document ).on() Bug: 65666 Change-Id:

[MediaWiki-commits] [Gerrit] CPB: Make LQT messages show up in CPB. - change (mediawiki...VectorBeta)

2014-06-17 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/140248 Change subject: CPB: Make LQT messages show up in CPB. .. CPB: Make LQT messages show up in CPB. I was missing these notification too often on

[MediaWiki-commits] [Gerrit] textSelection: Remove references to iframe - change (mediawiki/core)

2014-06-15 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/139690 Change subject: textSelection: Remove references to iframe .. textSelection: Remove references to iframe Another attempt to solve the

[MediaWiki-commits] [Gerrit] Toolbar: Fix dependencies of WikiEditor toolbar - change (mediawiki...WikiEditor)

2014-06-15 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/139759 Change subject: Toolbar: Fix dependencies of WikiEditor toolbar .. Toolbar: Fix dependencies of WikiEditor toolbar These modules are actually

[MediaWiki-commits] [Gerrit] [WIP] Try to split out wikiEditor vs codeEditor toolbar - change (mediawiki...CodeEditor)

2014-06-15 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/139760 Change subject: [WIP] Try to split out wikiEditor vs codeEditor toolbar .. [WIP] Try to split out wikiEditor vs codeEditor toolbar This is far

[MediaWiki-commits] [Gerrit] Popups: Fix popups for extiw links - change (mediawiki...Popups)

2014-05-19 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/134265 Change subject: Popups: Fix popups for extiw links .. Popups: Fix popups for extiw links These links were not ignored due to a typo. This also

[MediaWiki-commits] [Gerrit] Popups: Only run the selector for the a elements once - change (mediawiki...Popups)

2014-05-19 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/134266 Change subject: Popups: Only run the selector for the a elements once .. Popups: Only run the selector for the a elements once It's a

[MediaWiki-commits] [Gerrit] Popups: The promise of the popups was not forwarding failures - change (mediawiki...Popups)

2014-05-19 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/134267 Change subject: Popups: The promise of the popups was not forwarding failures .. Popups: The promise of the popups was not forwarding failures

[MediaWiki-commits] [Gerrit] Popups: handle links with empty or no title attributes - change (mediawiki...Popups)

2014-05-19 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/134268 Change subject: Popups: handle links with empty or no title attributes .. Popups: handle links with empty or no title attributes The script

[MediaWiki-commits] [Gerrit] Popups: Some small cleanup. - change (mediawiki...Popups)

2014-05-19 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/134269 Change subject: Popups: Some small cleanup. .. Popups: Some small cleanup. Bunch attr actions, add to dom as the last action, rm superflous

[MediaWiki-commits] [Gerrit] Inputbox: Some code conventions cleanup - change (mediawiki...InputBox)

2014-05-18 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/133961 Change subject: Inputbox: Some code conventions cleanup .. Inputbox: Some code conventions cleanup Change-Id:

[MediaWiki-commits] [Gerrit] InputBox: Cleanup usage of inline styles - change (mediawiki...InputBox)

2014-05-18 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/133962 Change subject: InputBox: Cleanup usage of inline styles .. InputBox: Cleanup usage of inline styles Change-Id:

[MediaWiki-commits] [Gerrit] InputBox: Don't append id to class - change (mediawiki...InputBox)

2014-05-18 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/133963 Change subject: InputBox: Don't append id to class .. InputBox: Don't append id to class The search2 form type was adding the id to the

[MediaWiki-commits] [Gerrit] tipsy: Merge some upstream changes - change (mediawiki/core)

2014-05-18 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/133973 Change subject: tipsy: Merge some upstream changes .. tipsy: Merge some upstream changes 4b3e29f: Remove superfluous slash 23994f5: tipsy

[MediaWiki-commits] [Gerrit] Tipsy: Added viewable region bounds checking to tipsy - change (mediawiki/core)

2014-05-18 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/133975 Change subject: Tipsy: Added viewable region bounds checking to tipsy .. Tipsy: Added viewable region bounds checking to tipsy Merge of

[MediaWiki-commits] [Gerrit] Tipsy: Improve accessibility slightly - change (mediawiki/core)

2014-05-18 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/134042 Change subject: Tipsy: Improve accessibility slightly .. Tipsy: Improve accessibility slightly - use role tooltip - use aria-hidden when

[MediaWiki-commits] [Gerrit] jquery.textSelection: Don't throw errors on empty collections - change (mediawiki/core)

2014-05-17 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/133942 Change subject: jquery.textSelection: Don't throw errors on empty collections .. jquery.textSelection: Don't throw errors on empty collections

<    1   2   3   4   5   6   7   >