[MediaWiki-commits] [Gerrit] wikidata...gui[master]: Fix documentation of CodeSamples.getExamples()

2017-10-23 Thread Lucas Werkmeister (WMDE) (Code Review)
Lucas Werkmeister (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/386006 ) Change subject: Fix documentation of CodeSamples.getExamples() .. Fix documentation of CodeSamples.getExamples() Change

[MediaWiki-commits] [Gerrit] wikidata...gui[master]: Fix CodeMirror height

2017-10-23 Thread Jonas Kress (WMDE) (Code Review)
Jonas Kress (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/385998 ) Change subject: Fix CodeMirror height .. Fix CodeMirror height Change-Id: Ib195dcf931911fd0b95937644fc2a65397fd4c2a --- M

[MediaWiki-commits] [Gerrit] wikidata...gui[master]: Improve code samples for several languages

2017-10-23 Thread Lucas Werkmeister (WMDE) (Code Review)
Lucas Werkmeister (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/385995 ) Change subject: Improve code samples for several languages .. Improve code samples for several languages Use heredocs

[MediaWiki-commits] [Gerrit] mediawiki...AdvancedSearch[master]: ArbitraryWordInput: Add tests

2017-10-23 Thread Pablo Grass (WMDE) (Code Review)
Pablo Grass (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/385991 ) Change subject: ArbitraryWordInput: Add tests .. ArbitraryWordInput: Add tests Add first tests for ArbitraryWordInput. Issue

[MediaWiki-commits] [Gerrit] mediawiki...AdvancedSearch[master]: ArbitraryWordInput: Resize input with placeholder

2017-10-23 Thread Pablo Grass (WMDE) (Code Review)
Pablo Grass (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/385983 ) Change subject: ArbitraryWordInput: Resize input with placeholder .. ArbitraryWordInput: Resize input with placeholder Invoke

[MediaWiki-commits] [Gerrit] mediawiki...TwoColConflict[master]: Fix collapse button formatting

2017-10-23 Thread Andrew-WMDE (Code Review)
Andrew-WMDE has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/385982 ) Change subject: Fix collapse button formatting .. Fix collapse button formatting Change-Id: If3beeb5ad90f4a591f4adc1c6aefcc85fb4b38d0

[MediaWiki-commits] [Gerrit] wikidata...gui[master]: Fix Wikidata birthday detection

2017-10-23 Thread Lucas Werkmeister (WMDE) (Code Review)
Lucas Werkmeister (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/385966 ) Change subject: Fix Wikidata birthday detection .. Fix Wikidata birthday detection In JavaScript, months are numbered

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseQualityConstraints[master]: Check constraints on qualifiers+references by default

2017-10-23 Thread Lucas Werkmeister (WMDE) (Code Review)
Lucas Werkmeister (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/385961 ) Change subject: Check constraints on qualifiers+references by default .. Check constraints on qualifiers+references

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseQualityConstraints[master]: Split some long lines in SparqlHelper

2017-10-23 Thread Lucas Werkmeister (WMDE) (Code Review)
Lucas Werkmeister (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/385958 ) Change subject: Split some long lines in SparqlHelper .. Split some long lines in SparqlHelper They could also

[MediaWiki-commits] [Gerrit] mediawiki...TwoColConflict[master]: Fix small summary field

2017-10-23 Thread Andrew-WMDE (Code Review)
Andrew-WMDE has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/385956 ) Change subject: Fix small summary field .. Fix small summary field Bug: T177381 Change-Id: I657f13011c4668d3f2830f90698a0a3954add0bb

[MediaWiki-commits] [Gerrit] wikidata...gui[master]: Add less dev mode support to embed.html

2017-10-23 Thread Jonas Kress (WMDE) (Code Review)
Jonas Kress (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/385952 ) Change subject: Add less dev mode support to embed.html .. Add less dev mode support to embed.html Use JS less compiler

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Add missing @throws documentation to Language::factory

2017-10-23 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/385951 ) Change subject: Add missing @throws documentation to Language::factory .. Add missing @throws documentation to Language

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Properly react on unknown languages in LanguageDirectionalit...

2017-10-23 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/385945 ) Change subject: Properly react on unknown languages in LanguageDirectionalityLookup .. Properly react on unknown languages

[MediaWiki-commits] [Gerrit] wikidata/build-resources[master]: Do not load ValueView extension

2017-10-21 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/385791 ) Change subject: Do not load ValueView extension .. Do not load ValueView extension It is no longer an extension, but a lib, which

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Install data values js lib as a git submodule, not as a comp...

2017-10-20 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/385408 ) Change subject: Install data values js lib as a git submodule, not as a composer dependency .. Install data values js lib as a git

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Install wikibase js serialization lib as a git submodule, no...

2017-10-20 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/385202 ) Change subject: Install wikibase js serialization lib as a git submodule, not as a composer dependency .. Install wikibase js

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Install wikibase js api as a git submodule, not as a compose...

2017-10-20 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/385199 ) Change subject: Install wikibase js api as a git submodule, not as a composer dependency .. Install wikibase js api as a git submodule

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Do not use messages from View-specific dependency in HtmlTim...

2017-10-20 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/385432 ) Change subject: Do not use messages from View-specific dependency in HtmlTimeFormatter .. Do not use messages from View-specific

[MediaWiki-commits] [Gerrit] wikidata...gui[master]: Allow passing options to Result Views

2017-10-20 Thread Jonas Kress (WMDE) (Code Review)
Jonas Kress (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/385427 ) Change subject: Allow passing options to Result Views .. Allow passing options to Result Views Introduces syntax to pass

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseQualityConstraints[master]: Remove support for old API output format

2017-10-20 Thread Lucas Werkmeister (WMDE) (Code Review)
Lucas Werkmeister (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/385388 ) Change subject: Remove support for old API output format .. Remove support for old API output format Bug: T168532 Change

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseQualityConstraints[master]: Use new API output format by default

2017-10-20 Thread Lucas Werkmeister (WMDE) (Code Review)
Lucas Werkmeister (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/385387 ) Change subject: Use new API output format by default .. Use new API output format by default Bug: T168532 Change-Id

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseQualityConstraints[master]: Add wikibase-snakview-indicator class in gadget

2017-10-20 Thread Lucas Werkmeister (WMDE) (Code Review)
Lucas Werkmeister (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/385374 ) Change subject: Add wikibase-snakview-indicator class in gadget .. Add wikibase-snakview-indicator class in gadget

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Add style for wikibase-snakview-indicator

2017-10-20 Thread Lucas Werkmeister (WMDE) (Code Review)
Lucas Werkmeister (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/385370 ) Change subject: Add style for wikibase-snakview-indicator .. Add style for wikibase-snakview-indicator Individual

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Add option to dispatch only to selected clients

2017-10-20 Thread Lucas Werkmeister (WMDE) (Code Review)
Lucas Werkmeister (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/385338 ) Change subject: Add option to dispatch only to selected clients .. Add option to dispatch only to selected clients Bug

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Don't inject WikibaseRepo as dependency of StatementBoostSco...

2017-10-19 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/385193 ) Change subject: Don't inject WikibaseRepo as dependency of StatementBoostScoreBuilder .. Don't inject WikibaseRepo

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Replace require_once with proper Composer class loading

2017-10-19 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/385184 ) Change subject: Replace require_once with proper Composer class loading .. Replace require_once with proper Composer class

[MediaWiki-commits] [Gerrit] wikidata...gui[master]: Copy code examples to build folder

2017-10-19 Thread Lucas Werkmeister (WMDE) (Code Review)
Lucas Werkmeister (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/385177 ) Change subject: Copy code examples to build folder .. Copy code examples to build folder This is required to make code

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Add missing @license and initial @author tags

2017-10-19 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/385171 ) Change subject: Add missing @license and initial @author tags .. Add missing @license and initial @author tags I found

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Update used Wikibase CodeSniffer rule set to version 0.2.0

2017-10-19 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/385170 ) Change subject: Update used Wikibase CodeSniffer rule set to version 0.2.0 .. Update used Wikibase CodeSniffer rule set

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseQualityConstraints[master]: Add missing @license tags and other phpdoc cleanup

2017-10-19 Thread Lucas Werkmeister (WMDE) (Code Review)
Lucas Werkmeister (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/385159 ) Change subject: Add missing @license tags and other phpdoc cleanup .. Add missing @license tags and other phpdoc cleanup

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseQualityConstraints[master]: Remove redundant @package tags

2017-10-17 Thread Lucas Werkmeister (WMDE) (Code Review)
Lucas Werkmeister (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384722 ) Change subject: Remove redundant @package tags .. Remove redundant @package tags phpDocumentor recommends removing

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseQualityConstraints[master]: Add missing line break

2017-10-17 Thread Lucas Werkmeister (WMDE) (Code Review)
Lucas Werkmeister (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384721 ) Change subject: Add missing line break .. Add missing line break Pointed out by Thiemo in a review comment on 153453b4f4

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseMediaInfo[master]: Update the used Wikibase CodeSniffer rule set to version 0.2.0

2017-10-17 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384691 ) Change subject: Update the used Wikibase CodeSniffer rule set to version 0.2.0 .. Update the used Wikibase CodeSniffer rule

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseLexeme[master]: Update the used Wikibase CodeSniffer rule set to 0.2.0

2017-10-17 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384689 ) Change subject: Update the used Wikibase CodeSniffer rule set to 0.2.0 .. Update the used Wikibase CodeSniffer rule set

[MediaWiki-commits] [Gerrit] wikidata...gui[master]: Show toolbar only when initialized

2017-10-17 Thread Jonas Kress (WMDE) (Code Review)
Jonas Kress (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384688 ) Change subject: Show toolbar only when initialized .. Show toolbar only when initialized Also changes opacity of toolbar to 0.2

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseLexeme[master]: Do not redeclare property in LexemePatcher

2017-10-17 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384677 ) Change subject: Do not redeclare property in LexemePatcher .. Do not redeclare property in LexemePatcher Two patches moved

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseLexeme[master]: Report which lexemes are updated by LexemeSerializationUpdater

2017-10-17 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384675 ) Change subject: Report which lexemes are updated by LexemeSerializationUpdater .. Report which lexemes are updated

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseLexeme[master]: Restore dummy demo data

2017-10-16 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384539 ) Change subject: Restore dummy demo data .. Restore dummy demo data This is basically restoring stuff removed

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseLexeme[master]: Do not fail in LexemeView if Lexeme has no ID

2017-10-16 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384534 ) Change subject: Do not fail in LexemeView if Lexeme has no ID .. Do not fail in LexemeView if Lexeme has no ID LexemeView is also

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseLexeme[master]: Make nextFormId field obligatory when deserializing lexeme data

2017-10-16 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384528 ) Change subject: Make nextFormId field obligatory when deserializing lexeme data .. Make nextFormId field obligatory when deserializing

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: WIP: Add wb-indicator span to snaks

2017-10-16 Thread Lucas Werkmeister (WMDE) (Code Review)
Lucas Werkmeister (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384524 ) Change subject: WIP: Add wb-indicator span to snaks .. WIP: Add wb-indicator span to snaks This alters the DOM structure

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseQualityConstraints[master]: Add constraints indicators to wb-indicators

2017-10-16 Thread Lucas Werkmeister (WMDE) (Code Review)
Lucas Werkmeister (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384525 ) Change subject: Add constraints indicators to wb-indicators .. Add constraints indicators to wb-indicators This fixes

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseLexeme[master]: Add a script for updating outdated serialized data in the DB...

2017-10-16 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384523 ) Change subject: Add a script for updating outdated serialized data in the DB (dev use only) .. Add a script for updating outdated

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Make Item… and PropertyFieldDefinitions accept arrays

2017-10-16 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384516 ) Change subject: Make Item… and PropertyFieldDefinitions accept arrays .. Make Item… and PropertyFieldDefinitions accept arrays

[MediaWiki-commits] [Gerrit] mediawiki...TwoColConflict[master]: Set a defaut page title for all edit conflict simulation steps

2017-10-16 Thread WMDE-Fisch (Code Review)
WMDE-Fisch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384515 ) Change subject: Set a defaut page title for all edit conflict simulation steps .. Set a defaut page title for all edit conflict

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Remove rare @package tags

2017-10-16 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384514 ) Change subject: Remove rare @package tags .. Remove rare @package tags These are the only files in the entire code base

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseQualityConstraints[master]: Add missing class documentation comments

2017-10-16 Thread Lucas Werkmeister (WMDE) (Code Review)
Lucas Werkmeister (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384510 ) Change subject: Add missing class documentation comments .. Add missing class documentation comments In preparation

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseQualityConstraints[master]: Update Wikibase CodeSniffer ruleset to 0.2.0

2017-10-16 Thread Lucas Werkmeister (WMDE) (Code Review)
Lucas Werkmeister (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384511 ) Change subject: Update Wikibase CodeSniffer ruleset to 0.2.0 .. Update Wikibase CodeSniffer ruleset to 0.2.0 Change-Id

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseLexeme[master]: Allow empty FormSets with empty constructor

2017-10-16 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384506 ) Change subject: Allow empty FormSets with empty constructor .. Allow empty FormSets with empty constructor This is just very

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseQualityConstraints[master]: Add tests for T178160

2017-10-16 Thread Lucas Werkmeister (WMDE) (Code Review)
Lucas Werkmeister (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384502 ) Change subject: Add tests for T178160 .. Add tests for T178160 This adds tests for the new Context functionality

[MediaWiki-commits] [Gerrit] wikidata...gui[master]: Add workaround for T178184

2017-10-16 Thread Lucas Werkmeister (WMDE) (Code Review)
Lucas Werkmeister (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384501 ) Change subject: Add workaround for T178184 .. Add workaround for T178184 Wikibase incorrectly escapes titles when

[MediaWiki-commits] [Gerrit] mediawiki...PropertySuggester[master]: Update Wikibase CodeSniffer rule set to 0.2.0

2017-10-16 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384493 ) Change subject: Update Wikibase CodeSniffer rule set to 0.2.0 .. Update Wikibase CodeSniffer rule set to 0.2.0 This patch

[MediaWiki-commits] [Gerrit] wikidata...gui[master]: Add app example

2017-10-16 Thread Jonas Kress (WMDE) (Code Review)
Jonas Kress (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384492 ) Change subject: Add app example .. Add app example Simple app that shows items nearby. Change-Id

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseLexeme[master]: Allow API response for Lemmas to be optional

2017-10-16 Thread Jonas Kress (WMDE) (Code Review)
Jonas Kress (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384467 ) Change subject: Allow API response for Lemmas to be optional .. Allow API response for Lemmas to be optional There is no Lemma

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Fix broken @covers tag in EntitySearchElasticTest

2017-10-16 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384451 ) Change subject: Fix broken @covers tag in EntitySearchElasticTest .. Fix broken @covers tag in EntitySearchElasticTest Change

[MediaWiki-commits] [Gerrit] mediawiki...Wikidata.org[master]: Update Wikibase Code Sniffer rule set to 0.2.0

2017-10-15 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384339 ) Change subject: Update Wikibase Code Sniffer rule set to 0.2.0 .. Update Wikibase Code Sniffer rule set to 0.2.0 This also

[MediaWiki-commits] [Gerrit] mediawiki...WikimediaBadges[master]: Update Wikibase CodeSniffer rule set to 0.2.0

2017-10-15 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384338 ) Change subject: Update Wikibase CodeSniffer rule set to 0.2.0 .. Update Wikibase CodeSniffer rule set to 0.2.0 Change-Id

[MediaWiki-commits] [Gerrit] mediawiki...Cognate[master]: Update Wikibase CodeSniffer rule set to 0.2.0

2017-10-15 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384337 ) Change subject: Update Wikibase CodeSniffer rule set to 0.2.0 .. Update Wikibase CodeSniffer rule set to 0.2.0 Change-Id

[MediaWiki-commits] [Gerrit] mediawiki...ArticlePlaceholder[master]: Update Wikibase CodeSniffer rule set to 0.2.0

2017-10-15 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384336 ) Change subject: Update Wikibase CodeSniffer rule set to 0.2.0 .. Update Wikibase CodeSniffer rule set to 0.2.0 Change-Id

[MediaWiki-commits] [Gerrit] integration/config[master]: Only run npm job for changes in mediawiki/extensions/Wikibas...

2017-10-14 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384236 ) Change subject: Only run npm job for changes in mediawiki/extensions/WikibaseJavaScriptApi .. Only run npm job for changes

[MediaWiki-commits] [Gerrit] wikidata...gui[master]: Change default suggestions for items in SelectorBox

2017-10-14 Thread Jonas Kress (WMDE) (Code Review)
Jonas Kress (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384203 ) Change subject: Change default suggestions for items in SelectorBox .. Change default suggestions for items in SelectorBox

[MediaWiki-commits] [Gerrit] wikidata...gui[master]: WIP: handle geoshape loading errors more gracefully

2017-10-13 Thread Lucas Werkmeister (WMDE) (Code Review)
Lucas Werkmeister (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384078 ) Change subject: WIP: handle geoshape loading errors more gracefully .. WIP: handle geoshape loading errors more gracefully

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseQualityConstraints[master]: Always include main snak context in API response

2017-10-13 Thread Lucas Werkmeister (WMDE) (Code Review)
Lucas Werkmeister (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384066 ) Change subject: Always include main snak context in API response .. Always include main snak context in API response Bug

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseQualityExternalValidation[master]: Update Wikibase CodeSniffer to version 0.2.0

2017-10-13 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384062 ) Change subject: Update Wikibase CodeSniffer to version 0.2.0 .. Update Wikibase CodeSniffer to version 0.2.0 Change-Id

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseQualityConstraints[master]: Let gadget cope with missing mainsnaks in response

2017-10-13 Thread Lucas Werkmeister (WMDE) (Code Review)
Lucas Werkmeister (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384060 ) Change subject: Let gadget cope with missing mainsnaks in response .. Let gadget cope with missing mainsnaks in response

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseQuality[master]: Update Wikibase CodeSniffer to version 0.2.0

2017-10-13 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384059 ) Change subject: Update Wikibase CodeSniffer to version 0.2.0 .. Update Wikibase CodeSniffer to version 0.2.0 Change-Id

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseMediaInfo[master]: Bind against FieldDefinitions interface instead of implement...

2017-10-13 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384047 ) Change subject: Bind against FieldDefinitions interface instead of implementation .. Bind against FieldDefinitions interface

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseQualityConstraints[master]: Remove misplaced "@group Wikibase"

2017-10-13 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384046 ) Change subject: Remove misplaced "@group Wikibase" .. Remove misplaced "@group Wikibase" This is not th

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseQualityConstraints[master]: Use assertEmpty instead of assertCount( 0, … )

2017-10-13 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384044 ) Change subject: Use assertEmpty instead of assertCount( 0, … ) .. Use assertEmpty instead of assertCount( 0, … ) It's

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseLexeme[master]: Remove meaningless @group WikibaseLexeme from all tests

2017-10-13 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384040 ) Change subject: Remove meaningless @group WikibaseLexeme from all tests .. Remove meaningless @group WikibaseLexeme from all

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseLexeme[master]: Use switch ( true ) instead of get_class comparisons in Lexe...

2017-10-13 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384034 ) Change subject: Use switch ( true ) instead of get_class comparisons in LexemePatcher .. Use switch ( true ) instead

[MediaWiki-commits] [Gerrit] wikidata...gui[master]: Simplify JavaScript example

2017-10-13 Thread Lucas Werkmeister (WMDE) (Code Review)
Lucas Werkmeister (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384031 ) Change subject: Simplify JavaScript example .. Simplify JavaScript example Let jQuery encode the query string. (We could

[MediaWiki-commits] [Gerrit] wikidata...gui[master]: Add modern JavaScript code sample

2017-10-13 Thread Lucas Werkmeister (WMDE) (Code Review)
Lucas Werkmeister (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384032 ) Change subject: Add modern JavaScript code sample .. Add modern JavaScript code sample The existing JavaScript sample

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseJavaScriptApi[master]: Release 3.0.0

2017-10-13 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384025 ) Change subject: Release 3.0.0 .. Release 3.0.0 Bug: T178088 Change-Id: Icb3fa7db8243f66b9741637cc1758ab9e43ef21a --- M README.md M

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseJavaScriptApi[master]: Removed Composer files

2017-10-13 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384020 ) Change subject: Removed Composer files .. Removed Composer files Bug: T178088 Change-Id: Ib148caa762a11484dee48fedb3f39c779997930d

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseJavaScriptApi[master]: Remove PHPCS config

2017-10-13 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384021 ) Change subject: Remove PHPCS config .. Remove PHPCS config Change-Id: I4df989ea68d7299a95867ef987466e6f6fc8ee49 --- D phpcs.xml 1 file

[MediaWiki-commits] [Gerrit] data-values/value-view[master]: Greatly simplify MessageProvider dependency injection

2017-10-13 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384027 ) Change subject: Greatly simplify MessageProvider dependency injection .. Greatly simplify MessageProvider dependency injection

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseJavaScriptApi[master]: Removed MediaWiki ResourceLoader module definitions

2017-10-13 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384022 ) Change subject: Removed MediaWiki ResourceLoader module definitions .. Removed MediaWiki ResourceLoader module definitions Bug

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseJavaScriptApi[master]: Install wikibase-data-values dependency using npm, not with ...

2017-10-13 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384019 ) Change subject: Install wikibase-data-values dependency using npm, not with Composer .. Install wikibase-data-values dependency using

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseJavaScriptApi[master]: Removed remaining MediaWiki integration files

2017-10-13 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384023 ) Change subject: Removed remaining MediaWiki integration files .. Removed remaining MediaWiki integration files Bug: T178088 Change-Id

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseJavaScriptApi[master]: Updated README

2017-10-13 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384024 ) Change subject: Updated README .. Updated README Bug: T178088 Change-Id: I474cd4788a7dc63a08af87cc7b635ea355cd8499 --- M README.md 1

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseJavaScriptApi[master]: Do not run QUnit tests using MediaWiki runner

2017-10-13 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384017 ) Change subject: Do not run QUnit tests using MediaWiki runner .. Do not run QUnit tests using MediaWiki runner This is going to become

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseJavaScriptApi[master]: Gave the upcoming npm package npm, and copied some package i...

2017-10-13 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384018 ) Change subject: Gave the upcoming npm package npm, and copied some package information from composer.json .. Gave the upcoming npm

[MediaWiki-commits] [Gerrit] mediawiki...Echo[master]: Minor PHPdoc fixes

2017-10-13 Thread WMDE-Fisch (Code Review)
WMDE-Fisch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384015 ) Change subject: Minor PHPdoc fixes .. Minor PHPdoc fixes Change-Id: I037df8d0bd13dd7a8201fd1408bb2f642f9786b6 --- M includes/api

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseJavaScriptApi[master]: Run QUnit tests with karma runner

2017-10-13 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384012 ) Change subject: Run QUnit tests with karma runner .. Run QUnit tests with karma runner This all is still far from perfect. Not all

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseJavaScriptApi[master]: Removed not used jshint config file

2017-10-13 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384011 ) Change subject: Removed not used jshint config file .. Removed not used jshint config file Change-Id

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Add missing retrun in getSummaryInputOOUI()

2017-10-13 Thread WMDE-Fisch (Code Review)
WMDE-Fisch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384009 ) Change subject: Add missing retrun in getSummaryInputOOUI() .. Add missing retrun in getSummaryInputOOUI() Change-Id

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Consistently use propertyLabelOrId instead of …IdOrLabel

2017-10-13 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384008 ) Change subject: Consistently use propertyLabelOrId instead of …IdOrLabel .. Consistently use propertyLabelOrId instead

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Make Entity expert consistently use rawValue

2017-10-13 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384007 ) Change subject: Make Entity expert consistently use rawValue .. Make Entity expert consistently use rawValue Change-Id

[MediaWiki-commits] [Gerrit] data-values/value-view[master]: Fix documentation of valueview.Expert.rawValue

2017-10-13 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383995 ) Change subject: Fix documentation of valueview.Expert.rawValue .. Fix documentation of valueview.Expert.rawValue Change-Id

[MediaWiki-commits] [Gerrit] data-values/value-view[master]: Remove unused messages

2017-10-13 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383988 ) Change subject: Remove unused messages .. Remove unused messages Change-Id: Ie23fc9600aece393e676b2578368399f382dde81 --- M

[MediaWiki-commits] [Gerrit] wikidata...gui[master]: Restore focus to editor after selecting example

2017-10-12 Thread Lucas Werkmeister (WMDE) (Code Review)
Lucas Werkmeister (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383882 ) Change subject: Restore focus to editor after selecting example .. Restore focus to editor after selecting example

[MediaWiki-commits] [Gerrit] wikidata...gui[master]: Add Wikilink code sample

2017-10-12 Thread Lucas Werkmeister (WMDE) (Code Review)
Lucas Werkmeister (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383873 ) Change subject: Add Wikilink code sample .. Add Wikilink code sample This produces a hyperlink to the query, in wikitext

[MediaWiki-commits] [Gerrit] integration/config[master]: Only run npm job for changes in data-values/value-view

2017-10-12 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383872 ) Change subject: Only run npm job for changes in data-values/value-view .. Only run npm job for changes in data-values/value-view Bug

[MediaWiki-commits] [Gerrit] wikidata...gui[master]: Remove duplicate _i18n function in FormatterHelper

2017-10-12 Thread Lucas Werkmeister (WMDE) (Code Review)
Lucas Werkmeister (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383871 ) Change subject: Remove duplicate _i18n function in FormatterHelper .. Remove duplicate _i18n function in FormatterHelper

[MediaWiki-commits] [Gerrit] data-values/value-view[master]: Remove remaining MediaWiki integration files

2017-10-12 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383864 ) Change subject: Remove remaining MediaWiki integration files .. Remove remaining MediaWiki integration files Bug: T177816 Change-Id

[MediaWiki-commits] [Gerrit] data-values/value-view[master]: Release 0.22.0

2017-10-12 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383867 ) Change subject: Release 0.22.0 .. Release 0.22.0 Bug: T177816 Change-Id: I3291ae62671e4fa82fe4ed67aa3cafa5375e459c --- M RELEASE

[MediaWiki-commits] [Gerrit] data-values/value-view[master]: Fix Travis CI config and use Node/JS environment on Travis CI

2017-10-12 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383866 ) Change subject: Fix Travis CI config and use Node/JS environment on Travis CI .. Fix Travis CI config and use Node/JS environment

[MediaWiki-commits] [Gerrit] data-values/value-view[master]: Updated release notes for the upcoming release

2017-10-12 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383865 ) Change subject: Updated release notes for the upcoming release .. Updated release notes for the upcoming release Bug: T177816 Change

[MediaWiki-commits] [Gerrit] data-values/value-view[master]: Removed PHPCS config

2017-10-12 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383862 ) Change subject: Removed PHPCS config .. Removed PHPCS config Change-Id: I4d8b9a89bd28d83ff3d5c5c334dee0e924c7f080 --- D phpcs.xml 1

<    2   3   4   5   6   7   8   9   10   11   >