jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/382462 )
Change subject: Add new icons for constraint violations
......................................................................
Add new icons for constraint violations
Parameter problems on the constraint statement continue to use the
standard “alert” icon, since they’re semantically different from
constraint violations of any kind.
Bug: T171586
Change-Id: Iff806b18f77f5343b4b4a7576048475ab67ecac0
---
M extension.json
M modules/gadget.js
A modules/icon/mandatory-constraint-violation.svg
A modules/icon/non-mandatory-constraint-violation.svg
4 files changed, 25 insertions(+), 1 deletion(-)
Approvals:
WMDE-leszek: Looks good to me, approved
jenkins-bot: Verified
diff --git a/extension.json b/extension.json
index fa16c0a..d24e514 100644
--- a/extension.json
+++ b/extension.json
@@ -49,6 +49,14 @@
"styles": "modules/SpecialConstraintReportPage.css",
"scripts": "modules/SpecialConstraintReportPage.js"
},
+ "wikibase.quality.constraints.icon": {
+ "class": "ResourceLoaderImageModule",
+ "selector": ".oo-ui-icon-{name}",
+ "images": {
+ "mandatory-constraint-violation":
"modules/icon/mandatory-constraint-violation.svg",
+ "non-mandatory-constraint-violation":
"modules/icon/non-mandatory-constraint-violation.svg"
+ }
+ },
"wikibase.quality.constraints.ui": {
"dependencies": [
"oojs-ui-core",
@@ -86,6 +94,7 @@
"oojs-ui-core",
"oojs-ui-widgets",
"oojs-ui.styles.icons-alerts",
+ "wikibase.quality.constraints.icon",
"wikibase.quality.constraints.ui"
],
"skipFunction": "modules/gadget-skip.js"
diff --git a/modules/gadget.js b/modules/gadget.js
index 42210b3..266b4db 100644
--- a/modules/gadget.js
+++ b/modules/gadget.js
@@ -157,7 +157,7 @@
buildPopup(
list.$element,
$target,
- haveMandatoryViolations ? 'alert' : 'info',
+ ( haveMandatoryViolations ? '' : 'non-' ) +
'mandatory-constraint-violation',
haveMandatoryViolations ? 'wbqc-issues-long' :
'wbqc-potentialissues-long'
);
}
@@ -260,6 +260,7 @@
'oojs-ui-core',
'oojs-ui-widgets',
'oojs-ui.styles.icons-alerts',
+ 'wikibase.quality.constraints.icon',
'wikibase.quality.constraints.ui'
] ).done( function () {
var api = new mw.Api(),
diff --git a/modules/icon/mandatory-constraint-violation.svg
b/modules/icon/mandatory-constraint-violation.svg
new file mode 100644
index 0000000..a6aa41c
--- /dev/null
+++ b/modules/icon/mandatory-constraint-violation.svg
@@ -0,0 +1,7 @@
+<?xml version="1.0" encoding="utf-8"?>
+<svg width="26" height="26" viewBox="0 0 26 26"
xmlns="http://www.w3.org/2000/svg";>
+ <g id="mandatory-constraint-violation">
+ <path id="rhombus" fill="none" stroke="#000" stroke-width="1.34"
d="M13 1l11.844 11.844L13 24.688 1.156 12.844z"/>
+ <path id="lightning" d="M0 6.542l-.455-.207-.32.707H0v-.5zm3.97
0l.475.16.22-.66h-.694v.5zM1.47
14l-.448.222.278.56.485-.393-.314-.39zm-1-2.025v-.5h-.806l.357.722.45-.222zm3.5
0l.315.39 1.097-.89h-1.41v.5zM2.516-.207l-2.97
6.542.91.414L3.425.206l-.91-.414zM0 7.043h3.97v-1H0v1zm3.497-.66l-2.5
7.458.948.32 2.5-7.46-.948-.317zM1.92 13.778L.916 11.754l-.896.443 1.002
2.025.897-.444zm-.135.61l2.5-2.024-.63-.777-2.5 2.024.63.78zM.47
12.476h3.5v-1H.47v1z" transform="translate(11.03 6)"/>
+ </g>
+</svg>
diff --git a/modules/icon/non-mandatory-constraint-violation.svg
b/modules/icon/non-mandatory-constraint-violation.svg
new file mode 100644
index 0000000..8a442a7
--- /dev/null
+++ b/modules/icon/non-mandatory-constraint-violation.svg
@@ -0,0 +1,7 @@
+<?xml version="1.0" encoding="utf-8"?>
+<svg width="28" height="28" viewBox="0 0 28 28"
xmlns="http://www.w3.org/2000/svg";>
+ <g id="non-mandatory-constraint-violation" transform="translate(4 4)">
+ <rect width="20" height="20" stroke="#000" fill="none" rx="2" ry="2"/>
+ <path id="exclamationMark" d="M-1 0v8h2V0h-2zm0 10v2h2v-2h-2z"
transform="translate(10 4)"/>
+ </g>
+</svg>
--
To view, visit https://gerrit.wikimedia.org/r/382462
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iff806b18f77f5343b4b4a7576048475ab67ecac0
Gerrit-PatchSet: 11
Gerrit-Project: mediawiki/extensions/WikibaseQualityConstraints
Gerrit-Branch: master
Gerrit-Owner: Lucas Werkmeister (WMDE) <lucas.werkmeis...@wikimedia.de>
Gerrit-Reviewer: Lucas Werkmeister (WMDE) <lucas.werkmeis...@wikimedia.de>
Gerrit-Reviewer: WMDE-leszek <leszek.mani...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
