Divadsn has uploaded a new change for review.
https://gerrit.wikimedia.org/r/324837
Change subject: Use isset( $options['isAutomatic'] ) to surpress unnecessary
errors.
......................................................................
Use isset( $options['isAutomatic'] ) to surpress unnecessary errors.
Change-Id: Ib9baac4aca92f1ad14069fd10edfb86ccf1f3925
---
M includes/WikidataPageBanner.functions.php
1 file changed, 2 insertions(+), 2 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikidataPageBanner
refs/changes/37/324837/1
diff --git a/includes/WikidataPageBanner.functions.php
b/includes/WikidataPageBanner.functions.php
index b518787..dc8c812 100755
--- a/includes/WikidataPageBanner.functions.php
+++ b/includes/WikidataPageBanner.functions.php
@@ -169,8 +169,8 @@
// don't auto generate banner if image is not
landscape, see bug report T131424
$fileWidth = $file->getWidth();
$fileHeight = $file->getHeight();
- if ( $options['isAutomatic'] && $fileWidth < 1.5 *
$fileHeight ) {
- return $banner;
+ if ( isset( $options['isAutomatic'] ) && $fileWidth <
1.5 * $fileHeight ) {
+ return null;
}
$templateParser = new TemplateParser( __DIR__ .
'/../templates' );
$options['bannerfile'] = $bannerfile->getLocalUrl();
--
To view, visit https://gerrit.wikimedia.org/r/324837
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib9baac4aca92f1ad14069fd10edfb86ccf1f3925
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikidataPageBanner
Gerrit-Branch: master
Gerrit-Owner: Divadsn <divad.nnamtd...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
