Brion VIBBER has uploaded a new change for review.
https://gerrit.wikimedia.org/r/122592
Change subject: [Gingerbread] Quick hack around more missing attrs
......................................................................
[Gingerbread] Quick hack around more missing attrs
Change-Id: Ic20b3d50aa0ec6b97f46419e6c2d2b5fb43ef334
---
M wikipedia/res/layout/activity_edit_section.xml
M wikipedia/res/layout/item_saved_page_entry.xml
M wikipedia/res/layout/item_toc_entry.xml
M wikipedia/res/values-v11/styles.xml
M wikipedia/res/values/styles.xml
5 files changed, 8 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/92/122592/1
diff --git a/wikipedia/res/layout/activity_edit_section.xml
b/wikipedia/res/layout/activity_edit_section.xml
index 914f60d..f2c7dd7 100644
--- a/wikipedia/res/layout/activity_edit_section.xml
+++ b/wikipedia/res/layout/activity_edit_section.xml
@@ -70,7 +70,6 @@
android:gravity="center"
android:text="@string/edit_section_abusefilter_back_text"
android:padding="8dp"
-
android:background="?android:attr/activatedBackgroundIndicator"
style="?android:textAppearanceMedium"
/>
<View android:layout_width="match_parent"
android:layout_height="1dp" android:background="@color/border"/>
diff --git a/wikipedia/res/layout/item_saved_page_entry.xml
b/wikipedia/res/layout/item_saved_page_entry.xml
index cf879ed..0a8ecf4 100644
--- a/wikipedia/res/layout/item_saved_page_entry.xml
+++ b/wikipedia/res/layout/item_saved_page_entry.xml
@@ -15,7 +15,7 @@
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:orientation="horizontal"
- android:background="?android:attr/activatedBackgroundIndicator"
+ style="ActivatedBackgroundIndicator"
>
<ImageView android:layout_width="16dp" android:layout_height="16dp"
android:id="@+id/saved_page_source"
diff --git a/wikipedia/res/layout/item_toc_entry.xml
b/wikipedia/res/layout/item_toc_entry.xml
index 57ff2a5..c1ed0ab 100644
--- a/wikipedia/res/layout/item_toc_entry.xml
+++ b/wikipedia/res/layout/item_toc_entry.xml
@@ -4,7 +4,7 @@
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:orientation="horizontal"
- android:background="?android:activatedBackgroundIndicator"
+ style="ActivatedBackgroundIndicator"
>
<View android:layout_width="0dp" android:layout_height="match_parent"
android:id="@+id/page_toc_filler"
diff --git a/wikipedia/res/values-v11/styles.xml
b/wikipedia/res/values-v11/styles.xml
index 376d45f..2074421 100644
--- a/wikipedia/res/values-v11/styles.xml
+++ b/wikipedia/res/values-v11/styles.xml
@@ -3,4 +3,7 @@
<style name="SelectableItem" parent="AppTheme">
<item
name="android:background">?android:attr/selectableItemBackground</item>
</style>
+ <style name="ActivatedBackgroundIndicator">
+ <item
name="android:background">?android:activatedBackgroundIndicator</item>
+ </style>
</resources>
\ No newline at end of file
diff --git a/wikipedia/res/values/styles.xml b/wikipedia/res/values/styles.xml
index 367113b..db57680 100644
--- a/wikipedia/res/values/styles.xml
+++ b/wikipedia/res/values/styles.xml
@@ -11,4 +11,7 @@
<style name="SelectableItem" parent="AppTheme">
<!--<item name="android:background">#ff00ff</item>--><!-- fixme better
default -->
</style>
+ <style name="ActivatedBackgroundIndicator">
+ <!--<item
name="android:background">?android:activatedBackgroundIndicator</item>-->
+ </style>
</resources>
\ No newline at end of file
--
To view, visit https://gerrit.wikimedia.org/r/122592
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic20b3d50aa0ec6b97f46419e6c2d2b5fb43ef334
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Brion VIBBER <br...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
