Bene has uploaded a new change for review.
https://gerrit.wikimedia.org/r/271240
Change subject: [WIP] Use entity type registry for content model mapping
......................................................................
[WIP] Use entity type registry for content model mapping
Change-Id: I3e54e658af99a3bffdf0ecd1562ccb1fafcb2fba
---
M lib/includes/EntityTypeDefinitions.php
M repo/includes/WikibaseRepo.php
2 files changed, 8 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/40/271240/1
diff --git a/lib/includes/EntityTypeDefinitions.php
b/lib/includes/EntityTypeDefinitions.php
index 5d24135..5ad6c66 100644
--- a/lib/includes/EntityTypeDefinitions.php
+++ b/lib/includes/EntityTypeDefinitions.php
@@ -65,4 +65,11 @@
return $this->entityTypeDefinitions->getMapForDefinitionField(
'change-factory-callback' );
}
+ /**
+ * @return string[]
+ */
+ public function getContentModelMapping() {
+ return $this->entityTypeDefinitions->getMapForDefinitionField(
'content-model' );
+ }
+
}
diff --git a/repo/includes/WikibaseRepo.php b/repo/includes/WikibaseRepo.php
index 5ec27d2..0bc1948 100644
--- a/repo/includes/WikibaseRepo.php
+++ b/repo/includes/WikibaseRepo.php
@@ -1097,11 +1097,7 @@
* @return array
*/
public function getContentModelMappings() {
- // @TODO: We should have smth. like this for namespaces too
- $map = array(
- Item::ENTITY_TYPE => CONTENT_MODEL_WIKIBASE_ITEM,
- Property::ENTITY_TYPE => CONTENT_MODEL_WIKIBASE_PROPERTY
- );
+ $map = $this->entityTypeDefinitions->getContentModelMapping();
Hooks::run( 'WikibaseContentModelMapping', array( &$map ) );
--
To view, visit https://gerrit.wikimedia.org/r/271240
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3e54e658af99a3bffdf0ecd1562ccb1fafcb2fba
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Bene <benestar.wikime...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
