Xqt has uploaded a new change for review.
https://gerrit.wikimedia.org/r/256387
Change subject: [bugfix] 'xcf' is a valid file extension
......................................................................
[bugfix] 'xcf' is a valid file extension
- assign delete_immediately message to msg_del_comm message before adding
line feed.
- Skip processing if no sd template is given
- move di assignments to needed code part. Otherwise the script would break
Change-Id: I8adc815c658a3c3cf3052e8fb39e0cdd867b1026
---
M scripts/checkimages.py
1 file changed, 7 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core
refs/changes/87/256387/1
diff --git a/scripts/checkimages.py b/scripts/checkimages.py
index 0e752e5..da83713 100755
--- a/scripts/checkimages.py
+++ b/scripts/checkimages.py
@@ -1477,7 +1477,7 @@
# Don't put "}}" here, please. Useless and can give problems.
something = ['{{']
# Unused file extensions. Does not contain PDF.
- notallowed = ("xcf", "xls", "sxw", "sxi", "sxc", "sxd")
+ notallowed = ('xls', 'sxw', 'sxi', 'sxc', 'sxd')
brackets = False
delete = False
notification = None
@@ -1493,10 +1493,6 @@
nn = i18n.translate(self.site, nothing_notification)
dels = i18n.translate(self.site, msg_del_comm, fallback=True)
smwl = i18n.translate(self.site, second_message_without_license)
-
- # Some formatting for delete immediately template
- di = u'\n%s' % di
- dels = dels % di
try:
self.imageCheckText = self.image.get()
@@ -1536,6 +1532,12 @@
return True
elif delete:
pywikibot.output(u"%s is not a file!" % self.imageName)
+ if not di:
+ pywikibot.output('No speedy deletion template given.
Skipping.')
+ return
+ # Some formatting for delete immediately template
+ dels = dels % di
+ di = '\n' + di
# Modify summary text
pywikibot.setAction(dels)
canctext = di % extension
--
To view, visit https://gerrit.wikimedia.org/r/256387
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8adc815c658a3c3cf3052e8fb39e0cdd867b1026
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Xqt <i...@gno.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
