Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/219167
Change subject: Add convenience getTerm method to TermIndexEntry ...................................................................... Add convenience getTerm method to TermIndexEntry Change-Id: I95cc093bec3f275b09257da6403037139debc3cd --- M lib/includes/TermIndexEntry.php M lib/tests/phpunit/TermIndexEntryTest.php 2 files changed, 18 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/67/219167/1 diff --git a/lib/includes/TermIndexEntry.php b/lib/includes/TermIndexEntry.php index 88facdb..4312cca 100644 --- a/lib/includes/TermIndexEntry.php +++ b/lib/includes/TermIndexEntry.php @@ -5,6 +5,7 @@ use MWException; use Wikibase\DataModel\Entity\EntityId; use Wikibase\DataModel\LegacyIdInterpreter; +use Wikibase\DataModel\Term\Term; /** * Object representing a term index entry. @@ -220,4 +221,11 @@ return 0; } + /** + * @return Term + */ + public function getTerm() { + return new Term( $this->getLanguage(), $this->getText() ); + } + } diff --git a/lib/tests/phpunit/TermIndexEntryTest.php b/lib/tests/phpunit/TermIndexEntryTest.php index 7946320..f56cb94 100644 --- a/lib/tests/phpunit/TermIndexEntryTest.php +++ b/lib/tests/phpunit/TermIndexEntryTest.php @@ -3,6 +3,7 @@ namespace Wikibase\Test; use Wikibase\DataModel\LegacyIdInterpreter; +use Wikibase\DataModel\Term\Term; use Wikibase\TermIndexEntry; /** @@ -173,4 +174,13 @@ } } + public function testToTerm() { + $termIndexEntry = new TermIndexEntry( array( + 'termLanguage' => 'en', + 'termText' => 'foo', + ) ); + $expectedTerm = new Term( 'en', 'foo' ); + $this->assertEquals( $expectedTerm, $termIndexEntry->getTerm() ); + } + } -- To view, visit https://gerrit.wikimedia.org/r/219167 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I95cc093bec3f275b09257da6403037139debc3cd Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Addshore <addshorew...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits