Addshore has uploaded a new change for review.
https://gerrit.wikimedia.org/r/108495
Change subject: Add further tests for ChangeOpReferenceRemove
......................................................................
Add further tests for ChangeOpReferenceRemove
Change-Id: Id2485bf07d6d7b320a1906a626e9489cd3780b42
---
M repo/tests/phpunit/includes/ChangeOp/ChangeOpReferenceRemoveTest.php
1 file changed, 17 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/95/108495/1
diff --git
a/repo/tests/phpunit/includes/ChangeOp/ChangeOpReferenceRemoveTest.php
b/repo/tests/phpunit/includes/ChangeOp/ChangeOpReferenceRemoveTest.php
index 2d73314..228c723 100644
--- a/repo/tests/phpunit/includes/ChangeOp/ChangeOpReferenceRemoveTest.php
+++ b/repo/tests/phpunit/includes/ChangeOp/ChangeOpReferenceRemoveTest.php
@@ -3,6 +3,7 @@
namespace Wikibase\Test;
use DataValues\StringValue;
+use InvalidArgumentException;
use Wikibase\ChangeOp\ChangeOpReferenceRemove;
use Wikibase\DataModel\Claim\Claims;
use Wikibase\DataModel\Claim\Statement;
@@ -26,6 +27,22 @@
*/
class ChangeOpReferenceRemoveTest extends \PHPUnit_Framework_TestCase {
+ public function invalidConstructorProvider() {
+ $args = array();
+ $args[] = array( '', '' );
+ $args[] = array( '', 'foo' );
+ $args[] = array( 'foo', '' );
+ return $args;
+ }
+
+ /**
+ * @dataProvider invalidConstructorProvider
+ * @expectedException InvalidArgumentException
+ */
+ public function testInvalidConstruct( $claimGuid, $referenceHash ) {
+ new ChangeOpReferenceRemove( $claimGuid, $referenceHash );
+ }
+
public function changeOpRemoveProvider() {
$snak = new PropertyValueSnak( 2754236, new StringValue( 'test'
) );
$args = array();
--
To view, visit https://gerrit.wikimedia.org/r/108495
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id2485bf07d6d7b320a1906a626e9489cd3780b42
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Addshore <addshorew...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
