John Vandenberg has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/179456

Change subject: Allow any autorun script to fail
......................................................................

Allow any autorun script to fail

autorun scripts are disabled by default in script_tests.collector,
however the collector isnt always used by nosetests.

Set all autorun scripts to be allowed_failure, if there isnt an
existing reason why they will always fail on every site.

Change-Id: I8288d628ee7807b0ba6e2992cd31dfbeca060eda
---
M tests/script_tests.py
1 file changed, 3 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core 
refs/changes/56/179456/1

diff --git a/tests/script_tests.py b/tests/script_tests.py
index f7e2422..d493aae 100644
--- a/tests/script_tests.py
+++ b/tests/script_tests.py
@@ -386,16 +386,12 @@
                                'checkimages',     # bug 68613
                                'data_ingestion',  # bug 68611
                                'flickrripper',    # Requires a flickr api key
-                               'lonelypages',     # uses exit code 1
                                'script_wui',      # Error on any user except 
DrTrigonBot
-                               'upload',          # raises custom ValueError
-                               ] + failed_dep_script_list or (
-                    (config.family != 'wikipedia' and script_name == 
'lonelypages') or
-                    (config.family == 'wikipedia' and script_name == 
'disambredir') or
-                    (config.family == 'wikipedia' and config.mylang != 'en' 
and script_name == 'misspelling')):
+                               ] + failed_dep_script_list:
                 dct[test_name] = unittest.expectedFailure(dct[test_name])
             elif script_name in ['watchlist',     # T77965
-                                 ]:
+                                 'lonelypages',   # exit code 1 on some sites
+                                 ] + auto_run_script_list:
                 dct[test_name] = allowed_failure(dct[test_name])
             dct[test_name].__doc__ = \
                 'Test running ' + script_name + ' -simulate.'

-- 
To view, visit https://gerrit.wikimedia.org/r/179456
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8288d628ee7807b0ba6e2992cd31dfbeca060eda
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: John Vandenberg <jay...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to