Bartosz Dziewoński has uploaded a new change for review.
https://gerrit.wikimedia.org/r/106855
Change subject: Always disallow user JS on Special:UserLogin
......................................................................
Always disallow user JS on Special:UserLogin
There are code paths where it wasn't done; let's do it for consistency
if not security.
Change-Id: I3d14a212e458f556a2dbff28471fe0eafdcbc6ab
---
M includes/specials/SpecialUserlogin.php
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/55/106855/1
diff --git a/includes/specials/SpecialUserlogin.php
b/includes/specials/SpecialUserlogin.php
index 8e5ef58..9dce606 100644
--- a/includes/specials/SpecialUserlogin.php
+++ b/includes/specials/SpecialUserlogin.php
@@ -159,6 +159,8 @@
$this->load();
+ $out->disallowUserJs(); // just in case...
+
// Check for [[Special:Userlogin/signup]]. This affects form
display and
// page title.
if ( $subPage == 'signup' ) {
@@ -1248,7 +1250,6 @@
wfRunHooks( 'UserLoginForm', array( &$template ) );
}
- $out->disallowUserJs(); // just in case...
$out->addTemplate( $template );
}
--
To view, visit https://gerrit.wikimedia.org/r/106855
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3d14a212e458f556a2dbff28471fe0eafdcbc6ab
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <matma....@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
