Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/179170
Change subject: Always use array style for GROUP BY/ORDER BY
......................................................................
Always use array style for GROUP BY/ORDER BY
Change-Id: I0b93a58e49eab4d6173102c99ca8694dc81e2adc
---
M includes/api/ApiQueryContributors.php
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/70/179170/1
diff --git a/includes/api/ApiQueryContributors.php
b/includes/api/ApiQueryContributors.php
index 7e76db2..94e175f 100644
--- a/includes/api/ApiQueryContributors.php
+++ b/includes/api/ApiQueryContributors.php
@@ -114,13 +114,13 @@
$this->addWhereFld( 'rev_page', $pages );
$this->addWhere( 'rev_user != 0' );
$this->addWhere( $db->bitAnd( 'rev_deleted',
Revision::DELETED_USER ) . ' = 0' );
- $this->addOption( 'GROUP BY', 'rev_page, rev_user' );
+ $this->addOption( 'GROUP BY', array( 'rev_page', 'rev_user' ) );
$this->addOption( 'LIMIT', $params['limit'] + 1 );
// Force a sort order to ensure that properties are grouped by
page
// But only if pp_page is not constant in the WHERE clause.
if ( count( $pages ) > 1 ) {
- $this->addOption( 'ORDER BY', 'rev_page, rev_user' );
+ $this->addOption( 'ORDER BY', array( 'rev_page',
'rev_user' ) );
} else {
$this->addOption( 'ORDER BY', 'rev_user' );
}
--
To view, visit https://gerrit.wikimedia.org/r/179170
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0b93a58e49eab4d6173102c99ca8694dc81e2adc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <umherirrender_de...@web.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
