Jackmcbarn has uploaded a new change for review.
https://gerrit.wikimedia.org/r/160550
Change subject: Call Title::exists() instead of checking the ID
......................................................................
Call Title::exists() instead of checking the ID
Bug: 70495
Change-Id: I732da9daccdc35b11d726818c3a7c81f5e810a32
---
M engines/LuaCommon/TitleLibrary.php
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Scribunto
refs/changes/50/160550/1
diff --git a/engines/LuaCommon/TitleLibrary.php
b/engines/LuaCommon/TitleLibrary.php
index 8a47798..12d63b4 100644
--- a/engines/LuaCommon/TitleLibrary.php
+++ b/engines/LuaCommon/TitleLibrary.php
@@ -87,7 +87,8 @@
if ( $ns === NS_SPECIAL ) {
$ret['exists'] = (bool)SpecialPageFactory::exists(
$title->getDBkey() );
} else {
- $ret['exists'] = $ret['id'] > 0;
+ // bug 70495: don't just check whether the ID != 0
+ $ret['exists'] = $title->exists();
}
if ( $ns !== NS_FILE && $ns !== NS_MEDIA ) {
$ret['fileExists'] = false;
--
To view, visit https://gerrit.wikimedia.org/r/160550
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I732da9daccdc35b11d726818c3a7c81f5e810a32
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Scribunto
Gerrit-Branch: master
Gerrit-Owner: Jackmcbarn <jackmcb...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
