[MediaWiki-commits] [Gerrit] Directiona adjustment to styling - change (mediawiki...VisualEditor)

[Mooeypoo (Code Review)]

Mooeypoo has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/101041


Change subject: Directiona adjustment to <figure> styling
......................................................................

Directiona adjustment to <figure> styling

Adding @noflip to align-left and align-right in the <figure> css styling
rules and removing the need to resize the Branch Node div element on center.

Change-Id: Iec6e589ba9ecdf32c1a0934b9eb05ee3fd42af66
---
M modules/ve-mw/ce/nodes/ve.ce.MWBlockImageNode.js
M modules/ve-mw/ce/styles/ve.ce.Node.css
2 files changed, 4 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/41/101041/1

diff --git a/modules/ve-mw/ce/nodes/ve.ce.MWBlockImageNode.js 
b/modules/ve-mw/ce/nodes/ve.ce.MWBlockImageNode.js
index 9bec405..38dc94a 100644
--- a/modules/ve-mw/ce/nodes/ve.ce.MWBlockImageNode.js
+++ b/modules/ve-mw/ce/nodes/ve.ce.MWBlockImageNode.js
@@ -237,18 +237,6 @@
                        'width': width + 5
                } );
 
-       // A image that is centered must have dimensions
-       // to its node div wrapper
-       if ( this.alignment === 'center' ) {
-               this.$element
-                       .css( {
-                               'width': width
-                       } );
-       } else {
-               this.$element.css( { 'width': 'auto' } );
-       }
-
-
        // update:
        this.size = {
                height: height,
@@ -266,9 +254,9 @@
        // Default is different between RTL and LTR wikis:
        if ( type === 'default' && alignment === 'default' ) {
                if ( this.$element.css( 'direction' ) === 'rtl' ) {
-                       return 'tleft';
+                       return 'mw-halign-left';
                } else {
-                       return 'tright';
+                       return 'mw-halign-right';
                }
        } else {
                return this.constructor.static.cssClasses[type][alignment];
diff --git a/modules/ve-mw/ce/styles/ve.ce.Node.css 
b/modules/ve-mw/ce/styles/ve.ce.Node.css
index dfb78af..e39471f 100644
--- a/modules/ve-mw/ce/styles/ve.ce.Node.css
+++ b/modules/ve-mw/ce/styles/ve.ce.Node.css
@@ -51,6 +51,7 @@
        margin: 5px;
 }
 
+/* @noflip */
 figure[typeof*='mw:Image'].mw-halign-right {
        clear: right;
        float: right;
@@ -61,6 +62,7 @@
        margin-right: auto;
 }
 
+/* @noflip */
 figure[typeof*='mw:Image'].mw-halign-left {
        clear: left;
        float: left;

-- 
To view, visit https://gerrit.wikimedia.org/r/101041
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iec6e589ba9ecdf32c1a0934b9eb05ee3fd42af66
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Mooeypoo <mor...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits