Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/202012
Change subject: Disable automatic sorting of Page Status Indicators
......................................................................
Disable automatic sorting of Page Status Indicators
Consistency is cited for automatic sorting of indicators, but benefits are not
demonstrated and it takes away any control of icon placement by the user
without having to play with the indicator name (which is often not possible) or
resort to other unsightly hacks in template: and module: space.
Indicators were created to move away from these hacks, but has failed in that
respect, and users want to regain control of indicator placement. Therefor this
patch removed the ksort() statement, so indicators are placed in the oder they
are placed on the page.
Sorting can be implemented at template level if so desired, as templates are
the main recommended method for invoking indicators in the first place.
Bug: T94307
Change-Id: If2148e0f9d705e732755f4f1d420e302d11810cf
---
M includes/OutputPage.php
1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/12/202012/1
diff --git a/includes/OutputPage.php b/includes/OutputPage.php
index cac89f4..efd5145 100644
--- a/includes/OutputPage.php
+++ b/includes/OutputPage.php
@@ -1383,8 +1383,6 @@
*/
public function setIndicators( array $indicators ) {
$this->mIndicators = $indicators + $this->mIndicators;
- // Keep ordered by key
- ksort( $this->mIndicators );
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/202012
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If2148e0f9d705e732755f4f1d420e302d11810cf
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader <gerritpatchuploa...@gmail.com>
Gerrit-Reviewer: Edokter <er...@darcoury.nl>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
