Spage has uploaded a new change for review.
https://gerrit.wikimedia.org/r/189158
Change subject: Don't add empty objects to mw.templates
......................................................................
Don't add empty objects to mw.templates
Test isEmptyObject() before adding module's templates.
Fixes T88879
Bug: T88879
Change-Id: Ifd62eba04a32e3d13643bf3cc30d670f00abe7db
---
M resources/src/mediawiki/mediawiki.js
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/58/189158/1
diff --git a/resources/src/mediawiki/mediawiki.js
b/resources/src/mediawiki/mediawiki.js
index bed5cb5..046f3de 100644
--- a/resources/src/mediawiki/mediawiki.js
+++ b/resources/src/mediawiki/mediawiki.js
@@ -1256,7 +1256,7 @@
}
// Initialise templates
- if ( registry[module].templates ) {
+ if ( registry[module].templates &&
!$.isEmptyObject( registry[module].templates ) ) {
mw.templates.set( module,
registry[module].templates );
}
--
To view, visit https://gerrit.wikimedia.org/r/189158
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifd62eba04a32e3d13643bf3cc30d670f00abe7db
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Spage <sp...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
