Bartosz Dziewoński has uploaded a new change for review. https://gerrit.wikimedia.org/r/220746
Change subject: Don't output an empty h1 element (one more, with feeling) ...................................................................... Don't output an empty h1 element (one more, with feeling) Bug: T103077 Change-Id: I786fb10c5688d13b779e84b4d83efc6c0fd992d8 --- M VectorTemplate.php 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/Vector refs/changes/46/220746/1 diff --git a/VectorTemplate.php b/VectorTemplate.php index eca1ae4..ec2c87a 100644 --- a/VectorTemplate.php +++ b/VectorTemplate.php @@ -110,7 +110,8 @@ if ( is_callable( array( $this, 'getIndicators' ) ) ) { echo $this->getIndicators(); } - if ( isset( $this->data['title'] ) ) { + // Loose comparison with '!=' is intentional, to catch null and false too, but not '0' + if ( $this->data['title'] != '' ) { ?> <h1 id="firstHeading" class="firstHeading" lang="<?php $this->text( 'pageLanguage' ); ?>"><?php $this->html( 'title' ) -- To view, visit https://gerrit.wikimedia.org/r/220746 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I786fb10c5688d13b779e84b4d83efc6c0fd992d8 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/skins/Vector Gerrit-Branch: master Gerrit-Owner: Bartosz Dziewoński <matma....@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits