jenkins-bot has submitted this change and it was merged.
Change subject: Ensure translated pages are rendered with data from master
......................................................................
Ensure translated pages are rendered with data from master
Possible fix for bug 46716. I can't reproduce it myself so
I can't test the fix either.
Hypothesis: the filter loads page existence data from slave.
Completely new translation would show up as non-existing and
be filtered out. Loading the actual content from master in
the next line would not help, as we already filtered that unit
away. By switching these lines we immediately load the content
and page existence from master and filter afterwads.
Bug: 46716
Change-Id: I5e71c7adf87c1a6ee953d9292965a9231c0299c9
---
M tag/TPParse.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Siebrand: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tag/TPParse.php b/tag/TPParse.php
index 37038df..0e9e302 100644
--- a/tag/TPParse.php
+++ b/tag/TPParse.php
@@ -176,8 +176,8 @@
$prefix = $this->title->getPrefixedDBKey() . '/';
if ( $collection instanceof MessageCollection ) {
- $collection->filter( 'translated', false );
$collection->loadTranslations( DB_MASTER );
+ $collection->filter( 'translated', false );
}
foreach ( $this->sections as $ph => $s ) {
--
To view, visit https://gerrit.wikimedia.org/r/60974
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5e71c7adf87c1a6ee953d9292965a9231c0299c9
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit <niklas.laxst...@gmail.com>
Gerrit-Reviewer: Siebrand <siebr...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
