Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/238671
Change subject: FauxRequest: Actually ignore headers from $_SERVER
......................................................................
FauxRequest: Actually ignore headers from $_SERVER
Follows-up 578a0c082ff21a62 which removed the private method
override for 'initHeaders' because it wasn't working. While that
commit didn't cause this bug, it is still a bug.
This class
Change-Id: I4c06369968e8c62e4306e08d1e69394b0957f5b5
---
M tests/phpunit/includes/FauxRequestTest.php
1 file changed, 12 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/71/238671/1
diff --git a/tests/phpunit/includes/FauxRequestTest.php
b/tests/phpunit/includes/FauxRequestTest.php
index eca5b39..c3e601b 100644
--- a/tests/phpunit/includes/FauxRequestTest.php
+++ b/tests/phpunit/includes/FauxRequestTest.php
@@ -20,4 +20,16 @@
array( 'text/plain', 'text/html' )
);
}
+
+ /**
+ * @covers FauxRequest::getHeader
+ */
+ public function testGetHeader() {
+ $_SERVER['HTTP_TEST'] = 'Example';
+
+ $request = new FauxRequest();
+
+ $this->assertEquals( $request->getAllHeaders(), array() );
+ $this->assertEquals( $request->getHeader( 'Test' ), false );
+ }
}
--
To view, visit https://gerrit.wikimedia.org/r/238671
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4c06369968e8c62e4306e08d1e69394b0957f5b5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Krinkle <krinklem...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
