Aude has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/247465

Change subject: Fix $forUpdate variable in WikiPageEntityRedirectLookup
......................................................................

Fix $forUpdate variable in WikiPageEntityRedirectLookup

this is fixed on master and just a guess, maybe related
to T115892 and worth + safe to backport.

Change-Id: I66f8fa3fe751a18155b4ad70c392ae425f695d54
---
M repo/includes/store/sql/WikiPageEntityRedirectLookup.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/65/247465/1

diff --git a/repo/includes/store/sql/WikiPageEntityRedirectLookup.php 
b/repo/includes/store/sql/WikiPageEntityRedirectLookup.php
index 85c9e6a..38df272 100644
--- a/repo/includes/store/sql/WikiPageEntityRedirectLookup.php
+++ b/repo/includes/store/sql/WikiPageEntityRedirectLookup.php
@@ -105,7 +105,7 @@
        public function getRedirectForEntityId( EntityId $entityId, $forUpdate 
= '' ) {
                $title = $this->entityTitleLookup->getTitleForId( $entityId );
 
-               $forUpdate === 'for update' ? DB_MASTER : DB_SLAVE;
+               $forUpdate = $forUpdate === 'for update' ? DB_MASTER : DB_SLAVE;
                $db = $this->loadBalancer->getConnection( $forUpdate );
 
                $row = $db->selectRow(

-- 
To view, visit https://gerrit.wikimedia.org/r/247465
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I66f8fa3fe751a18155b4ad70c392ae425f695d54
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: wmf/1.27.0-wmf.1
Gerrit-Owner: Aude <aude.w...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to