Tim Landscheidt has uploaded a new change for review. Change subject: Fix ORMRow::insert() on PostgreSQL. ......................................................................
Fix ORMRow::insert() on PostgreSQL. When inserting a new row, ORMRow explicitly passed NULL as the value for the id field which in MySQL means "use next value in sequence", but in PostgreSQL means "use NULL". With this change, for id fields no value is passed if it isn't set to non-null. This fixes bug #43475. This effectively bars the possibility to set the id field of an existing row to NULL, but the current code already disallows any changes in id fields. Change-Id: I29d86fa6fc38ff1852821658e4927b4d7d4a72b6 --- M includes/db/ORMRow.php 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/20/41020/1 -- To view, visit https://gerrit.wikimedia.org/r/41020 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I29d86fa6fc38ff1852821658e4927b4d7d4a72b6 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Tim Landscheidt <t...@tim-landscheidt.de> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
