Jackmcbarn has uploaded a new change for review.
https://gerrit.wikimedia.org/r/166038
Change subject: Fix access level and remove unnecessary redefinitions
......................................................................
Fix access level and remove unnecessary redefinitions
In I019c24d1, some member variables were accidentally changed from public
to protected. This restores those, and also fixes unnecessary
redefinitions in Scribunto_LuaModule.
Change-Id: Ib0232a5adcd9ad7ea5c0f4413ba06c42b5506d7b
---
M common/Base.php
M engines/LuaCommon/LuaCommon.php
2 files changed, 3 insertions(+), 17 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Scribunto
refs/changes/38/166038/1
diff --git a/common/Base.php b/common/Base.php
index 1fbf945..a360844 100644
--- a/common/Base.php
+++ b/common/Base.php
@@ -283,17 +283,17 @@
/**
* @var ScribuntoEngineBase
*/
- protected $engine;
+ public $engine;
/**
* @var string
*/
- protected $code;
+ public $code;
/**
* @var string
*/
- protected $chunkName;
+ public $chunkName;
/**
* @param ScribuntoEngineBase $engine
diff --git a/engines/LuaCommon/LuaCommon.php b/engines/LuaCommon/LuaCommon.php
index 4221431..28563c9 100644
--- a/engines/LuaCommon/LuaCommon.php
+++ b/engines/LuaCommon/LuaCommon.php
@@ -806,23 +806,9 @@
class Scribunto_LuaModule extends ScribuntoModuleBase {
/**
- * @var Scribunto_LuaEngine
- */
- protected $engine;
-
- /**
* @var string
*/
protected $initChunk;
-
- /**
- * @param Scribunto_LuaEngine $engine
- * @param string $code
- * @param string $chunkName
- */
- public function __construct( Scribunto_LuaEngine $engine, $code,
$chunkName ) {
- parent::__construct( $engine, $code, $chunkName );
- }
public function validate() {
try {
--
To view, visit https://gerrit.wikimedia.org/r/166038
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib0232a5adcd9ad7ea5c0f4413ba06c42b5506d7b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Scribunto
Gerrit-Branch: master
Gerrit-Owner: Jackmcbarn <jackmcb...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
