Esanders has uploaded a new change for review.
https://gerrit.wikimedia.org/r/199878
Change subject: Fix documentation of 'choose' event
......................................................................
Fix documentation of 'choose' event
It can't (and shoudn't) emit a null item. See #chooseItem.
Change-Id: I7f4ccb5e88e70b70d4333aad0ad8771ec8df0885
---
M src/widgets/SelectWidget.js
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/78/199878/1
diff --git a/src/widgets/SelectWidget.js b/src/widgets/SelectWidget.js
index 28ebcb6..3aba716 100644
--- a/src/widgets/SelectWidget.js
+++ b/src/widgets/SelectWidget.js
@@ -111,7 +111,7 @@
/**
* @event choose
* A `choose` event is emitted when an item is chosen with the #chooseItem
method.
- * @param {OO.ui.OptionWidget|null} item Chosen item
+ * @param {OO.ui.OptionWidget} item Chosen item
*/
/**
--
To view, visit https://gerrit.wikimedia.org/r/199878
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7f4ccb5e88e70b70d4333aad0ad8771ec8df0885
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Esanders <esand...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
