Eranroz has uploaded a new change for review. https://gerrit.wikimedia.org/r/237619
Change subject: Fix for T112104 ...................................................................... Fix for T112104 late debounce cause annoying flashes. Validate elements are updated before replacing elements in the DOM. Change-Id: Ia9556b0b9e9f5b0132be5a61a2cde7bb4dc5606e --- M modules/ext.echo.init.js 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo refs/changes/19/237619/1 diff --git a/modules/ext.echo.init.js b/modules/ext.echo.init.js index 49db620..b6c12d0 100644 --- a/modules/ext.echo.init.js +++ b/modules/ext.echo.init.js @@ -34,6 +34,8 @@ badgeIcon: 'speechBubble', links: links } ); + // avoid late debouncedUpdateThemeClasses + mw.echo.ui.messageWidget.updateElementClasses(); $existingMessageLink.replaceWith( mw.echo.ui.messageWidget.$element ); } @@ -48,6 +50,9 @@ }, links: links } ); + + // avoid late debouncedUpdateThemeClasses + mw.echo.ui.alertWidget.updateElementClasses(); $existingAlertLink.replaceWith( mw.echo.ui.alertWidget.$element ); } ); -- To view, visit https://gerrit.wikimedia.org/r/237619 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia9556b0b9e9f5b0132be5a61a2cde7bb4dc5606e Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Echo Gerrit-Branch: master Gerrit-Owner: Eranroz <eranro...@gmail.com> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits