Eranroz has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/156184

Change subject: Fix for bug 64797 - set href for langlinks
......................................................................

Fix for bug 64797 - set href for langlinks

Includes some internal changes for easier access to language links once they 
are ready.

Change-Id: Ia8b2ad22913693d2f88693091d288ca74d7d8c87
---
M lib/jquery.uls/src/jquery.uls.core.js
M lib/jquery.uls/src/jquery.uls.lcd.js
M resources/js/ext.uls.compactlinks.js
3 files changed, 14 insertions(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UniversalLanguageSelector 
refs/changes/84/156184/1

diff --git a/lib/jquery.uls/src/jquery.uls.core.js 
b/lib/jquery.uls/src/jquery.uls.core.js
index 548a07b..173a3f5 100644
--- a/lib/jquery.uls/src/jquery.uls.core.js
+++ b/lib/jquery.uls/src/jquery.uls.core.js
@@ -267,7 +267,8 @@
                                quickList: this.options.quickList,
                                clickhandler: $.proxy( this.select, this ),
                                source: this.$languageFilter,
-                               showRegions: this.options.showRegions
+                               showRegions: this.options.showRegions,
+                               onShowRegions: this.options.onShowRegions
                        } ).data( 'lcd' );
 
                        this.$languageFilter.languagefilter( {
@@ -396,6 +397,7 @@
 
        $.fn.uls.defaults = {
                onSelect: null, // Callback function to be called when a 
language is selected
+               onShowRegions: null, // Callback function to be called when a 
regions are ready
                searchAPI: null, // Language search API
                languages: $.uls.data.getAutonyms(), // Languages to be used 
for ULS, default is all languages
                quickList: null, // Array of language codes or function that 
returns such
diff --git a/lib/jquery.uls/src/jquery.uls.lcd.js 
b/lib/jquery.uls/src/jquery.uls.lcd.js
index 7d207bd..3a2ff10 100644
--- a/lib/jquery.uls/src/jquery.uls.lcd.js
+++ b/lib/jquery.uls/src/jquery.uls.lcd.js
@@ -179,6 +179,10 @@
                                lcd.regionLanguages[regionCode] = [];
                        } );
 
+                       // trigger for customization
+                       if ( this.options.onShowRegions ) {
+                               this.options.onShowRegions.call( this );
+                       }
                },
 
                /**
diff --git a/resources/js/ext.uls.compactlinks.js 
b/resources/js/ext.uls.compactlinks.js
index 871f076..c4759f9 100644
--- a/resources/js/ext.uls.compactlinks.js
+++ b/resources/js/ext.uls.compactlinks.js
@@ -132,6 +132,13 @@
                                        }
                                        this.$menu.css( 'left', this.left );
                                },
+                               onShowRegions: function () {
+                                       // set href according to language
+                                       this.$element.find( 'li a' ).each( 
function( i, langLink ) {
+                                               var language = $( 
langLink.parentNode ).data( 'code' );
+                                               $( langLink ).prop( 'href', 
compactLinks.interlanguageList[ language ].href );
+                                       } );
+                               }
                                // Use compact version of ULS
                                compact: true,
                                // Top position of the language selector. Top 
it 250px above to take care of

-- 
To view, visit https://gerrit.wikimedia.org/r/156184
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia8b2ad22913693d2f88693091d288ca74d7d8c87
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector
Gerrit-Branch: master
Gerrit-Owner: Eranroz <eranro...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to