Markus Kroetzsch has submitted this change and it was merged. Change subject: Fix handling of Container objects. ......................................................................
Fix handling of Container objects. The following code introduces new handling method of Container DI objects, SemanticData stores Containers in an array instead of passing them around as property-values, the writers handle these Subobjects separately on their own. The code is divided into small functions to make things cleaner and self-explanatory. This also fixes some very minor errors in previous commits Patchset 4: Not deleting smw_ids, these need special code which has to come in a separate commit. Not replacing DIContainers with DIWikiPages as this leads to difficult handling when removing Containers. Removing DIContainers is changed as per comments. Patchset 5: Containers are replaced with WikiPages after their data is copied to subSemanticData, all methods handle subSemanticData too. Patchset 6: Fix small errors with the code, proper subject compatibility checks '''Tested to work fine''' Change-Id: Ib407a10fe7c637b151ea9e342eb9bcb788588eed --- M includes/SMW_SemanticData.php M includes/storage/SQLStore/SMW_SQLStore3Table.php M includes/storage/SQLStore/SMW_SQLStore3_Writers.php 3 files changed, 173 insertions(+), 36 deletions(-) Approvals: Markus Kroetzsch: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/19378 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib407a10fe7c637b151ea9e342eb9bcb788588eed Gerrit-PatchSet: 7 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Nischayn22 <nischay...@gmail.com> Gerrit-Reviewer: Jeroen De Dauw <jeroended...@gmail.com> Gerrit-Reviewer: Markus Kroetzsch <mar...@semantic-mediawiki.org> Gerrit-Reviewer: Mwjames <jamesin.hongkon...@gmail.com> Gerrit-Reviewer: Nischayn22 <nischay...@gmail.com> Gerrit-Reviewer: Yaron Koren <yaro...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
