Lucie Kaffee has uploaded a new change for review.
https://gerrit.wikimedia.org/r/290431
Change subject: Fix the external ressources table
......................................................................
Fix the external ressources table
Bug: T135017
Change-Id: Ib23f4aafec7223e6bc7e809ff39699789544e145
---
M includes/Lua/mw.ext.articlePlaceholder.entityRenderer.lua
M modules/ext.articleplaceholder.defaultDisplay.css
2 files changed, 12 insertions(+), 5 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ArticlePlaceholder
refs/changes/31/290431/1
diff --git a/includes/Lua/mw.ext.articlePlaceholder.entityRenderer.lua
b/includes/Lua/mw.ext.articlePlaceholder.entityRenderer.lua
index 79d641c..22a5f64 100644
--- a/includes/Lua/mw.ext.articlePlaceholder.entityRenderer.lua
+++ b/includes/Lua/mw.ext.articlePlaceholder.entityRenderer.lua
@@ -193,7 +193,8 @@
if properties ~= nil then
for _, propertyId in pairs( properties ) do
if getDatatype( propertyId ) == "external-id" then
- identifierList = identifierList .. '<tr><td
class="articleplaceholder-id-prop">' .. labelRenderer( propertyId ) .. '</td>'
+ identifierList = identifierList .. '<tr
class="articleplaceholder-id-table">'
+ identifierList = identifierList ..'<td
class="articleplaceholder-id-prop">' .. labelRenderer( propertyId ) .. '</td>'
identifierList = identifierList .. '<td
class="articleplaceholder-id-value">' .. identifierRenderer( entity, propertyId
) .. '</td></tr>'
end
end
diff --git a/modules/ext.articleplaceholder.defaultDisplay.css
b/modules/ext.articleplaceholder.defaultDisplay.css
index 8deb306..01f2268 100644
--- a/modules/ext.articleplaceholder.defaultDisplay.css
+++ b/modules/ext.articleplaceholder.defaultDisplay.css
@@ -33,14 +33,20 @@
border: 1px solid black;
background-color: #F9F9F9;
width: 100%;
+ padding: 2%;
+ text-align: left;
+}
+
+th, td {
+ border-bottom: 1px solid #ddd;
+}
+
+.articleplaceholder-id-value {
+ word-break:break-all;
}
.articleplaceholder-statementgrouplist {
margin-top: 5%;
-}
-
-.articleplaceholder-statement {
- margin-top: 1.5em;
}
.articleplaceholder-value {
--
To view, visit https://gerrit.wikimedia.org/r/290431
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib23f4aafec7223e6bc7e809ff39699789544e145
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ArticlePlaceholder
Gerrit-Branch: master
Gerrit-Owner: Lucie Kaffee <lucie.kaf...@wikimedia.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
