Zfilipin has uploaded a new change for review.
https://gerrit.wikimedia.org/r/172719
Change subject: Fixed whitespace that RuboCop did not ignore
......................................................................
Fixed whitespace that RuboCop did not ignore
For some reason, RuboCop did not put this offence to .rubocop_todo.yml
file.
Change-Id: I8334ccb3075ad7ae839b438aca25772005f40756
---
M bin/doccomparer.rb
M bin/testsuitegenerator.rb
2 files changed, 13 insertions(+), 13 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/19/172719/1
diff --git a/bin/doccomparer.rb b/bin/doccomparer.rb
index 4bb52cc..fa0f23c 100644
--- a/bin/doccomparer.rb
+++ b/bin/doccomparer.rb
@@ -31,15 +31,15 @@
def sanitize_description text
cleanup_class_name(text)
- .gsub('null and undefined', 'null')
- .gsub('undefined and null', 'null')
- .gsub('array()', '[]')
- .gsub('jQuery|string|Function', 'string')
- .gsub('jQuery', 'Tag')
- .gsub('string|Function', 'string')
- .gsub('object', 'array')
- .gsub(/#(\w+)/, '\1()')
- .gsub(/Object\.<.+?>/, 'array')
+ .gsub('null and undefined', 'null')
+ .gsub('undefined and null', 'null')
+ .gsub('array()', '[]')
+ .gsub('jQuery|string|Function', 'string')
+ .gsub('jQuery', 'Tag')
+ .gsub('string|Function', 'string')
+ .gsub('object', 'array')
+ .gsub(/#(\w+)/, '\1()')
+ .gsub(/Object\.<.+?>/, 'array')
end
def smart_compare_process val, type
diff --git a/bin/testsuitegenerator.rb b/bin/testsuitegenerator.rb
index c804392..6ffcfcf 100644
--- a/bin/testsuitegenerator.rb
+++ b/bin/testsuitegenerator.rb
@@ -15,9 +15,9 @@
classes = php.select{|c| class_names.include? c[:name] }
testable_classes = classes
- .reject{|c| !c[:parent] || c[:parent] == 'ElementMixin' } #
can't test mixins separately
- .reject{|c| %w[Element Widget Layout Theme
MediaWikiTheme].include? c[:name] } # no toplevel
- .select{|c| c[:methods][0][:params].empty? } # only without
params :(
+ .reject{|c| !c[:parent] || c[:parent] ==
'ElementMixin' } # can't test mixins separately
+ .reject{|c| %w[Element Widget Layout Theme
MediaWikiTheme].include? c[:name] } # no toplevel
+ .select{|c| c[:methods][0][:params].empty? }
# only without params :(
# values to test for each type
expandos = {
@@ -72,7 +72,7 @@
expanded = config_comb.map{|config_option|
types = config_option[:type].split '|'
sensible = sensible_values[ [ klass[:name],
config_option[:name] ] ] ||
- sensible_values[ config_option[:name] ]
+ sensible_values[
config_option[:name] ]
if sensible == true
[] # the empty value will result in no
tests being generated
else
--
To view, visit https://gerrit.wikimedia.org/r/172719
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8334ccb3075ad7ae839b438aca25772005f40756
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Zfilipin <zfili...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
