jenkins-bot has submitted this change and it was merged.
Change subject: Hygiene: use return value according to docs
......................................................................
Hygiene: use return value according to docs
According to the docs for OnMenuItemClickListener, we should return true
when handling the event. This doesn't seem to have any effect in the way
we're using it but is good practice.
Change-Id: I3381618a417693ca1827efe87c07cdbd55d71cb9
---
M app/src/main/java/org/wikipedia/feed/view/CardHeaderView.java
1 file changed, 3 insertions(+), 4 deletions(-)
Approvals:
Dbrant: Looks good to me, approved
jenkins-bot: Verified
diff --git a/app/src/main/java/org/wikipedia/feed/view/CardHeaderView.java
b/app/src/main/java/org/wikipedia/feed/view/CardHeaderView.java
index d23d66d..866173c 100644
--- a/app/src/main/java/org/wikipedia/feed/view/CardHeaderView.java
+++ b/app/src/main/java/org/wikipedia/feed/view/CardHeaderView.java
@@ -94,13 +94,12 @@
switch (item.getItemId()) {
case R.id.menu_feed_card_dismiss:
if (callback != null & card != null) {
- callback.onRequestDismissCard(card);
+ return callback.onRequestDismissCard(card);
}
- break;
+ return false;
default:
- break;
+ return false;
}
- return false;
}
}
}
\ No newline at end of file
--
To view, visit https://gerrit.wikimedia.org/r/296849
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3381618a417693ca1827efe87c07cdbd55d71cb9
Gerrit-PatchSet: 2
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Niedzielski <sniedziel...@wikimedia.org>
Gerrit-Reviewer: BearND <bsitzm...@wikimedia.org>
Gerrit-Reviewer: Brion VIBBER <br...@wikimedia.org>
Gerrit-Reviewer: Dbrant <dbr...@wikimedia.org>
Gerrit-Reviewer: Mholloway <mhollo...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
